From unknown Sat Jun 21 05:18:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6154: error from: describe-face font-lock-* Resent-From: David Reitter Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: nathaniel.cunningham@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 May 2010 14:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6154@debbugs.gnu.org Cc: nathaniel.cunningham@gmail.com X-Debbugs-Original-To: Bug-Gnu-Emacs X-Debbugs-Original-Xcc: nathaniel.cunningham@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.127350089121595 (code B ref -1); Mon, 10 May 2010 14:15:03 +0000 Received: (at submit) by debbugs.gnu.org; 10 May 2010 14:14:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBTkx-0005cG-2D for submit@debbugs.gnu.org; Mon, 10 May 2010 10:14:51 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBTku-0005cB-Aa for submit@debbugs.gnu.org; Mon, 10 May 2010 10:14:49 -0400 Received: from lists.gnu.org ([199.232.76.165]:43198) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OBTkp-0001yx-7n for submit@debbugs.gnu.org; Mon, 10 May 2010 10:14:43 -0400 Received: from [140.186.70.92] (port=44961 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBTk6-0003lW-W3 for bug-gnu-emacs@gnu.org; Mon, 10 May 2010 10:14:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FREEMAIL_REPLY, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBTUx-0007uI-To for bug-gnu-emacs@gnu.org; Mon, 10 May 2010 09:58:25 -0400 Received: from mail-qy0-f187.google.com ([209.85.221.187]:34582) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBTUx-0007tU-Pf for bug-gnu-emacs@gnu.org; Mon, 10 May 2010 09:58:19 -0400 Received: by qyk17 with SMTP id 17so3853560qyk.12 for ; Mon, 10 May 2010 06:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:content-type:subject :date:references:to:message-id:mime-version:x-mailer; bh=T+A2zU/bkSYmFfejAl4T25lqcAsKooDsAPC1KeGoopA=; b=k33CQYIr+QKTp7qB+MnA18HiJZEjZWv4mGLGwTfbuFU+LnA8GhiIMIT17cJBu2MjSD upLPlrA4Bgh2KMFhvOdWqsXsc1+kEBSOO69L+IxDFy7SDiD01hWsCe3pJJN/dHspGOaF Z4g6uVHyDdelr0mEPloismjrIgLaMfLtE7Ttk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:subject:date:references:to:message-id :mime-version:x-mailer; b=w7qoU+BmRik98Je98ktr2K1iNnpd4lI+lEtHu3BTGxYbukGAhuZghLPONK+vHpJNt2 YpAqnkZ3LTQ5T3YHuq4trWMqSW1Y+TRJYJp+wSesDo37ZvWq52Afd54liwXRouRKGVzW q8HgN+mArWn0iaYkuplmCkoPkHf3guzQAKak4= Received: by 10.224.45.31 with SMTP id c31mr2593412qaf.223.1273499896742; Mon, 10 May 2010 06:58:16 -0700 (PDT) Received: from [192.168.1.42] (pool-72-95-200-56.pitbpa.east.verizon.net [72.95.200.56]) by mx.google.com with ESMTPS id v37sm4008634qce.18.2010.05.10.06.58.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 May 2010 06:58:15 -0700 (PDT) From: David Reitter Content-Type: multipart/alternative; boundary=Apple-Mail-52-987430898 Date: Mon, 10 May 2010 09:58:10 -0400 References: Message-Id: Mime-Version: 1.0 (Apple Message framework v1078) X-Mailer: Apple Mail (2.1078) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) --Apple-Mail-52-987430898 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii X-Debbugs-CC: nathaniel.cunningham@gmail.com `describe-face' assumes that `find-lisp-object-file-name' always returns = a file name. I'm seeing the bug described below because we're = pre-loading font-lock and this function returns `C-source'. I suggest the patch below.=20 Debugger entered--Lisp error: (wrong-type-argument stringp C-source) file-name-nondirectory(C-source) describe-face((font-lock-constant-face)) call-interactively(describe-face t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil) diff --git a/lisp/faces.el b/lisp/faces.el index 740c7f7..5994f3e 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1406,12 +1406,14 @@ If FRAME is omitted or nil, use the selected = frame." (setq file-name (find-lisp-object-file-name f 'defface)) (when file-name (princ "Defined in `") - (princ (file-name-nondirectory file-name)) + (princ (if (symbolp file-name) file-name + (file-name-nondirectory file-name))) (princ "'") ;; Make a hyperlink to the library. - (save-excursion - (re-search-backward "`\\([^`']+\\)'" nil t) - (help-xref-button 1 'help-face-def f file-name)) + (unless (symbolp file-name) + (save-excursion + (re-search-backward "`\\([^`']+\\)'" nil t) + (help-xref-button 1 'help-face-def f file-name))) (princ ".") (terpri) (terpri)) Begin forwarded message: > From: Nathaniel Cunningham > Date: May 10, 2010 1:57:32 AM EDT > To: Development of Aquamacs Emacs > Subject: [Aquamacs-devel] error from: describe-face font-lock-* > Reply-To: Aquamacs Developers >=20 > Just came across this error: > M-x describe-face [RET] font-lock-constant-face [RET] >=20 > Wrong type argument: stringp, C-source >=20 > No *Help* frame appears. If I then describe a different face = sucessfully, e.g. tabbar-default, then repeat the sequence above, the = *Help* frame get reused, and says: >=20 > Face: font-lock-constant-face (sample) (customize this face) >=20 > Documentation: > Font Lock mode face used to highlight constants and labels. >=20 > Defined in ` >=20 > I get the same error for all the font-lock faces tested so far, but no = others. --Apple-Mail-52-987430898 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii nathaniel.cunningham@gmail.= com

`describe-face' assumes that = `find-lisp-object-file-name' always returns a file name.  I'm = seeing the bug described below because we're pre-loading font-lock and = this function returns `C-source'.

I suggest the = patch = below. 



Debugg= er entered--Lisp error: (wrong-type-argument stringp = C-source)
  file-name-nondirectory(C-source)
  describe-face((font-lock-constant-face))
 &nbs= p;call-interactively(describe-face t = nil)
  execute-extended-command(nil)
 &= nbsp;call-interactively(execute-extended-command nil = nil)




diff --git a/lisp/faces.el b/lisp/faces.el
index = 740c7f7..5994f3e 100644
--- a/lisp/faces.el
+++ = b/lisp/faces.el
@@ -1406,12 +1406,14 @@ If FRAME is omitted or = nil, use the selected frame."
  = (setq file-name (find-lisp-object-file-name f = 'defface))
  (when = file-name
   (princ "Defined in = `")
- =  (princ (file-name-nondirectory = file-name))
+  (princ (if = (symbolp file-name) file-name
+   = (file-name-nondirectory file-name)))
  =  (princ "'")
   ;; Make a = hyperlink to the library.
- =  (save-excursion
-   =  (re-search-backward "`\\([^`']+\\)'" nil t)
- =    (help-xref-button 1 'help-face-def f = file-name))
+  (unless (symbolp = file-name)
+   =  (save-excursion
+     =  (re-search-backward "`\\([^`']+\\)'" nil t)
+ =      (help-xref-button 1 'help-face-def f = file-name)))
   (princ = ".")
  =  (terpri)
  =  (terpri))



Beg= in forwarded message:

From: Nathaniel = Cunningham <nathaniel.cunningham@gmail.= com>
Date: May 10, 2010 1:57:32 AM EDT
To: Development of = Aquamacs Emacs <aquamacs-devel@aquamacs.org>

Just came across this error:
M-x describe-face [RET] = font-lock-constant-face [RET]

Wrong type argument: stringp, = C-source

No *Help* frame appears.  If I then describe = a different face sucessfully, e.g. tabbar-default, then repeat the = sequence above, the *Help* frame get reused, and says:

Face: font-lock-constant-face = (sample) (customize this face)

Documentation:
Font Lock mode = face used to highlight constants and labels.

Defined in = `

I get the same error for all the font-lock faces tested = so far, but no others.

= --Apple-Mail-52-987430898-- From unknown Sat Jun 21 05:18:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6154: error from: describe-face font-lock-* Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 May 2010 15:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: David Reitter Cc: nathaniel.cunningham@gmail.com, 6154@debbugs.gnu.org Received: via spool by 6154-submit@debbugs.gnu.org id=B6154.127350584124057 (code B ref 6154); Mon, 10 May 2010 15:38:02 +0000 Received: (at 6154) by debbugs.gnu.org; 10 May 2010 15:37:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBV2n-0006Fy-1R for submit@debbugs.gnu.org; Mon, 10 May 2010 11:37:21 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBV2l-0006Fs-PL for 6154@debbugs.gnu.org; Mon, 10 May 2010 11:37:19 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AsgGAHLF50tLd+Zs/2dsb2JhbACCXZtCcr1XhRQEjDI X-IronPort-AV: E=Sophos;i="4.52,362,1270440000"; d="scan'208";a="63824691" Received: from 75-119-230-108.dsl.teksavvy.com (HELO pastel.home) ([75.119.230.108]) by ironport2-out.pppoe.ca with ESMTP; 10 May 2010 11:37:14 -0400 Received: by pastel.home (Postfix, from userid 20848) id B32E48205; Mon, 10 May 2010 11:37:14 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Mon, 10 May 2010 11:37:14 -0400 In-Reply-To: (David Reitter's message of "Mon, 10 May 2010 09:58:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > `describe-face' assumes that `find-lisp-object-file-name' always > returns a file name. I'm seeing the bug described below because we're > pre-loading font-lock and this function returns `C-source'. All faces are defined in Lisp code, AFAIK, so the value `C-source' is not a correct one. Without knowing how it happened, it's hard to tell where the problem should be fixed. Stefan From unknown Sat Jun 21 05:18:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6154: error from: describe-face font-lock-* Resent-From: David Reitter Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 May 2010 23:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Stefan Monnier Cc: nathaniel.cunningham@gmail.com, 6154@debbugs.gnu.org Received: via spool by 6154-submit@debbugs.gnu.org id=B6154.127353270412672 (code B ref 6154); Mon, 10 May 2010 23:06:02 +0000 Received: (at 6154) by debbugs.gnu.org; 10 May 2010 23:05:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBc24-0003IL-9t for submit@debbugs.gnu.org; Mon, 10 May 2010 19:05:04 -0400 Received: from mail-vw0-f44.google.com ([209.85.212.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBc23-0003Hz-2T for 6154@debbugs.gnu.org; Mon, 10 May 2010 19:05:03 -0400 Received: by vws9 with SMTP id 9so860539vws.3 for <6154@debbugs.gnu.org>; Mon, 10 May 2010 16:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=1po78ouNYCSsyAaL3yLnvr3jWHHfTSH7xjvTiUU1wPc=; b=h5TWr+Bfsslh+bxWK1aYxfAb9cOO3NDD17m5ePKzZWvb5YCRGyjDSKXkBn31Kvmtq2 Ro/dwwasHwsyADOCxi+SKFBvuatlr0qgPYb40BL25sov8S8ITbSXemUyoJl3UQPh6XdX nuJYZbFfXQnjT3HjwKzTl3BYPlC5oZATWxJA8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=abeYqK21eozZUod6ccmJhbBp/PAMuz9daaTl9mGuiLt82I1ftue3EkrrNcoxBFu0kc kEcnemdEDMRL8OJAiJEtOoi0vAcnBdmvdIhr446pAdKUkpTXT6YzfJ3WjJzCz8SgOovS LdoRi9hisFsXcBxppKeXHnAw08M4YFIloaQYk= Received: by 10.220.107.95 with SMTP id a31mr3888217vcp.86.1273532698706; Mon, 10 May 2010 16:04:58 -0700 (PDT) Received: from elin.psy.cmu.edu (ELIN.PSY.CMU.EDU [128.2.248.190]) by mx.google.com with ESMTPS id v12sm49244507vch.9.2010.05.10.16.04.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 May 2010 16:04:57 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: David Reitter In-Reply-To: Date: Mon, 10 May 2010 19:04:56 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <56843DC6-2E52-4BCD-8095-441ECD981063@gmail.com> References: X-Mailer: Apple Mail (2.1078) X-Spam-Score: -3.0 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On May 10, 2010, at 11:37 AM, Stefan Monnier wrote: >> `describe-face' assumes that `find-lisp-object-file-name' always >> returns a file name. I'm seeing the bug described below because = we're >> pre-loading font-lock and this function returns `C-source'. >=20 > All faces are defined in Lisp code, AFAIK, so the value `C-source' is > not a correct one. Without knowing how it happened, it's hard to tell > where the problem should be fixed. Perhaps "pre-loading font-lock" was not enough of a hint in my report. With a recent Emacs 23 branch checkout: add a lisp/site-load.el file with the contents (load "font-lock") then re-build. Then, Emacs -Q, and M-x describe-face RET font-lock-comment-face RET will produce the error. Trace, again, below. So: The `find-lisp-object-file-name' should probably return "font-lock.el" = instead of `C-source'. `describe-face' will break as it is should a face ever be defined in C. = See patch. Debugger entered--Lisp error: (wrong-type-argument stringp C-source) file-name-nondirectory(C-source) describe-face((font-lock-comment-face)) call-interactively(describe-face t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil) From unknown Sat Jun 21 05:18:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6154: error from: describe-face font-lock-* Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2010 03:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: David Reitter Cc: Stefan Monnier , 6154@debbugs.gnu.org, nathaniel.cunningham@gmail.com Received: via spool by 6154-submit@debbugs.gnu.org id=B6154.127354807319132 (code B ref 6154); Tue, 11 May 2010 03:22:02 +0000 Received: (at 6154) by debbugs.gnu.org; 11 May 2010 03:21:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBg1x-0004yX-9a for submit@debbugs.gnu.org; Mon, 10 May 2010 23:21:13 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBg1v-0004yS-AR for 6154@debbugs.gnu.org; Mon, 10 May 2010 23:21:11 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OBg1r-0006wQ-IZ; Mon, 10 May 2010 23:21:07 -0400 References: <56843DC6-2E52-4BCD-8095-441ECD981063@gmail.com> From: Dan Nicolaescu Date: Mon, 10 May 2010 23:21:07 -0400 In-Reply-To: <56843DC6-2E52-4BCD-8095-441ECD981063@gmail.com> (David Reitter's message of "Mon\, 10 May 2010 19\:04\:56 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) David Reitter writes: > On May 10, 2010, at 11:37 AM, Stefan Monnier wrote: > >>> `describe-face' assumes that `find-lisp-object-file-name' always >>> returns a file name. I'm seeing the bug described below because we're >>> pre-loading font-lock and this function returns `C-source'. >> >> All faces are defined in Lisp code, AFAIK, so the value `C-source' is >> not a correct one. Without knowing how it happened, it's hard to tell >> where the problem should be fixed. > > Perhaps "pre-loading font-lock" was not enough of a hint in my report. > > With a recent Emacs 23 branch checkout: > > add a lisp/site-load.el file with the contents > > (load "font-lock") Why would you do that? font-lock is loadup.el. > then re-build. > > Then, Emacs -Q, and > > M-x describe-face RET font-lock-comment-face RET > > will produce the error. Trace, again, below. > > > So: > > The `find-lisp-object-file-name' should probably return "font-lock.el" instead of `C-source'. > > `describe-face' will break as it is should a face ever be defined in C. See patch. > > > > > Debugger entered--Lisp error: (wrong-type-argument stringp C-source) > file-name-nondirectory(C-source) > describe-face((font-lock-comment-face)) > call-interactively(describe-face t nil) > execute-extended-command(nil) > call-interactively(execute-extended-command nil nil) From unknown Sat Jun 21 05:18:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6154: error from: describe-face font-lock-* Resent-From: David Reitter Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2010 03:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dan Nicolaescu Cc: Stefan Monnier , 6154@debbugs.gnu.org, nathaniel.cunningham@gmail.com Received: via spool by 6154-submit@debbugs.gnu.org id=B6154.127354939219681 (code B ref 6154); Tue, 11 May 2010 03:44:02 +0000 Received: (at 6154) by debbugs.gnu.org; 11 May 2010 03:43:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBgNE-00057O-0D for submit@debbugs.gnu.org; Mon, 10 May 2010 23:43:12 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBgNC-00057H-7J for 6154@debbugs.gnu.org; Mon, 10 May 2010 23:43:10 -0400 Received: by wwi17 with SMTP id 17so161931wwi.3 for <6154@debbugs.gnu.org>; Mon, 10 May 2010 20:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:mime-version :content-type:from:in-reply-to:date:cc:content-transfer-encoding :message-id:references:to:x-mailer; bh=rz3V0iGxhrI9+qH2bMfWmDXAYjRoLHN5L4ggrJRU6YA=; b=YJ+j3/gzKGDaHUtwcElz8UMWIzGRAIg2LP9EbQJGvP9izBAalaIvkBbICheAXwtkXF mpT7uzVJQhuJPVs52AJz6Cd7iwraPBqdecTGhm130gI/fbwK4og8CKhddL5tcAkJ64/g YEQFYAcK73bvJshnm59rTQuHKdLwOgFh7kON4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; b=cqvvx5ZRa+faBMxJVD0Vma7O2jB9IhWg5eH9JWQPgf6HzNEkG+jNaL+i6BoGdac0Ll caKlLDT0eAKESho8Otx56irV5TcsnRUrtWOOyM7IbcVRDT7IpdhkWUQmIeKje/bnwlnQ /CI3Hu0PZuQFVn94Hrjt3bP7QRWx1ke3WSLgw= Received: by 10.227.127.148 with SMTP id g20mr4594828wbs.192.1273549386368; Mon, 10 May 2010 20:43:06 -0700 (PDT) Received: from [192.168.1.43] (pool-72-95-200-56.pitbpa.east.verizon.net [72.95.200.56]) by mx.google.com with ESMTPS id u8sm45754468wbc.23.2010.05.10.20.43.03 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 May 2010 20:43:05 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii From: David Reitter In-Reply-To: Date: Mon, 10 May 2010 23:43:00 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <7497626F-443D-44B1-8621-637D86BE6C1B@gmail.com> References: <56843DC6-2E52-4BCD-8095-441ECD981063@gmail.com> X-Mailer: Apple Mail (2.1078) X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) On May 10, 2010, at 11:21 PM, Dan Nicolaescu wrote: >>=20 >> add a lisp/site-load.el file with the contents >>=20 >> (load "font-lock") >=20 > Why would you do that? font-lock is loadup.el. Thank you, I'll remove that. Still not sure why it would make a difference, or why the symptoms are = what they are... From unknown Sat Jun 21 05:18:21 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: David Reitter Subject: bug#6154: closed (Re: bug#6154: error from: describe-face font-lock-*) Message-ID: References: <5ky6075n4p.fsf@fencepost.gnu.org> X-Gnu-PR-Message: they-closed 6154 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: wontfix Reply-To: 6154@debbugs.gnu.org Date: Sat, 09 Jul 2011 18:24:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1310235842-30326-1" This is a multi-part message in MIME format... ------------=_1310235842-30326-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6154: error from: describe-face font-lock-* which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6154@debbugs.gnu.org. --=20 6154: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6154 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1310235842-30326-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6154-done) by debbugs.gnu.org; 9 Jul 2011 18:23:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfcBp-0007sf-Hv for submit@debbugs.gnu.org; Sat, 09 Jul 2011 14:23:41 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QfcBo-0007sR-1S for 6154-done@debbugs.gnu.org; Sat, 09 Jul 2011 14:23:40 -0400 Received: from localhost ([127.0.0.1]:55037) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QfcBi-0004vB-B9; Sat, 09 Jul 2011 14:23:34 -0400 From: Glenn Morris To: 6154-done@debbugs.gnu.org Subject: Re: bug#6154: error from: describe-face font-lock-* References: <56843DC6-2E52-4BCD-8095-441ECD981063@gmail.com> <7497626F-443D-44B1-8621-637D86BE6C1B@gmail.com> X-Spook: AIMSX Montenegro Blowpipe Cocaine undercover X-Ran: ;>`TK)pHNa>dc*HbzNZfQBZF[Vh}kkuwNNK0%?=gmqZ%w[?_zvDCX'Hm-lQ/a9>m(_kre: X-Hue: magenta X-Attribution: GM Date: Sat, 09 Jul 2011 14:23:34 -0400 In-Reply-To: <7497626F-443D-44B1-8621-637D86BE6C1B@gmail.com> (David Reitter's message of "Mon, 10 May 2010 23:43:00 -0400") Message-ID: <5ky6075n4p.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 6154-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) I don't see a need to keep open this particular report. Faces aren't defined in C, they are defined in Lisp. ------------=_1310235842-30326-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 May 2010 14:14:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBTkx-0005cG-2D for submit@debbugs.gnu.org; Mon, 10 May 2010 10:14:51 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBTku-0005cB-Aa for submit@debbugs.gnu.org; Mon, 10 May 2010 10:14:49 -0400 Received: from lists.gnu.org ([199.232.76.165]:43198) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OBTkp-0001yx-7n for submit@debbugs.gnu.org; Mon, 10 May 2010 10:14:43 -0400 Received: from [140.186.70.92] (port=44961 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBTk6-0003lW-W3 for bug-gnu-emacs@gnu.org; Mon, 10 May 2010 10:14:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FREEMAIL_REPLY, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBTUx-0007uI-To for bug-gnu-emacs@gnu.org; Mon, 10 May 2010 09:58:25 -0400 Received: from mail-qy0-f187.google.com ([209.85.221.187]:34582) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBTUx-0007tU-Pf for bug-gnu-emacs@gnu.org; Mon, 10 May 2010 09:58:19 -0400 Received: by qyk17 with SMTP id 17so3853560qyk.12 for ; Mon, 10 May 2010 06:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:content-type:subject :date:references:to:message-id:mime-version:x-mailer; bh=T+A2zU/bkSYmFfejAl4T25lqcAsKooDsAPC1KeGoopA=; b=k33CQYIr+QKTp7qB+MnA18HiJZEjZWv4mGLGwTfbuFU+LnA8GhiIMIT17cJBu2MjSD upLPlrA4Bgh2KMFhvOdWqsXsc1+kEBSOO69L+IxDFy7SDiD01hWsCe3pJJN/dHspGOaF Z4g6uVHyDdelr0mEPloismjrIgLaMfLtE7Ttk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:subject:date:references:to:message-id :mime-version:x-mailer; b=w7qoU+BmRik98Je98ktr2K1iNnpd4lI+lEtHu3BTGxYbukGAhuZghLPONK+vHpJNt2 YpAqnkZ3LTQ5T3YHuq4trWMqSW1Y+TRJYJp+wSesDo37ZvWq52Afd54liwXRouRKGVzW q8HgN+mArWn0iaYkuplmCkoPkHf3guzQAKak4= Received: by 10.224.45.31 with SMTP id c31mr2593412qaf.223.1273499896742; Mon, 10 May 2010 06:58:16 -0700 (PDT) Received: from [192.168.1.42] (pool-72-95-200-56.pitbpa.east.verizon.net [72.95.200.56]) by mx.google.com with ESMTPS id v37sm4008634qce.18.2010.05.10.06.58.15 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 10 May 2010 06:58:15 -0700 (PDT) From: David Reitter Content-Type: multipart/alternative; boundary=Apple-Mail-52-987430898 Subject: error from: describe-face font-lock-* Date: Mon, 10 May 2010 09:58:10 -0400 References: To: Bug-Gnu-Emacs Message-Id: Mime-Version: 1.0 (Apple Message framework v1078) X-Mailer: Apple Mail (2.1078) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) --Apple-Mail-52-987430898 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii X-Debbugs-CC: nathaniel.cunningham@gmail.com `describe-face' assumes that `find-lisp-object-file-name' always returns = a file name. I'm seeing the bug described below because we're = pre-loading font-lock and this function returns `C-source'. I suggest the patch below.=20 Debugger entered--Lisp error: (wrong-type-argument stringp C-source) file-name-nondirectory(C-source) describe-face((font-lock-constant-face)) call-interactively(describe-face t nil) execute-extended-command(nil) call-interactively(execute-extended-command nil nil) diff --git a/lisp/faces.el b/lisp/faces.el index 740c7f7..5994f3e 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1406,12 +1406,14 @@ If FRAME is omitted or nil, use the selected = frame." (setq file-name (find-lisp-object-file-name f 'defface)) (when file-name (princ "Defined in `") - (princ (file-name-nondirectory file-name)) + (princ (if (symbolp file-name) file-name + (file-name-nondirectory file-name))) (princ "'") ;; Make a hyperlink to the library. - (save-excursion - (re-search-backward "`\\([^`']+\\)'" nil t) - (help-xref-button 1 'help-face-def f file-name)) + (unless (symbolp file-name) + (save-excursion + (re-search-backward "`\\([^`']+\\)'" nil t) + (help-xref-button 1 'help-face-def f file-name))) (princ ".") (terpri) (terpri)) Begin forwarded message: > From: Nathaniel Cunningham > Date: May 10, 2010 1:57:32 AM EDT > To: Development of Aquamacs Emacs > Subject: [Aquamacs-devel] error from: describe-face font-lock-* > Reply-To: Aquamacs Developers >=20 > Just came across this error: > M-x describe-face [RET] font-lock-constant-face [RET] >=20 > Wrong type argument: stringp, C-source >=20 > No *Help* frame appears. If I then describe a different face = sucessfully, e.g. tabbar-default, then repeat the sequence above, the = *Help* frame get reused, and says: >=20 > Face: font-lock-constant-face (sample) (customize this face) >=20 > Documentation: > Font Lock mode face used to highlight constants and labels. >=20 > Defined in ` >=20 > I get the same error for all the font-lock faces tested so far, but no = others. --Apple-Mail-52-987430898 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii nathaniel.cunningham@gmail.= com

`describe-face' assumes that = `find-lisp-object-file-name' always returns a file name.  I'm = seeing the bug described below because we're pre-loading font-lock and = this function returns `C-source'.

I suggest the = patch = below. 



Debugg= er entered--Lisp error: (wrong-type-argument stringp = C-source)
  file-name-nondirectory(C-source)
  describe-face((font-lock-constant-face))
 &nbs= p;call-interactively(describe-face t = nil)
  execute-extended-command(nil)
 &= nbsp;call-interactively(execute-extended-command nil = nil)




diff --git a/lisp/faces.el b/lisp/faces.el
index = 740c7f7..5994f3e 100644
--- a/lisp/faces.el
+++ = b/lisp/faces.el
@@ -1406,12 +1406,14 @@ If FRAME is omitted or = nil, use the selected frame."
  = (setq file-name (find-lisp-object-file-name f = 'defface))
  (when = file-name
   (princ "Defined in = `")
- =  (princ (file-name-nondirectory = file-name))
+  (princ (if = (symbolp file-name) file-name
+   = (file-name-nondirectory file-name)))
  =  (princ "'")
   ;; Make a = hyperlink to the library.
- =  (save-excursion
-   =  (re-search-backward "`\\([^`']+\\)'" nil t)
- =    (help-xref-button 1 'help-face-def f = file-name))
+  (unless (symbolp = file-name)
+   =  (save-excursion
+     =  (re-search-backward "`\\([^`']+\\)'" nil t)
+ =      (help-xref-button 1 'help-face-def f = file-name)))
   (princ = ".")
  =  (terpri)
  =  (terpri))



Beg= in forwarded message:

From: Nathaniel = Cunningham <nathaniel.cunningham@gmail.= com>
Date: May 10, 2010 1:57:32 AM EDT
To: Development of = Aquamacs Emacs <aquamacs-devel@aquamacs.org>

Just came across this error:
M-x describe-face [RET] = font-lock-constant-face [RET]

Wrong type argument: stringp, = C-source

No *Help* frame appears.  If I then describe = a different face sucessfully, e.g. tabbar-default, then repeat the = sequence above, the *Help* frame get reused, and says:

Face: font-lock-constant-face = (sample) (customize this face)

Documentation:
Font Lock mode = face used to highlight constants and labels.

Defined in = `

I get the same error for all the font-lock faces tested = so far, but no others.

= --Apple-Mail-52-987430898-- ------------=_1310235842-30326-1--