From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 23:26:42 2023 Received: (at submit) by debbugs.gnu.org; 15 Feb 2023 04:26:42 +0000 Received: from localhost ([127.0.0.1]:57543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pS9NR-0005r4-Ul for submit@debbugs.gnu.org; Tue, 14 Feb 2023 23:26:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:55052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pS9NR-0005qx-37 for submit@debbugs.gnu.org; Tue, 14 Feb 2023 23:26:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pS9NQ-0004SG-TD for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 23:26:40 -0500 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pS9NP-0000hT-4D for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 23:26:40 -0500 Received: by mail-pj1-x1041.google.com with SMTP id bg2so7771880pjb.4 for ; Tue, 14 Feb 2023 20:26:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=msJknS4nHeLQjK/mRuOpxl0CKTjjiZmU9tDk7JUXNFc=; b=DLMQJbyikoQR8EQYn6MGnrlEcZKbZkwyWX0+ZcPvDJ2SU1JLuwCw3v4TiqZF93dZ6M 0Moj7CYsVi68CUJ+Wodnqp1R9naNm4T7maU6wIZJpZecr0xrdXz6P9eXXp2/Lh4sxzmH GK1nl032kFIXY35ygSaaAEeqEwtQNz9b07utm/sGw0kokYqE2cUSYhKmwHnVrk+obbFe 2LEPdm+J9JiJCC76t3YVvzsvG6ppzt8vYbIKtZbnnt/T7SCyojUshOGEjgb6tR3WDqbE GaqLzjswJKzvUFmHN68IxlgphOJXib6OCVXdLkc1tCVN/yJFFYiehsAtzNcA57RSh/+6 dihw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=msJknS4nHeLQjK/mRuOpxl0CKTjjiZmU9tDk7JUXNFc=; b=KqxZQSLYkux55y8/ntT1HDJqNoDTAhr4f+M3l2j2mZd53Sspl229xttnqIsOc6rICU ujscKvV9l5qRc/CMXqJlvJvYXRowPuybbCrFXExEwES44U4IRZsxGSBGgrR1gO6l3Vge Hr+BcUhwKK7qXe9HKSSvq+oNmeR0Xa7NIv3yWDShn5LWFrAyMzjzCqUPplt5aCfa9JhD gtK+HR6jXaMfENWlW/y6P2X3r+ZeOaVjWblNMZHKtME3AKZERK57Vsdxbl4qLBivXIIN nJICxww7ZiR0rjhQkk+Hp6/aeatJCLp8lJ3Kmqv/OUIU82OIxyIAJEzKMR90fe0qgCZq iStA== X-Gm-Message-State: AO0yUKWOiEhWij+AoSlii+W9Wz78PiHPREiPLlkTjE+7+CCIMlzdBPTC b4tm7LbmYMfqtTIpgxUfFIikIoOGPBLo+0GqM6Q= X-Google-Smtp-Source: AK7set/NzGWbtTQj25LcV7lNyu8kRS0Fm4Ao4AgifBGhpMeLCqytAeBxRYkFLPCjDeCpnIUWcDDMXQ== X-Received: by 2002:a17:902:c94a:b0:198:f8c9:7f4b with SMTP id i10-20020a170902c94a00b00198f8c97f4bmr2681566pla.2.1676435196598; Tue, 14 Feb 2023 20:26:36 -0800 (PST) Received: from Kais-MacBook.local ([222.195.81.43]) by smtp.gmail.com with ESMTPSA id 6-20020a170902ee4600b0019ac5d3ee9dsm617086plo.157.2023.02.14.20.26.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 20:26:36 -0800 (PST) From: Kai Ma To: bug-gnu-emacs@gnu.org Subject: 29.0.60; delete-frame will raise frames in another virtual desktop Date: Wed, 15 Feb 2023 13:26:32 +0900 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::1041; envelope-from=justksqsf@gmail.com; helo=mail-pj1-x1041.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_LOCAL_NOVOWEL=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On MacOS, delete-frame can raise a frame in another virtual desktop, which will cause switching between desktops. This is annoying, especially for emacsclient users. To quote frame.c: #ifdef NS_IMPL_COCOA else /* Under NS, there is no system mechanism for choosing a new window to get focus -- it is left to application code. So the portion of THIS application interfacing with NS needs to know about it. We call Fraise_frame, but the purpose is really to transfer focus. */ Fraise_frame (frame1); #endif However, this has an undesired side effect: the desktop will be switched. Steps to reproduce: 1. Run emacs. 2. C-x 5 2, and move the new frame to another desktop. 3. C-x 5 0. Now you see the desktop is switched. This is a known issue for some time [1] and there is a patch that simply disables raise_frame [2]. I'm not sure whether this patch is entirely correct (and I think not). But I do think the behavior should be improved; at least the undesired desktop switching should be avoided. Best regards, Kai [1] https://xenodium.com/no-emacs-frame-refocus-on-macos/ [2] https://github.com/d12frosted/homebrew-emacs-plus/blob/master/patches/emacs-28/no-frame-refocus-cocoa.patch From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 05:54:32 2023 Received: (at 61525) by debbugs.gnu.org; 15 Feb 2023 10:54:32 +0000 Received: from localhost ([127.0.0.1]:57939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSFQm-0007sa-Bw for submit@debbugs.gnu.org; Wed, 15 Feb 2023 05:54:32 -0500 Received: from sonic311-30.consmr.mail.ir2.yahoo.com ([77.238.176.162]:39320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSFQj-0007sJ-UZ for 61525@debbugs.gnu.org; Wed, 15 Feb 2023 05:54:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676458463; bh=dKSLSiWsAtUrd/XgnuyOuZIJxaWigqU5RDgV5kSTcR8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=hpnNmOgDM+Thr2X12UIvRC0bbGqimwChucRic67gcg1Tu2/qGno+eVHAqUPtxbT0hCC+2l6KQuWXIsPqu78dasoraF2S25d/MyuoaPnk93BUtkE0xCioedT70gEc7e0h3COAbQqCloiAzrC4LMQp856bi1whgvzvlvoHKvjCCXN9NNXwfNxf2HNQ5yuR1Fo9S/vfwFdUjq7k/1zCGrlY8nyeg2ZwEwG29gMx9SVgfH0EQcrDmt5T+OsJjBoNVhVMQfCRHxVWVSlbeUGSFkRLj8mutdQloQyQ1grYoPftXZVT+6woz/EBIUffUCox+4b3fToFZG6MNCEys+9LlpEU+A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676458463; bh=m7wN7Afwme+LalQ/jRzUJWKSHTwR61ZTTlrf7/KXS+E=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=VyKDkpfAtHUuIjGNWjofD/iDQVpCMfY0meg1EE00i47jnVTtRonsoIJapQqR0iekpBng0SORhIbGTKbODMPP/y2ojfQSB5ySdkgGyavSJKFBMokgg1dLRk6kr/tIEWK4NZFwWWENwRWWUg6wELK1EF5pVqMLxSpaYbuGHNuByugkF66kUo6MLwh5zSgwZCFqou/5C0Vl/ylVhe4QF/WtcnLUj3sU7Vrc0ghZOtC3vE38zH9uwp8B7gievQ1FdnbM/BLOK31y/P5WFCclffkzeWJuHnFtDkc6n0LIMQs7J7YFZkPKZ9QSkY9FgGvahiKe4ainQY+DEgteQ8YkYJPiZg== X-YMail-OSG: TqmMrVkVM1noRD_062cJ3IAeI5J5JrjlmKNDsUts0EjXm4HlxOgPHOyZZecroKL SwtM0ns8yzGmfL6pAozyHIRdGsGs6Pcoxb13mFiEv5rLKd.R6w.IFWxXDLv6G4zk58yO6hLeBJIX VuXL2Bfl3muv7gRasgtR4s1EgbNhSKVzn7scveCyPeogUhxybLVufzy7qXfMaRiKo4Qe1pqBLu.o AGIR89jTyUZVi6loTNd9zDIU.JN.imzgfJrq6jnNSuYVyXfwCpiKTSsRIup5UdoBTmsacPVuQxBc x7QZxga13OG8hljrmHdLrFgwYWcXh8BETvHgT.poEk53xuPJkr_gO9l5oHIpSv88rn.QXGOiC19y TWHGzyF.lOdkvk99r8gd_3ZglSXey0Y_8MdqBIQe3i8AriTmvnJP5gvli6aOZIW9IAX7GYKq0ZDL vKmXnuKEr392eIR8WSDQ_xpbbSmv2ufs3i0ZpN.Ip4IpjXSI437AP6UPH9TDi7UepGzs3oMVmcjE qfd5OgqiDtHqEQClq8i.9fuCW7t_LonL6x4LmpuonaFf1_u8nX_IzLyiaKJE3I1OGJB0AKrd2RBz SgoEmHvf0Dr08dt1ap2OxOpQO94maoIX6IFMu1uz0jSgGx8pMZSK6nEVttIrXU7QntvRryYamOk6 JPGEJu.biA3wE8ru_JanBybdjOgt_8CG4XD687K4nsaR9pilMRNEpZwnlaIqHOm8pHdjRrYMKQct 3z..WedT6QTDlP6RJnw2hpd.jl0yxwEz5GKiaZXKZr2o1zZdNgofJNyWLIkA70K02_gifOUqOu7k NeHzy_ALs8AXtrO7xbDF8PcB607BBjjo8DIcG1M9M8k68oDtOGBUmo_yM7ZgsSeKpPjj56BaBOXb ALwZj.8fao6f0CP5g3OSPv.RiGpYF0SZ2cfZAtrn8J_jbhm3qM5RKsBzyzlxGd.9VEteoaRrdBWK aKt_htNi0HbZv3K.PNeihSHomGuo_SwhxF5bDUOAdI1chdcpGX6YoeX3cWy._49fsCo.wXSGHTeF R5Cy.uPQ70OlZ1zd9EZz_hN5WCqADL1CxwRVdy0_8Di6HsnRP62QH2lXZLIXZIIAhS1pTWWtJeQ_ 8J88FP6qQfqqLslI2hwqtNFJP_hGjfvsB4sUbMHGggT8YlcLNAROEjuxaV0wZ3TXWGIdJKzNE1mU FtOW7FricX74hj3s4B1.yhrN2ZKnHBr_45cSuKEFPeI1a_iA5kcBSAUms2V2OHd9WDMG.UjldF27 RiaEzPwa4ESnCgIR7dyu.7SYA7Q1SyJab4LeVnpg3sMrzEqpQPfIutjPDVNhDYC4IGcGAhbonenk HeQU6nWcUgKNSRAOYWSD0UaNCL.khcZZrkAPLOriR7skpQzSJJU0aEnwQeLE2APkXxTGF2inp__A L9Bx_BgismoKMsqe1gaiBuT9KtdamrtFriVpxB8jiDHyHujwZAuNAW1VfKGlBbkFxNSGdKPGznoJ .s6f3jg.FOz.g6VTCxNYPyoofNvvNv7v1AdGu8ESTbB6Hu6A1Tcabcmntmq0oRZwCMzJVvrkgk5. Gwjg2F1JwzqRo1PA71hXmmhrM0PvzZzTW6gfcWn5S1U0Na_ELSwuxhDox.1TAW4LMZ.w_ymocG4x tW6evPB9iTsL9SbHofJWU_7_OuujaaNzJJpxP5SsEMGfxtDhlSymJC.fvX20qnysmbZgZqKhuEXS 2xvC7dB1hzLF4kXu5VtlqSOGTQIYkkaCIYsa80rJZV_mATQViPYMtl.ZtYCelEuE7JCicK2hicVK tPt4PN8Z_YzLFSguX4pkMTIceuZ50TgHG7_Ckj1CkfQHDY3wPT3buA00Z2A14F2Qh9AjitXbDaDQ 4_WLcfUkaLcpBXYkJ8MTKNO4ASd1WV8dLWTM8gyqPKYrp09CTVT1_AIpHGsJtAF2SjbOlJT3qOuX 060GOFeURGLClik3s_bYhM_2PGjSVll_yecKOeAU9exPrmaRnayEWAIVtzQ6VbmPQvYbpHzBJGdO ssCFtUiV7NX49GK3FOIIcm6ZZ70.pHQg3LwGA2yXNl_u1FG_Hkkm.OhJuSDTrHeCMDQ07VsCKAnM moOWtqMM0DxQKx_i4WC_rVY8V2Bbm17s7Wa4XPPEjytWXsPr_uyKQkkTc_Fzs7zC1Nqe41aeAG25 ACDIG_RV1Pk5AF0v3zPPq00I8AyCiys5RSlXGIZMxX5jHCZScq3KbTDVUFcxfU.2mnYU2TcdhCYn KO97EMUUp5s_QXFRoNh238FVSZ72gLJgeug55jvmR X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Wed, 15 Feb 2023 10:54:23 +0000 Received: by hermes--production-ir2-65c64dfd66-mp9nb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 141e552a3256eade7703038d5e46ba23; Wed, 15 Feb 2023 10:54:19 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Kai Ma Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: Date: Wed, 15 Feb 2023 11:54:17 +0100 In-Reply-To: (Kai Ma's message of "Wed, 15 Feb 2023 13:26:32 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1819 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Kai Ma writes: > On MacOS, delete-frame can raise a frame in another virtual desktop, > which will cause switching between desktops. This is annoying, > especially for emacsclient users. > > To quote frame.c: > > #ifdef NS_IMPL_COCOA > else > /* Under NS, there is no system mechanism for choosing a new > window to get focus -- it is left to application code. > So the portion of THIS application interfacing with NS > needs to know about it. We call Fraise_frame, but the > purpose is really to transfer focus. */ > Fraise_frame (frame1); > #endif > > However, this has an undesired side effect: the desktop will be > switched. > > Steps to reproduce: > > 1. Run emacs. > 2. C-x 5 2, and move the new frame to another desktop. > 3. C-x 5 0. Now you see the desktop is switched. > > This is a known issue for some time [1] and there is a patch that simply > disables raise_frame [2]. I'm not sure whether this patch is entirely > correct (and I think not). But I do think the behavior should be > improved; at least the undesired desktop switching should be avoided. > One downside of removing raise_frame is that, after you press C-x 5 0, you cannot start typing right away without first focusing on another Emacs frame manually. People would consider this a regression from previous versions and something that doesn't happen on GNU/Linux. A possibly better approach could be: Once the "other" frame to select is chosen by the code that is just above in frame.c, call some Obj-C code that extracts the EmacsView and makes it the first responder: EmacsView *view = FRAME_NS_VIEW (frame1); [self makeFirstResponder:view]; I haven't tested this, but perhaps this makes the other frame receive focus without switching desktops in a multi-desktop configuration. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 10:42:01 2023 Received: (at 61525) by debbugs.gnu.org; 15 Feb 2023 15:42:01 +0000 Received: from localhost ([127.0.0.1]:33664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSJuy-00082c-S0 for submit@debbugs.gnu.org; Wed, 15 Feb 2023 10:42:01 -0500 Received: from sonic311-31.consmr.mail.ir2.yahoo.com ([77.238.176.163]:45548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSJuq-00081c-2y for 61525@debbugs.gnu.org; Wed, 15 Feb 2023 10:41:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676475705; bh=uLiHa7pghwO5a2ZgdQuZdFCnoCuj63WkMP9nA6MzL3g=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=gK1JmWZfkccCaEqFo40CE2gF8XEtxYi91K/NKkx67NXL8luHPIijMQAow89EsUJAPCClS8lnK1tsH5IuAmivwS6dnmLUYcjQH6KfgfHiS9f++lub2Jx0zU060U2pedjqvskzHJRCf7BMmF335ovcxT2rPxKRozzKnNYO8TfDXS2bvpQNgfjMffKzC4Cilf5WNXeMeo8vDh15HjmV3s7Tmwgi8fJjCx+mpMri1K3uHLe7a+bQlmamrxqHBGbYwISdDklu8uWbD1C/Bfj+JdpWLWGY7ZFmnGgLxy785Jctwpj1YrW8Mqrd2QpdL8wxVZa4p+IbKdCysWW5jfWl+wVyaA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676475705; bh=/NoMubAb0+1mfY1+5YLsMyrLBO37ueasuxF0kEncZ6r=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=UCvtuYCa2K+5MIcfFzXZdA0Gu7tY87RVGqqRH3FOjM6nNjeAi4fuj0Wjp3psUz2Mfqk+uotMRJrB/vd1BEP/51bGbrpmw8Xns7yTbmI73X5/T5u7fefge/ifc9bAeIdUIIQJ3Pr6lctt733nDmTFSkF7oyHWIDIk2Xzz7ttg4V40iy2JpI4mml+YCH9V17qBZjbfJR1DZ025Jpn06bPaWATMG55jeKGsPo1OhNPjhtfw/ek4uXkZgAbfluuQjyyCOzRH7F/itwbCffUlOe3Rtnf2yCJT8BBU90IOsvrgbg8q+Xsr73K05L8kBvhLvGn+xiPEgMVhYvBzDeXkh3xcZA== X-YMail-OSG: NdM8zL0VM1nwb3O7dHTNPpguR_p4aIuyLVLIzWcjG6q4zK6vLyPH5BFB0POEyOO okBUPMYVrPJyK4jS_B8HZiVG5GdB9QBiGra70RRuf0ploKMAFLANiOegz7QvLFheTmdkoXFxz43g GrhXY20nh2dnNbBe98y5oeexazwlDw7y99y67UjAitmuLJGV5dKYdrvz8BrYerCH672h99tpYWBn x9ga7ImFxFnu57dUCGK3wzPWgPwK2T6rpbuhQ7PKZBwww47O9Op9y7_XayVBGuLvM4toKmmumeG5 0TGWmYnVnm70BdS.YYIIbEX82I0Icd8KoYMct8NDcUdVZU0xxxLswGelSJ62mAR3NbHwTc3Nezwj L2C279aqkmvhZAwWXiZ0CXozB6mrCJlEaDGAp2d1no.SjaGTMwI21bTCaz.fhKF2fofFEty09.DS Oe0k8dJaEtxbg67KjEBDbLT72mCFMPXaZBNQfnSRSyuUEl_GCwTZ5JcPtAMxUepW3N7dBR6IVFc_ IjXBWtccfszcw5lufZkChrNNZvRe23uwVRVCQM5bnUfXRPBYotOB8pbzmnEPhj6xiNfFk.qwA.FO OC88TOEDUrG8GwFJasX5BGVwWs4WhmLtDK8IpJR6.EuoCR9b09xDnrT_WMS58xpWFJBgW82hkzLf Npw8GHHuQOJqOPP7SDLTETtZktQHUQ7uFFJj507eMyqx1sShWh1N1d8Uxa_SJQ_x4UA1pDzD7JKV 6KnUXyvu5ZA4bjGFsOmcHztpRWzadcvRuvO8lKN7Q7X3zEchKLzKsXFinfpiUWn59iqQH8IMbDkz RKlnc8LKlhm6b9ru2JhD9VrFmjqsxcpslEuyXXD9AFR6LSzM3glw3oTX41J5E8LBDHh3NfTT.6jE xh1fCUx.t3yl8VQU4vwjDX.lsCGxLic8fm8QjIHex3bNWuuhBtgkbwk_N.qrk1rNxpMOfiEeMQQy LJsjqn.tOq5eT4RIJo3i6m9Tp1ga4bhJ0c3hUqENYjTezXAzGez3ARjZLMAeVoMkYemcTSsac6xd vgYtAxBN4Gr1QCU2hH2eHk4x00nqpeRjOQzvDx2yHI1Xgc2OCDDWixFWFPEAHLDOAv4eL4Wy8R0h u1lbUf8_ghnIRiTXwv1dcsmryNwPG5QVV51WM.OzygyFmMsJiuxmVsd3iYiobGOefyD3qtD0gRKV j4knqO3uylgTbIz_bc81wNgEfGjZjMib0yQ9EZK5sweTImjQQbDQiJsAPsNEtpHxAHsgsO81hOQ2 VUEpwkoRaDHtzuNdu7b44MGwIvYy8tmBRj5WBFFBkFop84l1RRW8m8gZ_P4p1128t9GMmw8hArZy _dcHNvRvN.B8wB9lmyVhE5LIaL92j.pVFSzEZS5TaW.Nx33Od6EGrbYEHEQ0_HIG9vvEBVxRzd8R ouOw8AmEyjH_35PpEVkhDF5oFQyUPDM3okK0psVFmZkaAejhhauWIaToDbpmxyqwEid7nYNx.EBc OL.uNYr3L.NxbtwPyfbMv9Ga6_5XvWbdcXY5GY3GG9ZRm2cKDqeLLabjEZQzOLOn3MXgo6wLaKv1 Z_8ak2swiTXFLIUWEG95xy5LozGU_YESZe5QeVI3AeoxEt26Wju3bWRgidvexOrDQBCd58eHXvCj QeG9vqsOktQ82E0WEiD8pnhBwlgKyDP_N97mkOJ5UpMrMT5oO.341AnQAnhyrTfzhDBcwWDs2zyF b3AzrBhNsC0p1f4.xOku4Nv_TEoyVrbFVIGBmqM1d65Bz5H7gfPq1cR7MverriaHDKqdmCjaDgz7 oWvAiidUNH8X1HYrKDVfUUb3f_QfMvuAMXha_6PqSnvtLtNWJgEQemDCiizWnLQPQ5DAV4i0JSaA EXMZLR0Ejb0TCfCfRQV15KJ.F7PR3AYYMx3vPWMXXdkkEYOlDqTBCthnZtj1_OuNu33_JHZ_UsrB Rr.lKpJXseY92fU81IYoXdYPMmSz68DNYZ4i7UTanYRxpDarNysQbrZpHl9IJzoJWqHAdi5f7ZbG cYZF1QuRiyfeYLbCcCfx9koilW0kl4NKcOPmf3oWOwtNYO9t_D9Jo56i3KWrw3pEK88J5dE.FfIg P97Ty_Uitg.N1Xecl6X1zI0gSgwCB4qp.Gm5xbkbYkdQ0xPHznz2GDeJUm5zthA0azMndK0Pwr_B 0Wp2X0uxLFuRxRKKj6OHOEJctKje8ApLSGuZJ97koanUu5fe.EQ6dTqt1vWTFGMVE1dJRYvL.VCt GO3PC9kKL_hOorOXghe43Lo56kxyWX5yrhtZuvpK9iRc- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ir2.yahoo.com with HTTP; Wed, 15 Feb 2023 15:41:45 +0000 Received: by hermes--production-ir2-65c64dfd66-fhq4t (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a8f82125e86db1c10b4afcb3a99308dc; Wed, 15 Feb 2023 15:41:42 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Daniel =?utf-8?Q?Mart=C3=ADn?= via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: Date: Wed, 15 Feb 2023 16:41:41 +0100 In-Reply-To: ("Daniel =?utf-8?Q?Mart=C3=ADn?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Wed, 15 Feb 2023 11:54:17 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3556 X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, Kai Ma X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > One downside of removing raise_frame is that, after you press C-x 5 0, > you cannot start typing right away without first focusing on another > Emacs frame manually. People would consider this a regression from > previous versions and something that doesn't happen on GNU/Linux. > > A possibly better approach could be: > > Once the "other" frame to select is chosen by the code that is just > above in frame.c, call some Obj-C code that extracts the EmacsView and > makes it the first responder: > > EmacsView *view =3D FRAME_NS_VIEW (frame1); > [self makeFirstResponder:view]; > > I haven't tested this, but perhaps this makes the other frame receive > focus without switching desktops in a multi-desktop configuration. The attached patch avoids the unwanted side effects of raise-frame by making the other frame the key window, instead. Could you give it a try? --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-NS-Do-not-raise-a-different-frame-when-closing-a-fra.patch >From 50cb6ed653b17bb5f712872f3f664e1273e498d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Wed, 15 Feb 2023 16:33:14 +0100 Subject: [PATCH] [NS] Do not raise a different frame when closing a frame * src/frame.h: Declare an NS-only function to make a frame the key window. * src/nsfns.m (ns_make_frame_key_window): Implement it. * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of Fraise_frame. (Bug#61525) --- src/frame.c | 5 ++--- src/frame.h | 5 +++++ src/nsfns.m | 5 +++++ 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/src/frame.c b/src/frame.c index 983424b0bee..b2319a35aed 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2152,9 +2152,8 @@ delete_frame (Lisp_Object frame, Lisp_Object force) /* Under NS, there is no system mechanism for choosing a new window to get focus -- it is left to application code. So the portion of THIS application interfacing with NS - needs to know about it. We call Fraise_frame, but the - purpose is really to transfer focus. */ - Fraise_frame (frame1); + needs to make the frame we switch to the key window. */ + ns_make_frame_key_window (XFRAME (frame1)); #endif do_switch_frame (frame1, 1, Qnil); diff --git a/src/frame.h b/src/frame.h index b95b94c7685..2eb9de81f0a 100644 --- a/src/frame.h +++ b/src/frame.h @@ -1380,6 +1380,11 @@ window_system_available (struct frame *f) extern void frame_size_history_plain (struct frame *, Lisp_Object); extern void frame_size_history_extra (struct frame *, Lisp_Object, int, int, int, int, int, int); +#ifdef NS_IMPL_COCOA +/* Implemented in nsfns.m. */ +extern void ns_make_frame_key_window (struct frame *f); +#endif + extern Lisp_Object Vframe_list; /* Value is a pointer to the selected frame. If the selected frame diff --git a/src/nsfns.m b/src/nsfns.m index 8804a7df7cf..cd41c6095a0 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -685,6 +685,11 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side. SET_FRAME_GARBAGED (f); } +void ns_make_frame_key_window (struct frame *f) +{ + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; +} + /* tabbar support */ static void ns_set_tab_bar_lines (struct frame *f, Lisp_Object value, Lisp_Object oldval) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 10:50:04 2023 Received: (at submit) by debbugs.gnu.org; 15 Feb 2023 15:50:04 +0000 Received: from localhost ([127.0.0.1]:33683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSK2l-0008L5-Ev for submit@debbugs.gnu.org; Wed, 15 Feb 2023 10:50:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:36772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSK2j-0008KW-8e for submit@debbugs.gnu.org; Wed, 15 Feb 2023 10:50:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSK2i-0005Dl-1U for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 10:50:00 -0500 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSK2g-000830-Bg for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 10:49:59 -0500 Received: by mail-pg1-x542.google.com with SMTP id a23so12826567pga.13 for ; Wed, 15 Feb 2023 07:49:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UZESHUey2zKd7M7e4rLXE+X8zq52al/8reB78xfv9Zw=; b=AH/MQmVkg+dnDJMkDvP7uMuZ8K6EkDRNR4cm8aeoa2JIZmm8RqdBaZzSVzyfDnUAkA OA/qYAGCqU+favHNs8lhEnt469Vcj0xNPvVc5tU5u8kUfSo35dmDzd2XMDDcAKS3lZJx pkeEJF3DVlKtwz87LHasNjv8vKkbu6lEMm6XbLlAeEKohnCqPkIgxlEMuPD6IxepLBR+ BaBHrH2PM4r7rFAp+/LvAKu+3nhIgWwzolLuSF7lDKbDOB2fNFfQN7b+t8gl3IcSga69 RfNMAHVuympI5oT7JYvDigf1v61vE/6huIv2Cq+qeQUd3tTwS9njAWiI0N1nmlWhv6ut S0oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UZESHUey2zKd7M7e4rLXE+X8zq52al/8reB78xfv9Zw=; b=5Ny8TjrUP6ovmIyoXZVfxEV9wFvCK1bk8h36QQowqE0dKs/rsWj3XSY1AyP8ZOG1IA MBgGc+xj2yii++CwZVXQaUBH+60/ycZxyq1tV5qoXedHvYN5U6XqaqA6NMWsSZUO4Yfx mW4QhmX/YvD/5CK/uXP3QRb/8DRBcxh1BVcvxFDxPjyuGVbPHCJvmwjykb/gJii/7Ujy +4K036+yHbqdfEXjMujkyZGaMriRNyhp6YaO5DsEWf8VEoZ8/PmMXzaXdW9URQxK4hhg WECJJuxIQ983tlIoGwjG1DhS0tJZnK3TvZVA0sdbRr1PP6NoCNwVdA1oZYVR49qPwtWA mY/Q== X-Gm-Message-State: AO0yUKUVX3ljwvayZULAYKQA5ndLti7HsAsCC3uPIVtLpr13tFIKaysW 3/WoG3ig5q6Znu2lrGwgggQ= X-Google-Smtp-Source: AK7set/royCubIekQnIANkXO/gtTCo4GYV/RcMZDc+lzz7/qdK+1Mg6cRo4XyKZ20QyvN52BTiEJvg== X-Received: by 2002:a62:190a:0:b0:5a8:46b0:826f with SMTP id 10-20020a62190a000000b005a846b0826fmr2093909pfz.22.1676476196268; Wed, 15 Feb 2023 07:49:56 -0800 (PST) Received: from smtpclient.apple ([2404:c800:922f:c43:a8cb:bbff:fe7b:8380]) by smtp.gmail.com with ESMTPSA id c19-20020aa781d3000000b0058bc7453285sm11859541pfn.217.2023.02.15.07.49.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Feb 2023 07:49:55 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop From: Kai Ma In-Reply-To: Date: Thu, 16 Feb 2023 00:49:41 +0900 Content-Transfer-Encoding: quoted-printable Message-Id: <67519603-3933-4CCB-8118-F6304D356D2D@gmail.com> References: To: =?utf-8?Q?Daniel_Mart=C3=ADn?= X-Mailer: Apple Mail (2.3731.300.101.1.3) Received-SPF: pass client-ip=2607:f8b0:4864:20::542; envelope-from=justksqsf@gmail.com; helo=mail-pg1-x542.google.com X-Spam_score_int: -15 X-Spam_score: -1.6 X-Spam_bar: - X-Spam_report: (-1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_LOCAL_NOVOWEL=0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit Cc: 61525@debbugs.gnu.org, =?utf-8?Q?=22Daniel_Mart=C3=ADn_via_Bug_reports_for_GNU_Emacs=2C_the_S?= =?utf-8?Q?wiss_army_knife_of_text_editors=22?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) > On Feb 16, 2023, at 00:41, Daniel Mart=C3=ADn = wrote: >=20 > Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army = knife of > text editors" writes: >=20 >>=20 >> One downside of removing raise_frame is that, after you press C-x 5 = 0, >> you cannot start typing right away without first focusing on another >> Emacs frame manually. People would consider this a regression from >> previous versions and something that doesn't happen on GNU/Linux. >>=20 >> A possibly better approach could be: >>=20 >> Once the "other" frame to select is chosen by the code that is just >> above in frame.c, call some Obj-C code that extracts the EmacsView = and >> makes it the first responder: >>=20 >> EmacsView *view =3D FRAME_NS_VIEW (frame1); >> [self makeFirstResponder:view]; >>=20 >> I haven't tested this, but perhaps this makes the other frame receive >> focus without switching desktops in a multi-desktop configuration. >=20 > The attached patch avoids the unwanted side effects of raise-frame by > making the other frame the key window, instead. Could you give it a > try? >=20 > <0001-NS-Do-not-raise-a-different-frame-when-closing-a-fra.patch> Thanks for the very fast fix! I can confirm it works for me on macOS = 13.1. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 12:08:47 2023 Received: (at 61525) by debbugs.gnu.org; 15 Feb 2023 17:08:47 +0000 Received: from localhost ([127.0.0.1]:33815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSLGw-0002Cm-JL for submit@debbugs.gnu.org; Wed, 15 Feb 2023 12:08:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSLGt-0002CU-SR for 61525@debbugs.gnu.org; Wed, 15 Feb 2023 12:08:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSLGo-0004HW-FP; Wed, 15 Feb 2023 12:08:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=KfcN7WdTddVme6ZRY/7e6L8kdcS6S9Q7fsxnD4pmQ4w=; b=SyQ0y04K1P6lUTXsJqzH sWDIrfhGodQcSChl8VSpVbhvBeBwoArR7BXKWCIdjSlmRQfxPe+QS3zR7/e84PB74KDBsy37qE3+W y4O2GeGfBxMkAs+9OwP+7jLWIG3xSUFGtRNtfhlkNSwQgkg9i6mZgReL69lgzuI/ZQJ60CL93h07b kzaiPiIkOBPacZFz6HQ043D2JhIvYrNepz+O86UAsa8S3R9l4uR5Gm5oIObJEN6qJrQjQfl65il/m hNXfkbn3KkEAcHhRzwkqMDWNUT/T14+zE/MIJq65qqY+134XDWdfHdbBHeT8FqpDQb//dk+6I0Tlk 23XOAWr/KxpTgQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSLGn-0005C1-NJ; Wed, 15 Feb 2023 12:08:38 -0500 Date: Wed, 15 Feb 2023 19:08:19 +0200 Message-Id: <835yc2c0vw.fsf@gnu.org> From: Eli Zaretskii To: Daniel =?utf-8?Q?Mart=C3=ADn?= In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: justksqsf@gmail.com > Date: Wed, 15 Feb 2023 16:41:41 +0100 > From: Daniel Martín via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Daniel Martín via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > > > > > One downside of removing raise_frame is that, after you press C-x 5 0, > > you cannot start typing right away without first focusing on another > > Emacs frame manually. People would consider this a regression from > > previous versions and something that doesn't happen on GNU/Linux. > > > > A possibly better approach could be: > > > > Once the "other" frame to select is chosen by the code that is just > > above in frame.c, call some Obj-C code that extracts the EmacsView and > > makes it the first responder: > > > > EmacsView *view = FRAME_NS_VIEW (frame1); > > [self makeFirstResponder:view]; > > > > I haven't tested this, but perhaps this makes the other frame receive > > focus without switching desktops in a multi-desktop configuration. > > The attached patch avoids the unwanted side effects of raise-frame by > making the other frame the key window, instead. Could you give it a > try? Thanks. > +void ns_make_frame_key_window (struct frame *f) > +{ > + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; > +} Is this new call guaranteed to exist and work well on all the supported OS versions where we have the NS build? I wouldn't want to fix this on some systems and break it on others at the same time. Alternatively, can we come up with a change that does both what the old code did and this addition? That old code did work at some point, I presume? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 18:49:15 2023 Received: (at 61525) by debbugs.gnu.org; 15 Feb 2023 23:49:15 +0000 Received: from localhost ([127.0.0.1]:34454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSRWU-0003u5-W0 for submit@debbugs.gnu.org; Wed, 15 Feb 2023 18:49:15 -0500 Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:36227) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSRWQ-0003tp-LZ for 61525@debbugs.gnu.org; Wed, 15 Feb 2023 18:49:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676504944; bh=gZCIv9lqbuZ67TgGGoAK/4qENfjLUGYQZk6MtVK+2hs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=XHbPc5esk4b59r/pM+mqlxYzYNCy77sCKzGgkRRKGza0qMyT0iCl2DEv63pljh1Yvou71IkTeks0d4xzi93ui7JIBq7VCBghWPbmAojMJvyKIJHmk3gwK1/oi2e8TpByuhkIPH4MiJ4+EyIn5chbnyS2H3D8ewTJzUMIsjsfd7UDA0CWNBddX5NovOJaSIWoTINZFJYe2CUSCHZVCNwcS/h2q4V+rMiRa3UqI7ooF+Ip6YgH6v0QE+RbbEA1FX+7QK6qkNZidALaLRR2/mn8UItq+XWq9i8QTqGZKzA7bOzVhUueABYvrDJEyag/bXDSvr+0Ei6ag2+8L70KlU3qMA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676504944; bh=OO8FMl3iXp64rlqbC5DLnjgBjyuz6CLYfYxcDm7cZqk=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=n7tbkqTto1YpaEmsql/6j4mcQzjgH1j4SdwN7AVtWZB4UQQmLTI0uPs/rt+5NH5jl+ESrCce1eT1Tk8UPZ5PU5wHbYluCx7Iz18lc/cUtAmwUbrh/QgkUIMkZWP2R5X85FEGDnS/6exxODt1lWP6C6FAMHfpO57iJmxHmLhwRqUamkpKgHvrB3wpBqHIWphiZU7XEHSyXqiRkYpJGD+vGNW0A8QWQARt4rjIjjFFVrDey6zH2TQFMkq0iLZaO8FYUUT7h/GWEeG0ZC34rhQrCZdIUqrbKOY+c/ZS07gOQcvVtxx2svN41flsPklWuoE5ve/BmBAjxc8IPCHBfwYDYw== X-YMail-OSG: r6knUCMVM1lPHB_PW300xgtefuNE7xsO2w.Vu5T1Fuh4Egu35NwIq87Zo2a4XbX 22CWdiBYwFUgECux20mCyY.MClBNI6PlUoLj1qjLLHQpSPVg3k348htFr78IUvdvYKZwEW0a0Y4F m2XjfjckBd6a6I4GaTnE0QZgm9.c7tMWnVVwh1M1iMN9F7kbkUN7FUa121SUJl16.pJG1xetskr3 rNcpOplb51T5R3BR8EOXki4qhyb3CS2cEQ4pOLVHqD.a5fQV4ACePgTlupK4lJ00Nd2TcOgXHxkP U1YL_KOf_XNKnZ1fp00i2P9NZgfxxcdGuDyBbsAneo09.w8Q66CdUx2UuZnThLM0tEkXzUwwp_E2 Z8.fSY1h2L_YLENqn9wOj0qPJsuhN.38S3mb089H_KEsiH5ySYL4m3mC2zOKJkU2I8D6B63D9RE8 GO9AEMqpMnun0JX_QQLsaEfRzqu.Mc8Mj45wnypZOiwwWzpcEhkMmir0BXvCBOj2UzG1nEAy.xn_ wS1a8VDdmxEeSpU3eXT9GF10BbWhV6vLNxscg8AiD83s1mw8MROIg2SKp.wKRiRYgQ2CKXe8ASE_ icXvKeb.HPIu8ZKmdsiHHq0H47_6eQLpGeOKOzWe28ezwor9McU0mgDg1Q6F6DavwKsS5LXOa3wE 1cpHI5hQdJKd_EnKYHZuo.IOL_X4WUdABanTPjZZlPqc5GAi5P44MkkQO.b2mzutqR871CVeE.MB 680e2WP4NHDBzTVzH7Ol4qXSX1Sl7gbVAC05EsH5okbJjV7h.nOMB1VH2X5MCZlmQwvubE5b6FYs YkfKcJ4Ewt7a81U050J_HlwpcsWQ0.BiZkc2jyMIW8Vwp0yGrDIkCZqi7pGSHEkPelDDj8ipO1nS Bh8rjRI0B9dPiGtuREC5BX265GQKTgulE8yK9yPh2.baKyQ_duNIfHhen4UU4McnP6oSPy80wrqQ ExB5jnCUb_jZSF5tXVOS8TjfyJjp5PR2rhgnx2M4bt0vU1vm81YC3xS1nGmUAtMd5jMqpDSSYjCE NwPsRnpYGMwijmFO.d5jK9YNxdX7Fh94Y8hGx.Qj6FeZeGluxUNqyv625oFUxjQz1QMqFGr3B2vz wpEnb_vAf9oMkqpS1zQ.H_BbqnvE4onNNmP90hjAOyirrkcuxuk.wf4PsXr1ZPN26xTp1iZZZENE vECZFZIu7V6g6pvIDtuRd6LgYG9vRloB.aHGSUnl9flJRLMIr5jKpRnBzdSSGD1T.ZaaJN2mF54o GB9Owe_5_vu7VX0kAhO8u7fc.eYaKvsSlmjZNXeT75lSbnLDaTk0ciLNVp1i8h5ZrZdkyjMiDIdc rZ7.Kkcm4lp12P4l_9TXqQaMMfSxiBFfbHvp9YsTf.TKbaJSXMr5dEckTmqpFvleE_k0Q7lm60r. YTwFcibN9d6VyQUsKZX4kGtL4D18bPW7e2MbXsvwCjReJo0O2WN4.uw.H9IV6XU4lBOK5wEiki_3 S.84UMTLxnkcw30dKQSX_pBn_Hs8T1HODyCNzTzHc_GQV2zrQz3hthEBNUtMLNG6Rd8oSaVLddEA yPc93wivCG4Wc6j42h_qttCr5McU34_BiiZrB1.m8PeHVOKZdzQ_jv0eNzGMED4g8pMNwd9tk6S5 bqOPQucgBer90aXhyVm6E50bZoOAfQyjjtvGOO5gKoDy2aMtYPTAwUS1SO4dYpx_PzJaBF7UofSE 5uQaSea8W5wh5ptgxkPF1R_G9pzeZyC.Ypa1yRVtNuReqTMVKxaRSNPVu5maOics4FMtxlw.VGvn W_LhLGCy5gANrXdVYVEo0ulrgUfbtkyQEW0EezlW6iIoWfiERHHmOQeGtUtOdmToFB7Qi0fXaChO Q0y66wk1mXB1o9p9QlvkEVWfJR3jJqisd4nwM.pobQZOJcFyZtSa6saE_Luhwdn8B5RgMhqjfIeP MRLdT7vJ.XUZFg98fUZPKkBV3nAqphtF08wV3DApKC8xXgQSdwJ6QApNQKfTymsRen0RhU6xI5.B Iecw0S0jTks6Qz10j61.DURfFwQ3wt4f4wpCkapkSUuWYCAvnL4XO1QWcIGqYUadtynLsOb0rduo 6IXe6ebYFyItgezAP.PZs0HJzdWTuV8xWfhGP8i4YcujwvSl9SYtkUsmH3QNNm7JjeKQqeQfH7Us nI4JvFVRO3yTzkR_Hug7Tow0ZAnoc.E3GQmm5Rif3ET0o2XgLPodwwyLkvm6LJ4dMya_8GLvbyIS eeQ8ykYHAzBfo12PYZSvpZOfarpBaqi3mruKV_wJGLPQ- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Wed, 15 Feb 2023 23:49:04 +0000 Received: by hermes--production-ir2-65c64dfd66-vsc2c (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 366fdfd4be3b624e76b5d97f6b008fe9; Wed, 15 Feb 2023 23:49:00 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Eli Zaretskii Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: <835yc2c0vw.fsf@gnu.org> Date: Thu, 16 Feb 2023 00:48:59 +0100 In-Reply-To: <835yc2c0vw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Feb 2023 19:08:19 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3995 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> +void ns_make_frame_key_window (struct frame *f) >> +{ >> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; >> +} > > Is this new call guaranteed to exist and work well on all the > supported OS versions where we have the NS build? I wouldn't want to > fix this on some systems and break it on others at the same time. makeKeyWindow is a very old API that should be available on every macOS and GNUstep we support, AFAIK. I see usages of that API in other parts of the NS build, in things as central as frame creation, and they are not protected by any version or system check. > > Alternatively, can we come up with a change that does both what the > old code did and this addition? That old code did work at some point, > I presume? This is not the case of the old code breaking at some point. It's a difference in behavior between the GNU/Linux version of Emacs and the NS version of Emacs. In GNU/Linux, if you place an Emacs frame in a separate desktop and press C-x 5 0, the window manager does not automatically switch to the desktop where the other Emacs frames reside. I don't know the reason why the NS build has been calling raise-frame for so long. I presume it was considered a good enough way to refocus to another frame after closing one, in a world where virtual desktops were not very common and the behavior reported by the OP was ignored. I've attached a revised version of the patch, to fix a couple of code style issues. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-NS-Do-not-raise-a-different-frame-when-closing-a-fra.patch >From 07035d7bfadff32d6ff954c221331f2060e0f5fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Wed, 15 Feb 2023 16:33:14 +0100 Subject: [PATCH] [NS] Do not raise a different frame when closing a frame * src/frame.h: Declare an NS-only function to make a frame the key window. * src/nsfns.m (ns_make_frame_key_window): Implement it. * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of Fraise_frame. (Bug#61525) --- src/frame.c | 5 ++--- src/frame.h | 5 +++++ src/nsfns.m | 6 ++++++ 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/src/frame.c b/src/frame.c index 983424b0bee..b2319a35aed 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2152,9 +2152,8 @@ delete_frame (Lisp_Object frame, Lisp_Object force) /* Under NS, there is no system mechanism for choosing a new window to get focus -- it is left to application code. So the portion of THIS application interfacing with NS - needs to know about it. We call Fraise_frame, but the - purpose is really to transfer focus. */ - Fraise_frame (frame1); + needs to make the frame we switch to the key window. */ + ns_make_frame_key_window (XFRAME (frame1)); #endif do_switch_frame (frame1, 1, Qnil); diff --git a/src/frame.h b/src/frame.h index b95b94c7685..30c1de20fde 100644 --- a/src/frame.h +++ b/src/frame.h @@ -1380,6 +1380,11 @@ window_system_available (struct frame *f) extern void frame_size_history_plain (struct frame *, Lisp_Object); extern void frame_size_history_extra (struct frame *, Lisp_Object, int, int, int, int, int, int); +#ifdef NS_IMPL_COCOA +/* Implemented in nsfns.m. */ +extern void ns_make_frame_key_window (struct frame *); +#endif + extern Lisp_Object Vframe_list; /* Value is a pointer to the selected frame. If the selected frame diff --git a/src/nsfns.m b/src/nsfns.m index 8804a7df7cf..96434230cc6 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -685,6 +685,12 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side. SET_FRAME_GARBAGED (f); } +void +ns_make_frame_key_window (struct frame *f) +{ + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; +} + /* tabbar support */ static void ns_set_tab_bar_lines (struct frame *f, Lisp_Object value, Lisp_Object oldval) -- 2.34.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 20:39:18 2023 Received: (at 61525) by debbugs.gnu.org; 16 Feb 2023 01:39:19 +0000 Received: from localhost ([127.0.0.1]:34528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSTF0-00072A-KV for submit@debbugs.gnu.org; Wed, 15 Feb 2023 20:39:18 -0500 Received: from sonic311-52.consmr.mail.ne1.yahoo.com ([66.163.188.233]:42422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSTEu-00071s-WA for 61525@debbugs.gnu.org; Wed, 15 Feb 2023 20:39:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676511546; bh=J7y3DXSpwMVUJpnQMwtT+kQZZ1zv8bo+g14DwxFwWvg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=m7rwrsMZFvpbpMssJR7QnFeaVcfnsGGKcn7coE3xa4cvU0yJ9UFS57RXPS/1AesADkkeRZFFtV0m0QODfDS7NtHSzmfeRuJZQHSNsvxeYOFcU4FwiEprcDeppphyr/5A1Z4Radj4TwG7ibkUiMuSWW4gCFBNnsy40Ly7ig6O62Ly3uLb4fMLiJlVw/+5/NjxvDtJXOLtkEBUCzLeOxGDr8QL07p61A8TzHpTZxAu7TJqg7zpCDDtb8Antp8dcSfBjDrzjIF1Me/MdAEioE81W9kjP0f+4EkzijW4U9m5rctgcRuGEyogjn/q0qotRhYYRIsSeNNxmFdCTCB2naiB+g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676511546; bh=0u0L9AJdRivBIabnl5NYlCeucL7tUsAzQUjfA/0bWn7=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XIcrn7k+N5e2+7lOOwprx9guimx5lodZl+yynkuxqk7VdpPgr8HNICe+M8GBl/T0G4oN9wqHVqd5akch7EKTo40o4cm/j3nIqtz0LftSfKgHWeRROqwzVHDjhr0FyRSXSzR2e4uJ/ROwnsHPelLfNKPiwA42FtBTuWIjFLutQUhKnn4Tb9tSqfIEuwwJiJBmauplXb0982sZ8YHaWo5TywBxcChfY/cHy7REn3RYtTcV+x6uLNNGJvNqIUmnFQ3yT3rnxI4LtX+8oTGLg9Zc1pGfJcb3qo+QL1UQTb91VpXijdcxpaZkmdcFSpP5gM/53038kBkzhmH63OzxjX/xTQ== X-YMail-OSG: TnHxDPUVM1naaIylZlbdmjdy6zBUA19UXX7JMW65QkfWTd0imqCH0vw8SPAY34h sqpVUMYediddGDRu1PugDz0d_oTIuAhKEpdMVSaVvSVLLk01U0Ya2P4WgZFP7ksnRyyA8N.LMyme rMutZimtLeXGGViT07CHa7gtGfl..b6JPgRC1frx_NyW4RCANkGka3D_QnsV22kP5qVK.fuZUIIk YLyH1WXdndGIxzsBQ5_qrINqkL3l4DsvtK3U5bDzikQampUOH3O0LrqXQeLbdyGUsj3ZEDAfH8zY iFTVJZWEC8EGldVni7fHhAx0YXI8U7hLTgvZnWP6Tx7NJ_bW.GWu60iUk5x2ukWtWB4X.XFtdBsw jPZMnqR.MQm7lxJZTX1kJrTP7OqoN4VLtwHXreRnOmnrfypcAOPV4x1gRsZxjHoFEry_D9SKX4Lp 3mmqUQhT1OEEP.z5.Dg3rHR_Cb5mlrllqgMimFz.Khmwu1dKm9tiSzqgL2qGEw1uj1u69bjwIq4L LTHR0QBhqKgXGWhI03JSAwHIBR7ppo5gn7Qy17pICa_wLRoAwFfgGYVAWiNXKOjjD9GNBn8F4oLl NEQWIi5DMMbrS8Fy311iafP4G7Zkzz63kZpXujivgv3xT.xb2tt0Pczx.4p.RmVMhzhZ3QYdxWJS pA7eSy6AmK16NAlbUYSSS4X_WYOHG1moyjoP5fY6exN09Q7kz7VAlZUbl5pA1ChAl4sdFYUEkhgR DfyEq115KlDOGIYtovb.fuwb2D0t17lMuIAN5.Igz6S4_9nBhWoRw3IeP4bdk8H4dvS3HNYBg3Bh fka.oSoa2pk7t0JsLpWiMxeZBp33zAR_WTIO.NteJWgQaLdjAZIS7tze2BoPvsxjTPeSlnQ0lLlO Havxnw7GQoclQGBILKSTKGVHXUImX87e8LwKN0BztucJ5wNgpm4NlbMXduoAvToHY4OmLvuMFVoi IC6iN2b6cQuz6FWNNm6kQabuq_m9X.nDJuzAWIoshL1TXO3C4KCAFV_yfLxGfbveLQjxfk08bDbO 3vULhB8RN1aiBzP6y3eHXEtByqfAG_D43kOa0ppjtoF9.NS1DlDTi4wTf_m1KK4cBk3ZS.Z.Qbar RJaq_ityxMOTyTGY3ymE3FgxybS4bvGSBuCigvrYBdIHiyQr5.hY5hLdyZNWQHNI3GhAF1hXx75P 3SxSNKpctbEIdF.wDCnBjFD5F0kt5vYIUFKLg9mTmTnpUoStXtWUDZeLnH7BACiJbhsm52KQcsUn GWq8QWjfyYdmV35o1axIdhtYh2VOXmDeQtTbJvdadKV3RgMlOBnWD7cQysr2maQjYc0ZCmagUMiJ Pp6hqSxlHwpy550wwSxyWBxJTnWJvzdRt1eUqDgZMWaJTMJGmJLPPbVeVmaCi0CYDgVUMAbm_1tH so8lb4zCoOGH2gq2g8YLdMpC5ucFmrhusbRjYCMcthsnA2anz.21RKeUk88u_WXErmnivMifS6QM GmEzd0LyYjvZZflKT1Mn5uArTGI.D_8h4PUKjqHLHTqM_dgqxojNiw106nU8wvIM03T4xq5LD1gY j5QWJwiKpxPNgZUuJVQQ3e9nPhNdgo5vFJZb80zkq7lSQ4grDQ8zWRANK7xG81aw5oObbARFxthH P_caXrT7ueyLTfw3TS2KA5ggWAITqmZOn..67XGGTUEdNQ2jKP64Ib0KVbp5ekVq6UXLtuoESgOd iL6CT8aIferpbSgEtYee7f6u6UTZIj4VmXo_bZrxsO6vhAC3aaE6sYd_vA8nV7aZyJgo_Tmwvl4r RUapstVBnwx.Tz.Gb.Xjai8yqFMykG27Q7JJofP4HA11GTyHhQyTXbJJoUoc.YzbESU1cq4xpTWU _MbVVIb3CbsdUq3.zWwigoos9zRqRcXo9cBSTVib8vK2uZ6YSCsu6ekWfSGKaN.YHiRym8D9OoCz wzuqIUzhomJnLABElT7Jbj.S3rK1ucknjrjTrN4iCNL_KSppBJYTZf1KkoWsQdxb3QdU7XLngttM TihNlMkMemtzjsgDKym7EV6BLUoQV42qdhf8X.PFLIDAGK3s.W_X0HrmBjJQuEwOM9TNmd2f4py1 I8B6SXJaF_giuWTirnlCuEOJisdsFIjO9zU2IPwqGNj5ZJwvrnP8S8CHY2Xckm1P3pFyJeAzpvu5 6z9K2H0Bann3C.Bkj259jlHqPgzisyxKlf2ohdKy23.tMtOjzuyS24wr6lc6T0eWp4t66HFT1sp6 T2AVEGOC_XnfiSYwo9DZEHWz15B9RXfrx8J.xY1Kx3f9.paUhfllP4KOTEm5kR9LUCG61 X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.ne1.yahoo.com with HTTP; Thu, 16 Feb 2023 01:39:06 +0000 Received: by hermes--production-sg3-9fc5746c8-pz6sb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ea1343912508f178e916992d8e4b5638; Thu, 16 Feb 2023 01:37:03 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop In-Reply-To: <835yc2c0vw.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Feb 2023 19:08:19 +0200") References: <835yc2c0vw.fsf@gnu.org> Date: Thu, 16 Feb 2023 09:36:46 +0800 Message-ID: <871qmqs85t.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1843 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com, Daniel =?utf-8?Q?Mart=C3=ADn?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: justksqsf@gmail.com >> Date: Wed, 15 Feb 2023 16:41:41 +0100 >> From: Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >>=20 >> Daniel Mart=C3=ADn via "Bug reports for GNU Emacs, the Swiss army knife = of >> text editors" writes: >>=20 >> > >> > One downside of removing raise_frame is that, after you press C-x 5 0, >> > you cannot start typing right away without first focusing on another >> > Emacs frame manually. People would consider this a regression from >> > previous versions and something that doesn't happen on GNU/Linux. >> > >> > A possibly better approach could be: >> > >> > Once the "other" frame to select is chosen by the code that is just >> > above in frame.c, call some Obj-C code that extracts the EmacsView and >> > makes it the first responder: >> > >> > EmacsView *view =3D FRAME_NS_VIEW (frame1); >> > [self makeFirstResponder:view]; >> > >> > I haven't tested this, but perhaps this makes the other frame receive >> > focus without switching desktops in a multi-desktop configuration. >>=20 >> The attached patch avoids the unwanted side effects of raise-frame by >> making the other frame the key window, instead. Could you give it a >> try? > > Thanks. > >> +void ns_make_frame_key_window (struct frame *f) >> +{ >> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; >> +} justksqsf@gmail.com, please write: void ns_make_frame_key_window (struct frame *f) { ... } instead. > Is this new call guaranteed to exist and work well on all the > supported OS versions where we have the NS build? I wouldn't want to > fix this on some systems and break it on others at the same time. Yes, this seems to exist in GNUstep (meaning that it should exist in an old Mac OS as well.) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 03:10:42 2023 Received: (at 61525) by debbugs.gnu.org; 16 Feb 2023 08:10:42 +0000 Received: from localhost ([127.0.0.1]:34775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZLm-00011b-Ce for submit@debbugs.gnu.org; Thu, 16 Feb 2023 03:10:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZLh-00011H-0P for 61525@debbugs.gnu.org; Thu, 16 Feb 2023 03:10:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZLb-0003rb-Hn; Thu, 16 Feb 2023 03:10:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jS1r8E8FYEg1IVMNvJv+3ddOyKyc3Bo4TxyMNqWE4Zg=; b=Ud33JwPqQmhgBaDsvra4 WiL+ySmeUNCmaZaxppnBOKajet08G7FNlKda4F9OEl+G+szCwQuKwfwVw4MgJO1TQL0bdCcXI9A63 Cna56mkEHkr9JD9YUq4GK51CEqH1bBfry/vpIQrMpxDQGo06BHSWA3r7BhrVCOwBPKY5KlskKtxXW nPbqURFx/xMKNlLRD2JLHuSqo7xXjv3mEF/bMSSBDkjXR7E3nP40T6bkQ+urtR7tccpTjjf1YEGEi k+fF5GHgdRKpxMC2Evpib5RTJZxL5aVvXhf977E1QN0juZOf4bgY1RjvUUQSr+cuidUmff9JjPi1t y2ed/UkgL2CBBg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSZLY-0004v5-KG; Thu, 16 Feb 2023 03:10:31 -0500 Date: Thu, 16 Feb 2023 10:10:11 +0200 Message-Id: <83k00i81zw.fsf@gnu.org> From: Eli Zaretskii To: Daniel =?iso-8859-1?Q?Mart=EDn?= In-Reply-To: (message from Daniel =?iso-8859-1?Q?Mart=EDn?= on Thu, 16 Feb 2023 00:48:59 +0100) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: <835yc2c0vw.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Martín > Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com > Date: Thu, 16 Feb 2023 00:48:59 +0100 > > Eli Zaretskii writes: > > >> +void ns_make_frame_key_window (struct frame *f) > >> +{ > >> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; > >> +} > > > > Is this new call guaranteed to exist and work well on all the > > supported OS versions where we have the NS build? I wouldn't want to > > fix this on some systems and break it on others at the same time. > > makeKeyWindow is a very old API that should be available on every macOS > and GNUstep we support, AFAIK. I see usages of that API in other parts > of the NS build, in things as central as frame creation, and they are > not protected by any version or system check. Does this include the behavior? That is, does that call behave the same on all those versions? > I don't know the reason why the NS build has been calling raise-frame > for so long. I presume it was considered a good enough way to refocus > to another frame after closing one, in a world where virtual desktops > were not very common and the behavior reported by the OP was ignored. Did you try looking at Git history for this code? Maybe the log messages of the relevant commits and/or bug reports and/or discussions on emacs-devel around the dates of the commits tell something about the reasons? I've seen too many cases where changing old code introduced regressions because some aspect of the behavior was disregarded, and would like to avoid that, certainly if this is for the release branch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 03:32:07 2023 Received: (at 61525) by debbugs.gnu.org; 16 Feb 2023 08:32:07 +0000 Received: from localhost ([127.0.0.1]:34795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZgU-0001Zm-Fs for submit@debbugs.gnu.org; Thu, 16 Feb 2023 03:32:07 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:38738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSZgO-0001ZD-LF for 61525@debbugs.gnu.org; Thu, 16 Feb 2023 03:32:04 -0500 Received: by mail-pj1-f65.google.com with SMTP id kk7-20020a17090b4a0700b00234463de251so5063262pjb.3 for <61525@debbugs.gnu.org>; Thu, 16 Feb 2023 00:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=epfmkDC7Ph8fzY5L7Mmf8CSO/LR18jMPikpgosPwdsk=; b=InH745woFk1DuTRTKhob5PgYkGIG4anemTacFmEssqiVALIn6IiHOuXDgjhSl0NUzW 5SeDrx8xE3VpmCG1qVr5i+eDtmWlFBC94hH1ZjSZhYDCQC0VOIIHOoqUa3SWz1Dd7oM3 LDWB8tYSbeaRXLxL4zlDn0nrjUw+0MxhB/+QLe6ryaO7WhQltAdV3LfkvdxPTIblNq8m rdNJqllOHxosqjV3/yzWf1JYb9uTfmtpJXhnLyBbU8qO/k7q7Gk7a8bi4VUV2TU7WR/E oFz+yCZHoFqM0iuaR93q5PD9M0q79FRAUdbg2KVDInfelmyZqG7/o9GpkS3dVqjManP0 gKsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=epfmkDC7Ph8fzY5L7Mmf8CSO/LR18jMPikpgosPwdsk=; b=SP+pmxt7oBhKa2AIIGM+iwzKMEMY91kmSJ6yU2B/KnHe3EwjC+BcL/8PYrS4IUkxAM tjsPQmyihHcgiXeUBFlmOOJyHZpZKZuhnIDt8GikiCirprQXolXNovufkprAaXNC9gez v4jaw/1rZZcwY+hEnuI/teWCJV8AVKqAFX0p/5FQLzafA+IdBtq6RKO0J1dIaaXcrsCR ymsDzYlhpdNHb5U+1YO/kdBtFA/yoV1YyfrLLZkpme4SODJRj6jzLcfvyPDSnEKo1I2b ZfJFw1D/bgIkHnJ6N9ijx3kzerCTo2MYstTNJM+gevTjNn3FYs2HkTe5rSaWV5VrMVgM flcA== X-Gm-Message-State: AO0yUKVb4mETk8fygHAhUa+ot7VyUaPbtVw58Jb5nnD7StSzU/XxhrD6 PAIOsRgblzmAiVH44pv2VHI= X-Google-Smtp-Source: AK7set8FWIkyHXIl3xrSEiczH/ESf24qMc2kj3s2bkszBrBi5VVBcYy+K4DOTLqxFJsogSui7iYSBA== X-Received: by 2002:a05:6a20:8401:b0:be:9478:55ba with SMTP id c1-20020a056a20840100b000be947855bamr5718252pzd.60.1676536314902; Thu, 16 Feb 2023 00:31:54 -0800 (PST) Received: from smtpclient.apple ([134.209.106.31]) by smtp.gmail.com with ESMTPSA id p25-20020a62ab19000000b005a8ce67874asm714240pff.86.2023.02.16.00.31.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2023 00:31:54 -0800 (PST) From: Kai Ma Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_29B352B4-95AB-4B63-80A1-9C1795197AD4" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop Date: Thu, 16 Feb 2023 17:31:40 +0900 In-Reply-To: <83k00i81zw.fsf@gnu.org> To: Eli Zaretskii References: <835yc2c0vw.fsf@gnu.org> <83k00i81zw.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, =?utf-8?Q?Daniel_Mart=C3=ADn?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --Apple-Mail=_29B352B4-95AB-4B63-80A1-9C1795197AD4 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > On Feb 16, 2023, at 17:10, Eli Zaretskii wrote: > > Did you try looking at Git history for this code? Maybe the log > messages of the relevant commits and/or bug reports and/or discussions > on emacs-devel around the dates of the commits tell something about > the reasons? I've seen too many cases where changing old code > introduced regressions because some aspect of the behavior was > disregarded, and would like to avoid that, certainly if this is for > the release branch. FWIW, the relevant commits: . edfda78355 first appeared as part of do_switch_frame . 06302656f3 changed . ac71ced75b moved to delete_frame --Apple-Mail=_29B352B4-95AB-4B63-80A1-9C1795197AD4 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
On Feb 16, = 2023, at 17:10, Eli Zaretskii <eliz@gnu.org> wrote:

Did you try looking at = Git history for this code?  Maybe the log
messages of the relevant = commits and/or bug reports and/or discussions
on emacs-devel around = the dates of the commits tell something about
the reasons?  I've = seen too many cases where changing old code
introduced regressions = because some aspect of the behavior was
disregarded, and would like to avoid that, certainly if = this is for
the release = branch.

FWIW, the relevant = commits:
 . edfda78355 first appeared as part of = do_switch_frame
 . 06302656f3 = changed
 . ac71ced75b moved to = delete_frame

= --Apple-Mail=_29B352B4-95AB-4B63-80A1-9C1795197AD4-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 16:03:45 2023 Received: (at submit) by debbugs.gnu.org; 16 Feb 2023 21:03:45 +0000 Received: from localhost ([127.0.0.1]:37787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSlPs-0007UW-NN for submit@debbugs.gnu.org; Thu, 16 Feb 2023 16:03:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:42952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSlPq-0007UP-Uk for submit@debbugs.gnu.org; Thu, 16 Feb 2023 16:03:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSlPq-0000dW-K9 for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 16:03:42 -0500 Received: from sonic310-11.consmr.mail.ir2.yahoo.com ([77.238.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSlPo-0004dS-17 for bug-gnu-emacs@gnu.org; Thu, 16 Feb 2023 16:03:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676581413; bh=sTRlNhKu1QYBRCY8lhRiH/0uWanHwYMfOCOULEH4nSY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=HAYHOcqDCIKeROIScXYxhtYIMRbcWglUHdR5KQifSV0aZnIwPAbfNJKmeMy1Iffq/UVmb2JOKizg0pDrJYiecByTIjC3vuEbI3GAIu5khKl2XvzNBwEo8LANLJnHwwVKq5OqOuF20LPiIHwfhkRUuIYctJ2K5i/6BdryaKs4soBhb3f4NCvLVB88VscfgaVdBf8kzqey8QTNA/qkBhAA0eCTGTmH9O9ea506aw+hlGO9r5ckdRvA2c5yqP4gGDzLzG3wBMbT5/FXBAXzz52jmcCufEGOph4xFPhypaIiC4pEkjhWpRHSloovvFF8T//s0oQUsGESiUVnMBx2YOcyjw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676581413; bh=yTt/GEK/jxSCnagPAdB1hlb7th8KqLkCosSET7s9iSb=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=iHh5UDPGn4C/a2zFPNwau/6TCOj4z8V2I2p6wF5mRu/6zpiJDefzR1r0SZCeS8MLjpnEFLqtyIrIU+rJHIqAFspJ4/uqDdiZfFOQ5i+r6NHfAu8seKE6ZSmbAkY2sCwioHggu0b8Kqxm7ZsSRtNyvyeFc/JBpjUidjiSNd9zZBnj+bxp4PDC8ZaDY3lmg2X5QEw2EjVOcpTki/MdkF0Prk+7ormx5ZQnRcnm6e5FZ3NgKPF+7BYQc8/N993ZlFip8q+Bhh+Wi+jSf7ppcXyciJljQ8QKmhhtSR10oqj5olDO8ypX/cBQulmM6L5Qsd5BpY28Ha+dSHCrggqejIXAFQ== X-YMail-OSG: 0r6fG5sVM1nGb0LVZ7iqnTuTEiqt.2XDz9MlosovxrKIXecFciOeqBU3XGCsGLJ _BkXbFS4AB8YjHWfUMbLOU.qe.SfRMkAc6HJQz3xFe0AE8hqiQCrRGmM2m_2MOusX5101HLsCp1K .NDQe_NbxC1c.9ANtlV0RHaI4hDpR9Vr2_3Zh5NwxDIx4RUKfxrXqgaLvNcmSmvaYFQS6rQq1h1d LyDxq1oPpvI2C2EExQ1hBuOeFrrwBryKTuSthRIjlFaBbHeNgfw8PRF.YWd5OEGg2RYD4W6QhJcR w5KdN3f_pMfkKwOfepa4qEbAulIaYKGcI7m1v3IoF0AQp.XAzDU6NHghX6R4UYlxDb4Z14AjQntq FefahGBQ2oweVD5IGxcvcC_LBIiVDGpVDGQNFjDDzvf..YvI_HPUdjpFGalA2VhRh80zUWvbuaoB W_Mr5m9b3cCLTWThXHkbIiCnVESs4fwNE_sbN.gy2svYlufUjeqZjSvRJ47vQJguipKSAUI2OlpJ k3nSCvqc4fceW7rK9we8zREc_nHmeK3Tw1OVC0ULUMYcJYjt.1b34NfrPJ_Skp4PQ8M.XpALwhO. iqVWxumSPA4RV0ZsdTruPbfYN1DtgCAFY_LJPAZ3tvCC0hLUG2AAErnjiHIK11K_K03ZjaKSndzq ype5axQNZphgUS2UmXT5QMH1QIL7y716eC1FqQJNNDxhSXQKuOD15SndcxL3FkA0AjRWV6KJeFqH xYjgVekeHctTrD60hkNjdJE0owP9KP_2C_TbFJNwXOdSLJ0G4VSLzu3ZLGFsqwXiIxU.heQmgMi0 HDneoh3ivDrJmUQBbd61MfMBligDQtk9BUEl7Anh13n._lhX1rGyIwIjRxi4bMlRQ4JPx.3IJFXS 3KiF7SC0wNKMhlMSg0O.xvgeQZRCMdOgB_WdKxV3B2W5XNVZ7OENin5EtCrYNINZJTzaD27SFvjA ciToq17JOWL_tiwIK2mbwI8QE0P8cQa_yLGX390ixowv5VLDfrBa3gSB5JzNvsyp9dLkkM7e1Aif PhycytqPkbISRVSpoFGzxoToCmKdnM5R6lwzNAczS3IfWdbB7F3pBgGXGL58CB3uR5AAJOIZJaZE .ruVmTjiQG7HX1fS6Nqv_29DStSe8i3Mezgnn3kXAWNeO39enrXPqPYqaHXzaWT93tPe8fPnWAPJ LqOJKWk4yPwrv5QPzeuxULicWudxG_n.71wET98oH18xPNz8WnFx2E7L0mHhq4V0GKPmRN0e8_3H 4.Mjgs1IhAsmYig3Ttqrur6re.Od1MVX9RD8ZQoQB2paTlUITQ3DAhj.nSjeM2xQgdmdPGK64vGw bwK1oQaK7LLJcHbgKHnRjX1pwSo9RFIht78CAehMCo2zV0J_LvbY05Z3p02VZ4x9QaILIiWyF3vp WpWXQe9FykzlbQH.QPIymXBlG5dm6mihPNMqPewoBVF3kkVdytl_fKAloiWo1Tzz1ojb93gJ41tL .Xnqqy5Fn3s0.it55wnnawHyBsGH.DhSnGM1yv37Z041DRiQTSOGoJiOPkzO5ezIGsOIiT9jLAUn rR3KcxC1d4J4TZLzXJ0FxXTfsL6OglESqYRGquO4dB2TMLpZXrqnsJ9ihVouinf2u9xsGazujJNx atZuDPPG7KZax5wUv3MViKUaWgS14FjmFHkvF_8Xfa2Fc28tyjXqHcUwlPHL3qbnArsMjP8Jh_p5 t7u_4LKikVXp9QAaqhv5yMqTj81QpB5zBfYq8v2nFw8glurdSyPbGE_31OB75NJsUpW.6kjmxVLd 7XMBtJX8lb1JQ9GsJPY7unL3.a7RjxvE4qsHdmniY.zaQtMGRMYPS57L1.czc7yHxLaSE99OKVJy QOJfw7QYVjHkcuKRDf4guGQe3DWHS4Xs4.FOgbfpgbsynBWCK82uEBfYOHMetRajNc46UXXurRrK hoOxzOQFC_tDYnQnzidt_K1rQmi.YuacJ_QEOJj1PVZNIg1ecc00ncQHmaufqmCpz60iePUACRrN 0ydNlw.cAjzXnNnDaOOlxWTij05f5bXcZpomUrjvy_dmWRMvt_EwANpOlEBRcQdTq4rtb_ea.Pog 94FuRf3PIQaIZ2sSfELrNlmm.FY4jBC3q.6VaGbKJvTWX5TWLN4Vf74EqjBKU4PZcpHgYyOi0bPr AJPYlGvJYZ.vX8fvJ5mabRDWvzW4_H2DHLmVUV6ZxTvviTmLikGOXECGvjf_rOfYmQYli9lDyDMY lGy5LW7LYNMjQYHP_S6fyR1eNurM8wHrwsb_aP.WcMHEv X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Thu, 16 Feb 2023 21:03:33 +0000 Received: by hermes--production-ir2-65c64dfd66-mp9nb (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0e0085d519f42103a7a6dc7d560cf75f; Thu, 16 Feb 2023 21:03:28 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: <835yc2c0vw.fsf@gnu.org> <871qmqs85t.fsf@yahoo.com> Date: Thu, 16 Feb 2023 22:03:27 +0100 In-Reply-To: <871qmqs85t.fsf@yahoo.com> (Po Lu via's message of "Thu, 16 Feb 2023 09:36:46 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 294 Received-SPF: pass client-ip=77.238.177.32; envelope-from=mardani29@yahoo.es; helo=sonic310-11.consmr.mail.ir2.yahoo.com X-Spam_score_int: -7 X-Spam_score: -0.8 X-Spam_bar: / X-Spam_report: (-0.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: submit Cc: Po Lu , 61525@debbugs.gnu.org, Eli Zaretskii , justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > > justksqsf@gmail.com, please write: > > void > ns_make_frame_key_window (struct frame *f) > { > ... > } > > instead. > Thanks, I've fixed that in the second version of the patch. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 17:40:59 2023 Received: (at 61525) by debbugs.gnu.org; 16 Feb 2023 22:40:59 +0000 Received: from localhost ([127.0.0.1]:37885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSmvy-0002P5-Rv for submit@debbugs.gnu.org; Thu, 16 Feb 2023 17:40:59 -0500 Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:32956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSmvx-0002Or-0z for 61525@debbugs.gnu.org; Thu, 16 Feb 2023 17:40:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676587251; bh=vOlU7MvHj8v8hBcunl7QuMHCDmqUf2+NoS9KoixZJTY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=IBRqxQW4fsiL+/oJWPFSax++GaxfKxId92c/NomM9wY0BMXxpr5tbv1v9Fwmw+vchuxMZqfXgDi1Xle1I6+5k54MUKodUXkbmI8qsdBw7wKstT9Sd1tD5xe2fSfwgaa9TQG2ufACtWaONlXaY9SE8NG1QeYERtg3kBNgs2HVpi24J0n5bAVtFXMsvVdM6Gs7PZhVQTA0w2mBB5agU1XPodozWetDBJOJuNZKJaiAjr2O0kRDT0w7I/6SOgWtzXk7+wR/aUVZYfaCt9cYhi6zFGrnb964vyxMoZng9TRozYhKwNJX52xN5ducn7rYLFCRjPlhMbbi9/q0yGBBVjq6Nw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676587251; bh=uGu5nnPO5uH+js4O7nfyknfMMlEbJ9v+4/OyOZdEuqz=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=YCjQu9IUfkVLtlSi6iLFTclnwKKOmfX7R2WvAb0tV3XRSnmvpf9n3u/ntl1pqh3H8RYy0WCIttBH69fyS0j5w3FGHGkYJw1kV4wbcIn+nyGw1uUqXT2LMPekbo9euhgjWZ8/bPjATFwbwranZfL0mmBDTMih6lv7suP/3lcLJpUJwpNjKYQ7RRVSwmLLmEP1PcE7VYrl1fBFWP9oDdCNZqZWn0uOocd/BJed+6FGx43OpHpX68H9pwWi+pRDay2aE06p3x6OPijRNbl/5lf8N53hlVk7uIjY2DfzpbDsjMgcfk1w+sqS3FQliF5m5D2RHHCup4xttNwqljpEFPIL5Q== X-YMail-OSG: MsCk1P4VM1kEaz8O4lnazaPJkELkHokNhDYc0InJzK2fn20pjWAQwAlO9LHsJby IE.RoE2L67in.zQXbbjUJlJ5j3VeuPVoems1UxWk2Pi3_v8sEqFh_ugKaROl.VAywfT7NG8QlOv5 e1B_O9GDxeT7td7eEhY4BAlVTXNT.mZwOBEqxedvRKAq_7eUOYLuhdPCK8zfMMivgx0lG7SAb8ce y2dA27JOaQppwjcZs9O4iDVQBFQC4asIl3vPLQAnDVQczM8saDQjGL2Y5KQLJMUV1YzeRIY5sjzC S1U4RBK7HdG5TgjDagQOK8o2BaP3L9I8ngFqvBzqfddhQF9YrO5s2FtX7zWMYeWyoJEFfO.QMfre frT5S6bzrR9r6vgfSeAxB25Tevdp0vX2QS0lgs2veux_OaHX4cuYQeM_59VAbONliIEHUEXhunIE TKpkt9zAugzDcE0jnExcrCcDxDvLDXUHJYTpGCmTPClPGLtjXoQVs6PmIHk77vkLBd98h8JbCP6c 2wA28W5DLUcaws7WK1slgNZyFlxfW9qXjxvVSDAnEoJmTfbMDoEYbzzOpJoeKAX4BooR7011p7et _SiDwkJLoIndUAeS4nsFTI.LdpOxsl6hh__Xo5Ju512Q_JV6OQXp_VLMy8SKduRcEVRpsrDec2vy Ho_d3Mpj7gwutbH2O4Pxl0scbJbvBTiOlh22M7AMtt72G9Rk8HjtLaXzXXV23JJeL7r18bkPkEcv eExJ.KBxvWMfEJIHpNrS94oQtwXx3DEQSn_YlDluTscah7x7jV6KVAqPKvT4li.2gchA5oaTRBK1 MTmmAtRF_.rasF1gTHN7Mu4AZcM0parNqkvtck59KaDk1l1gzqG2vPWk0aCH54kwMUnrxjcmE1MZ KUgrWHl_63iB0eU2lz3kVYTFdGpAsj7e4xcJPHSPvbPzmUj8Gx26p6r763DgG0A04bLE.iBRcmyh PXLxfFjssWhhg_6WEwklDHStxZThsmUFScbM1luxDmN.6yHM7X4YgQarDL2NwZy6x77shNBdX4mN pHnLzRqQsGCfAh1CVpsj6v5L_3KC73DThQsC4mqAg7RdCE93fMTnRKOOxhrRBVjUkFCgu4wHrvDd iOhm4Fj7BstO0ck8FS_AWpCW8H_Ct4ssCa9CXNgaqWE2KU3RpRXUmM7UxTFPB7MpdiMrgybbnZDD hPDNbrA.B6D2oO0.NBIrfqyL6J.JrYzpxHj4wCwfcxbgg377Sbw6nRgUyqRESoioKgD849P3EBzA w1KNkn1BJSx2zpBiqifXg_cRi26nhGfuJky.bNq95CRhf5JwYKFs61KdKQhKZzNJE7h_c_bSGnBR 3Wb9E1KqI_ENpj98ismz1An39FPmjCaXKKl2KOJGOfmi0onb5d2YED9a.YC0dEJBu8PihPkzoRY6 zDEL56xJ5Dh9wHAkmCfBz.FllON3h8RPfhxOFT7Vaae84mrwAKrtZejh4DoMYgoLUMjZ2WsAKWin c4AIn7PQXKXdgTaBLH8jBpQeJqfs4BwAFfclCSKNVQ1iWGPSKPDuAoAaX5VMchAjoKtawejzifuO BP07PRagb8qafrru4KgFhmgpI8H63_X3C2gqbtjsrOdnd9n8Czqlk3kcobJMTUcDoXjSxnmypVAV yIpZZgo92TinpJc71.IYxWYkf83vVrZVuXn3VsnIJBKO_gdTfDaWNcZuzK_Qv493KmayySXyMNeD hVPr8Q0GqWkQ2L4Ph2UvRAGWiPnd_JXLotDgGSbguv6kRVRw.EbVb35x5e5PGY0s2edp4KyYAve2 wZLrLrT61MJ3LEUQPa6mMpWomFQ.D5UJi6PU_ipOE74K1XC7ykxhqf0EyW9QdKO4GHT6bghsJ8mL LqrkH.4ns3E34UD2TU_ggQttBidPEaCTCttG9ZSkChUwT6PTdjvPMVnADg4s6xK1inl8hjwbrfHM fIENAMRMST_ipC4vfLgCtmfTcVZhfvYWEMRYd3WwPAuXKjUqHH_zY0zCF1usnVfbem6RD9ntGIj5 DvaJylCPMTRVbl8gy1DApl1JvVotIHUSxODwjvEwhtpo0K9GZGjmWy2pcny0CUueVqT8R5Qlnv1f r7UPfA8prNFJOe41UY6F_v_xkcHn0Ou3sTeBJcIi8hSKKHXDvtRIaqOsseBFXaUh7rtBEx3qtlR_ hkdGYCMBKwDBGdpY56LQ9e4RLxPKAtJSc.gvJXuT5FZF84KUIj3Rc2fNz8WVn6Tsv0sYF5gM1D7c O9KwJ2avqkKQ9XD4ZOWFfYjb8Cq4vGAn6sJ3pKHO_QA-- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Thu, 16 Feb 2023 22:40:51 +0000 Received: by hermes--production-ir2-65c64dfd66-svnc4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 38e7f84a68d4504f48f2a391ca59154f; Thu, 16 Feb 2023 22:40:48 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Eli Zaretskii Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: <835yc2c0vw.fsf@gnu.org> <83k00i81zw.fsf@gnu.org> Date: Thu, 16 Feb 2023 23:40:47 +0100 In-Reply-To: <83k00i81zw.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Feb 2023 10:10:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 842 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Eli Zaretskii writes: > > Does this include the behavior? That is, does that call behave the > same on all those versions? > I'd say yes, although as Apple software is non-free, it's difficult to be 100% sure. > > Did you try looking at Git history for this code? Maybe the log > messages of the relevant commits and/or bug reports and/or discussions > on emacs-devel around the dates of the commits tell something about > the reasons? I've seen too many cases where changing old code > introduced regressions because some aspect of the behavior was > disregarded, and would like to avoid that, certainly if this is for > the release branch. I'm OK to wait for if someone perhaps has a better idea to solve this issue. In any case, as the pretest is so close, I think that any change in the area should go to Emacs 30. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 02:54:01 2023 Received: (at 61525) by debbugs.gnu.org; 17 Feb 2023 07:54:01 +0000 Received: from localhost ([127.0.0.1]:38361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSvZA-0005vx-U9 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 02:54:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSvZ9-0005vh-Br for 61525@debbugs.gnu.org; Fri, 17 Feb 2023 02:53:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSvZ3-0007GW-WB; Fri, 17 Feb 2023 02:53:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=zG3ur0zD1gZ47LbytdExE/n4s1LeX5n0yDSQR6EI2Pc=; b=pZrC7Z4qY8cwkpcWtg9v TvGgHSDoN1uISXuMMmMNRr8v87YDH8MQvmDnWXvf7RObvil++T8P9ltqKuUj7A/QtoQ6H7Qe25AAS p2fQI5UUm42ruu7B45LcjEAqwStoGp3c9oWRCAjlC8tuMbfqSG9WMvPqB/OwrVpA4QwQL2AE/JWpv LMzOnO2Wn1fWEAUoaOUUCk1HLsrkF8ct3mvuyhMV9IM5buhqEIRrqRocuoPowQ1Q15RV45+tLeSlo r45iFOXA9UoUHn60syvQN1pa2pkl2HmndBLgwpQaVVdw64gbva++lQ1yxkrLJjIJ66CjCSKlYDlVz +hliCEqHqvTPRQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSvZ3-0007dA-AY; Fri, 17 Feb 2023 02:53:53 -0500 Date: Fri, 17 Feb 2023 09:53:52 +0200 Message-Id: <83v8k020dr.fsf@gnu.org> From: Eli Zaretskii To: Daniel =?iso-8859-1?Q?Mart=EDn?= In-Reply-To: (message from Daniel =?iso-8859-1?Q?Mart=EDn?= on Thu, 16 Feb 2023 23:40:47 +0100) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: <835yc2c0vw.fsf@gnu.org> <83k00i81zw.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Martín > Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com > Date: Thu, 16 Feb 2023 23:40:47 +0100 > > > Did you try looking at Git history for this code? Maybe the log > > messages of the relevant commits and/or bug reports and/or discussions > > on emacs-devel around the dates of the commits tell something about > > the reasons? I've seen too many cases where changing old code > > introduced regressions because some aspect of the behavior was > > disregarded, and would like to avoid that, certainly if this is for > > the release branch. > > I'm OK to wait for if someone perhaps has a better idea to solve this > issue. In any case, as the pretest is so close, I think that any change > in the area should go to Emacs 30. It's fine by me to install this on master. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 17:22:35 2023 Received: (at control) by debbugs.gnu.org; 19 Feb 2023 22:22:35 +0000 Received: from localhost ([127.0.0.1]:49864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTs4o-0004NU-Uj for submit@debbugs.gnu.org; Sun, 19 Feb 2023 17:22:35 -0500 Received: from sonic314-20.consmr.mail.ir2.yahoo.com ([77.238.177.146]:37622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTs4m-0004N9-Sl for control@debbugs.gnu.org; Sun, 19 Feb 2023 17:22:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1676845345; bh=jM0p8RMn8fBJaCsYazzUhbUV/hQApAbjibh7qOOin8c=; h=From:To:Subject:Date:References:From:Subject:Reply-To; b=IQiL9i23EDes046wiyleGV5Q3QSDzcuxmFOXsnu9GxOes1P6yQUr34Q9fG7dc+rzxqF3nvaGJzrMSLxq9oJlTne64alrf9rP/c38q/hxS8jQpoJgEMqV8aAHAYRCc/Fj7ZkKyvLwYicH8zXZsbQ2QA2xkgj62DnBA2gNNF4AYbwea7ymAatBSUT+NkVVjjOL255xCZbnTS2lK54hl1SwAyrCUymPV0LN7J/pZuW5L2C3iy2n6SSX8o2Y3fgALTPYOYP5WoJAGX49/Uoegl7x6PnDc83l2T7QOiT7qAAce7+uC9ndimDpHtylRWhUCb212VjKR6NP8Y4VrRw7kp7ijg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1676845345; bh=i3h9hkOBNUNCc+dIG1PASqauWho+E4PKg1OmR7ojAbn=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Mt5pdM3uL5bGqIS/L5HX3V5osySEJszcLcudXmqc9uAP0xn5avqnZ2ZKUQVeUDqSViiiHasxguxIqv/vQ2HV2dLVqc1FTXRRA9fecqDIWJwx0QCzLDLvGvPDYP9m0z6W/C2guA2mp92xtQlvewiPMIXaCIDl1i5v7fhJuBslTkH43pKeg6bHl+UP8oPWmufScxfY0/H/ZiRCn+WYUVKDjO2RcbBTT983I3qOfa9sJ0gcugnLaJHWIVMaFZNTNVt7odHsNdDxuvej+kNJ86ShSuDNuFEbI8UF75ZD+nUK1iDsZdPIdjs/FzFhUPBMdZpWBMDxgGUvJQfL6IfrS5lazg== X-YMail-OSG: LMOmpZEVM1leYtroQiwXHRJwT.avaIrJVB87AD3lsxU0_LwaCZqxSVscbpIpVmN ADeTKccLA5D4b7GhSLPmlh2Dj_aHNrv0CmXS00vU91RrmTb9fEhrn_jOic6V7zVImpBvYvYq4CFQ la_Wj8pmV0QMueEBIeLP0KIk20v49h.Uyk9dETMaVPULtdTrkGeTZDmTZZ7EDYuXtRKwFecXbkgh IrUUVvMFWm8DCuwJCLmOBfk65ydEaoj5MlG2nqbvPD.SVBRYlh3C.oyc4z28U0VB3tUH2HhO6rGW cn7vjESqs5kF04PY09pvqUfzODVqI.E_2dV5AUr5Y6e4yYoOEWV91wTqWSomZwI24oDpY_lhh5Hx oGA2Kf8igYpnMPZVcLtenwqR1Ob8Qspuz2ictJEwabRLbSlVyIZBLKDiMmuB48jS8thFhn2X0uiG Ry6XLcgNRvYYKrAxZeMqZoD3f4uaqcBzlGYcyFnFiRT3PwzlrrlLjuU2aHqKbiyOKLLsgxA6oVUX WAbSGajxxYfY9Mh57z6fFQKui6A3QRneeKSjpFtUh0zuPcWKCiQuTwIkocX0rWkJXvdSokbqmQiX dLsE140tkXcLxvVayZ7uZpkyGGdGc_WDlUqdqtZeYOUCN8cW7pEvXGhapJzCMRDEKo2XVR0gk0cB CqPJX0E.n6Af97OkwOdTVL5Ptja2f9GkHAZbCVIWz6T4vHkdxfja1oB6_jlUkp4mdhY21QqJMNMe 0mRYuSj.0QU5BLs0WNAliaAbkz15pCvlZ_PzKIPepd7dj4GQQzghHIh603DiKofpWCnJ3QeflygM MryyRZKLFnG9CRBH1oYfDMGOSS4bl3sdj0ZDK9L.W95V520Q8Aon2LLUYLRjnuCFklD3M2_LvYUF agWExvHCYTxpQ5O0ZBkj3EZWssFZOd8d0t6yMFZAhVa8TUlod4DMvf0xnJga1A.c088Ce2nG84y5 nRRhyMIRyle4D7mkpW2wONcv3xmIuacdPK6zDDXrRgKX2FdJelnr8BhJ_n_yvtfM7MlprU70dsfv eq4KZKvrnLM94be57XOBvDzp8u2.Ao.297I.nvmlehccCmc0bM4viUgfkG2_eaF9S7viUzV9vmD_ TIBqVTTgOd5tNOCs3H.1RhYRX2GOclRoD0_rQmOYNyY0c355AIHxGCCNKdxNlK1a3n8PuJACwlia oOfNwN2k2r_mzGSluV2hnTCMwEr.HTHAVkuNUAkHmNpFlunLa1obXYdVrQwuOjBohy_UQaW2Icm8 _c9vUJUPgW.WgvBBYfVT8E.lN_NawdqrLAzJ6RYNBydnGHJ_haRVhJdVZIDzysAnPFKt3AZ1cECx M1yBQAwXJ41KMtrtROW.daEc78zPSMjq0lD0QiwrDpSa3pi20Ef.V4AQZulhFfHUfAc5DmxKqM.u 9sL8D_m6Gd1oigkg1ks0i0nrJo_jJ6nFssvLxyFq04rpYXTMgNiNYZKC7yYzHpcvVfilRcd_VsqF ECTl5Pbv62N.KljAny.QKRqAzz.2dUuJwjoaWkZC7rxMMo1l28zjJr.Y5eMYoYkNRS.CIYprO_El LI5.FRsP8rs46qr_7bj07zVlkd_bafx9FqpHv17ftHg6YPmw.B9nA3TgabxwF5_hcYdwIjnGgm7E exXrlii51HBm6dD1zVgx7tZw8xODLHEUYbzrnfL7EW_lSllK4Z7uymy_CJ0HIuQs3Rol0NFSU_zu EFRXaFZvwE.bjefQp8gDG6c9wu3CcG28.UXhRc3oTG8yCyScd6S5f80KczgncKCWA7D2GYYIdGd2 K_HbKQ.nER3qc0Di5S31emENQfaLausv5lBZP2YP3XLnRTkWgllcGiJH1ZWcXLsDEcik3.Nsvqap moLvsEw4QLpxnotKr5H5l3rdLhywV51eDtEMG_DiEcXwx5pCpkfJdVjHNI17TZJrDhn1iw8_KhIe 21Q4sds72Z7QnfKx7jgoGJYhuzrunjNYL8EX_Apdbv96Lt1dpgTD11lPZMpvtxwSVu.9dAxAIbQL ks.xcyEK1xC4OsvNEcO2.83VqXHR0QOIH7TnFIcXkuci5KKIUwJaL6kh.fT63QW7uWnZH700EE10 omnYY1NfmeNCCtrY5b1d1aFku5iXxNsZHZC5StUPBWfQiy4joiluHj_Ddagf96SMsUvxktmoPLEK nV1Ytcq5GsKat7AJpqfkjjlJu6zBRgHM5iOJ9AxDFtkN2QmTa17j6UI6qG7db7_Oa9xzZbIgoIRe as0yfBNG5ZdywHMR9VwBYjsi1wY6r X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sun, 19 Feb 2023 22:22:25 +0000 Received: by hermes--production-ir2-65c64dfd66-2jlf9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 7fbb7c0d0ace66a6df05f4d451a04098; Sun, 19 Feb 2023 22:22:23 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: control@debbugs.gnu.org Subject: control message for bug #61525 Date: Sun, 19 Feb 2023 23:22:22 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain References: X-Mailer: WebService/1.1.21183 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 25 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) tags 61525 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 09:20:53 2023 Received: (at 61525) by debbugs.gnu.org; 18 Aug 2023 13:20:53 +0000 Received: from localhost ([127.0.0.1]:46364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWzPI-0005xt-PN for submit@debbugs.gnu.org; Fri, 18 Aug 2023 09:20:53 -0400 Received: from sonic313-20.consmr.mail.ir2.yahoo.com ([77.238.179.187]:42896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWzPH-0005xb-0h for 61525@debbugs.gnu.org; Fri, 18 Aug 2023 09:20:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1692364844; bh=XYu17L1lmgwXzqR/qfPdIuoPdFp2gjOHXwIbFIsGcX8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=EdfB34RXWB9lxrWUBg05FBEYDEL0K2/pizzevlM53H4p2B283VxjQYvFkjcHsh1gKL8RSQsM3uUYZrB/jTUIq2t6ZefYtZdTrYQ/EMnQIcoxNBxtwcRs4C78AkwPk7iU3OgFTiu0zvHuTRfvt4SedsORvxAQ+GeyEuycHiR4/6faW0u4NDkcRk9kH+LJTEO7l27aWF9TDaMjxIKHBzRHA9YMHz+PYT0TMo/fT48P/Nxj9jz0YPfdn79/Ifc0aZoSUPlD5QMeSOlqsnahTGPkmItlj6XG5swf0qoFlaE56OFMhuOzxAk7LNM0Frw+ib1veAL1+bjK/5kpoPB8p6crxg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692364844; bh=+ue0qJSXmOJF0ZTNgUl93WKApKSZCvYgkK0NkSGlQFN=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=ejKCDqRShz7RNAPRW95lq0fwuM50iWxH+yVUFumIHV+Lu7oqhC7VYXxKuwOd6iM804y3C5+a8NXXS31YbPHlzk4Z48Wp5vhm8h1bNm3dMG3/y4Z4a3hUAHOq0WSrPiKyecAEOBMgQedeq+hnvBc+X0fF4ssVja7LfL8p15DtL5OWXOIc2Z3s9IjA6P3VO4l4aHvw8Jm2bh1crxCMxn9jKdD611AQdvWfj5vUJFJKCiZ+rWF8Zy+P4Z9HPQxssKIVfSxsnfiKhAKk7knr6CnVzekKGXIrILU/rT4PQcphaCXLi5yv/t4fbW+qsLj5rveKVbszPykYJAmjDs/oRXYLZg== X-YMail-OSG: .62WKlkVM1nH10JCwhNdau_6uVffTFck5xi0oGXsLX1T9yvGthsnsaxTfWl6xp6 pHe_dUGPoqudCSFiQDkHdcx4G3KBIRRAd7EoScwBXsUx1rh3DhpWBpX6EwIsaeWC2NlNnfrLCGl. KytNeU8C2D9_tTPeAhd9Ej5lhG3qJ6uLe4L2AqjK8mzawPRKMoLeGSS9WYHaGtKJcnmX4heOwT1v HhFdAtjitrveP1Z.NJXLA6XoR7cKMGkDtk10ibdA7sBgZal690VBJNHDjpfHsgGQPOhfMdEbvkdq PGnB8JeEVfNMTGv7Hd_HF56GMHfIiyheY58kUBFXQ_0NvxccexDo_udbzDt1dwzFKksZpBCGA2Sb K0.lgmTbEVMYX9L.Ud_AQGpP2McKF_BFH88Lisc4cXCj4A1wiO2UFS7cUp_cVEDFDOA6d5sKqRP0 wR284ytVO1tLqQeJjh5TPiA_qn.q_7Zs16.TQJvq0cF0qOGYdg3FmD_ySIKuvJ519nGScwQ2erAp kO5xmNrY1rF65m6QFBFFGBpzicL0GPcau5l7zGnFz2PJVusINFWS.bAkSq0WSfcit8UpKjuUZiNN Wy7EID96Ye8ZX0_0.md3HkNPUh_lFwk3.s_2IAWf0gXsZUJa6T.dfEek_dK1cn92os9fnQD49B9P gOfG7DZws8H34nZEuVy0U4LVX0g_Xy10dnlGWety0PtPrG7ZeKBxNmIKDEoUcDMd6KQlqCE2LCIu _wvTGkJLsthfzzlBNy3.7z4yFyjJbxsUGYuCo8axapmr6qjsCQiXTorKxf3NTfV0XQfXt2ayUnoQ JTpvnR_5gHR3ANLrlOI1L_sxpGe.n29UsHAG1x3m72_QjdNa1iE2.swC7BUTn876E8rgob9JEuYf zCWm2jhwa_HAGg1A31YCcI7rir1jluqLitj4K0vJvN.hm82CN_y8Dvd1jD0P4nliPzdj4Awm0Bc. M7HNKimkKhcusSIS6xB_ar4qmRf0RXuI12BK7A4xdCi4xMNJVCBniTL04NM_1AWEbQp7jAk66zpf 2SdN3ZOjUj.eVEQZ7iHqEqF4ebQIT.nPVGzUkfjXbryD8i32svSJSCraNF4Cj3riWpwBPOp0lHkK Cl_HWWbRvyn_nFlc_FZmte4tSLhYV9qV0Hy6em_mLmzAMEr.D5dXfJwMwiKgPm6yGWJCvnm3EtUO 2GqN595E68AEM2JrRg7jBxtAcKZhAlY70vLSlk.zImChIy_dQce3E0r5UA85A6uNIH0HPlza0Q9c GeWaAxq6jf7mXnNQZml5H1N1NZ6oy20uDOYMqvjvWm1I6PrwhBSXljZ3RqSaY9zwIg.6.z8WHgq9 3F21qJ4Nno7.rZf0qdb15HLBN4iclJEzHg_Ab8VjVpWIe7KDqmWeopEhnAnZI5ZQ3MoN5B6Gd_FF MP_9uvZsp9YlospebeySXlXNyXrYSngNhWzSay8ZtGx31NFbQVfWjOFgoQqjcuEK6UehPO2O8hvc rhxP5RzRrsGBYNTee_t7CJcpJKFddsfaqddnkP8lSLkcIjJPkCMHK.7WBZQFgOqefK_bSSOTpU3E ZuieJ3sPNcbpg63HMk7SgZ6l7tE6bS3U_Y0CaTqZLOpZwd.BorWsN_PgdLB75LSKe1.2Aq24Urz0 OArqphAG7Grxxw35zk6j7WDT0Hc473.0ZynyvKvilLegxpUkX7xQnTsc4IZyQb05S7jNSqeePRrA OAvKTN7R0mNT5SZXHyGWAYTq3i9b5VUj7pWE3eN6PI.5WLRHozEP95AFKojqXVvanRn7.LYVMRE5 VHUDt.GXVbgqxoZV.lHScUGefc8aXUAftrMhfd4Z8lfRdmajVoVgHrQqd48.4qi5KOuuAtatouuG DHGDJs4DWvEtifePO48tmqB_1FVKO2r8xqaXMCW4G045hDoI_r1O.k2QQsljEJqDvxUx8dF4QUt0 Ql3AjtrPXe6lsnQewpxG_fMsurlGg9jVamaQecxmsqzmPmPCnnLs9VBdZUMLxGBqEP69bVFS9iYH 4H_j_J02psme8NJYApKVSnNRaY3bMXDJOZZ9g5Oz39fTSZyezk_DozhJMlUQMkYIKVEPtdD.BvL4 fp7yLx0qRZfLU45gzlbJQpG0EVRVFV9xlD922EpGA6Y.dwV6u__dcFy8kHByuvGDRgDXPfwMZWR5 q2DLc6RUZCAJzm9phNMBtNs4if.eue6.LvI72UOLuCe25fwrCOObGj55VRFt89ZWWlRm0MUDOcqb bQLrOG_RzQbGkWA._Xmd0x5ThRM7xEyB7uUOY X-Sonic-MF: X-Sonic-ID: 927e3a0c-832b-41c3-ba48-6e00c004ae16 Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.ir2.yahoo.com with HTTP; Fri, 18 Aug 2023 13:20:44 +0000 Received: by hermes--production-ir2-5cc57b9c45-hvdt8 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a346996458e2239d54ee0cc56c299a70; Fri, 18 Aug 2023 13:20:42 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Eli Zaretskii Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop In-Reply-To: ("Daniel =?utf-8?Q?Mart=C3=ADn=22's?= message of "Thu, 16 Feb 2023 00:48:59 +0100") References: <835yc2c0vw.fsf@gnu.org> Date: Fri, 18 Aug 2023 15:20:41 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3855 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Daniel Mart=C3=ADn writes: > >>> +void ns_make_frame_key_window (struct frame *f) >>> +{ >>> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; >>> +} >> >> Is this new call guaranteed to exist and work well on all the >> supported OS versions where we have the NS build? I wouldn't want to >> fix this on some systems and break it on others at the same time. > > makeKeyWindow is a very old API that should be available on every macOS > and GNUstep we support, AFAIK. I see usages of that API in other parts > of the NS build, in things as central as frame creation, and they are > not protected by any version or system check. > Got a report about some problems closing frames when Emacs runs inside a macOS terminal. So here's a new version of the patch that protects the code that makes the other frame the key window, so that it only runs when the frame is a GUI frame. Kai Ma, could you give it a try and see if everything works well now? Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-PATCH-NS-Do-not-raise-a-different-frame-when-closing.patch >From 74a22d417beb86bccee8886660caa0d12b052576 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Fri, 18 Aug 2023 15:03:21 +0200 Subject: [PATCH] [PATCH] [NS] Do not raise a different frame when closing a frame * src/frame.h: Declare an NS-only function to make a frame the key window. * src/nsfns.m (ns_make_frame_key_window): Implement it. * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of Fraise_frame. (Bug#61525) --- src/frame.c | 15 +++++++++------ src/frame.h | 4 ++++ src/nsfns.m | 6 ++++++ 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/frame.c b/src/frame.c index da00cbf4bce..addeb013b4a 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2212,12 +2212,15 @@ delete_frame (Lisp_Object frame, Lisp_Object force) } #ifdef NS_IMPL_COCOA else - /* Under NS, there is no system mechanism for choosing a new - window to get focus -- it is left to application code. - So the portion of THIS application interfacing with NS - needs to know about it. We call Fraise_frame, but the - purpose is really to transfer focus. */ - Fraise_frame (frame1); + { + /* Under NS, there is no system mechanism for choosing a new + window to get focus -- it is left to application code. + So the portion of THIS application interfacing with NS + needs to make the frame we switch to the key window. */ + struct frame *f1 = XFRAME (frame1); + if (FRAME_NS_P (f1)) + ns_make_frame_key_window (f1); + } #endif do_switch_frame (frame1, 0, 1, Qnil); diff --git a/src/frame.h b/src/frame.h index c85df378da6..f4726f1c0e5 100644 --- a/src/frame.h +++ b/src/frame.h @@ -1521,6 +1521,10 @@ window_system_available (struct frame *f) extern void frame_size_history_plain (struct frame *, Lisp_Object); extern void frame_size_history_extra (struct frame *, Lisp_Object, int, int, int, int, int, int); +#ifdef NS_IMPL_COCOA +/* Implemented in nsfns.m. */ +extern void ns_make_frame_key_window (struct frame *); +#endif extern Lisp_Object Vframe_list; /* Value is a pointer to the selected frame. If the selected frame diff --git a/src/nsfns.m b/src/nsfns.m index b846b490ff7..a79892f73b6 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -685,6 +685,12 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side. SET_FRAME_GARBAGED (f); } +void +ns_make_frame_key_window (struct frame *f) +{ + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; +} + /* tabbar support */ static void ns_set_tab_bar_lines (struct frame *f, Lisp_Object value, Lisp_Object oldval) -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 09:29:01 2023 Received: (at 61525) by debbugs.gnu.org; 18 Aug 2023 13:29:02 +0000 Received: from localhost ([127.0.0.1]:46388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWzXB-0006B5-FT for submit@debbugs.gnu.org; Fri, 18 Aug 2023 09:29:01 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]:55550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWzXA-0006Ap-7a for 61525@debbugs.gnu.org; Fri, 18 Aug 2023 09:29:00 -0400 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-6887c3aac15so828362b3a.2 for <61525@debbugs.gnu.org>; Fri, 18 Aug 2023 06:28:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692365334; x=1692970134; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ny+TPK7B/yTVbVtA55N3E8Sa7RGrhN9dmaVeMbOoijo=; b=h+8EDxea4llDxRrbBaQuwNzjmyoc7ovU+5m8HIwriCpPUumxRZns36mfD1QG4+FRmi YZAoOUsP0jfUXqfDlkX9UmflA4EaGpc+ukqAkigITNSSI3pMRSjDK6hFf7gjrt54wI4o Y3Bn0CvKzhN7H8WXN9pXLqf3U4Vq7il5LTbOrIEXEFXLOQSDn3NCclzJ/yN5GOP7G8e8 jHVRwGvznVJHS6yyNQhJ0OfiU55ttf392knR+PFoVoRt7Zi5PCACUZIHfQ1Ab/R6EIBT c7Rm/R2chNlUtzRJCJDeCBBqcorn/fVJfWK6PsxG+elRaP3MnORlUFj8cpUyLFcPsWJJ Tcew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692365334; x=1692970134; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ny+TPK7B/yTVbVtA55N3E8Sa7RGrhN9dmaVeMbOoijo=; b=WrNbWl3bWAhzTIEwEylgtc+WTggovPoL54hP7I5oXE+wv1bHUo+mnQZ/y8jKlPfCAS prTkbbPtJDetlXC6+Tg0hQWI4HKLLAID2bQyLpHB2cB8694fPNo0NTGDXNQf3++pV//B Bq9+yqBwbEgHh6g6H8ENV+q6yS2DRWVcpX033I9m8ZVgZFdn+IySWqTfnrDoTeHonwXL 7GneKUMQfa8nGab/Kuv7GjGDJINUm5Ya/GaEdQ8za+bj/Vwp2R+AfSUWTtj6k9xT7EBH WM6YShEQ1kYN3sjZmtNjs4LR2oEOaOOkaj5MbR/G9TNiiruoXXxf63kAgOEOknJiyUeK e1sQ== X-Gm-Message-State: AOJu0YxYxRqVqm3ygZcZcgPWocyXFGyb3hiIUIZ2l6Gghf2cbzzOIgSm YHTDJ51VX2573QNlNh+ephU= X-Google-Smtp-Source: AGHT+IG1IXbT5kfY4qIubblEVje9uh9mrUq9qEgS2HXrKeiJju+Xxk9Z75KkZ+YyDMHDkv4cthT7nQ== X-Received: by 2002:a05:6a00:10c8:b0:686:babd:f5c1 with SMTP id d8-20020a056a0010c800b00686babdf5c1mr3077701pfu.25.1692365333806; Fri, 18 Aug 2023 06:28:53 -0700 (PDT) Received: from smtpclient.apple ([2404:c800:922f:e1e:9cf2:fcff:fecc:2ed2]) by smtp.gmail.com with ESMTPSA id n13-20020aa78a4d000000b00682a27905b9sm1590108pfa.13.2023.08.18.06.28.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Aug 2023 06:28:53 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop From: Kai Ma In-Reply-To: Date: Fri, 18 Aug 2023 21:28:39 +0800 Content-Transfer-Encoding: quoted-printable Message-Id: <37C28861-130C-49CB-B284-82D8AAAA3C3F@gmail.com> References: <835yc2c0vw.fsf@gnu.org> To: =?utf-8?Q?Daniel_Mart=C3=ADn?= X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) > On Aug 18, 2023, at 21:20, Daniel Mart=C3=ADn = wrote: >=20 > Daniel Mart=C3=ADn writes: >>=20 >>>> +void ns_make_frame_key_window (struct frame *f) >>>> +{ >>>> + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; >>>> +} >>>=20 >>> Is this new call guaranteed to exist and work well on all the >>> supported OS versions where we have the NS build? I wouldn't want = to >>> fix this on some systems and break it on others at the same time. >>=20 >> makeKeyWindow is a very old API that should be available on every = macOS >> and GNUstep we support, AFAIK. I see usages of that API in other = parts >> of the NS build, in things as central as frame creation, and they are >> not protected by any version or system check. >>=20 >=20 > Got a report about some problems closing frames when Emacs runs inside = a > macOS terminal. So here's a new version of the patch that protects = the > code that makes the other frame the key window, so that it only runs > when the frame is a GUI frame. >=20 > Kai Ma, could you give it a try and see if everything works well now? > Thanks. >=20 > <0001-PATCH-NS-Do-not-raise-a-different-frame-when-closing.patch> Thanks. Everything works fine now. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 18 23:27:15 2023 Received: (at 61525) by debbugs.gnu.org; 19 Aug 2023 03:27:15 +0000 Received: from localhost ([127.0.0.1]:49154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXCcN-0004mx-8g for submit@debbugs.gnu.org; Fri, 18 Aug 2023 23:27:15 -0400 Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:36130) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXCcL-0004mf-E0 for 61525@debbugs.gnu.org; Fri, 18 Aug 2023 23:27:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692415626; bh=W9XA65a+/G/iU30Ic36teIJIedcCzL/SWJDUIH/V9dQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=dJPd43/LY5fKOriD9/t4IzShMId0bX3kp8lmd0RAS2+zJpyBwOjt9WLis8O2XT+aykx7shxAzZnRV4i1zpf2LgCbxBP1Ir663GqbyP3XlNAe9Gy6fHiKfAoeGSjQoIsMjuY08tQVDI1rtkewygMt7T24j3PSAcZlzoA1OAByrJFKBr/sh71MHfztny7eEFyhVj5We5OfXeExRSE85uKyrhhqP4s/W6WUeF3G1ttRgjdu/sEeEW/ar3qRArZ/N5QMxO2QXLfg89L0vHmyBjc2F1W7gPGeaDVANYY3v6cYfEzV83RwA2o8Jck8PYpy5aelk7dvGWapLU+7/4RItuGCrA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692415626; bh=R7rlCnjgr0+EtPhEmjQSEGuqHiZ+y2kdbc22Aa3yQZa=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=H/VR2sgRtsWB4vcpqUf9G2+aib4gqU5ZzveS1CDae9TjxZ796nTRLNznW55JQyURF3MmdmjjJS/ZkdXxlRs85UOEBzH0u+Wvaw5qaL6PtiumSf5s80c3Q8ICdiSav/TiptubLBh4irdFUnwUSnhf20QB4aW9fL0H0ipCXksX9//36OJzt/x/8+HYHJJtBQ77KBkzWfgeUvKYC8V5CuVKEjgF8paQ8lnFKpMNZqzZxuO7veHr5MoGy+YETW4OBJRYVX6nqYNT+4eGTmtyPRh5uP9/OuHaBUYnlkIS2a1jpHv6CMPsQ9QEWjqopyq0w08gtE1PM8Eu+Y9MlWiu/hrlGg== X-YMail-OSG: 6SMoGP0VM1lVcXr9K5.0c2GwUWl1Jy24dZ1DKLrvqorbT29P1.qXmyoIq3z2uuG 3bSScUNA_dqZmYpff3.BQIjDEHJkV3FbtZBQa8NADV289qNX_q4DEBfss2.8Sq4rs9BBZVShYZfR R.0F8fSH70s0.It2jeyFap52nliNz.5IiFUkJKpac2nsq87jYxi6csT5tbvly.d.wdPuIcTJHYOT toccgx9VxEvRPOmVUlhdQsHwSAzc_EH_S0_lmHCpI1xDVvQsW0ssvd2RyOl.5tnXdVYSmG_6Lzqq dhbbHIDax4fUILpRQEPCdWnNCGJS5Mzrz6e1LCqlWnWU52jhrMiOEWre5B8SBCqXHsu8eYOMqoRR 2DRlKrHxfBX4rMVULCWYhOtpvbIpVf53CCcTB8qx3s6Zm8YlSWcrgJ0.A4wVzSB.RNGyjl3hG7Yz FuAO0TXxt2VESqF63dGwfvl1biYMXlONX9CLoCtGtK.oQFQnhlF2wMXvC2qsIqSvvmoy6VORMCCW OUtZcfwWY_3lA8fluCUkXqYd1bVE9veZz7_7TNVPeHxNP3HN9Y.c85DDWqt4AaNI6H5ie.czVZrS W19VdyPFH9L8C0Avh0uoRSV2UH3qVNDslfXW_bKEhObA5oql8h.9.BKIYar.moFkRoWxsw.7isSh g_LT9w808EBCceNuka_bPeEZZf73Wz5PlxC0c93ww_Yno72uV_iGzA3sG77LicuFVC8hJQ60dHKL cSp44DTfEJgKiwLeHt1MilJWDNVA4u1XZZLBdOIKtmgtZpA22nnxP7WWABw2O0rDr22d.f3hBE24 FTS6kwr3q.WVL0hoHn8QyDcMymonx6QqMQKUuTsA3hTvDL2XhOzbsFpht5pXItZ42j0UFpu_2XyF xnzk9m3PPSgByMo8wELCZjozIbWWnzeyRZ3bHd734_Xt7SjsuhPGhUBheQAjnPjjidHdZYlos_I3 8QmjsMGh2OFaI0fxiUvEoBZsSlPKFfPE2fVFyYn41zqZ8JL4vc28bbboYTcIWZ23BzrAMLvxiAdt 7rdNfKxkUfMu_juV6252Tsv9qxla_bP6x.YmjMqPyGWvQFodfXALWx.FcbfNO299Ea3eFRB5Myl0 VKgoMNJRhh2UMHZ8FRewelCAHZwco7hkoYioYmm.rvlcfvLky9j_7ZJOOH6zRG9U1DvfG7FBMfsO DTYZ0QtO7NZSXXF1f9zzAtQytakz.yNZVsK8R.e2s6PsLyS5oAGiP6aA5M6AEoeHiTXCHHpgvlPB aP2E0G_yE6rQXBBgCZXrpRT_9r3kBvQzQyfkuicNvOFrL610y6Y82SSRxzLS.zPFTjfG1G2u.Dza Ewq.I7C5r.tDN27Rw5PGJwV8G8Jq6S09MUg0sJ6dSIFfeeo_1avAjMw4sPC6.OtIWrbq6AR5Gw3d jZXNYjrbt_zmxOmFEd8ZrzMLexXziWUCsxRz3i3YRwHD7uUPcpzi2HcX4etVBnneE5p0qOsvxPt3 t1frRTSmbURs4.r2ktUe97THTw_uxEVkaco3ncP11bYSuJYUW_AZx0CQfiAJ6pGIIz6naEshch8e AurHCMsNkGFqrH5EmoK1x63UOWudy.8z2Jp4z8vSSdTnGaj6dbBLCnEAQpEg8p6YY1uHGVNC51ID 4544so055o9qYXZXqBWFq.m1ppB76CcmHbvz_1AQqIXtXY81QwyiCrag.bfVgtEFEEU0JfKhW8sW 0KJ1izmw7BnKg3XN8NkIN5LS4lk25CUw67CykGNvPI2rTdYSCizaf9v8VIECzV.XtaKezvmehlym vicZVIQi8Py3bodDmMFXEbXKJabq0qC5E9z_DSX0TafAMTTAJqRinhxQcSQF_IdlHlDEBI_vLXGh PiqvLM2CZFdM1zFfBNZgCm8NhpeXLOBQC_36LifqTaCDCbNuscy5uKIeG8ALKY3dFr.X8hh2vXOG cBXw1LFkfU4KqPtQQOkT.nWf05vcGzglTyfDxwE.b7NMPEoWYaLA4MhTHfnyTrmbNCZpbgViDVrt sp1qmL2z_kj.lYhf1uvdL_m2bDPYaf2Yf33IgfzETvCrlocprK7HJe8jkPZ8dBRgko0jI8fWyHt7 uQ3o37TjvEfPT62tRuiTPQLt4l8NBzMO11rppnyfh8BMC9kf5pkfiGwrt3GUKa8_RW3f3s.UuiID Q3xx0Tw7LAaUic.W66ajVmafCBPjVWZfodpzbOK9xrcLfipBQCfD_Z8DcZq5Z7JUOciPMuprGznj 4NXPwf659t7scD092FAUZjOL9U0NTikUAyxLoz__9gW3XbUXiQ4D8ATXj4Qb.D8j9A0s- X-Sonic-MF: X-Sonic-ID: 2a727ef8-ed36-4aca-83bc-5f53b39d88c1 Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 19 Aug 2023 03:27:06 +0000 Received: by hermes--production-sg3-69654d8bd-752gm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1391d4b8719a979974defcbe6ded3b39; Sat, 19 Aug 2023 03:27:02 +0000 (UTC) From: Po Lu To: Daniel =?utf-8?Q?Mart=C3=ADn?= Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop In-Reply-To: ("Daniel =?utf-8?Q?Mart=C3=ADn=22's?= message of "Fri, 18 Aug 2023 15:20:41 +0200") References: <835yc2c0vw.fsf@gnu.org> Date: Sat, 19 Aug 2023 11:26:57 +0800 Message-ID: <87350fg1a6.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 435 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, Eli Zaretskii , justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Daniel Mart=C3=ADn writes: > * src/frame.h: Declare an NS-only function to make a frame the key > window. > * src/nsfns.m (ns_make_frame_key_window): Implement it. > * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of > Fraise_frame. (Bug#61525) This commit message extends into column 70. Please fill it to 64 columns, or else the ChangeLog entries generated will be incorrectly formatted. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 19 04:29:04 2023 Received: (at 61525) by debbugs.gnu.org; 19 Aug 2023 08:29:04 +0000 Received: from localhost ([127.0.0.1]:49354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXHKS-0004ft-0D for submit@debbugs.gnu.org; Sat, 19 Aug 2023 04:29:04 -0400 Received: from sonic306-19.consmr.mail.ir2.yahoo.com ([77.238.176.205]:38958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXHKP-0004fG-Nr for 61525@debbugs.gnu.org; Sat, 19 Aug 2023 04:29:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.es; s=s2048; t=1692433734; bh=cwffzKeys8rlxXvHD6QyN9s0wtd3PEhjSPeyxsBp0dQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=XDbFSvm9bbgIMpkXjNxtw4sYRsWJgWWU3pSIrNOBWf73PJqHZ2CRwb8PTk9PdEvlXebLeo8STKxdTvQT2bddcertwuUKHhbitS1NMPLdFiRjp7j6Gs5xnqIHTSivJmJOURgResQtuliyuS/eklEMFfwjXKtUXSIBvCp2f3zDNG2ijTYTP5p6d7X2SZmuKxR29Gep9WsBMMqpUvtzO2Z2XcZpEAOXSyxRK8SxILHTRCObZq6ULAD5nTBTfntV0rpOrbKnE/dcYuedK4OwfHOXIAog5M10p5Lhw8bBAxbQ3umz688b9EP282CTFftQWpTYTz2GGyvA4uWP7/vr90auMQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1692433734; bh=njEhDH+yy3gyjtj117GsUWeI2rgBXHgsqH65ArmhJ+O=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=t+JHj1DeL5vlm8x0OMBQOeAXdBA6KFAE5oSTP6MBp6C8MgJVA/ltX6oKz9sPiwed/PNnfK/HwKb3UmqABjzPTOzBrKqpK9dw2InjTuUqgaMebmTX7wCUdmC+QW220P+tEv4jcuqISn6IyM31X1G0pxB1+Th5l7NvVQFxwDIbOj0V4dKIuJvlqazhgqWHihgkw5pUmjrxZbtFAlDUXdYTxyC5d/D0WmdctJca2DV9rHe+urexxjr9SxWAip8JJtm5toci4rPKosJpCUyFP6G5wmxw2ykrRdo3F7vj996jV592rtbf6sh3K5no4dTvc6o7IdEGHRpKHp7gIN2mALHf7Q== X-YMail-OSG: PYvpIEoVM1nAJn2l5J3SFdaRDAauPldd5LdANMIBf1ZbogEjKwWyjV6CfxPDN5. weh.UrM3P4hXNyNVBbT3ejTPKstcRfDl_r8NzYQixNrCT_YFWD3cCUAEKztd.wYVIU5jBS0EJLc1 GBTcN0YAe54kNJNXzDrmU64IsB0MWOjqwyfbu9fRWNoOKVvz.kf.8JTfls7DTMAZaAXdNEcxloBL h7ZtnTyXKO0FAgkuNzs3UpLW2M5pYK56Yxx9bsqFAzuLLpWdrjQbp72G4_eC8INxwCoNGt_m4_Aq zCr8uXyPY741aesTmW7d4ayhrC4uEvXebCHtCFTTmUMUedyvOWFmLlnMPjgLVrbIFqdXAfRCYZb7 .NbpAA4S8hHF5XUIYKIHexNrjWTlFYL.c5MXNKVTyUQsQsnqQVqMLQduogcA8GjqRE9AJAY7xB04 HOxLRe4oqk3BtWk6hKPCM4sqIF3Lk1YrZr_yx0YdGzxXUxdHeqKyJPIxJr7YSkj5RQcHZeS.PRd5 KCCEtTCyTWPMh_vHKyVpKb9mF315Mka4N4oZOev4nSZAzvFHUxw28yK6dWnej0NGqm3BBq.RZgUn 2naSTnCZaW1been207k.9ADl6geF7KDwyIfUQb39Igxcvc1FWHH1WE167e0eVf3XReVMI9qcwb7y psz3vCdXYsymaPceqWSpujum9RDYJHU_dFUavCso.77onEVb7HbrOz7Gcodw0MD0N4jFWTRNRlxl VVzRZGoY.PjrbtmLokBkFuSoCyAcEzs9cpccaihvJwxzHxsKI6htodPZSgfTJafW.0W_MOpUPcK1 A3ms6MjqruLuDRx02VMELM1L_pQIrpwry2VaZRSuUB_XhpdGHxqFNIMs5XCnI24WUwWh_dusRPk0 wy6FOAcdQjBOxoDKQeB4gA56Nq7SPMiUA5Wrjvo5oHwEnXz.XpSgJzc8jn_gENqmi_fk5L_PN8Av wkBqQSNFgnFGKeIj_14uinoUc7ZkPuuvCcvq4MQor0tTiNiBkwde1bZ4InVUy5wr0slJC4mfFFW1 8Qu4iH1TkvmzByw_GSo6ScyVGYUwNEYceHT4_4ze6SB5sW6_P5H5E0JUVxIfzEvU8pdCxI9EQ1pP z6i_8qyhj8vR7iY8APczUEvfUzGl4IQhX7S72I96TVVheuGNLS9gk9VLFRJLsHKKaXPqTVDOzOA8 nJjStns26JjmekUp3SsvjqU_LeS6CIK2DCALPzB7GjZjURUlz1Cs7guZi20EpIIYCor3diFS0KQ1 acQpefsbXD_6esmbd6a9xC8jHf4uC8rtsfdy6QP70KO8z9n41rr55tpUzDmF.pOCV8WjEfJ0sKUR fkk.Ike48awQmUtsNlxH8u3ZRSsK1sMFf6qs2hxj7Y1o8Hn0_Ng_tn1kxHNoCs5eqgknSVV0s15C MmyXOyda0dm7gTNWIeMJVUqY04ub9HBVDMzJyFl8yYxE.7n30T5ux5u3GoMJcAt902JHXkWzznwU rBdbtDSn26FI6JpH4yr59DnAOErjlDnuXOr4flrAXnJ9qKFw8I5mEgPX.L899kZJ6UFhqxkCHbjL 7GEKjFOd_1hYRu0ysQ4llUZvw0lqA2MnJzEmv7MbjLiotOwQ0tfe13AmEfg_APaNFZcropAGvAXy Ho3gsEy6.KLBgru2BTnEDvD04Vnybwt97fl9TzIUWrCzE08P9da0kVXXC8rblUGaNGses0px1De7 84SGHXkZ9mo9GcRhioNsGWhLGTRx9bKm04CXmET_lCogYUlEmBcW9Owf2m7vtNtQKbhgRxQ_o7Yt .4f0zgWCNt1nN5_e_QmwCgPoemvdFm4MqMXAz11W3bApJJzHdRSjwfncLBgp_ms4BW5qTPBxKT.n 2f3e4YIgV.TEE4pCZXiGuMkU9IuynHE5rkFDQENd2SUhwg4WBvBWdWY2NjCvWE3Jla64nfDRyuDx _8UdSds8rl_T7KuP63808LM0.UX2qQOxlBJwXOnkNVfmMQd68YVxwa2qnFoS1WBcVI3ji0BxW5a2 iimj7dhtiQnPue45kFuLKGUndH2rhtjpnV.UWCbcjDS7fInv0fapnrCI4xRtCtVcnA3dliYaC0_M Fxfqhf97iuvpTHm3iDxaF38RbLXq.VnpgFE2.bskRqGCX_SMycG61nUPJ2wbXnZYfNBAP61Wcf3m wZsBVR29sezLF5PkIX5mWfQjeyH3ZFFGtm4ONoNMokNZgVdCTGmAcyFO6vR3ChZrKXECcSRbw5OR 5c.fDGK5V9YuoPrkqCwfvM.6TPPZRFfV7Ll7AUO0mQ.ZiK_8- X-Sonic-MF: X-Sonic-ID: 5e19f312-0141-4021-ae8b-754fb4fa1b50 Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ir2.yahoo.com with HTTP; Sat, 19 Aug 2023 08:28:54 +0000 Received: by hermes--production-ir2-5cc57b9c45-4sdwq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 85717370380f088ffac272e0e9a79061; Sat, 19 Aug 2023 08:28:49 +0000 (UTC) From: =?utf-8?Q?Daniel_Mart=C3=ADn?= To: Po Lu Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop In-Reply-To: <87350fg1a6.fsf@yahoo.com> (Po Lu's message of "Sat, 19 Aug 2023 11:26:57 +0800") References: <835yc2c0vw.fsf@gnu.org> <87350fg1a6.fsf@yahoo.com> Date: Sat, 19 Aug 2023 10:28:48 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Mailer: WebService/1.1.21732 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3431 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 61525 Cc: 61525@debbugs.gnu.org, Eli Zaretskii , justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Po Lu writes: > Daniel Mart=C3=ADn writes: > >> * src/frame.h: Declare an NS-only function to make a frame the key >> window. >> * src/nsfns.m (ns_make_frame_key_window): Implement it. >> * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of >> Fraise_frame. (Bug#61525) > > This commit message extends into column 70. Please fill it to 64 > columns, or else the ChangeLog entries generated will be incorrectly > formatted. I've attached a new patch with the commit message wrapped at 64 columns. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-NS-Do-not-raise-a-different-frame-when-closing-a-fra.patch >From 3f8d0ee00ab9392d27831d64ef154c92b2b60608 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=ADn?= Date: Fri, 18 Aug 2023 15:03:21 +0200 Subject: [PATCH] [NS] Do not raise a different frame when closing a frame * src/frame.h: Declare an NS-only function to make a frame the key window. * src/nsfns.m (ns_make_frame_key_window): Implement it. * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of Fraise_frame. (Bug#61525) --- src/frame.c | 15 +++++++++------ src/frame.h | 4 ++++ src/nsfns.m | 6 ++++++ 3 files changed, 19 insertions(+), 6 deletions(-) diff --git a/src/frame.c b/src/frame.c index da00cbf4bce..addeb013b4a 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2212,12 +2212,15 @@ delete_frame (Lisp_Object frame, Lisp_Object force) } #ifdef NS_IMPL_COCOA else - /* Under NS, there is no system mechanism for choosing a new - window to get focus -- it is left to application code. - So the portion of THIS application interfacing with NS - needs to know about it. We call Fraise_frame, but the - purpose is really to transfer focus. */ - Fraise_frame (frame1); + { + /* Under NS, there is no system mechanism for choosing a new + window to get focus -- it is left to application code. + So the portion of THIS application interfacing with NS + needs to make the frame we switch to the key window. */ + struct frame *f1 = XFRAME (frame1); + if (FRAME_NS_P (f1)) + ns_make_frame_key_window (f1); + } #endif do_switch_frame (frame1, 0, 1, Qnil); diff --git a/src/frame.h b/src/frame.h index c85df378da6..f4726f1c0e5 100644 --- a/src/frame.h +++ b/src/frame.h @@ -1521,6 +1521,10 @@ window_system_available (struct frame *f) extern void frame_size_history_plain (struct frame *, Lisp_Object); extern void frame_size_history_extra (struct frame *, Lisp_Object, int, int, int, int, int, int); +#ifdef NS_IMPL_COCOA +/* Implemented in nsfns.m. */ +extern void ns_make_frame_key_window (struct frame *); +#endif extern Lisp_Object Vframe_list; /* Value is a pointer to the selected frame. If the selected frame diff --git a/src/nsfns.m b/src/nsfns.m index b846b490ff7..a79892f73b6 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -685,6 +685,12 @@ Turn the input menu (an NSMenu) into a lisp list for tracking on lisp side. SET_FRAME_GARBAGED (f); } +void +ns_make_frame_key_window (struct frame *f) +{ + [[FRAME_NS_VIEW (f) window] makeKeyWindow]; +} + /* tabbar support */ static void ns_set_tab_bar_lines (struct frame *f, Lisp_Object value, Lisp_Object oldval) -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 26 04:06:06 2023 Received: (at 61525-done) by debbugs.gnu.org; 26 Aug 2023 08:06:06 +0000 Received: from localhost ([127.0.0.1]:41690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZoJ4-00049J-CK for submit@debbugs.gnu.org; Sat, 26 Aug 2023 04:06:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZoJ2-00048r-Dp for 61525-done@debbugs.gnu.org; Sat, 26 Aug 2023 04:06:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZoIr-0005E5-Vy; Sat, 26 Aug 2023 04:05:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DUwgaU9KPaCGhkixeQmSF3gPYXRgeWOkWilR8Um9gdo=; b=isBtLlSbujt0pyIh9KQp BVliwq9OlJmIKQvfUTVJQotpCbsUyRn+GFux13SkCCYqYE0hEpQdFedYWCdRnRwdmE6u/8J/hlR/r gtJwexzcBDn01eq5q5DEbwEOcg087fyIye9BrwPxMo7dkn46wxHbgXcdufrLiDVchFGFppB267v6b XGOO96EeCnWjTrVSlS3mjSyGx+7S+Aix1Ufu0YfXUWMz1k4EuqhJhaoS8fNfoyN3UgA1ebpBqY1U1 BQu6mrhskqMinPoocBI+Hbmgs66oFe1A+k3BzhcpKGjPpy3deCvMYH2tRC9IPlgsf9hn+/CRsJ8mX CoAcDvNiUGMKVg==; Date: Sat, 26 Aug 2023 11:06:21 +0300 Message-Id: <83y1hykz2a.fsf@gnu.org> From: Eli Zaretskii To: Daniel =?utf-8?Q?Mart=C3=ADn?= In-Reply-To: (message from Daniel =?utf-8?Q?Mart?= =?utf-8?Q?=C3=ADn?= on Sat, 19 Aug 2023 10:28:48 +0200) Subject: Re: bug#61525: 29.0.60; delete-frame will raise frames in another virtual desktop References: <835yc2c0vw.fsf@gnu.org> <87350fg1a6.fsf@yahoo.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61525-done Cc: luangruo@yahoo.com, 61525-done@debbugs.gnu.org, justksqsf@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Martín > Cc: Eli Zaretskii , 61525@debbugs.gnu.org, justksqsf@gmail.com > Date: Sat, 19 Aug 2023 10:28:48 +0200 > > Po Lu writes: > > > Daniel Martín writes: > > > >> * src/frame.h: Declare an NS-only function to make a frame the key > >> window. > >> * src/nsfns.m (ns_make_frame_key_window): Implement it. > >> * src/frame.c (delete_frame): Call ns_make_frame_key_window instead of > >> Fraise_frame. (Bug#61525) > > > > This commit message extends into column 70. Please fill it to 64 > > columns, or else the ChangeLog entries generated will be incorrectly > > formatted. > > I've attached a new patch with the commit message wrapped at 64 columns. Thanks, installed on the master branch, and closing the bug. From unknown Fri Jun 20 07:17:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 23 Sep 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator