GNU bug report logs - #61521
"default" is now the first item returned from (font-faces), breaking various code.

Previous Next

Full log

Message #35 received at 61521 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Brennan Vincent <brennan <at> umanwizard.com>
Cc: 61521 <at> debbugs.gnu.org
Subject: Re: bug#61521: "default" is now the first item returned from
 (font-faces), breaking various code.
Date: Wed, 15 Feb 2023 16:24:46 +0200

> From: Brennan Vincent <brennan <at> umanwizard.com>
> Date: Wed, 15 Feb 2023 09:01:31 -0500
> Cc: 61521 <at> debbugs.gnu.org
> 
> > On Feb 15, 2023, at 07:58, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> > 
> >> 
> >> Date: Tue, 14 Feb 2023 19:31:30 -0500
> >> From: Brennan Vincent <brennan <at> umanwizard.com>
> >> 
> >> Various code seems to expect "default" to be the /last/ item in the list
> >> returned by that function, not the first. For example, this comment in faces.el:
> >> 
> >>  ;; The `reverse' is so that `default' goes first.
> >>  (dolist (face (nreverse (face-list)))
> > 
> > That comment is obsolete and needs to be changed (and the call to
> > nreverse should perhaps be removed).
> 
> If the order returned by face-list is not guaranteed, then why does it do sorting at all?

Good question.  AFAICT, the sorting was added when we switched from
storing faces in alists to storing them in hash tables.  It probably
sorted faces to be more compatible with what face-list returned before
the switch to hash table.  So I suspect the order we have now is
simply a bug, and we do need to change the order of sorting to get
back the original order.

Gregory, any counter-arguments?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.