GNU bug report logs - #61521
"default" is now the first item returned from (font-faces), breaking various code.

Previous Next

Full log

View this message in rfc822 format

From: Brennan Vincent <brennan <at> umanwizard.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61521 <at> debbugs.gnu.org
Subject: bug#61521: "default" is now the first item returned from (font-faces), breaking various code.
Date: Wed, 15 Feb 2023 09:01:31 -0500

> On Feb 15, 2023, at 07:58, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> 
>> 
>> Date: Tue, 14 Feb 2023 19:31:30 -0500
>> From: Brennan Vincent <brennan <at> umanwizard.com>
>> 
>> Various code seems to expect "default" to be the /last/ item in the list
>> returned by that function, not the first. For example, this comment in faces.el:
>> 
>>  ;; The `reverse' is so that `default' goes first.
>>  (dolist (face (nreverse (face-list)))
> 
> That comment is obsolete and needs to be changed (and the call to
> nreverse should perhaps be removed).

If the order returned by face-list is not guaranteed, then why does it do sorting at all?

>> Also, org-html-htmlize-generate-css does not work when default comes first in
>> the list (as it skips processing all fonts after default).
> 
> Isn't that a bug in that Org function?  It shouldn't rely on any
> particular order.

In that case, we can consider this bug report to relate to the broken Org function, which is how I initially discovered the face-list issue.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.