GNU bug report logs - #61521
"default" is now the first item returned from (font-faces), breaking various code.

Previous Next

Full log

Message #23 received at 61521 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: brennan <at> umanwizard.com, 61521 <at> debbugs.gnu.org
Subject: Re: bug#61521: "default" is now the first item returned from
 (font-faces), breaking various code.
Date: Wed, 15 Feb 2023 15:43:34 +0200

> Cc: 61521 <at> debbugs.gnu.org
> Date: Wed, 15 Feb 2023 09:00:44 +0000
> From: Gregory Heytings <gregory <at> heytings.org>
> 
> Thanks.  It seems the change you describe is not a recent one: the first 
> element of the list returned by 'face-list' is 'default' in Emacs 27, 28, 
> 29 and 30.  (This is caused by e3b8ddd500, since which frame faces are 
> stored in a hash table instead of an alist.)

Right.  So I wonder whether we should remove the nreverse call in
face-set-after-frame-default.  WDYT?

> Given this, and the fact that the docstring of 'face-list' does not 
> specify the order in which the faces are returned, it's not clear to me 
> that there is a bug here.  Code that assumes a given order should probably 
> be fixed.

I agree.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.