Subject: bug#61519: 30.0.50; thing-at-point misdetects emails with numerals in user part

From: Robert Pluim <[email-masked]>
Date: Wed, 15 Feb 2023 12:15:48 +0100

>>>>> On Wed, 15 Feb 2023 08:04:26 +0900, Aaron Madlon-Kay <[email-masked]> said:

    Aaron> 1. Launch Emacs with `emacs -Q`
    Aaron> 2. Enter an email address with a numeral in the user part, like
    Aaron>    [email-masked]
    Aaron> 3. With point inside the domain part of the email address, evaluate
    Aaron>    `(thing-at-point 'email)`
    Aaron> 4. Result will be [email-masked]` (expected [email-masked]`)

    Aaron> The cause of this is the implementation of `thing-at-point-looking-at'
    Aaron> where it backs up one character at a time to find the start of the
    Aaron> email. The value for `thing-at-point-email-regexp' allows numbers in
    Aaron> the user part only from the *second* character, so as the function
    Aaron> backs up it will mistakenly find the `0` in [email-masked]` to be
    Aaron> outside of the email address.

That regexp has a few other issues, but breaking out the full rfc 822
parser for this would be overkill. Could you try the following patch?

Robert
-- 

diff --git i/lisp/thingatpt.el w/lisp/thingatpt.el
index 9363a474cb5..f3367290dee 100644
--- i/lisp/thingatpt.el
+++ w/lisp/thingatpt.el
@@ -645,7 +645,7 @@ thing-at-point-looking-at
 
 ;;   Email addresses
 (defvar thing-at-point-email-regexp
-  "<?[-+_.~a-zA-Z][-+_.~:a-zA-Z0-9]*@[-.a-zA-Z0-9]+>?"
+  "<?[-+_~a-zA-Z0-9][-+_.~:a-zA-Z0-9]*@[-a-zA-Z0-9]+[-.a-zA-Z0-9]*>?"
   "A regular expression probably matching an email address.
 This does not match the real name portion, only the address, optionally
 with angle brackets.")