From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 09:18:18 2023 Received: (at submit) by debbugs.gnu.org; 14 Feb 2023 14:18:18 +0000 Received: from localhost ([127.0.0.1]:52971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRw8Q-00024R-33 for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:18:18 -0500 Received: from lists.gnu.org ([209.51.188.17]:40034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRw8N-00024J-Tr for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:18:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRw8N-0002KW-ON for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 09:18:15 -0500 Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRw8F-0005i3-E2 for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 09:18:15 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=q24ai9BW uspMbFNZe7jiIivH0H2qTF9C1Ahxl0NosYw=; h=date:subject:to:from; d=ledu-giraud.fr; b=1eBAqDBn4urHMYqTBNIUZDpB8MbFIBZTxFSy8ZXDboMP5CSgCY aTfFdmOuzi0YQzLSN1xv4jZCrgrlrjq1wWBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=q24ai9BWuspMbFNZ e7jiIivH0H2qTF9C1Ahxl0NosYw=; h=date:subject:to:from; d=ledu-giraud.fr; b=MrjaZWiJVzjqHvf5RUOPWXas3XomAHo1rI4kTQnSHcoMx90b73 CdK1cqdMOrx8KjCTkQpNThTga99FNpFnMst1BGaL/9iTnzbVtpFESAdBetdTpqixMgPxqi uwJYO2RzGxrszRT5zquVNMi92YqL4EFLx031q2Ip7JI+6wVX2SDLjGHXfhWHVWM846cIRz uenSyZuazJLFCC3nxxzWC30foNxcbl5lLbPRyOnPxAUweKHp9TBQdofKuJUe2CqJxTUIrV pw+NBLPNcEA6eUMMj9082DZQwwVvC0HhQ3CPZ61y3iV/AZHcmULobMBGxze/L9hhJo2wn7 s6GAL/gV3UbA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7c6caa9b (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Tue, 14 Feb 2023 15:17:59 +0100 (CET) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 30.0.50; [PATCH] Update thumbnail buffer's header more Date: Tue, 14 Feb 2023 15:17:58 +0100 Message-ID: <8735785o15.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Hi, Without this patch, the header of the thumbnail buffer does not always update correctly (for instance with "C-t .", "C-t a" and even "C-t d"). Best regards, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Update-thumbnail-buffer-s-header-more.patch >From bfff40cc6e9327d90040578d3b751c03bb0911eb Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Tue, 14 Feb 2023 15:08:17 +0100 Subject: [PATCH] Update thumbnail buffer's header more * lisp/image/image-dired.el (image-dired-display-thumbs): Call image-dired--update-header-line. --- lisp/image/image-dired.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el index 49b8d9f03c8..cfcd1851188 100644 --- a/lisp/image/image-dired.el +++ b/lisp/image/image-dired.el @@ -593,7 +593,8 @@ image-dired-display-thumbs (if do-not-pop (display-buffer buf) (pop-to-buffer buf)) - (image-dired--line-up-with-method)))) + (image-dired--line-up-with-method) + (image-dired--update-header-line)))) ;;;###autoload (defun image-dired-show-all-from-dir (dir) -- 2.39.1 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 2, x86_64-unknown-openbsd7.2, cairo version 1.17.8) of 2023-02-13 built on computer Repository revision: 609319da870eac75cf4715de8abfaac9233d98f9 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: OpenBSD computer 7.2 GENERIC.MP#1028 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: global-git-commit-mode: t magit-auto-revert-mode: t gnus-dired-mode: t display-time-mode: t display-battery-mode: t server-mode: t shell-dirtrack-mode: t repeat-mode: t desktop-save-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/ef-themes-0.10.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs /home/manuel/.emacs.d/elpa/transient-0.3.7/transient hides /home/manuel/emacs/share/emacs/30.0.50/lisp/transient Features: (shadow emacsbug magit-patch magit-extras face-remap magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff git-commit log-edit magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-section find-dired ffap mailalias dabbrev shr-color sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth qp utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss w3m w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util image-crop misearch multi-isearch cl-print add-log smerge-mode diff whitespace vc-annotate magit-utils dash ibuf-ext ibuffer ibuffer-loaddefs image-dired-dired shortdoc descr-text pulse help-fns radix-tree image-file image-converter image-dired image-dired-tags image-dired-external image-dired-util vc-dir ewoc org-indent mhtml-mode reveal view pascal vc-hg conf-mode flymake-cc flymake-proc flymake warnings vc css-mode sgml-mode facemenu sh-script smie executable vc-cvs vc-rcs log-view pcvs-util js c-ts-common treesit imenu oc-basic org-element org-persist org-id org-refile avl-tree ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-dired autorevert filenotify vc-git diff-mode vc-dispatcher vc-svn bug-reference paredit edmacro time battery exwm-randr xcb-randr exwm-config exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes modus-operandi-theme modus-themes ytdious osm mingus libmpdee reporter edebug debug backtrace transmission diary-lib diary-loaddefs color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load mu4e mu4e-org mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config bookmark ido supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt cl-extra help-mode speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs visual-basic-mode cl web-mode derived disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint ansi-osc ansi-color ring hyperspec thingatpt slime-autoloads dired-aux dired-x dired dired-loaddefs notifications dbus xml repeat easy-mmode desktop frameset stimmung-themes-autoloads rust-mode-autoloads ebdb-autoloads magit-autoloads debbugs-autoloads git-commit-autoloads magit-section-autoloads ef-themes-autoloads with-editor-autoloads paredit-autoloads dash-autoloads ytdious-autoloads transmission-autoloads transient-autoloads exwm-autoloads hyperbole-autoloads detached-autoloads info package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 1313150 454816) (symbols 48 78290 10) (strings 32 387199 29286) (string-bytes 1 11441146) (vectors 16 200605) (vector-slots 8 3892965 133077) (floats 8 793 457) (intervals 56 48431 12000) (buffers 984 166)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 08:58:24 2023 Received: (at 61508) by debbugs.gnu.org; 15 Feb 2023 13:58:24 +0000 Received: from localhost ([127.0.0.1]:58289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIIi-0001ZC-Gv for submit@debbugs.gnu.org; Wed, 15 Feb 2023 08:58:24 -0500 Received: from mail-ot1-f46.google.com ([209.85.210.46]:36725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIIg-0001Yx-1X for 61508@debbugs.gnu.org; Wed, 15 Feb 2023 08:58:23 -0500 Received: by mail-ot1-f46.google.com with SMTP id n25-20020a9d7119000000b0068bd8c1e836so5694114otj.3 for <61508@debbugs.gnu.org>; Wed, 15 Feb 2023 05:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date:message-id:reply-to; bh=c4pse6aBAOfsNCV13+Zwp/+48cEWjgn0qlOdlwbHVkY=; b=LEr//JYToYL8yXQVqJkCCt0VOqt5+UyUmPWuCKBXm/BWITg4EQfeyp7zayXjGjJda8 R1pGjxgyXyZh5g1UA7mpG9IDA9jE9fdKsyYpSuOkR7KRUYJV9PJX/Quq9Q4BEkusgAs5 x81Xt2dTE/erf8FTj4mGA29d3yUZCR7g+BA0NrYfjmYApJUT5mwIVUXSI5hoUyEILe7X vLPiutUMNI/LpFndSxfcXpoQckW9aYhyew5Jt5woEbp1cfHb46r57A47S+pnuKQYGzLf ryRlw1edzuHysVBqWG1f6dqqCoNiRax6eUQSqtjb+FzLyLUEXk84iOJpAC9AVccSC6lP cx7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c4pse6aBAOfsNCV13+Zwp/+48cEWjgn0qlOdlwbHVkY=; b=ORYJzDp3RezRf27SbFyDhHytXv7yUjEXj0IBcHA1ET8cPbEsWo+8q1vJkwDCYqcwLk ujj3e6CigquEuHtcGfzMhw3H4F/XJt3GYMN52hl93R07av/zLvKZIXDm+JMeKJ6uH09g jPQB7W90er8R4x7lcaqxzhcMU1PGdsLgX5QT9j7od54EAMhpf+xT1p+hUOWamvEPUf9N I5DoIzt3rJpsKUXSRQuKEjKzteXRXeJ4c08qIAMWYZZICLmBh06gT1lBaepFqmjGHSYJ YLERKNZtAmqpclh43UBUpfpAHj4FPi4tDOD9IX3tjrcLlk3a5rjeZU6KZIpucNMilJ2n xAyQ== X-Gm-Message-State: AO0yUKWtYImZApYUECiA7aE0j+/CuJ9bPPs8VqHTc1vmf6NLTZ4GEs3u 78mbGxa4mw0RDmtsk/lw2U5iv92WExwjZ21NZhYNJY8d X-Google-Smtp-Source: AK7set93frPZQFz4XUv2vkeJIkx2C029mU4CI8kvtqLdHAqNM7GkjdLwfb1qWjcbGIeGG7P0IsC+V8QqWDutQW1XEW0= X-Received: by 2002:a9d:7459:0:b0:68b:e0cd:faba with SMTP id p25-20020a9d7459000000b0068be0cdfabamr98120otk.76.1676469496228; Wed, 15 Feb 2023 05:58:16 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 15 Feb 2023 05:58:15 -0800 From: Stefan Kangas In-Reply-To: <8735785o15.fsf@ledu-giraud.fr> References: <8735785o15.fsf@ledu-giraud.fr> X-Hashcash: 1:20:230215:61508@debbugs.gnu.org::cJNoN2v40VnsEE56:69aa MIME-Version: 1.0 Date: Wed, 15 Feb 2023 05:58:15 -0800 Message-ID: Subject: Re: bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more To: Manuel Giraud , 61508@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61508 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Without this patch, the header of the thumbnail buffer does not always > update correctly (for instance with "C-t .", "C-t a" and even "C-t d"). Thanks for the patch. > From bfff40cc6e9327d90040578d3b751c03bb0911eb Mon Sep 17 00:00:00 2001 > From: Manuel Giraud > Date: Tue, 14 Feb 2023 15:08:17 +0100 > Subject: [PATCH] Update thumbnail buffer's header more > > * lisp/image/image-dired.el (image-dired-display-thumbs): Call > image-dired--update-header-line. > --- > lisp/image/image-dired.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el > index 49b8d9f03c8..cfcd1851188 100644 > --- a/lisp/image/image-dired.el > +++ b/lisp/image/image-dired.el > @@ -593,7 +593,8 @@ image-dired-display-thumbs > (if do-not-pop > (display-buffer buf) > (pop-to-buffer buf)) > - (image-dired--line-up-with-method)))) > + (image-dired--line-up-with-method) > + (image-dired--update-header-line)))) > > ;;;###autoload > (defun image-dired-show-all-from-dir (dir) > -- > 2.39.1 Eli, is it okay to install the above bug fix on the emacs-29 branch at this point? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 09:15:13 2023 Received: (at 61508) by debbugs.gnu.org; 15 Feb 2023 14:15:13 +0000 Received: from localhost ([127.0.0.1]:58339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIYy-0004Rh-UL for submit@debbugs.gnu.org; Wed, 15 Feb 2023 09:15:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSIYx-0004RT-No for 61508@debbugs.gnu.org; Wed, 15 Feb 2023 09:15:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSIYr-0004Zp-Dx; Wed, 15 Feb 2023 09:15:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CB9DOJhkx5BjQAg1zZLOuA6/1zgupgo8C7jEAykPa/A=; b=VqIeGf2UlNPW gwCpnSILz2F/Z+jAXQotYFrhLO3NVRZ3fr2NXZDe+LWmRJjM+v2uteFK4FIGTaHTiqZCOP86Fknk8 YTgKaDPLAEeezg8i7XkPsglOQDi2/8vhu41tcwtI/NoQS3y3byyZB5EF4ns2JkWiEV2hypgHz9FA+ 8F3OhiA+Ln1bRh3pr0oKzYaHKOuRq2sh/U9PgX7/GHgylderDrAZns5SLqaY3ErNPJoTy6JZClHy6 aS1aQPu2MYWERt1cehniKO/82Z7d6XHJhUqjPfGSsCQU/4za/ZjU2I8t/8K43LsiJCmJOCzJdqmpB rTFIK0Iu6bF50LDybRI7Zw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSIYp-00006S-FY; Wed, 15 Feb 2023 09:15:04 -0500 Date: Wed, 15 Feb 2023 16:14:44 +0200 Message-Id: <83fsb7aucr.fsf@gnu.org> From: Eli Zaretskii To: Stefan Kangas In-Reply-To: (message from Stefan Kangas on Wed, 15 Feb 2023 05:58:15 -0800) Subject: Re: bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more References: <8735785o15.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61508 Cc: 61508@debbugs.gnu.org, manuel@ledu-giraud.fr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 15 Feb 2023 05:58:15 -0800 > > > diff --git a/lisp/image/image-dired.el b/lisp/image/image-dired.el > > index 49b8d9f03c8..cfcd1851188 100644 > > --- a/lisp/image/image-dired.el > > +++ b/lisp/image/image-dired.el > > @@ -593,7 +593,8 @@ image-dired-display-thumbs > > (if do-not-pop > > (display-buffer buf) > > (pop-to-buffer buf)) > > - (image-dired--line-up-with-method)))) > > + (image-dired--line-up-with-method) > > + (image-dired--update-header-line)))) > > > > ;;;###autoload > > (defun image-dired-show-all-from-dir (dir) > > -- > > 2.39.1 > > Eli, is it okay to install the above bug fix on the emacs-29 branch at > this point? Yes, thanks. (This whole area of Emacs was revamped for Emacs 29, right? So this is just fixing a regression introduced while we were at that.) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 15 11:01:54 2023 Received: (at 61508) by debbugs.gnu.org; 15 Feb 2023 16:01:54 +0000 Received: from localhost ([127.0.0.1]:33722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSKEE-0000GR-G3 for submit@debbugs.gnu.org; Wed, 15 Feb 2023 11:01:54 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:13275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSKEB-0000GE-1w for 61508@debbugs.gnu.org; Wed, 15 Feb 2023 11:01:53 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=5gj8TOXt tBYrIWcV19o47G6hVKbIiTWvKvIqEnHVzWo=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=1PN+nD81Xp8LbelpEl/qaJNAHpbEzk HRUxej1/Rvp55EMNbfoon75DtZ3SQf6L1lE2pOWEZegFUIqoLYaT+3Dg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=5gj8TOXttBYrIWcV 19o47G6hVKbIiTWvKvIqEnHVzWo=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=V4txcbpSBFTLmmoRzZYMQVe4lFAb5FOKImqOWz lgR+8xjWdf5AKyxOruDdbtC7vHGItQvCPCjhSIyw9wJyGqjjgP+K2a3qhIay6TB0jLBXOx sn4bIl+1wtRgzZZjMnOyBIwp1Sis/lhgg3CSp3/VNHuQFHE10DiE97LN7y6OZ8scR3ChVW pXV8jAxu3m57kb4JSXhDXWDH3xPTyT8bs2ZrLUzgrAIEzCaToDKJ0J4u+k+IHq9RO80PSS 4VnOAWRnGy35iJy6OfhdiPZfzdoPqmkDylScPtq5ChMSqQkfM11YA5xryZOKzGroazMrX1 D/KU2fV7x2grja6VpRnNE65w== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 36fedf7c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 15 Feb 2023 17:01:49 +0100 (CET) From: Manuel Giraud To: Stefan Kangas Subject: Re: bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more In-Reply-To: (Stefan Kangas's message of "Wed, 15 Feb 2023 05:58:15 -0800") References: <8735785o15.fsf@ledu-giraud.fr> Date: Wed, 15 Feb 2023 17:01:47 +0100 Message-ID: <873576lxxw.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61508 Cc: 61508@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >> Without this patch, the header of the thumbnail buffer does not always >> update correctly (for instance with "C-t .", "C-t a" and even "C-t d"). > > Thanks for the patch. After this patch, I have one more to prevent error out should the list of dired selected files contains a non image. As it a change in behaviour, I'll make a new bug report with this. -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 17:51:27 2023 Received: (at 61508) by debbugs.gnu.org; 18 Feb 2023 22:51:28 +0000 Received: from localhost ([127.0.0.1]:45141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTW3D-0005L1-NT for submit@debbugs.gnu.org; Sat, 18 Feb 2023 17:51:27 -0500 Received: from ledu-giraud.fr ([51.159.28.247]:7023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTW3B-0005Ks-Jt for 61508@debbugs.gnu.org; Sat, 18 Feb 2023 17:51:26 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=aZGw56OI CjrMzY28sU9x3Ssf7O9UJ0T2Bkj4dCtcdNo=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=lT9flBw0li3mj+sdZoEA0MmWjljuX0 oaznUx5f1BS9T9PSCPhnVCCYIB7nN3pgAkYHvVquouasW05Qe0LIMiDA== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=aZGw56OICjrMzY28 sU9x3Ssf7O9UJ0T2Bkj4dCtcdNo=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=1lZUKD0pySs4GcqFG5+gwzRraZaznO9L8Y/8Ck s3VCAgsnFk99WGDufkuV0HoGULysFatrBPBdYHPNCBvSRywx24isJ/GIBlRmkHufqR/zbU ICHVwFwjX7aSpCEW/+/guJTdZzysPjNmTidkD7jnlRvGuUp7iVyQ2fG5yA9rMFMj1yein8 4vRrhmkmnuUYdq0Br0gCwoPKSsvboZTkCr2SK2t9dC5ZNyNpb+gmmX0qIK0e3YBXUl66hY XKEx/B/H8ZaS+Qbomt00XbapwaalWB30G75mJBRiEMZUk+wDRhQSxyReftawzIuYSWp9ZL PocDc2czZqFqw0B5MYLP8diA== Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 325fe6e5 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 18 Feb 2023 23:51:23 +0100 (CET) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more In-Reply-To: <83fsb7aucr.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Feb 2023 16:14:44 +0200") References: <8735785o15.fsf@ledu-giraud.fr> <83fsb7aucr.fsf@gnu.org> Date: Sat, 18 Feb 2023 23:51:22 +0100 Message-ID: <87a61aa8ph.fsf@ledu-giraud.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61508 Cc: 61508@debbugs.gnu.org, Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: [...] >> Eli, is it okay to install the above bug fix on the emacs-29 branch at >> this point? > > Yes, thanks. (This whole area of Emacs was revamped for Emacs 29, > right? So this is just fixing a regression introduced while we were > at that.) I guess that you are quite busy now but do you think you could apply it then? -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 19 01:26:15 2023 Received: (at 61508-done) by debbugs.gnu.org; 19 Feb 2023 06:26:16 +0000 Received: from localhost ([127.0.0.1]:45486 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTd9L-0000TY-It for submit@debbugs.gnu.org; Sun, 19 Feb 2023 01:26:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTd9K-0000TM-0A for 61508-done@debbugs.gnu.org; Sun, 19 Feb 2023 01:26:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTd9E-0004UT-6I; Sun, 19 Feb 2023 01:26:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=upLe8YYDPtp6f03NKrnHK6csci3mo8FM2lFawBctAwY=; b=PE14FYqv6VAY PgDjh2J+E5yR4TcNnPn7JkDTvgCdsmofEKNMbxzkdWKVn5cTMV/YukTSsK59mcrnqSU0oKKMFZIgP aoPR9xZ6iKSvIWZldYdtLPRUimJAhqfTzJ0lo0PMuz2+qvJ0ohJh8soGEmHT2ux8Zsd2jsD+7AwaX fpV6X0J2Ol5W3JPTjyQ7S1KEr/MJMXcfETJ7/b5jzho8tiAyn3g4p8mZ/IX/xOtwDFasXJ9sNvoMs T02ujXdvHti3BWWszynyL2a8Npk5vTgS8E3k9LH2LvxstECdN2EUeyL1BTWtaKT0CAC4LOHTiP8oR zUtacC2T9lM6raG5KR8DfQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTd9D-0003MI-Es; Sun, 19 Feb 2023 01:26:08 -0500 Date: Sun, 19 Feb 2023 08:26:12 +0200 Message-Id: <83lekuxjaz.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87a61aa8ph.fsf@ledu-giraud.fr> (message from Manuel Giraud on Sat, 18 Feb 2023 23:51:22 +0100) Subject: Re: bug#61508: 30.0.50; [PATCH] Update thumbnail buffer's header more References: <8735785o15.fsf@ledu-giraud.fr> <83fsb7aucr.fsf@gnu.org> <87a61aa8ph.fsf@ledu-giraud.fr> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61508-done Cc: stefankangas@gmail.com, 61508-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: Stefan Kangas , 61508@debbugs.gnu.org > Date: Sat, 18 Feb 2023 23:51:22 +0100 > > Eli Zaretskii writes: > > [...] > > >> Eli, is it okay to install the above bug fix on the emacs-29 branch at > >> this point? > > > > Yes, thanks. (This whole area of Emacs was revamped for Emacs 29, > > right? So this is just fixing a regression introduced while we were > > at that.) > > I guess that you are quite busy now but do you think you could apply it > then? Done. From unknown Sun Aug 17 01:49:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 19 Mar 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator