GNU bug report logs - #61497
emacs-lsp-treemacs unused leftover icons in sources

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61497: closed (emacs-lsp-treemacs unused leftover icons in
 sources)
Date: Mon, 06 Mar 2023 14:16:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 06 Mar 2023 15:15:09 +0100
with message-id <87leka0xw2.fsf <at> fsfe.org>
and subject line Re: emacs-lsp-treemacs unused leftover icons in sources
has caused the debbugs.gnu.org bug report #61497,
regarding emacs-lsp-treemacs unused leftover icons in sources
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
61497: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61497
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jelle Licht <jlicht <at> fsfe.org>
To: bug-guix <at> gnu.org
Subject: emacs-lsp-treemacs unused leftover icons in sources
Date: Tue, 14 Feb 2023 02:06:55 +0100

Commit e0d2ec418bb on master removed icons that are unclearly licensed
from the sources of emacs-lsp-treemacs. Quoted here: 

--8<---------------cut here---------------start------------->8---
gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.

emacs-lsp-treemacs bundles icons with unclear licenses.
See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
--8<---------------cut here---------------end--------------->8---

Some icons are still left in the sources, in the 'icons/vscode'
directory' of the source tarball one builds by running `guix build
--source emacs-lsp-treemacs'. I have never used vscode, and am
unfamiliar with the licensing situation of it and its related icons.

In case these icons are also unclearly licensed, I propose we follow the
same strategy as done earlier by Liliana, and remove the vscode icons
entirely.  If the icons are actually licensed under an unproblematic
license, it would be nice if they were installed when running `guix
install emacs-lsp-treemacs', and the license property of the package
updated to reflect this fact.

Thanks for any insight,
- Jelle

[Message part 3 (message/rfc822, inline)]

From: Jelle Licht <jlicht <at> fsfe.org>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 61497-done <at> debbugs.gnu.org
Subject: Re: emacs-lsp-treemacs unused leftover icons in sources
Date: Mon, 06 Mar 2023 15:15:09 +0100

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht:
>> Commit e0d2ec418bb on master removed icons that are unclearly
>> licensed
>> from the sources of emacs-lsp-treemacs. Quoted here: 
>> 
>> --8<---------------cut here---------------start------------->8---
>> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons.
>> 
>> emacs-lsp-treemacs bundles icons with unclear licenses.
>> See also <https://github.com/emacs-lsp/lsp-treemacs/issues/123>.
>> --8<---------------cut here---------------end--------------->8---
>> 
>> Some icons are still left in the sources, in the 'icons/vscode'
>> directory' of the source tarball one builds by running `guix build
>> --source emacs-lsp-treemacs'. I have never used vscode, and am
>> unfamiliar with the licensing situation of it and its related icons.
>> 
>> In case these icons are also unclearly licensed, I propose we follow
>> the same strategy as done earlier by Liliana, and remove the vscode
>> icons entirely.  If the icons are actually licensed under an
>> unproblematic license, it would be nice if they were installed when
>> running `guix install emacs-lsp-treemacs', and the license property
>> of the package updated to reflect this fact.
> From what I could gather, vscode-icons [1] are actually CC-BY, but used
> without proper attribution in this package.  As for why they're unused,
> I mostly forgot to whitelist them.
>
> Cheers
>
> [1] https://github.com/microsoft/vscode-icons

Fixed + pushed to master in #61649 / 3f222cd5ad,
closing this issue.

- Jelle

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.