From unknown Sun Aug 17 22:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61497: emacs-lsp-treemacs unused leftover icons in sources Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Feb 2023 01:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61497 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 61497@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167633682623912 (code B ref -1); Tue, 14 Feb 2023 01:08:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Feb 2023 01:07:06 +0000 Received: from localhost ([127.0.0.1]:52015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRjmk-0006DW-6o for submit@debbugs.gnu.org; Mon, 13 Feb 2023 20:07:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:48402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRjmh-0006DG-Id for submit@debbugs.gnu.org; Mon, 13 Feb 2023 20:07:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRjmh-0007MQ-7L for bug-guix@gnu.org; Mon, 13 Feb 2023 20:07:03 -0500 Received: from mail1.fsfe.org ([217.69.89.151]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRjme-0001gX-Rk for bug-guix@gnu.org; Mon, 13 Feb 2023 20:07:02 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1676336816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=Bny+Ixg7Ia8tYYGeixtR9pbraetSl9irNLaMlYx9kzs=; b=BqYee3jbbupCVfBoUbC9nb5LtxXYWh94SJZxwLjvKmDby7ECFzBr13CVViLr0mf2oU0yGs SV1Ctv7zGtKLtFJHpmDiM9oJdd0uOzX4a2g8z30ZqBTGcVjDIb1IGqHbvjarZzHsBeAp8v Rj88p9YCtptlbW4V18VdmVM0z/EDcnc= Date: Tue, 14 Feb 2023 02:06:55 +0100 Message-ID: <87v8k55a34.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.69.89.151; envelope-from=jlicht@fsfe.org; helo=mail1.fsfe.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Commit e0d2ec418bb on master removed icons that are unclearly licensed from the sources of emacs-lsp-treemacs. Quoted here: --8<---------------cut here---------------start------------->8--- gnu: emacs-lsp-treemacs: Remove unclearly licensed icons. emacs-lsp-treemacs bundles icons with unclear licenses. See also . --8<---------------cut here---------------end--------------->8--- Some icons are still left in the sources, in the 'icons/vscode' directory' of the source tarball one builds by running `guix build --source emacs-lsp-treemacs'. I have never used vscode, and am unfamiliar with the licensing situation of it and its related icons. In case these icons are also unclearly licensed, I propose we follow the same strategy as done earlier by Liliana, and remove the vscode icons entirely. If the icons are actually licensed under an unproblematic license, it would be nice if they were installed when running `guix install emacs-lsp-treemacs', and the license property of the package updated to reflect this fact. Thanks for any insight, - Jelle From unknown Sun Aug 17 22:09:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61497: emacs-lsp-treemacs unused leftover icons in sources Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Feb 2023 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61497 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Jelle Licht , 61497@debbugs.gnu.org Received: via spool by 61497-submit@debbugs.gnu.org id=B61497.16764026729402 (code B ref 61497); Tue, 14 Feb 2023 19:25:02 +0000 Received: (at 61497) by debbugs.gnu.org; 14 Feb 2023 19:24:32 +0000 Received: from localhost ([127.0.0.1]:57003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pS0um-0002Ra-1t for submit@debbugs.gnu.org; Tue, 14 Feb 2023 14:24:32 -0500 Received: from mail-ej1-f65.google.com ([209.85.218.65]:33552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pS0ul-0002RN-8V for 61497@debbugs.gnu.org; Tue, 14 Feb 2023 14:24:31 -0500 Received: by mail-ej1-f65.google.com with SMTP id ml19so42820493ejb.0 for <61497@debbugs.gnu.org>; Tue, 14 Feb 2023 11:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=F028LaOICqiT0HK1fwHG7FKxn63qX1dWHACbaChQc7w=; b=oybYgRBI+v6pIb/vxqsTGQlP41p1UX7IjV0kfYA927LrfhXKPQw8jsqRo/2Qqwti3D XvU1ud6ZK3rJ6NOrqKf4649NbQC3PcXgGpYKrpDbRExDHkprVux/Zna+UxhtFFGTQZDQ NVXamCTRwiJKiHHAXhhM4MOFi7TwxGgLTILjfuvAyevS+/VHUruMGGZ0Ruuao+ffBOzo Zl/dafp1zPo6V5iwBgloOSE1VPb1TOwC4TU+Cf0aC4vx5BEtxpXFI44jtBYCBo+lFx2J zcsoN4UvvgtObUdMrGhxhSPw+lzHWHHoeb4kSdkyrZnpk0FuwShB8GZUqn2SBtcdpABD 6XcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=F028LaOICqiT0HK1fwHG7FKxn63qX1dWHACbaChQc7w=; b=YFNaREGxrW6liDnJ3Vk89bw4E424R+F0sIhu04bpV1HERuGKw0Q17TD0bQVFjUNdnf YWPliGxwlHt19FncB39Z6h/rYJd3PPkR1szZdZho45i13U01I+ZXajVjV/XtYqCspWfP LS2aw/6w1uWzxkLFcBc93WZNE8Y8ZqIWIGYInUBcSH19+firghAwiw25lzxQzw43DnDO xWM6e1EmZe+vEtIuFT9D9L4U7cz2OK7ugjUMWN/Bw5ot8Etlis/qX4zAlPgzhljbbx/I NAGQz6cSFvLx7eHfXjZcVK956KMWiRqsJwiTBQQEUdIMCj9LcedPot2qWYVFsYO72gxB 2xqQ== X-Gm-Message-State: AO0yUKVdpdOL6P1o168/lUmBmEUgXEs4GHdv1PsO0DMTXcvEkh54hwLz LmkbcsLjPV5wuCyzO8u/UT0= X-Google-Smtp-Source: AK7set9pjNdQ1P6WhwDQwxbjTrfvtY6H1Vz5neNg4aSly9WtcpmSko97sRtzjwt5Isle4KVzOeJofQ== X-Received: by 2002:a17:906:a2d6:b0:883:b1b4:e798 with SMTP id by22-20020a170906a2d600b00883b1b4e798mr3969008ejb.10.1676402665427; Tue, 14 Feb 2023 11:24:25 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id x16-20020a170906711000b008512e1379dbsm8753554ejj.171.2023.02.14.11.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 11:24:24 -0800 (PST) Message-ID: <3c5bf58df07650ebeaf0c9411c0a23a548904e24.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 14 Feb 2023 20:24:23 +0100 In-Reply-To: <87v8k55a34.fsf@fsfe.org> References: <87v8k55a34.fsf@fsfe.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht: > Commit e0d2ec418bb on master removed icons that are unclearly > licensed > from the sources of emacs-lsp-treemacs. Quoted here:=20 >=20 > --8<---------------cut here---------------start------------->8--- > gnu: emacs-lsp-treemacs: Remove unclearly licensed icons. >=20 > emacs-lsp-treemacs bundles icons with unclear licenses. > See also . > --8<---------------cut here---------------end--------------->8--- >=20 > Some icons are still left in the sources, in the 'icons/vscode' > directory' of the source tarball one builds by running `guix build > --source emacs-lsp-treemacs'. I have never used vscode, and am > unfamiliar with the licensing situation of it and its related icons. >=20 > In case these icons are also unclearly licensed, I propose we follow > the same strategy as done earlier by Liliana, and remove the vscode > icons entirely.=C2=A0 If the icons are actually licensed under an > unproblematic license, it would be nice if they were installed when > running `guix install emacs-lsp-treemacs', and the license property > of the package updated to reflect this fact. >From what I could gather, vscode-icons [1] are actually CC-BY, but used without proper attribution in this package. As for why they're unused, I mostly forgot to whitelist them. Cheers [1] https://github.com/microsoft/vscode-icons From unknown Sun Aug 17 22:09:14 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jelle Licht Subject: bug#61497: closed (Re: emacs-lsp-treemacs unused leftover icons in sources) Message-ID: References: <87leka0xw2.fsf@fsfe.org> <87v8k55a34.fsf@fsfe.org> X-Gnu-PR-Message: they-closed 61497 X-Gnu-PR-Package: guix Reply-To: 61497@debbugs.gnu.org Date: Mon, 06 Mar 2023 14:16:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1678112161-27867-1" This is a multi-part message in MIME format... ------------=_1678112161-27867-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61497: emacs-lsp-treemacs unused leftover icons in sources which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61497@debbugs.gnu.org. --=20 61497: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61497 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1678112161-27867-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61497-done) by debbugs.gnu.org; 6 Mar 2023 14:15:32 +0000 Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZBci-0007Eo-Gd for submit@debbugs.gnu.org; Mon, 06 Mar 2023 09:15:32 -0500 Received: from mail1.fsfe.org ([217.69.89.151]:38462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZBcg-0007Eg-P3 for 61497-done@debbugs.gnu.org; Mon, 06 Mar 2023 09:15:31 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1678112129; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gqJ3dabP2BzXov4MGbCTwp4+qf0vD9syVU35pEbB6ds=; b=TdCuvWr1Fk8sDvACuWElTvOT2lU7Xb+gpnaOumeZdMTD/va3/woSwq4q1anVECtQAHSHu/ FnQjJzQJA5XwSVt+4FDDmJUxn3qjn/bq4tz/jIs654xpuMWEQ3i32HsZln1xlQpjjO0Dgu iTJvbNTSvlQ6lw8UzdtL+aTPk/WNkT0= To: Liliana Marie Prikler , 61497-done@debbugs.gnu.org Subject: Re: emacs-lsp-treemacs unused leftover icons in sources In-Reply-To: <3c5bf58df07650ebeaf0c9411c0a23a548904e24.camel@gmail.com> References: <87v8k55a34.fsf@fsfe.org> <3c5bf58df07650ebeaf0c9411c0a23a548904e24.camel@gmail.com> Date: Mon, 06 Mar 2023 15:15:09 +0100 Message-ID: <87leka0xw2.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61497-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Liliana Marie Prikler writes: > Am Dienstag, dem 14.02.2023 um 02:06 +0100 schrieb Jelle Licht: >> Commit e0d2ec418bb on master removed icons that are unclearly >> licensed >> from the sources of emacs-lsp-treemacs. Quoted here:=20 >>=20 >> --8<---------------cut here---------------start------------->8--- >> gnu: emacs-lsp-treemacs: Remove unclearly licensed icons. >>=20 >> emacs-lsp-treemacs bundles icons with unclear licenses. >> See also . >> --8<---------------cut here---------------end--------------->8--- >>=20 >> Some icons are still left in the sources, in the 'icons/vscode' >> directory' of the source tarball one builds by running `guix build >> --source emacs-lsp-treemacs'. I have never used vscode, and am >> unfamiliar with the licensing situation of it and its related icons. >>=20 >> In case these icons are also unclearly licensed, I propose we follow >> the same strategy as done earlier by Liliana, and remove the vscode >> icons entirely.=C2=A0 If the icons are actually licensed under an >> unproblematic license, it would be nice if they were installed when >> running `guix install emacs-lsp-treemacs', and the license property >> of the package updated to reflect this fact. > From what I could gather, vscode-icons [1] are actually CC-BY, but used > without proper attribution in this package. As for why they're unused, > I mostly forgot to whitelist them. > > Cheers > > [1] https://github.com/microsoft/vscode-icons Fixed + pushed to master in #61649 / 3f222cd5ad, closing this issue. - Jelle ------------=_1678112161-27867-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Feb 2023 01:07:06 +0000 Received: from localhost ([127.0.0.1]:52015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRjmk-0006DW-6o for submit@debbugs.gnu.org; Mon, 13 Feb 2023 20:07:06 -0500 Received: from lists.gnu.org ([209.51.188.17]:48402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRjmh-0006DG-Id for submit@debbugs.gnu.org; Mon, 13 Feb 2023 20:07:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRjmh-0007MQ-7L for bug-guix@gnu.org; Mon, 13 Feb 2023 20:07:03 -0500 Received: from mail1.fsfe.org ([217.69.89.151]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRjme-0001gX-Rk for bug-guix@gnu.org; Mon, 13 Feb 2023 20:07:02 -0500 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1676336816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=Bny+Ixg7Ia8tYYGeixtR9pbraetSl9irNLaMlYx9kzs=; b=BqYee3jbbupCVfBoUbC9nb5LtxXYWh94SJZxwLjvKmDby7ECFzBr13CVViLr0mf2oU0yGs SV1Ctv7zGtKLtFJHpmDiM9oJdd0uOzX4a2g8z30ZqBTGcVjDIb1IGqHbvjarZzHsBeAp8v Rj88p9YCtptlbW4V18VdmVM0z/EDcnc= To: bug-guix@gnu.org Subject: emacs-lsp-treemacs unused leftover icons in sources Date: Tue, 14 Feb 2023 02:06:55 +0100 Message-ID: <87v8k55a34.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.69.89.151; envelope-from=jlicht@fsfe.org; helo=mail1.fsfe.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Commit e0d2ec418bb on master removed icons that are unclearly licensed from the sources of emacs-lsp-treemacs. Quoted here: --8<---------------cut here---------------start------------->8--- gnu: emacs-lsp-treemacs: Remove unclearly licensed icons. emacs-lsp-treemacs bundles icons with unclear licenses. See also . --8<---------------cut here---------------end--------------->8--- Some icons are still left in the sources, in the 'icons/vscode' directory' of the source tarball one builds by running `guix build --source emacs-lsp-treemacs'. I have never used vscode, and am unfamiliar with the licensing situation of it and its related icons. In case these icons are also unclearly licensed, I propose we follow the same strategy as done earlier by Liliana, and remove the vscode icons entirely. If the icons are actually licensed under an unproblematic license, it would be nice if they were installed when running `guix install emacs-lsp-treemacs', and the license property of the package updated to reflect this fact. Thanks for any insight, - Jelle ------------=_1678112161-27867-1--