GNU bug report logs - #61489
[PATCH 1/1] Increase BLOCK_ALIGN from 2¹⁰to 2¹⁵

Previous Next

Package: emacs;

Reported by: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>

Date: Mon, 13 Feb 2023 20:01:02 UTC

Severity: normal

Tags: patch

Merged with 61490

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #11 received at 61489 <at> debbugs.gnu.org (full text, mbox):

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
Cc: 61489 <at> debbugs.gnu.org
Subject: Re: bug#61489: [PATCH 1/1] Increase BLOCK_ALIGN from
 2¹⁰to 2¹⁵
Date: Mon, 13 Feb 2023 22:30:27 +0000
Konstantin Kharlamov <Hi-Angel <at> yandex.ru> writes:

> While testing this change on Archlinux system with Intel i5-7200U CPU,
> average time of garbage collection gets reduced by ≈25%. While
> monitoring PSS of emacs with and without customizations loaded before
> and after the patch, no statistically significant differences were
> discovered. So overall, this change is a win.

In GNU Emacs 30.0.50 (build 9, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.17.6) of 2023-02-14 built on localhost
Repository revision: 51320630cfbc452326e1d0d7b8a313f682129ec1
Repository branch: kk/bug-61489-increase-block
Windowing system distributor 'The X.Org Foundation', version 11.0.12101006
System Description: Gentoo Linux

Linux localhost 6.1.9-gentoo-x86_64 #1 SMP PREEMPT_DYNAMIC Mon Feb 13
14:05:49 +03 2023 x86_64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
GenuineIntel GNU/Linux

Running the benchmark from the blog post:
- without the patch: 0.600450
- with the patch:    0.321723 (~50% improvement)

I also changed gc-cons-threshold to 250,000,000 and gc-cons-percentage
to 0.0001. The results are nearly the same.

Running
(1) gc-cons-threshold <- most-positive-fixnum;
(2) org-element-parse-buffer on huge Org file (22Mb)
(3) garbage-collect:
- with the patch:    1.2494823932647705
- without the patch: 1.1721010208129883 (~6% improvement)

Memory consumption nearly unchanged.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>




This bug report was last modified 2 years and 175 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.