From unknown Fri Aug 22 01:03:59 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61478 <61478@debbugs.gnu.org> To: bug#61478 <61478@debbugs.gnu.org> Subject: Status: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` Reply-To: bug#61478 <61478@debbugs.gnu.org> Date: Fri, 22 Aug 2025 08:03:59 +0000 retitle 61478 28.2; eglot keeps sending `didSave` notifications despite the= active server not supporting `textDocumentSync` reassign 61478 emacs submitter 61478 ~kby severity 61478 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 09:53:17 2023 Received: (at submit) by debbugs.gnu.org; 13 Feb 2023 14:53:17 +0000 Received: from localhost ([127.0.0.1]:48085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRaCi-00065s-C7 for submit@debbugs.gnu.org; Mon, 13 Feb 2023 09:53:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:57056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRaCN-00064w-3n for submit@debbugs.gnu.org; Mon, 13 Feb 2023 09:52:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRaCM-0006D1-UH for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 09:52:54 -0500 Received: from tilde.team ([2607:5300:60:4f58::248]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRaCL-0007hv-6v for bug-gnu-emacs@gnu.org; Mon, 13 Feb 2023 09:52:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.team; s=mail; t=1676299971; bh=jgscNYr+ge+37AcRcCbwq7iJ7uR+AygKXYgYElUotRE=; h=Date:To:From:Subject:From; b=Hu9MGLNel94WAqcmgFJUS14gjgHjGZetegPb/ZC79ICj6pp02fwqDIC8tUbIAw+mb nE2R6K0N5etl0DP+U47dvhtKEyAgaZ43K2kSXoMmrhA/teCq8wzAD+OxhQXH5vEInd /HYCrSwoA8W1jdRkYVqx9SVo6B9Dv5/h9FJ4NBmM= Received: from [IPV6:2001:7c7:20e8:7d:3af2:c68c:cf92:6e31] (unknown [IPv6:2001:7c7:20e8:7d:3af2:c68c:cf92:6e31]) by tilde.team (Postfix) with ESMTPSA id EE2AD4C02E1 for ; Mon, 13 Feb 2023 14:52:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------RVsN7AJzjW2HtvFq2iuAEoJl" Message-ID: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> Date: Mon, 13 Feb 2023 15:52:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-GB, de-DE To: bug-gnu-emacs@gnu.org From: ~kby Subject: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` Received-SPF: pass client-ip=2607:5300:60:4f58::248; envelope-from=kby@tilde.team; helo=tilde.team X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 13 Feb 2023 09:53:15 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This is a multi-part message in MIME format. --------------RVsN7AJzjW2HtvFq2iuAEoJl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I've come across this bug whilst using the Dart language server, which is included in the Dart SDK. Steps to reproduce bug: - Create example Dart project using Flutter: `flutter create hello_world` - Open `hello_world/lib/main.dart` in Emacs - Start eglot with `M-x eglot RET` - Make a rudimentary change in the file; ex. add a line break - Save with `C-x C-s` - Following text appears in the minibuffer area: `[eglot] Server reports (type=1): Unknown method textDocument/didSave` Related bug reports (on GitHub): https://github.com/dart-lang/sdk/issues/36464 and https://github.com/microsoft/language-server-protocol/issues/288 I am using eglot 1.11 (from ELPA) with Emacs 28.2 on Arch. Thanks in advance. || --------------RVsN7AJzjW2HtvFq2iuAEoJl Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

I've come across this bug whilst using the Dart language server, which is included in the Dart SDK.

Steps to reproduce bug:

- Create example Dart project using Flutter: `flutter create hello_world`

- Open `hello_world/lib/main.dart` in Emacs

- Start eglot with `M-x eglot RET`

- Make a rudimentary change in the file; ex. add a line break

- Save with `C-x C-s`

- Following text appears in the minibuffer area: `[eglot] Server reports (type=1): Unknown method textDocument/didSave`

Related bug reports (on GitHub): https://github.com/dart-lang/sdk/issues/36464 and https://github.com/microsoft/language-server-protocol/issues/288

I am using eglot 1.11 (from ELPA) with Emacs 28.2 on Arch.

Thanks in advance.

--------------RVsN7AJzjW2HtvFq2iuAEoJl-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 13:30:59 2023 Received: (at 61478) by debbugs.gnu.org; 13 Feb 2023 18:30:59 +0000 Received: from localhost ([127.0.0.1]:51550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRdbP-0003DB-6q for submit@debbugs.gnu.org; Mon, 13 Feb 2023 13:30:59 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:53862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRdbM-0003Cx-W6 for 61478@debbugs.gnu.org; Mon, 13 Feb 2023 13:30:57 -0500 Received: by mail-wm1-f45.google.com with SMTP id he5so1509290wmb.3 for <61478@debbugs.gnu.org>; Mon, 13 Feb 2023 10:30:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9RlO8keaQXSnsu9Tk4Mixv4Acnzh03zXAKQ7+Fa9E0o=; b=JAqTInj+BaQ/QTuKy8W+1/x7550MW6wxwc3YSQ+RFkR5vAZzVYK5y0Zp2scawDzNCK fGiEWNwt9BA4sBvQZ9nA4J316No2Tv00Wcp6WQfnm1tw8goxep1VdBfAhEAGDj+ZGrFv vSYJHIfgPwyr/GpKtEFmsBKwSG4SaKOL7Ij5ZqZlMKLpRd8OdfdcAXZe2H+0a+RgXSQJ JfLv8/WHL5yuG+1Rx/FstQFpW2szo5+6JIHO897zQbPopnDk3OAKcTbcGX23BSd773Lt FSZEzAbBZKra0goWYb4z9Zot1xddq2mWyDQ4mTtjtkpzE7Sen8aETGbFM8KcxdbQSB99 9HJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9RlO8keaQXSnsu9Tk4Mixv4Acnzh03zXAKQ7+Fa9E0o=; b=TeYvlel4Z3Nj1jyOMBx2uxIFU2a2MjYcUCifwshUBLcze4zokdv/wL8m67qzWpoF2M xgkN/+q7LO2A4b7gETNWx5zbSWgjBL4WDQGAKUOIqxmg0rJfPmXHZMfsV2VBoh7951st OfExR23SEyoQxhnGHa3P5atIF+JlE0bVBMUkTV+o9CNmo1xb8BhkMw4YLor/q1KD+X7Q Kne/kNqPUAlTWIs9AE2ijCk+4a0Jh5OqqRW+ixVV/i8f5JaQeQVhEP07OMyz7R5/OUMk SX0AOfp/GWrLkP37abwXQbZnZCTtmeYb35QZxKB5F/wiLj7wVZU6oc4cg4TlXSXOPDVp Bo/Q== X-Gm-Message-State: AO0yUKVcviGkxBupWMMZedWyrC9Ai/cReFe6YF5epw/w2bX83vjz7fg/ HK+muZsM0EnpO4iBXX8PrTI= X-Google-Smtp-Source: AK7set/d96x0LXFNbyjJX3+fOl2rMeQeQ/EuKwioZ9wuITU3a3qmLwOvBwiBZ8rO5fh5srjEkkoFrg== X-Received: by 2002:a1c:7417:0:b0:3dd:62fe:9914 with SMTP id p23-20020a1c7417000000b003dd62fe9914mr19879973wmc.18.1676313050087; Mon, 13 Feb 2023 10:30:50 -0800 (PST) Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id a1-20020a05600c348100b003db0ee277b2sm18140143wmq.5.2023.02.13.10.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 10:30:49 -0800 (PST) From: Felician Nemeth To: 61478@debbugs.gnu.org Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> Date: Mon, 13 Feb 2023 19:30:48 +0100 In-Reply-To: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> (bug-gnu-emacs@gnu.org's message of "Mon, 13 Feb 2023 15:52:47 +0100") Message-ID: <873579l8o7.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61478 Cc: ~kby , =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > - Following text appears in the minibuffer area: `[eglot] Server > reports (type=1): Unknown method textDocument/didSave` Without actually looking into the details, this feels similar to an earlier issue, which I unfortunately closed: https://github.com/joaotavora/eglot/issues/360 The commit referenced in #360 only fixed the willSave part. I guess the solution to this bug report should be probably similar to that fix: Eglot should check (eglot--server-capable :textDocumentSync :save) before sending a textDocument/didSave. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 13:45:05 2023 Received: (at 61478) by debbugs.gnu.org; 13 Feb 2023 18:45:05 +0000 Received: from localhost ([127.0.0.1]:51556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRdp3-0003Z4-Is for submit@debbugs.gnu.org; Mon, 13 Feb 2023 13:45:05 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:45918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRdp1-0003YH-R4 for 61478@debbugs.gnu.org; Mon, 13 Feb 2023 13:45:04 -0500 Received: by mail-oi1-f176.google.com with SMTP id cz14so11010803oib.12 for <61478@debbugs.gnu.org>; Mon, 13 Feb 2023 10:45:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=sEcEGIuuJIVYbRQb5lOuUhdH45y47wGixqYWPVRCwF8=; b=YtoHpNBYTsd1QFm14DTG2btL8MP5YVY2aSbZUa2YcVHkaItxC/bR6b7tsHirGzqfTw awVAJHxtFITVNrdY7RoyFpw5pHirWQth6jbx40OEOpJHogXj9Q1qo/SyWX071cvGMGCo A+ie3JKHqgBF5fUQhYvjJTGL2r09NZNAJRPrvz/gmpoF8yRViS0EKyYyyzkzn4Lis5bQ RDwVLY4Z2nhaU8gXVcbI/zPcN8+CRA4vVKvVz3BYG4mHuDSh2hvk7K90uLT0X9zc//nF e3TekMWJVrHI6NTDI+jGw8Twmg/iV+ZJlKCcIGb5VR71Gg4BLRSQYt5XijXNGX06srds gzHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sEcEGIuuJIVYbRQb5lOuUhdH45y47wGixqYWPVRCwF8=; b=pMwcebyCAnnsNrdBWkvn9s+OfEDhOEPGKnZkJXWlC8ik5A7zntj3QWwL3or3eoaqtI 1z535Nlsqm+nUak9KcngpERO3lWvg3YBPb1SdTtO5jJ+juHlNZ7q8pgXS6dOQyeZ1pCk sJeeg2oIFKt6n/iHsJpPZ7UFZ5MyGe+hMzoRzfTkgylrpbKDgomHmWeaSPYhAUw/oXjN vgb6Fge2yl3CEhh+f8Nh8VYYeF2I0QLiffBx/yvzmCMRkp2c5WnOapHJZSfI76y2BMDi KfMSsCQPw3uKStj1/4/RWXYf/syuH35x7tzUF0gfsnzoC3M7shlI48rYpnQVzLGO4bKi WgDw== X-Gm-Message-State: AO0yUKUGYfmd4jpuv/5slVI92y1A/GWUJZeZSuS02tudOdhMuwsUz4Ac PMrxX0d++YUp1vS4p0B+6ngRz/MH8YcEwe8pKSo= X-Google-Smtp-Source: AK7set8A1fMSP08fZmatINRl9+gt/lrbqngRLVnBtIL1OLLSYbfYakqusS7zKSPLkv8FEc6rJbSDnZr8vXpXLebPO3Q= X-Received: by 2002:a05:6808:18aa:b0:369:e573:3e54 with SMTP id bi42-20020a05680818aa00b00369e5733e54mr1866855oib.215.1676313897656; Mon, 13 Feb 2023 10:44:57 -0800 (PST) MIME-Version: 1.0 References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> In-Reply-To: <873579l8o7.fsf@betli.tmit.bme.hu> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Mon, 13 Feb 2023 18:44:47 +0000 Message-ID: Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` To: Felician Nemeth Content-Type: multipart/alternative; boundary="00000000000066e7e305f4993ee1" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61478 Cc: ~kby , 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000066e7e305f4993ee1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yep, Felician, that is exactly it. Should be a straightforward patch. I'll do it, if noone beats me to it. Jo=C3=A3o On Mon, Feb 13, 2023, 18:30 Felician Nemeth wrote: > > - Following text appears in the minibuffer area: `[eglot] Server > > reports (type=3D1): Unknown method textDocument/didSave` > > Without actually looking into the details, this feels similar to an > earlier issue, which I unfortunately closed: > https://github.com/joaotavora/eglot/issues/360 > > The commit referenced in #360 only fixed the willSave part. I guess the > solution to this bug report should be probably similar to that fix: > Eglot should check (eglot--server-capable :textDocumentSync :save) > before sending a textDocument/didSave. > --00000000000066e7e305f4993ee1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yep, Felician, that is exactly it. Should be a straightfo= rward patch. I'll do it, if noone beats me to it.

=
Jo=C3=A3o

On Mon, Feb 13, 2023, 18:30 Felician= Nemeth <felician.nemeth@gm= ail.com> wrote:
> - Follo= wing text appears in the minibuffer area: `[eglot] Server
>=C2=A0 =C2=A0reports (type=3D1): Unknown method textDocument/didSave`
Without actually looking into the details, this feels similar to an
earlier issue, which I unfortunately closed:
https://github.com/joaotavora/eglot/issues/= 360

The commit referenced in #360 only fixed the willSave part.=C2=A0 I guess t= he
solution to this bug report should be probably similar to that fix:
Eglot should check (eglot--server-capable :textDocumentSync :save)
before sending a textDocument/didSave.
--00000000000066e7e305f4993ee1-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 18:48:45 2023 Received: (at 61478) by debbugs.gnu.org; 13 Feb 2023 23:48:45 +0000 Received: from localhost ([127.0.0.1]:51985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRiYv-0004Cf-Bx for submit@debbugs.gnu.org; Mon, 13 Feb 2023 18:48:45 -0500 Received: from mail-wm1-f46.google.com ([209.85.128.46]:45878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRiYt-0004CP-0L for 61478@debbugs.gnu.org; Mon, 13 Feb 2023 18:48:43 -0500 Received: by mail-wm1-f46.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso10289876wms.4 for <61478@debbugs.gnu.org>; Mon, 13 Feb 2023 15:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X7Uf3av4KQlIz5JAEequ8Jpcu3dPE27GB/PxPNhE9SM=; b=WiR0aJEfYg5b6DKT0sOzglyBt/rH+jQzkzm5JlNHQxmbq7Z5vKCU1CssQCiPe2/ViJ IrHABHWv1xoLtDlRerl6kUKz9kxoRX+zkfm7kIBXWG3kDOhBNVqKtp0670vO2S7ZXjZ8 CmL3AVXsk6Wnwra4rRnuwWySe9IjUCQXpYdXwHCMOVE9RyFqZWqBAHPbpt+WdV2NMBmI hq/PISnfZxTC9kdk3r39uB4gO0yTiUQIOQXO3AOS05PQWts6g/xXfCB2vkzbdQB98Kva nIoILY0qCvwxEeJxGEnQutv/04GJu7tqbaVZddIN4HU9IHK7xQ/j8cXX2OT8emVdzzBu 0B/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X7Uf3av4KQlIz5JAEequ8Jpcu3dPE27GB/PxPNhE9SM=; b=a0eJHIN/atfBv3xeLryh56xmDxQskbAx3ld8y9XqNwoeFL5Yg7Lr2drl9jQ4SYbvLg 5I9eWhiNCo6edj3qAFR/NnaIhGl33HbZpKpSNZzjf0H84+w7jV3vxOWX4xvJlTwQze+y pCm/0XakdkHn7MiO3XuPWQgwUOvLoWID8ibP0QRQ+2utYJN2JWtJwMDIUIXarFa6/Vzg t9mB/8EgJUqCn67nIB/fpWXofyTEKFW3XKwviCBthUfLu15d+mzV4PUInELAjlE1gyZZ KpT9BZcgV1f5X5broTaEqQzZCye4B3833lTHmHPS/W6sdx8dBJyzsK4XvAbsgVGsLftO rk8Q== X-Gm-Message-State: AO0yUKUK8KKnt2Wy5U3knOocgUw/WQvK0t5DjTve0mrlrmHzAEeiF1Cb EHpCs8v868gFkJzC64QTg/g= X-Google-Smtp-Source: AK7set+sz263CkekpjH476dmDr7bfofQEsai8VLM2YuYzCbFrZ2lp/mun1wK40/lqERWNSLMY0jhpA== X-Received: by 2002:a05:600c:a293:b0:3df:ee64:4814 with SMTP id hu19-20020a05600ca29300b003dfee644814mr384092wmb.20.1676332116995; Mon, 13 Feb 2023 15:48:36 -0800 (PST) Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id l9-20020a05600c4f0900b003db1ca20170sm16512163wmq.37.2023.02.13.15.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 15:48:36 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: ~kby Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` In-Reply-To: <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> (kby@tilde.team's message of "Mon, 13 Feb 2023 20:00:37 +0100") References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> Date: Mon, 13 Feb 2023 23:50:25 +0000 Message-ID: <87v8k5t9a6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61478 Cc: eliz@gnu.org, Felician Nemeth , 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ~kby writes: > This should suffice, no? Yes, that should be the correct patch.=20=20 Eli, this is a one-line/trivial change. Do we need (rather than prefer) copyright assignment for this one to go in and close the bug? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 03:16:47 2023 Received: (at 61478) by debbugs.gnu.org; 14 Feb 2023 08:16:47 +0000 Received: from localhost ([127.0.0.1]:52442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRqUZ-0006FT-5Z for submit@debbugs.gnu.org; Tue, 14 Feb 2023 03:16:47 -0500 Received: from tilde.team ([198.50.210.248]:60700 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRe4A-00048f-Qc for 61478@debbugs.gnu.org; Mon, 13 Feb 2023 14:00:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.team; s=mail; t=1676314841; bh=57DmKPY2ABOvpKXAjAvjYip5u+vdRcdJLYD2UEV/TgE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hC7Rg2Q96atVPBRaOZxaet9lkQJl/cbm9zqLVwYZNtf0FEUUom1PttznWnydd5Isa QgQMfU34NAPRKgmEB8DanDXiUOsk7YgmEWmRqUCUPh6uc9e2X6EwHW/mYKnjl4m5K6 ZuEytZfRUt4N81gQX5/TeM9EhZZXf1btvp5EkEy8= Received: from [IPV6:2001:7c7:20e8:7d:3af2:c68c:cf92:6e31] (unknown [IPv6:2001:7c7:20e8:7d:3af2:c68c:cf92:6e31]) by tilde.team (Postfix) with ESMTPSA id 4E9814C0585; Mon, 13 Feb 2023 19:00:41 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------S7kUM0tr9FRHkBgFK40Q9sFI" Message-ID: <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> Date: Mon, 13 Feb 2023 20:00:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` Content-Language: en-GB, de-DE To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Felician Nemeth References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> From: ~kby In-Reply-To: X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 61478 X-Mailman-Approved-At: Tue, 14 Feb 2023 03:16:46 -0500 Cc: 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------S7kUM0tr9FRHkBgFK40Q9sFI Content-Type: multipart/alternative; boundary="------------Yak4jxrTdWHn3FytzkWAn48E" --------------Yak4jxrTdWHn3FytzkWAn48E Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit This should suffice, no? On 13.02.23 19:44, João Távora wrote: > Yep, Felician, that is exactly it. Should be a straightforward patch. > I'll do it, if noone beats me to it. > > João > > On Mon, Feb 13, 2023, 18:30 Felician Nemeth > wrote: > > > - Following text appears in the minibuffer area: `[eglot] Server > >   reports (type=1): Unknown method textDocument/didSave` > > Without actually looking into the details, this feels similar to an > earlier issue, which I unfortunately closed: > https://github.com/joaotavora/eglot/issues/360 > > The commit referenced in #360 only fixed the willSave part.  I > guess the > solution to this bug report should be probably similar to that fix: > Eglot should check (eglot--server-capable :textDocumentSync :save) > before sending a textDocument/didSave. > --------------Yak4jxrTdWHn3FytzkWAn48E Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

This should suffice, no?

On 13.02.23 19:44, João Távora wrote:
Yep, Felician, that is exactly it. Should be a straightforward patch. I'll do it, if noone beats me to it.

João

On Mon, Feb 13, 2023, 18:30 Felician Nemeth <felician.nemeth@gmail.com> wrote:
> - Following text appears in the minibuffer area: `[eglot] Server
>   reports (type=1): Unknown method textDocument/didSave`

Without actually looking into the details, this feels similar to an
earlier issue, which I unfortunately closed:
https://github.com/joaotavora/eglot/issues/360

The commit referenced in #360 only fixed the willSave part.  I guess the
solution to this bug report should be probably similar to that fix:
Eglot should check (eglot--server-capable :textDocumentSync :save)
before sending a textDocument/didSave.
--------------Yak4jxrTdWHn3FytzkWAn48E-- --------------S7kUM0tr9FRHkBgFK40Q9sFI Content-Type: text/x-patch; charset=UTF-8; name="didSave.patch" Content-Disposition: attachment; filename="didSave.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsIGIvbGlzcC9wcm9nbW9kZXMv ZWdsb3QuZWwKaW5kZXggOGVjZGVmZDQ5MGQuLjI2N2E3YTVlYTIzIDEwMDY0NAotLS0gYS9s aXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbApA QCAtMjQ5NiwxMyArMjQ5NiwxNCBAQCBXaGVuIGNhbGxlZCBpbnRlcmFjdGl2ZWx5LCB1c2Ug dGhlIGN1cnJlbnRseSBhY3RpdmUgc2VydmVyIgogKGRlZnVuIGVnbG90LS1zaWduYWwtdGV4 dERvY3VtZW50L2RpZFNhdmUgKCkKICAgIlNlbmQgdGV4dERvY3VtZW50L2RpZFNhdmUgdG8g c2VydmVyLiIKICAgKGVnbG90LS1zaWduYWwtdGV4dERvY3VtZW50L2RpZENoYW5nZSkKLSAg KGpzb25ycGMtbm90aWZ5Ci0gICAoZWdsb3QtLWN1cnJlbnQtc2VydmVyLW9yLWxvc2UpCi0g ICA6dGV4dERvY3VtZW50L2RpZFNhdmUKLSAgIChsaXN0Ci0gICAgOzsgVE9ETzogSGFuZGxl IFRleHREb2N1bWVudFNhdmVSZWdpc3RyYXRpb25PcHRpb25zIHRvIGNvbnRyb2wgdGhpcy4K LSAgICA6dGV4dCAoYnVmZmVyLXN1YnN0cmluZy1uby1wcm9wZXJ0aWVzIChwb2ludC1taW4p IChwb2ludC1tYXgpKQotICAgIDp0ZXh0RG9jdW1lbnQgKGVnbG90LS1UZXh0RG9jdW1lbnRJ ZGVudGlmaWVyKSkpKQorICAod2hlbiAoZWdsb3QtLXNlcnZlci1jYXBhYmxlIDp0ZXh0RG9j dW1lbnRTeW5jIDpzYXZlKQorICAgIChqc29ucnBjLW5vdGlmeQorICAgICAoZWdsb3QtLWN1 cnJlbnQtc2VydmVyLW9yLWxvc2UpCisgICAgIDp0ZXh0RG9jdW1lbnQvZGlkU2F2ZQorICAg ICAobGlzdAorICAgICAgOzsgVE9ETzogSGFuZGxlIFRleHREb2N1bWVudFNhdmVSZWdpc3Ry YXRpb25PcHRpb25zIHRvIGNvbnRyb2wgdGhpcy4KKyAgICAgIDp0ZXh0IChidWZmZXItc3Vi c3RyaW5nLW5vLXByb3BlcnRpZXMgKHBvaW50LW1pbikgKHBvaW50LW1heCkpCisgICAgICA6 dGV4dERvY3VtZW50IChlZ2xvdC0tVGV4dERvY3VtZW50SWRlbnRpZmllcikpKSkpCiAKIChk ZWZ1biBlZ2xvdC1mbHltYWtlLWJhY2tlbmQgKHJlcG9ydC1mbiAmcmVzdCBfbW9yZSkKICAg IkEgRmx5bWFrZSBiYWNrZW5kIGZvciBFZ2xvdC4K --------------S7kUM0tr9FRHkBgFK40Q9sFI-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 07:02:20 2023 Received: (at 61478) by debbugs.gnu.org; 14 Feb 2023 12:02:21 +0000 Received: from localhost ([127.0.0.1]:52762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRu0q-0004Gk-LH for submit@debbugs.gnu.org; Tue, 14 Feb 2023 07:02:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRu0o-0004GT-Q0 for 61478@debbugs.gnu.org; Tue, 14 Feb 2023 07:02:19 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRu0P-00063V-K3; Tue, 14 Feb 2023 07:01:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=c4vwH2OnPWPRaUaZZKIgGMoBy5GfI7NTl+N2GG3XY5w=; b=XLajE1pwPGyuzgvHazrP h8OeQoX6XkqRa6yyu3yQwgzjVP1fUvSL9l/bN1I5HjDqalX0As6ZZnKVB2Gwaa3tmv4vifek6lo2e pZDlB2DtJUzAd8OFjkMW6bQ8Rb+I6H8pyGJKr8Z/idG/77Tqu+urBxSSqaNRq1wO8+tiaiDRhYef9 wFWFM+y0y1Z9/6EzMIVBWszPUPbV5/pZ6bW6L4gAtygMi8wRtB/UI6GrpiRBZ29yARqnBLNCTc2VR /Itrw6PbtpZEcEBI/7xkpawTT/v3/8GJnoc5LMEqW94sw9a3DCqKOaLsIhUazPipxi4/a5XlxhkRO M0YdVhC9bKNP7Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRu0L-0000mP-M7; Tue, 14 Feb 2023 07:01:51 -0500 Date: Tue, 14 Feb 2023 14:01:27 +0200 Message-Id: <83h6voe9rc.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: <87v8k5t9a6.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Mon, 13 Feb 2023 23:50:25 +0000) Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> <87v8k5t9a6.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61478 Cc: felician.nemeth@gmail.com, kby@tilde.team, 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: Felician Nemeth , 61478@debbugs.gnu.org, > eliz@gnu.org > Date: Mon, 13 Feb 2023 23:50:25 +0000 > > ~kby writes: > > > This should suffice, no? > > Yes, that should be the correct patch. > > Eli, this is a one-line/trivial change. Do we need (rather than prefer) > copyright assignment for this one to go in and close the bug? ENOPATCH Probably no need for copyright assignment, but I need to see the changes. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 07:57:55 2023 Received: (at 61478) by debbugs.gnu.org; 14 Feb 2023 12:57:55 +0000 Received: from localhost ([127.0.0.1]:52833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRusc-0008EX-MY for submit@debbugs.gnu.org; Tue, 14 Feb 2023 07:57:55 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:34786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRusa-0008EI-M7 for 61478@debbugs.gnu.org; Tue, 14 Feb 2023 07:57:53 -0500 Received: by mail-oi1-f176.google.com with SMTP id t5so12903970oiw.1 for <61478@debbugs.gnu.org>; Tue, 14 Feb 2023 04:57:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9RE+oAnsUSBlHebbdv2WYGRD1p8NSs2OMu5x+Eu0PsE=; b=izn9yxfS3oeJ+FVKxwzhjY/vqKZXqbx3zRHGfPUOBrkWtebVDuY9YrdupD5qGpODdL SAxoebd2XyiVZi7Q+ijPeXigxq4ZUbOBDv2qpM/3tk0cUXxIi+nFzqECKzDEfZnXQ8cC VTn0RcVhZ5VD9Rf5XU+u502lg9N0P7a1GBIJTOTDj3M0UPZVdZtDB+WCP36+FdB2Bjm7 MxeEpCA5ee5XYM51MImN+hLZL2W3xukT/QpvCHWCQki3AiLfVHzj8GSvW6X+Q7DLUgkX sYsH+c45bEgvRb0WH7IAPhRKFsuyD2oqKiOStvtLZ9RwTYb1J/u50ufX+cdPCIyiZxgk kcDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9RE+oAnsUSBlHebbdv2WYGRD1p8NSs2OMu5x+Eu0PsE=; b=gPL+bzpJ6BYo1s5kyhzEtG7sGtM0QX1U6GCTn041l9SpzdjFVbJ8gOGX6P8m2BWdJV M/0FgaACPwd+WG52IF4sApVkB5zhGLp3PhUiFw8hR9R0FhpfjNjFa0eU0OTel3zN299L iwWuUwEhYU+5/YNQef0ARINSaJd/++y032R43+iOxNUy10DIPDuPrjUjKprF3+tfRvyy al234WbwGy5KIbY/sZIFXdT+8IeCg1goLvDs+gya7sBMjCzroZhQjRhcm+tQorQXKSQE 9Sf5fJ+BJne8WWPjVuvWQCceyMlfjIVLHZCEV3Xew6LrY//+TTUXuYW3OuIXTM57Apbz rLIA== X-Gm-Message-State: AO0yUKWtNEMQNa4y59Co/cj+6UjEVKUcoeYPOjkekfbJ0gcELbgYLLTJ NY2kZ7Ncj6cFT4RME1DP0fECWknA4C6cVPpv4ac= X-Google-Smtp-Source: AK7set9qNH7tVtiK/qWEpo5PXWaATMnVOjgdN5o9GKz/50qHfq2plQXSNWrmwxWwGu6QFK51bSH6wCgixa7UcklydaY= X-Received: by 2002:a05:6808:2082:b0:36d:d60e:d7fa with SMTP id s2-20020a056808208200b0036dd60ed7famr1229440oiw.171.1676379465884; Tue, 14 Feb 2023 04:57:45 -0800 (PST) MIME-Version: 1.0 References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> <87v8k5t9a6.fsf@gmail.com> <83h6voe9rc.fsf@gnu.org> In-Reply-To: <83h6voe9rc.fsf@gnu.org> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 14 Feb 2023 12:57:35 +0000 Message-ID: Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` To: Eli Zaretskii Content-Type: multipart/alternative; boundary="00000000000092a86d05f4a882ad" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61478 Cc: Felician Nemeth , kby@tilde.team, 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000092a86d05f4a882ad Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Feb 14, 2023, 12:02 Eli Zaretskii wrote: > > From: Jo=C3=A3o T=C3=A1vora > > Cc: Felician Nemeth , 61478@debbugs.gnu.org= , > > eliz@gnu.org > > Date: Mon, 13 Feb 2023 23:50:25 +0000 > > > > ~kby writes: > > > > > This should suffice, no? > > > > Yes, that should be the correct patch. > > > > Eli, this is a one-line/trivial change. Do we need (rather than prefer= ) > > copyright assignment for this one to go in and close the bug? > > ENOPATCH > > Probably no need for copyright assignment, but I need to see the > changes. > I don't understand, i see a didSave.patch file attached to to kby's mail to this bug. That's the (trivial) patch I'm referring to. Can't you see it, Eli? Jo=C3=A3o > --00000000000092a86d05f4a882ad Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Feb 14, 2023, 12:02 Eli Zaretskii <eliz@gnu.org> wrote:
> From: Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com>= ;
> Cc: Felician Nemeth <felician.nemeth@gmail.com>,=C2= =A0 61478@debbugs.gnu.org,
>=C2=A0 =C2=A0eliz@gnu.org
> Date: Mon, 13 Feb 2023 23:50:25 +0000
>
> ~kby <kby@tilde.team> writes:
>
> > This should suffice, no?
>
> Yes, that should be the correct patch.=C2=A0
>
> Eli, this is a one-line/trivial change.=C2=A0 Do we need (rather than = prefer)
> copyright assignment for this one to go in and close the bug?

ENOPATCH

Probably no need for copyright assignment, but I need to see the
changes.

I don't understand, i see a didSave= .patch file attached to to kby's mail to this bug. That's the (triv= ial) patch I'm referring to. Can't you see it, Eli?

Jo=C3=A3o
--00000000000092a86d05f4a882ad-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 09:00:28 2023 Received: (at 61478) by debbugs.gnu.org; 14 Feb 2023 14:00:28 +0000 Received: from localhost ([127.0.0.1]:52944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRvr9-0001cB-LP for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:00:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRvr7-0001bn-49 for 61478@debbugs.gnu.org; Tue, 14 Feb 2023 09:00:26 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvr1-0000hh-Hg; Tue, 14 Feb 2023 09:00:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=XEe3ibxH1GbWH3ysqChi3BOWcehVzelZsEQ3WFqMJ7U=; b=rZjPESrbvW6d5TYvBGJO eaBXctU+YmCTW4MrKrmEcp5m1RUQk2eKTLbEJ2iIMwJcSXe8Ete9twbTT+F1pIjMjJPB0lwVvUj5H JqN6D1KFKkws2+xdbJtHmFNBkvdDD23/8x5LKm53Ha9/nF5kibWfTFi1MEwjpizSfCoi9hP8j8icF aYNOYC926cDitEM1g1f2CQWKclBm8bbHr30TKK5HGGdQ66rDK1A9K14i8Y00g/N4Hf6whBtOXcVqI eyQdntxHnY0r8Eo7ImPyINfQWuHiTP/KEdtEQoq2v/k1z5bfm/+P49hETZn3B3F6dt+qMhBGl6qx5 uG7ahD2UPgKayQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvqt-0004jM-Js; Tue, 14 Feb 2023 09:00:19 -0500 Date: Tue, 14 Feb 2023 15:59:50 +0200 Message-Id: <83wn4kcppl.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Tue, 14 Feb 2023 12:57:35 +0000) Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> <87v8k5t9a6.fsf@gmail.com> <83h6voe9rc.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61478 Cc: felician.nemeth@gmail.com, kby@tilde.team, 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Tue, 14 Feb 2023 12:57:35 +0000 > Cc: kby@tilde.team, Felician Nemeth , 61478@debbugs.gnu.org > > ENOPATCH > > Probably no need for copyright assignment, but I need to see the > changes. > > I don't understand, i see a didSave.patch file attached to to kby's mail to this bug. That's the (trivial) patch I'm > referring to. Can't you see it, Eli? You mean, the one here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61478#17 ? I received this message after receiving and answering yours. If that is the patch, it is OK, but please remember a proper commit log message, which mentions the bug number and includes the Copyright-paperwork-exempt thingy. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 09:10:44 2023 Received: (at 61478) by debbugs.gnu.org; 14 Feb 2023 14:10:44 +0000 Received: from localhost ([127.0.0.1]:52961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRw15-0001s4-MB for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:10:43 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:38893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRw13-0001rq-N2 for 61478@debbugs.gnu.org; Tue, 14 Feb 2023 09:10:42 -0500 Received: by mail-wm1-f41.google.com with SMTP id f47-20020a05600c492f00b003dc584a7b7eso13755133wmp.3 for <61478@debbugs.gnu.org>; Tue, 14 Feb 2023 06:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HT/uiQRC07huhReKAP1OR6CPiyr/+hOuJ5DCzoh6kqQ=; b=GQl3TTsLh1p52JAkNc/kmFrbRzZiq2bJQpDvDUzygd168hS2IdIAY9RToSByDEK2AX M8Z8RgNJWYvqFfnH1Ttx1IEEYSnXR3xkPuGN8eIkA9bBOcPOFpHO8/T9dI5BfD+SLU72 Ei9W91VVrKyKFBM3/0IMZ/cw7GLJtgZjLkAn0HQUjcjxX/u83NFTO1of5+yfFUSGK54t EGp693lKS1JuorNcNWQOWCyuYS2xIdA0IIxAEUiHCMsKtg9lw835YxppgGBpL4yV5/jo ix9WTrpEhey2Owd7OdKIWodPvIhs3SmnuAzf0t3qpHo+a9ttkWC907sL0QpE2g6yhUHg nQ/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HT/uiQRC07huhReKAP1OR6CPiyr/+hOuJ5DCzoh6kqQ=; b=BtIFKR2JqbPYnXfPIkvWieXTBWT2owOCsKjksfnhtmqSA4mg976g4WvPRTHsEuFEW7 1PvSsQ4CqvdjNT/xL4cNwJp2HBC521Ia2I6G+Hfej2ue/t+xUeAZ1DgOh893AJZhz3EE oX4wDjlUiQRgnv/2fgufgiWtQWQiNbVPib9EHC+A5CI0A7GOyxmfdXLxCEY6Y9LcVxbN h7i++9U9c8LCVR/VKA8usJhhAnzj9XUGN0K5+DF5LcDRtgMKWEEURjVui0wXaBxg6GJO V20HSCOW2orJss/BxboUTQfEQqCBm+dNX1oM4gseoqHlJLxOhlHU8/s528qVudQHkpxJ 2tOg== X-Gm-Message-State: AO0yUKVQTDpnSSdVa9aVzWI3VfV62mRXVux/s/w+qdOm/pNeB0NSXT7w Tuygjw1Z0uDRJB+lBrCsmkQonCPSE9w= X-Google-Smtp-Source: AK7set/VeB3ReAf3sq7PX3datwyX/9LVohCZWNCaGiC/PM78YXDCcgaNarTz01J7BMZHslQr+0FZNQ== X-Received: by 2002:a05:600c:16c6:b0:3db:1434:c51a with SMTP id l6-20020a05600c16c600b003db1434c51amr2126558wmn.40.1676383835698; Tue, 14 Feb 2023 06:10:35 -0800 (PST) Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id q1-20020a05600000c100b002c54d8b89efsm9079610wrx.26.2023.02.14.06.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 06:10:34 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Eli Zaretskii Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` In-Reply-To: <83wn4kcppl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Feb 2023 15:59:50 +0200") References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> <87v8k5t9a6.fsf@gmail.com> <83h6voe9rc.fsf@gnu.org> <83wn4kcppl.fsf@gnu.org> Date: Tue, 14 Feb 2023 14:12:23 +0000 Message-ID: <87pmactjy0.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61478 Cc: felician.nemeth@gmail.com, kby@tilde.team, 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Date: Tue, 14 Feb 2023 12:57:35 +0000 >> Cc: kby@tilde.team, Felician Nemeth , 61478@d= ebbugs.gnu.org >>=20 >> ENOPATCH >>=20 >> Probably no need for copyright assignment, but I need to see the >> changes. >>=20 >> I don't understand, i see a didSave.patch file attached to to kby's mail= to this bug. That's the (trivial) patch I'm >> referring to. Can't you see it, Eli? > > You mean, the one here: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61478#17 > > ? I received this message after receiving and answering yours. Odd, as the one you got earlier was a reply to the one you got later. An EOUTOFORDER somewhere (probably due to moderation?) > If that is the patch, it is OK, but please remember a proper commit > log message, which mentions the bug number and includes the > Copyright-paperwork-exempt thingy. Yep, I'll provide that. It's 'Copyright-paperwork-exempt: Yes' in its own line, I think. Regarding the "kby " author. Kby is there any better name? Eli, are these obscure names OK as well? Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 09:40:45 2023 Received: (at 61478) by debbugs.gnu.org; 14 Feb 2023 14:40:45 +0000 Received: from localhost ([127.0.0.1]:53022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRwU8-0002f2-TY for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:40:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRwU2-0002ei-43 for 61478@debbugs.gnu.org; Tue, 14 Feb 2023 09:40:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRwTv-0006zi-VG; Tue, 14 Feb 2023 09:40:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DCP1EGjds8LxLAqis5hNFZjAlDaK3G3ByD6OB2wObF4=; b=m71/UfgRl3t6UWYCid7M 7eX1jCQYs+RrEdJakUMj7hHUq7h2878Q/7o5oWyf3g0Uydzwe9T3nzapEjDfGQ2RX03jdjNDm8VXO lfNDwGdfS3F1HPtyaJ0jR/nBhszEVdwsI190EMUsCFNBk4ldbxRSCT0LQfdZA8m1rmbAHILt+x84A hr2D2dcJ2ViNYU77Npca5TrpTozsYFOQwm8aqRg9sn0V32nXcXQU/0Hz3IteWxP4vx0HLVycy5C/N 4cWlSduhLMT2sqZsl2E7Q9dTQd0K5wkpscNDWQ0vSFrrKeeTUM/ZFX0D39HZg6tPMYpewu59spzGD TC7gWKlRLQz3NA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRwTv-00074W-6D; Tue, 14 Feb 2023 09:40:31 -0500 Date: Tue, 14 Feb 2023 16:40:09 +0200 Message-Id: <83o7pwcnue.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: <87pmactjy0.fsf@gmail.com> (message from =?utf-8?B?Sm/Do28g?= =?utf-8?B?VMOhdm9yYQ==?= on Tue, 14 Feb 2023 14:12:23 +0000) Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> <87v8k5t9a6.fsf@gmail.com> <83h6voe9rc.fsf@gnu.org> <83wn4kcppl.fsf@gnu.org> <87pmactjy0.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61478 Cc: felician.nemeth@gmail.com, kby@tilde.team, 61478@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Cc: kby@tilde.team, felician.nemeth@gmail.com, 61478@debbugs.gnu.org > Date: Tue, 14 Feb 2023 14:12:23 +0000 > > Eli Zaretskii writes: > > > You mean, the one here: > > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61478#17 > > > > ? I received this message after receiving and answering yours. > > Odd, as the one you got earlier was a reply to the one you got later. An > EOUTOFORDER somewhere (probably due to moderation?) Order of mail delivery is not guaranteed in general. > Regarding the "kby " author. Kby is there any better > name? Eli, are these obscure names OK as well? If the authors don't want to provide a longer name, we are fine with how they call themselves. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 18:32:27 2023 Received: (at 61478-done) by debbugs.gnu.org; 14 Feb 2023 23:32:27 +0000 Received: from localhost ([127.0.0.1]:57332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pS4mh-0006Lo-Da for submit@debbugs.gnu.org; Tue, 14 Feb 2023 18:32:27 -0500 Received: from mail-wr1-f53.google.com ([209.85.221.53]:36428) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pS4mf-0006Lb-6k for 61478-done@debbugs.gnu.org; Tue, 14 Feb 2023 18:32:25 -0500 Received: by mail-wr1-f53.google.com with SMTP id o18so17423875wrj.3 for <61478-done@debbugs.gnu.org>; Tue, 14 Feb 2023 15:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gUWIcOQ6Gexdk2Dq3S8EC8PkahaihyAu7DIyuzgjGac=; b=QqQR3VsRk5Iexe6oIGKOjz2h2caGR5UDzc2zDj87jTpwrTuhI/5yRcOpFPhJisL9NT Cvm5lg1JLKAZ5GVDyIXNDSD0GbhwtChPRXBEJiVzDwHYeardtGMFOUG6Ra9fC3Yu+qwC E74+DWVDTZ4NvimFN7ne/GDGQ6Thw8hIdNLcwEuLtklFqyfQ64Ce2T7LTKctb0SSkRTB bffxHtdw2H05dUoYut3PfyO37ywMt52z/AQA1hOI6irICTnhRIqChARph+HZnGKBHLid GPIH0o2JoMVYcVMQr89jb51mNRDlYtN47H/FvuGOHR7TnhsSv+sAC4lojOrlyi1NEZMI 7fHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gUWIcOQ6Gexdk2Dq3S8EC8PkahaihyAu7DIyuzgjGac=; b=aWeityshSJ0vnp72SOpzGLB7TW7IXMW5ih2saT0nUpaIHzGpvGRoLgZQlZaOZvCpfa yT6ouaG49WYKS6Xl3POX4epIXZrwtqE+5CMblrVZIiSe6wwqyy+adG40e9khN2/HgzFL wGoy6A0n2klncr8f+znMoex8x3McjQB1EtV8a0rgZz/CyMzfsdgXb4Noy1JnaPoHkKgQ eLyp5pDtOh16Y4zaiGJhGCNRDCA0pH+gHbbVCJFItb6vs/mCGGoznxuHbfzniRNPkm8f dDOxxbmZ1zC1O9CVse6cRoRZo7qKS3HozDhsCMSoVnByyDXN8/zvmmiGNtt4/TRoBo2R Fxlw== X-Gm-Message-State: AO0yUKW8mR5MCDUKsdy28pM1kiW37va9w4wat3xwLz9zo8DPSs8x6p5C lWQV5LEed1ka68Fjx9Qf9wa+Rm5af6Q= X-Google-Smtp-Source: AK7set98jmbcY14FZT+u0mA9meo49PbYPquGgD5T13CcvvEDZXiCDw5uekniIdSiFkvMqBvDYdQUuQ== X-Received: by 2002:a5d:4612:0:b0:2c5:56f7:51f4 with SMTP id t18-20020a5d4612000000b002c556f751f4mr3857729wrq.22.1676417539033; Tue, 14 Feb 2023 15:32:19 -0800 (PST) Received: from krug (87-196-72-142.net.novis.pt. [87.196.72.142]) by smtp.gmail.com with ESMTPSA id k16-20020adfe8d0000000b002c54536c662sm12698735wrn.34.2023.02.14.15.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 15:32:18 -0800 (PST) From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= To: Eli Zaretskii Subject: Re: bug#61478: 28.2; eglot keeps sending `didSave` notifications despite the active server not supporting `textDocumentSync` In-Reply-To: <83wn4kcppl.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Feb 2023 15:59:50 +0200") References: <43958a5c-a163-d1b3-5c1c-8a5ea3c1064d@tilde.team> <873579l8o7.fsf@betli.tmit.bme.hu> <40747c6f-f899-70fa-4e94-97361e239f42@tilde.team> <87v8k5t9a6.fsf@gmail.com> <83h6voe9rc.fsf@gnu.org> <83wn4kcppl.fsf@gnu.org> Date: Tue, 14 Feb 2023 23:34:07 +0000 Message-ID: <87lekzu8i8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61478-done Cc: 61478-done@debbugs.gnu.org, felician.nemeth@gmail.com, kby@tilde.team X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Jo=C3=A3o T=C3=A1vora >> Date: Tue, 14 Feb 2023 12:57:35 +0000 >> Cc: kby@tilde.team, Felician Nemeth , 61478@d= ebbugs.gnu.org >>=20 >> ENOPATCH >>=20 >> Probably no need for copyright assignment, but I need to see the >> changes. >>=20 >> I don't understand, i see a didSave.patch file attached to to kby's mail= to this bug. That's the (trivial) patch I'm >> referring to. Can't you see it, Eli? > > You mean, the one here: > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61478#17 > > ? I received this message after receiving and answering yours. > > If that is the patch, it is OK, but please remember a proper commit > log message, which mentions the bug number and includes the > Copyright-paperwork-exempt thingy. I just committed this patch as agreed, to emacs-29. Closing. Jo=C3=A3o From unknown Fri Aug 22 01:03:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 Mar 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator