GNU bug report logs - #61477
[PATCH] gnu: python-pygraphviz: Update to 1.10

Previous Next

Package: guix-patches;

Reported by: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>

Date: Mon, 13 Feb 2023 14:35:03 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61477 in the body.
You can then email your comments to 61477 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Mon, 13 Feb 2023 14:35:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 13 Feb 2023 14:35:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
To: <guix-patches <at> gnu.org>
Cc: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
Subject: [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Mon, 13 Feb 2023 14:03:31 +0100
* gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
---
 gnu/packages/graphviz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
index 7c2cb1eae0..1691658576 100644
--- a/gnu/packages/graphviz.scm
+++ b/gnu/packages/graphviz.scm
@@ -213,7 +213,7 @@ (define-public python-graphviz
 (define-public python-pygraphviz
   (package
     (name "python-pygraphviz")
-    (version "1.7")
+    (version "1.10")
     (source
      (origin
        (method git-fetch)
@@ -223,7 +223,7 @@ (define-public python-pygraphviz
        (file-name (string-append "pygraphviz-" version "-checkout"))
        (sha256
         (base32
-         "0jqc3dzy9n0hn3b99zq8jp53901zpjzvvi5ns5mbaxg8kdrb1lfx"))))
+         "1yrzjp5n86ynlj32p5dj1aj67md6bzkk8hac74j5y3mbl94m259g"))))
     (build-system python-build-system)
     (inputs
      (list graphviz))

base-commit: 5b1eab43f011983d9ee560d6935409b6b39706ff
-- 
2.30.2




Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Wed, 15 Feb 2023 15:59:04 GMT) Full text and rfc822 format available.

Message #8 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>,
 61477 <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Cc: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Wed, 15 Feb 2023 12:50:32 +0100
Hi Philippe, Chris,

On Mon, 13 Feb 2023 at 14:03, Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at> wrote:
> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
                                                               --^
                                                            Missing dot

Missing two ending dot: one commit headline and one ChangeLog.

Well, QA says red:

    https://qa.guix.gnu.org/issue/61477

but it appears to me unrelated.  Chris, an idea?


Cheers,
simon






Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Wed, 15 Feb 2023 16:21:01 GMT) Full text and rfc822 format available.

Message #11 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
To: <61477 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Wed, 15 Feb 2023 17:19:50 +0100
> Missing two ending dot: one commit headline and one ChangeLog.
Fixed in attached revised patch (but it appears to me as a
nitpicking...).

> Well, QA says red:
I don't really understand why the QA is complaining...

Philippe.





Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Wed, 15 Feb 2023 16:23:01 GMT) Full text and rfc822 format available.

Message #14 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
To: <61477 <at> debbugs.gnu.org>
Cc: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
Subject: [PATCH] gnu: python-pygraphviz: Update to 1.10.
Date: Wed, 15 Feb 2023 17:19:51 +0100
* gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10.
---
 gnu/packages/graphviz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/graphviz.scm b/gnu/packages/graphviz.scm
index 7c2cb1eae0..1691658576 100644
--- a/gnu/packages/graphviz.scm
+++ b/gnu/packages/graphviz.scm
@@ -213,7 +213,7 @@ (define-public python-graphviz
 (define-public python-pygraphviz
   (package
     (name "python-pygraphviz")
-    (version "1.7")
+    (version "1.10")
     (source
      (origin
        (method git-fetch)
@@ -223,7 +223,7 @@ (define-public python-pygraphviz
        (file-name (string-append "pygraphviz-" version "-checkout"))
        (sha256
         (base32
-         "0jqc3dzy9n0hn3b99zq8jp53901zpjzvvi5ns5mbaxg8kdrb1lfx"))))
+         "1yrzjp5n86ynlj32p5dj1aj67md6bzkk8hac74j5y3mbl94m259g"))))
     (build-system python-build-system)
     (inputs
      (list graphviz))

base-commit: b4d2670771b8c2b9c4aedbef0371f1d23197d209
-- 
2.30.2




Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Wed, 15 Feb 2023 16:28:01 GMT) Full text and rfc822 format available.

Message #17 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 61477 <at> debbugs.gnu.org, Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Wed, 15 Feb 2023 16:24:35 +0000
[Message part 1 (text/plain, inline)]
zimoun <zimon.toutoune <at> gmail.com> writes:

> On Mon, 13 Feb 2023 at 14:03, Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at> wrote:
>> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10
>                                                                --^
>                                                             Missing dot
>
> Missing two ending dot: one commit headline and one ChangeLog.
>
> Well, QA says red:
>
>     https://qa.guix.gnu.org/issue/61477
>
> but it appears to me unrelated.  Chris, an idea?

Appears grey (unknown) to me currently, but it could have been red
previously.

I see one odd and unrelated thing here, the derivation for
openmv-openscenegraph is flapping around as there's a #<gexp in the
builder script. I've fixed that in
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=12127395dc55d9ea389a6dc619207c406725237e
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Thu, 16 Feb 2023 11:48:01 GMT) Full text and rfc822 format available.

Message #20 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>, 61477 <at> debbugs.gnu.org
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Thu, 16 Feb 2023 10:49:19 +0100
Hi Philippe,

On Wed, 15 Feb 2023 at 17:19, Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at> wrote:

> Fixed in attached revised patch (but it appears to me as a
> nitpicking...).

Yes, it is nitpicking! :-)  I mentioned it in case committer would have
missed it – to fix it before pushing.

Cheers,
simon

PS: If I understand correctly, after Bordeaux you are now in
Vienna.  Nice! :-)




Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Thu, 16 Feb 2023 11:48:02 GMT) Full text and rfc822 format available.

Message #23 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 61477 <at> debbugs.gnu.org, Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Thu, 16 Feb 2023 12:31:57 +0100
Hi Chris,

On Wed, 15 Feb 2023 at 16:24, Christopher Baines <mail <at> cbaines.net> wrote:

>>     https://qa.guix.gnu.org/issue/61477
>>
>> but it appears to me unrelated.  Chris, an idea?
>
> Appears grey (unknown) to me currently, but it could have been red
> previously.

As a wish :-), would it be possible to report somewhere when the QA
pushes the issue in the queue?


> I see one odd and unrelated thing here, the derivation for
> openmv-openscenegraph is flapping around as there's a #<gexp in the
> builder script. I've fixed that in
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=12127395dc55d9ea389a6dc619207c406725237e

Ah, thanks.  Well, the ’inherit’ thing bites us at so many places now
that I am starting to be doubtful if it is a good pattern at scale.
Anyway. :-)

Cheers,
simon

PS: BTW, the new version [1] LGTM. ;-)

1: https://issues.guix.gnu.org/msgid/20230215161951.37438-2-swartvagher <at> par.tuwien.ac.at





Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Fri, 17 Feb 2023 16:49:02 GMT) Full text and rfc822 format available.

Message #26 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: zimoun <zimon.toutoune <at> gmail.com>
Cc: 61477 <at> debbugs.gnu.org
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Fri, 17 Feb 2023 16:47:13 +0000
[Message part 1 (text/plain, inline)]
zimoun <zimon.toutoune <at> gmail.com> writes:

> On Wed, 15 Feb 2023 at 16:24, Christopher Baines <mail <at> cbaines.net> wrote:
>
>>>     https://qa.guix.gnu.org/issue/61477
>>>
>>> but it appears to me unrelated.  Chris, an idea?
>>
>> Appears grey (unknown) to me currently, but it could have been red
>> previously.
>
> As a wish :-), would it be possible to report somewhere when the QA
> pushes the issue in the queue?

I don't follow what you mean, but I'd suggest filing a wishlist bug
against the guix package for qa-frontpage feature requests.

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#61477; Package guix-patches. (Fri, 17 Feb 2023 17:07:02 GMT) Full text and rfc822 format available.

Message #29 received at 61477 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 61477 <at> debbugs.gnu.org
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10
Date: Fri, 17 Feb 2023 18:05:55 +0100
Hi,

On Fri, 17 Feb 2023 at 17:48, Christopher Baines <mail <at> cbaines.net> wrote:

> > As a wish :-), would it be possible to report somewhere when the QA
> > pushes the issue in the queue?
>
> I don't follow what you mean, but I'd suggest filing a wishlist bug
> against the guix package for qa-frontpage feature requests.

Today, it is not possible to know the status: when the patch is
scheduled, I do not know when it was.

I will do my best for filling wishlist bug report.

Cheers,
simon




Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Mon, 20 Feb 2023 13:06:02 GMT) Full text and rfc822 format available.

Notification sent to Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>:
bug acknowledged by developer. (Mon, 20 Feb 2023 13:06:02 GMT) Full text and rfc822 format available.

Message #34 received at 61477-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at>
Cc: 61477-done <at> debbugs.gnu.org
Subject: Re: [bug#61477] [PATCH] gnu: python-pygraphviz: Update to 1.10.
Date: Mon, 20 Feb 2023 14:05:19 +0100
Hello,

Philippe SWARTVAGHER <swartvagher <at> par.tuwien.ac.at> writes:

> * gnu/packages/graphviz.scm (python-pygraphviz): Update to 1.10.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 21 Mar 2023 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 86 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.