GNU bug report logs - #61468
[PATCH] gnu: cat-avatar-generator: Update to 2.

Previous Next

Full log

View this message in rfc822 format

From: Julien Lepiller <julien <at> lepiller.eu>
To: zimoun <zimon.toutoune <at> gmail.com>, Evgeny Pisemsky <evgeny <at> pisemsky.com>,  61468 <at> debbugs.gnu.org
Subject: [bug#61468] [PATCH] gnu: cat-avatar-generator: Update to 2.
Date: Mon, 13 Feb 2023 13:28:08 +0100

Hehe version "1" got through review ;) I agree it would be nice to use git-version instead, but I wouldn't go back to version "0" since guix would detect a package downgrade.

Evgeny, I can take care of that don't worry.

Le 13 février 2023 12:47:05 GMT+01:00, zimoun <zimon.toutoune <at> gmail.com> a écrit :
>Hi,
>
>On Mon, 13 Feb 2023 at 06:40, Evgeny Pisemsky <evgeny <at> pisemsky.com> wrote:
>
>>  (define-public cat-avatar-generator
>>    (package
>>      (name "cat-avatar-generator")
>> -    (version "1")
>> +    (version "2")
>>      (source (origin
>>                (method git-fetch)
>>                (uri (git-reference
>> -                     (url "https://framagit.org/Deevad/cat-avatar-generator.git")
>> -                     (commit "71c0c662742cafe8afd2d2d50ec84243113e35ad")))
>> +                    (url "https://framagit.org/Deevad/cat-avatar-generator.git")
>> +                    (commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")))
>
>The common practise when it is not yet released is to use this pattern:
>
>--8<---------------cut here---------------start------------->8---
>(let ((commit "9360ea33f79d1dad3e43494b09878b5e3f6b41fa")
>        (revision "2"))
>    (package
>      (name "cat-avatar-generator")
>      (version (git-version "1" revision commit))
>[...]
>                    (commit commit)
>--8<---------------cut here---------------end--------------->8---
>
>Although it was not used by the initial addition
>3bedac50571204643d5e3b204dc720ae7d571a1f. :-)
>
>Even, maybe version should 0 and not 1; I do not know.
>
>Cheers,
>simon
>
>
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.