GNU bug report logs - #61460
30.0.50; Calendar shows eclipse for quarter moon

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Ulrich Müller <ulm <at> gentoo.org>
Cc: 61460 <at> debbugs.gnu.org
Subject: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon
Date: Tue, 14 Feb 2023 11:56:58 +0100

Ulrich Müller <ulm <at> gentoo.org> writes:

> Next round: The following simplifies the calculation and IMHO makes it
> much easier to understand. Results are identical, and tests pass.

Yes, thanks.  I want to suggest to get rid of the successive rebinding
to the variable `moon-lat' and use a different name (`node-distance'
maybe?) since that calculation is not just a simple conversion of units.

> Alternatively, we could leave the result in degrees (as all other
> calculations in lunar.el are in degrees) and change the values in the
> final cond to 13.9 and 21.2 degrees. This would also get rid of the
> excessive number of digits.

Good idea.  The conversion to radians is a bit artificial and not really
useful, just harder to read.

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.