GNU bug report logs - #61460
30.0.50; Calendar shows eclipse for quarter moon

Previous Next

Full log

Message #118 received at 61460 <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 61460 <at> debbugs.gnu.org
Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon
Date: Wed, 22 Feb 2023 12:32:30 +0100

>>>>> On Wed, 22 Feb 2023, Michael Heerdegen wrote:

> Ulrich Mueller <ulm <at> gentoo.org> writes:
>> It is probably a matter of personal taste, but I dislike the nested
>> concats. This seems simpler (not tested, though):
>> 
>> -        (cons mark (concat (lunar-phase-name (nth 2 phase)) " "
>> -                           (cadr phase))))))
>> +        (cons mark
>> +              (let ((eclipse (nth 3 phase)))
>> +                (concat (lunar-phase-name (nth 2 phase)) " "
>> +                        (cadr phase)
>> +                        (if (string-empty-p eclipse) "" " ")
>> +                        eclipse))))))

> Fine by me (my preference would be Andreas' suggestion).

Use something like ‘(unless (string-empty-p eclipse) " ")’? WFM.

> We also need to fix the space handling in calendar-lunar-phases aka M in
> calendar - when no eclipse occurs, the descriptions end with a
> trailing space.

While at it, maybe replace ‘(car (last x))’ by ‘(nth 3 x)’?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.