From unknown Sat Jun 21 10:36:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61460 <61460@debbugs.gnu.org> To: bug#61460 <61460@debbugs.gnu.org> Subject: Status: 30.0.50; Calendar shows eclipse for quarter moon Reply-To: bug#61460 <61460@debbugs.gnu.org> Date: Sat, 21 Jun 2025 17:36:23 +0000 retitle 61460 30.0.50; Calendar shows eclipse for quarter moon reassign 61460 emacs submitter 61460 Ulrich Mueller severity 61460 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 14:57:50 2023 Received: (at submit) by debbugs.gnu.org; 12 Feb 2023 19:57:50 +0000 Received: from localhost ([127.0.0.1]:46845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRITu-0003Aq-BL for submit@debbugs.gnu.org; Sun, 12 Feb 2023 14:57:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:38888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRITr-0003Ag-15 for submit@debbugs.gnu.org; Sun, 12 Feb 2023 14:57:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRITq-0000Y6-4P for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 14:57:46 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pRITm-0000uU-TY for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 14:57:45 -0500 From: Ulrich Mueller To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Calendar shows eclipse for quarter moon Date: Sun, 12 Feb 2023 20:57:36 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=140.211.166.183; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) $ emacs -Q M-x calendar RET M This will show the following phases of the moon: Saturday, January 7, 2023: Full Moon 12:07am (CET) Sunday, January 15, 2023: Last Quarter Moon 3:17am (CET) ** Eclipse possible ** Saturday, January 21, 2023: New Moon 9:56pm (CET) Saturday, January 28, 2023: First Quarter Moon 4:20pm (CET) ** Eclipse ** Sunday, February 5, 2023: Full Moon 7:28pm (CET) Monday, February 13, 2023: Last Quarter Moon 5:07pm (CET) ** Eclipse possible ** [...] Note that it shows eclipses for first and last quarter moon which is astronomically impossible. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.6) of 2023-02-09 built on localhost Repository revision: 1518fc5d7c5bedbbe35053696c7ec06020c81b05 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101005 System Description: Gentoo Linux Configured using: 'configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --datarootdir=/usr/share --disable-silent-rules --docdir=/usr/share/doc/emacs-30.0.9999 --htmldir=/usr/share/doc/emacs-30.0.9999/html --libdir=/usr/lib64 --program-suffix=-emacs-30-vcs --includedir=/usr/include/emacs-30-vcs --infodir=/usr/share/info/emacs-30-vcs --localstatedir=/var --enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp --without-compress-install --without-hesiod --without-pop --with-file-notification=inotify --with-pdumper --enable-acl --with-dbus --with-modules --with-gameuser=:gamestat --with-libgmp --with-gpm --without-native-compilation --without-json --without-kerberos --without-kerberos5 --with-lcms2 --with-xml2 --without-mailutils --without-selinux --without-sqlite3 --with-gnutls --without-libsystemd --with-threads --without-tree-sitter --without-wide-int --with-sound=alsa --with-zlib --with-x --without-pgtk --without-ns --without-gconf --with-gsettings --without-toolkit-scroll-bars --with-xpm --with-xft --with-cairo --with-harfbuzz --with-libotf --with-m17n-flt --with-x-toolkit=lucid --with-xaw3d --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --without-webp --with-imagemagick --with-dumping=pdumper 'CFLAGS=-march=native -ggdb -O2 -pipe' 'LDFLAGS=-Wl,-O1 -Wl,--as-needed'' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG LCMS2 LIBOTF LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_CTYPE: en_GB.UTF-8 value of $LC_TIME: en_GB.UTF-8 value of $LANG: POSIX locale-coding-system: utf-8-unix Major mode: Special Minor modes in effect: tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date subr-x cl-loaddefs cl-lib cal-julian lunar solar cal-dst mule-util cal-move cal-menu calendar cal-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 45225 9891) (symbols 48 5661 0) (strings 32 15659 2104) (string-bytes 1 452825) (vectors 16 10193) (vector-slots 8 157214 14550) (floats 8 507 444) (intervals 56 611 0) (buffers 976 14)) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 15:07:21 2023 Received: (at 61460) by debbugs.gnu.org; 12 Feb 2023 20:07:21 +0000 Received: from localhost ([127.0.0.1]:46850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRId7-0003Pw-KV for submit@debbugs.gnu.org; Sun, 12 Feb 2023 15:07:21 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:49366 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRId6-0003Pi-1j for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 15:07:20 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: 61460@debbugs.gnu.org Subject: Re: 30.0.50; Calendar shows eclipse for quarter moon Date: Sun, 12 Feb 2023 21:07:09 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This patch for lunar.el fixes the problem for me: >From cde66af556a76beb4c4232c4056fe8b60dbafe30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Sun, 12 Feb 2023 20:57:49 +0100 Subject: [PATCH] Fix spurious display of eclipses in Calendar * lisp/calendar/lunar.el (eclipse-check): Don't show an eclipse unless it's new moon or full moon. (bug#61460) --- lisp/calendar/lunar.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 0db811417af..70681f42c90 100644 --- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -161,7 +161,9 @@ remainder mod 4 gives the phase: 0 new moon, 1 first quarter, 2 full moon, (phase-name (cond ((= phase 0) "Solar") ((= phase 2) "Lunar") (t "")))) - (cond ((< moon-lat 2.42600766e-1) + (cond ((string= phase-name "") + "") + ((< moon-lat 2.42600766e-1) (concat "** " phase-name " Eclipse **")) ((< moon-lat 0.37) (concat "** " phase-name " Eclipse possible **")) -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 15:20:29 2023 Received: (at 61460) by debbugs.gnu.org; 12 Feb 2023 20:20:29 +0000 Received: from localhost ([127.0.0.1]:46861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRIpp-0003jO-Dw for submit@debbugs.gnu.org; Sun, 12 Feb 2023 15:20:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRIpo-0003jB-BR for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 15:20:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRIpi-0004Tr-AW; Sun, 12 Feb 2023 15:20:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=D0EXWPYYdPuXWvctSTADbbZgqPYxD9DGthtggylqEfE=; b=H4SJNm8+4bxF7/1UvO9n 6EAcNWC0F+fC0FNUqyh5qtEJzurzpLcmaH+6mktkAVV+AmekDLcZTrJPfiMIEhKhEnHp16mMu2Eit EA9GVAtgVs3Xij3P1+nk5XkhDrd8QJkOgssyp0b1RLfCatB7Yw4pZsva/Rn25vE4Q+IlaN3F206JB x13Yx/6e0g2xS04w/yqW937HY1JgimkxnFkHqJmFSaeifQbZ08A61qGkKXEQ9oIBZ+gdzOn5f5/lI eGCn4ClyoB+4yJ/waqISzclBYrNiDwbui7dKHAlAQEVnnuRHTy85ljerlQ6FJGHQf9rzJRdn64zH7 I/h6vZDo1dv33w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRIpT-0000YQ-5x; Sun, 12 Feb 2023 15:20:22 -0500 Date: Sun, 12 Feb 2023 22:19:42 +0200 Message-Id: <83ttzqfxgh.fsf@gnu.org> From: Eli Zaretskii To: Ulrich =?iso-8859-1?Q?M=FCller?= In-Reply-To: (message from Ulrich =?iso-8859-1?Q?M?= =?iso-8859-1?Q?=FCller?= on Sun, 12 Feb 2023 21:07:09 +0100) Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Müller > Date: Sun, 12 Feb 2023 21:07:09 +0100 > > This patch for lunar.el fixes the problem for me: > > >From cde66af556a76beb4c4232c4056fe8b60dbafe30 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Ulrich=20M=C3=BCller?= > Date: Sun, 12 Feb 2023 20:57:49 +0100 > Subject: [PATCH] Fix spurious display of eclipses in Calendar > > * lisp/calendar/lunar.el (eclipse-check): Don't show an eclipse > unless it's new moon or full moon. (bug#61460) Thanks, but what about https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20414#14 It sounds like the "impossible" argument was already voiced in that discussion? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 16:14:01 2023 Received: (at 61460) by debbugs.gnu.org; 12 Feb 2023 21:14:01 +0000 Received: from localhost ([127.0.0.1]:47077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRJfd-0005Ox-BC for submit@debbugs.gnu.org; Sun, 12 Feb 2023 16:14:01 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:54648 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRJfb-0005Og-JS for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 16:14:00 -0500 From: Ulrich Mueller To: Eli Zaretskii Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <83ttzqfxgh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Feb 2023 22:19:42 +0200") References: <83ttzqfxgh.fsf@gnu.org> Date: Sun, 12 Feb 2023 22:13:49 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Sun, 12 Feb 2023, Eli Zaretskii wrote: > Thanks, but what about > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20414#14 > It sounds like the "impossible" argument was already voiced in that > discussion? Indeed, and it was ignored. :( An eclipse can only occur when the three bodies (Sun, Earth, and Moon) are in a straight line configuration. Which is the case for new moon and full moon, but not for quarter moon. See also https://eclipse.gsfc.nasa.gov/LEdecade/LEdecade2021.html which lists 2023-05-05 and 2023-10-28 as the only dates of lunar eclipses in 2023, but _not_ 2023-01-28. That output of Calendar is definitely wrong. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 22:25:35 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 03:25:35 +0000 Received: from localhost ([127.0.0.1]:47270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRPTD-0007Ak-IH for submit@debbugs.gnu.org; Sun, 12 Feb 2023 22:25:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRPTB-0007AU-4l for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 22:25:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRPT5-00049u-QU; Sun, 12 Feb 2023 22:25:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=r/Z3Gof6yLq0P5CS/HYOsYLttnYD8BE5KyoJOaC9wHY=; b=pvGGKEwyw2Om cPKYJczRhjYP2AkU4Cy+sFWBK5bybI0Qmwe+F3sV6O9u5Z/PVVJR/sz1g841jm6SJgmxyKF4mHeSC 6MmMG5aWi9E5voD2XWj8MzLKgkTItjgNbtDo2wKFlQik7WBTL58L/zCvs5vCM4jQUpQYjRdJMKWtW wzf/9CTZS3HcoK6pzPjBvGYrAyyc1p+cDUTp3pWEdPZLpBFnzIcMXkoSxVJTtad5JsI+zBYpANbHk VHauCa7gtsRidJEIW9AR56DzZwXEN8KDtR6VVgf8FP5vhsHBOZK0/3DWtqFmBzcP2WK7s6LbFpJYH 5fyfkBa+JLOaVCAu5L43xQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRPSp-0003Q0-VO; Sun, 12 Feb 2023 22:25:27 -0500 Date: Mon, 13 Feb 2023 05:24:47 +0200 Message-Id: <83r0uufds0.fsf@gnu.org> From: Eli Zaretskii To: Ulrich Mueller In-Reply-To: (message from Ulrich Mueller on Sun, 12 Feb 2023 22:13:49 +0100) Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <83ttzqfxgh.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Mueller > Cc: 61460@debbugs.gnu.org > Date: Sun, 12 Feb 2023 22:13:49 +0100 > > >>>>> On Sun, 12 Feb 2023, Eli Zaretskii wrote: > > > Thanks, but what about > > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20414#14 > > > It sounds like the "impossible" argument was already voiced in that > > discussion? > > Indeed, and it was ignored. :( > > An eclipse can only occur when the three bodies (Sun, Earth, and Moon) > are in a straight line configuration. Which is the case for new moon and > full moon, but not for quarter moon. > > See also https://eclipse.gsfc.nasa.gov/LEdecade/LEdecade2021.html which > lists 2023-05-05 and 2023-10-28 as the only dates of lunar eclipses in > 2023, but _not_ 2023-01-28. That output of Calendar is definitely wrong. Fine, then please install this on the emacs-29 branch (assuming all the tests still pass after the change), and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 22:25:42 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 03:25:42 +0000 Received: from localhost ([127.0.0.1]:47273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRPTJ-0007B3-RX for submit@debbugs.gnu.org; Sun, 12 Feb 2023 22:25:42 -0500 Received: from mout.web.de ([212.227.17.11]:51535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRPTH-0007Ac-CZ for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 22:25:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676258715; bh=RFxFRp4FEE6kGJKtclTP+x4+DGeM4vvEvAfh+aX6JuU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=By3794VxLo11F7119QX+FdbRfWcPyG76JPhgFwuiY8/fElaxXuuNCsDSw/naKEabA VZdC0W2uATRXTudArFjK/roUNVOHuNRVhdvZlf6t7YUMnWq6yzoDaOuKG0wZ7iRf/f OOVQ261kXrxB0ePU7OfC6HjqI6aUwUgXsaPAEnt3EcWnoaD//YibB5j1a3ptJjOSkP 5UYTl4RA3MwwAE6NaIpgPQqk+CJFYeogibIx3+D2VKHGsKDcF7QZIrYg3EqFlfBaJD iL+PVwaOWzSxvEcdePvkBTsEQgjL2JF1flXsH8aptM9y5jrkEHDtoOSzeFlSu2BRy6 5qHBcoZYXo02g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MUlDP-1p0loJ3qyX-00QrAK; Mon, 13 Feb 2023 04:25:14 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Sun, 12 Feb 2023 21:07:09 +0100") References: Date: Mon, 13 Feb 2023 04:25:13 +0100 Message-ID: <87sffab61y.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:D6qq+2pp9yOOMM/3xF6VsoE9Z2Mdj4/1PKoUDxDr2fmOXvhUXVz ZNAQ4NQrnI1KFMBO+JuOM9uVqgw+nkhPed/UcXXyxOBFQ0r73F930goWW73J4rxf6r0w7ph w5L2br8EmU6jM84NbgBD/G0gzPsW33IqX9FRSrt+GhgabXpbFcVPOrSf/NAWtVLDNOz7ati IuPZbAYQUB0lWNN3fZXpw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:KqQoGfPa4dM=;PcF6L7YJuxYhprWFIwOmEJ0xRcO PrG3Ur64gQz9WsJJpUv1iZ7kr+MBT3mjsfUNbD+3U8bZbGiUQMR1bbo6si0rUTSiXyOyNTgu4 GcgjpHES3ddMGEKSyAU3XSag9/PdzUdVzjqv+qY+ctg7nPDMbcVCOOmLZzHU/kZFn9aPmTMi3 M5Azc0qANyrxAbfcfmsoSfaxZnftuW/GMdQMUL8lpIO/DBOe5IUylb/IR42wDJbZxHdZk1rQO /8x7ZgiGB57SC0h1b6x4YHFun5RaMgjDU1JN9wvH1CRBCO1nNmG2zRkCCEJnedbVRUfdRGLG5 CNiol4MOu+xQ2TYTvW47HIMDSnFpAMug42rGX/VDouWx8jMj2dUu5sXIeSiJUFAuIS4+U47NU 2Le10M4Lh3UDKhYT5Id8qG4rAXkwZZiib1NFislY6WQEVLdx2mACgQeDX/i0R+OQt282AT1br EXlw2odBX/xVA6e9CgcjrUINJpiGzcf825NH/fJVkH6uAhVtk/0ZTgr9TJyxmPWuDD8pkL0w7 9ksdv2ucuvotqsjwTfsEzgrqishOY/Q0/oq3VJqwvYAYVyTQaA1vnyepoBzeYCuWh184px2Nv eRKjgGFdQQoHOjYKIXtfnBWThSSb6aRtDwcywf7fyVoQ30tv7fBWnPTxfr2F4wUE83lvS0GIl QW8jlzKmqbAnsfqoI9lL5bQ17rjGOYCUP2sSl1y47iaRoxipPCnFdtd/tsd4+NnIpZ+xw7fYW kSo8djhzczg5h4dRdq6B1lNi9CqNt92lS5ARbajM8U55OCyM06Jhyu9wEElrykauev98zOWfX 7oph53e83hbtYKSNbligfWqC4aa8b3rHTn1gBsRMmhIo54yT/fHFQxbacEE+CFt4nXihPDrxY Me9zlY7Zs78sl8Llo5nLXuSgwl7U/PImYk40a7WoEdncq6pSsF5E91tV7UbuUDqLxiHxHyO3C chud3RT+ICnMzQIiy7wFx5qqHj0= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich M=C3=BCller writes: > @@ -161,7 +161,9 @@ remainder mod 4 gives the phase: 0 new moon, 1 first = quarter, 2 full moon, > (phase-name (cond ((=3D phase 0) "Solar") > ((=3D phase 2) "Lunar") > (t "")))) > - (cond ((< moon-lat 2.42600766e-1) > + (cond ((string=3D phase-name "") > + "") > + ((< moon-lat 2.42600766e-1) > (concat "** " phase-name " Eclipse **")) > ((< moon-lat 0.37) > (concat "** " phase-name " Eclipse possible **")) Sorry if I am misunderstanding, but is this good enough? Then I don't understand. This doesn't go specifically to you only. What I understand is: there are two conditions that have to be met at the same time, and these are more or less independent over time: (1) the latitude of the moon has to be smaller than a certain angle, and (2) it has to be new moon or full moon. Correct? My questions: (1) AFAIU, the "phase name" is derived from one of four values of the moon "phase". Is this really good enough to decide whether it is new moon or full moon? AFAIU the four moon phases all have the same length. So AFAIU the test you added is not strong enough, we must first test whether it is full moon or new moon, only at these days can an eclipse happen, and only for these exact dates we need to check the moon's latitude for whether it is small enough for an eclipse. (2) https://en.wikipedia.org/wiki/Lunar_node tells that the limit for the longitude of the moon is different for lunar vs. solar eclipses. The same will be the case when we test the latitude. The test we currently use doesn't reflect that. Should it? Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 23:52:51 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 04:52:51 +0000 Received: from localhost ([127.0.0.1]:47343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRQpf-0001HJ-8o for submit@debbugs.gnu.org; Sun, 12 Feb 2023 23:52:51 -0500 Received: from mout.web.de ([212.227.15.3]:33703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRQpc-0001H1-W6 for 61460@debbugs.gnu.org; Sun, 12 Feb 2023 23:52:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676263944; bh=NrllF9C/mwJEQIEOStnBsAC1E8BSWb6B/fIIamgoclw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=lSgmB7l4VgrbeBZz6ni2Jg9ZHaKmQaaIoAl4472L1xkMKFAZKcItuCht4SafEGzcu YQD9hLfJJqX7lLkmy3Z/0GVNlZJ/I/pQPcu3cwO0KENDTW0a4CT1VzQlrMYTeDOUkO EgaPqPtgD0jVyowyV5RfnoSzW7yUdyGtLDoK1RHemirl80mUW9fV3zLd13HhASOw28 U4yxLV4HowMGxSISUUb6Sd8z2KX9BcTVr4P/JfoIQt4CN5hNLD7jaLDSpG5abgJKXw Ci74dcZ6g+kyTRrLjM3oXiLGCXVBWaK47MTZ1iOK9ujId1iMj+QC1cjUb+wbxOubtS 3mGdWqZoLeB1A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MhWkh-1owmuR0LLf-00eaki; Mon, 13 Feb 2023 05:52:24 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87sffab61y.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 04:25:13 +0100") References: <87sffab61y.fsf@web.de> Date: Mon, 13 Feb 2023 05:52:22 +0100 Message-ID: <87k00mb20p.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:iPwsMr2gR0qHViAYM3FCVth4KAXa0SG9D+otZRt9HAUPyqlLEnn AKUUD9oECBlhLA1MP3FekhCvy9IpFjfp/uvrdLbrGE5aJZZTv8qPAMl2X6IHbo6joYhT7kV rMOo6uEpuQpi7dIb8QOk/fbbEHUwkkd//Pn/xYcOhM6Fy9HP0xt5JLSVleGzLm6vptfZ65V 9iglpWKu6DmrlqKm+PafA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:MSLpWGX42RM=;E4zPA0tDvBBUvB0XYC83t6k0Q2j o5+bfb+VmYLN4qEFRzJceb0cXVd2h8fwOBweDQAVSW2srKcKz/vnBgkBaWU5tt/oBWJuQpkd/ 5l2diQsvhJqOYZzDHB1CvHXeWSanXYi+AbXPy1DSK35J/C8RqMOSFLzI+Z3fBscW9YkcFX+yH 1e61n8x++Z7NO9LKFCINWoOuzAWaVT331L4XnixBSaclP2zf210xxZ+WKpykLxz3ZFrDeQxye s842710tKUxnifyxRH0QxspidXNZCMvLhf4hDTkPj2S0xUq2hZlxdW4kwFy7A4AgCiz72LuNm XPhaBygcDUPqwjcQTuo6Nx/zTKX/NxqqIpHUPwL6sVkG27qxsLJ9vJHHGiNKzeOs8Syok869d B6SzDIIGw4mY+Nav9ASo4x32cUkl43QmACiJslu5R6LdI2IWrj8zQD8TED7JlVh261EA08HyZ G7S5es7FnpouOxPV1sk5JxQEq2FiqTZSVaHd5aIYOaj2O5fOUiyUGYpk+EsQVh+tfzzBDtCgA AKPw++erXT/LnTJR29CcZmJH26F/Xn09eI6gXDT8m8ISPk8y1k+7IQ42bFyWMJkHZCxkQZFER 0mBbuAuj52hnjUF4Xd4DpW4AcEcx8S0U+6UI97bsGq+sokMR26M29LwJdl9+H+tTqq0YTCwjR PTv1V4MV59hwOzhxnIiJeJlQ/FeuiE/gGB+6x2pffjH7skp5W6Pvomvslz1sczE/Cl8UiXJr4 +T3d1fXW0wj2uxkixjBEGcQBggEG6Onq9CNs39T7ha+uEveWlZBi884ot0cr2/LcLhnzjotaJ vZNUOvJ/QdPepu7IlugnN37juqI5A+cpOlZ+/02wxZPk1DdsSgtcVsJx374rOd7doOADCy1+m fy/sNcCgCQxwIlRxgrqyJ7/8PZRj/1mN2nuJi9i3spH/1aMrK+xMZ16uHIHKIh04u+RAX0zxR sHghcw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > > (phase-name (cond ((= phase 0) "Solar") > > ((= phase 2) "Lunar") > > (t "")))) > > - (cond ((< moon-lat 2.42600766e-1) > > + (cond ((string= phase-name "") > > + "") > > + ((< moon-lat 2.42600766e-1) > > (concat "** " phase-name " Eclipse **")) > > ((< moon-lat 0.37) > > (concat "** " phase-name " Eclipse possible **")) > > (1) AFAIU, the "phase name" is derived from one of four values of the > moon "phase". Is this really good enough to decide whether it is new > moon or full moon? I understand this now: That code is only ever called at the day of the start of each (quarter) moon phase, so your patch should be correct, in my opinion. > (2) https://en.wikipedia.org/wiki/Lunar_node tells that the limit for > the longitude of the moon is different for lunar vs. solar eclipses. > The same will be the case when we test the latitude. The test we > currently use doesn't reflect that. Should it? I still have that question, though. I only found values for the longitude, we test the latitude (which is available in the surrounding code, this should be no problem). But it really looks to me like those two values 0.24 and 0.37 should depend on the moon phase (or kind of eclipse respectively) instead of testing both. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 00:14:17 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 05:14:17 +0000 Received: from localhost ([127.0.0.1]:47358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRRAO-0001qF-Sb for submit@debbugs.gnu.org; Mon, 13 Feb 2023 00:14:17 -0500 Received: from mout.web.de ([212.227.15.14]:43171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRRAM-0001q1-Os for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 00:14:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676265230; bh=9CyWCrRb3qagyY4bhRvSa/LiB2IbJVkK2PbigmiClCg=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ODMH3bGrWsQllqv28GcnroFaV0REzQ/732QYrYhGgkBf7ZgdCJ6iHD7/lo6PLX7hL OS7q3dw7GhCnDmikWUTqmQ2YSH5UdiDXYgRMKj2ypvgqod2qVjdh+XDriKz3CCfMl7 hvu4oLCrSXhhOMrIGi1/++8Rk/wrPUO1rmSHiFv+jfIhZMq6HTIFftMKPRwn8lc3j+ GrKqjbvASC+sOQcGJiLXPXYUC746ZNEiReF0fLt3OPYZICONW5dllSOZnKmN7C0tbS A6m7pocl+P0KOZ8mx1+TEWvKNtLKvhkLbVGEVuScTWmEr2/hkaYgKZurLqSARWfnMc ZKPHuZ6MUN53w== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mv3US-1oaR261YHY-00r3vg; Mon, 13 Feb 2023 06:13:50 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87sffab61y.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 04:25:13 +0100") References: <87sffab61y.fsf@web.de> Date: Mon, 13 Feb 2023 06:13:49 +0100 Message-ID: <87cz6eb10y.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:OODnNF+55WwBDD/0efSodsQN5TwHw3flHYnFQKeQYetr+Ga6KE5 ayV+mw2b4M9DCAmcquvpMHJ+/nooH7EjLigaLFp3eW+wLy9YGlufpGl2j8RCHPgX1syjhSm 07mMEu1VmcNQjfwBDE7trTCdK4od1moUiawv0JqFvWu0fOrUSmvxvf19VQ34JtAf3XIqTgZ EHR5fy4AB5J2cTTnEvq4Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:r9v+1AK5wMk=;aTQkruXzBJXMPrrF8iyc4eWS7Oa awARRope8JVZ0LUbC3FDSyU5i1xFYZZo+2KwqFcNpyF7vbHRsK324ptdeDtlnnqhiOsasCUJf wJT8J4yH3cEEBJw38LPfL3Qx7Viuhur9c+QoTrzvcJRa8NICnEtMgKqiw+e8M7WL8MMeZmvJR 0uALRJP4wNt5A2YLKItVan8FDH395mk1a/zvHtPPn93V8Bcw4hJPo2OwguiJJQnVTqpidAD6d Ligbol7ScgQLYPga/yAaw4u7P3Ej7H7Fy+OK4EuwazpGvoVNFVrXSEC3N7Q3lROjC/0L1kTY6 nN7q/yb9N2o46AdLT8Kdokwx4m3/mH97mMnbjwWHpbTsphOp28XGvj/I3X0DFLyXY4ERAAoG9 SHaAD/kOh8SmOGXkF/bEbZn7sJ2r67E1q1Gy/v4nY7/ro4i1m5JVMaqcG4tn3K72cpq4KNCgv QhcDPhlwn7NesDBwqI3Cia8G2H1kWSkO3zdG7by4mvieMvX35HrXXosh2JH8EukgNzGLWjRuf wjj3oIBXmcodVKnU4c/0U4ur0KtxHgHGKx2JloGFAuvdH5sUOzRoWLt0hCwKokmjbV7o3fL0m 80O3BU4gUahhjNBVKFlVwWz0866cIiE0tDrL2x2vR9P3+7pB0oldMWGE53sRMdWHq7TT3nX2V 3p4gF3iqDyRmOSNGkv3BR22WX6tmP0+5Aa/diM5UGxHCQUeuX3gsNr7cLGi8BsnJvY0wd/mmm brlz7kgZpKFskmZw28cSr/u+RXpq1OZjNa1TEupVIRsjwAbNtAlsNcgQHrQRH1amFjIWbKeAD ADwVks5F15Ye1tWq5xCaYyFhgC8tbz1wAZ8oPa5xds6JZ8tU434FVAmH6TiJ5I5YUKXT9k3Pw BgOGiyK4KDmUH0aLhoZnMMDeUAnZZ1uJr3b2K/BDfvqDHJTdKf+wBtFqfjpXVs/OHJlqwfkKF oMniHSqYch7HFAAFs8JyHQ6nhfs= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > My questions: [...] BTW (3), I also don't understand those conversions of the latitude: #+begin_src emacs-lisp (defun eclipse-check (moon-lat phase) (let* ((moon-lat (* (/ float-pi 180) moon-lat)) (moon-lat (abs (- moon-lat (* (floor (/ moon-lat float-pi)) float-pi)))) (moon-lat (if (> moon-lat 0.37) (- float-pi moon-lat) moon-lat)) (...)) (...))) #+end_src What does this do? Don't we just want to convert a value in [0 360) to one in [-pi pi] and use the absolute value of that, or so? That would look like (abs (* (/ float-pi 180) (- moon-lat 180))) Why is our calculation so complicated? Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 01:01:45 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 06:01:45 +0000 Received: from localhost ([127.0.0.1]:47441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRRuL-0003Ca-Fy for submit@debbugs.gnu.org; Mon, 13 Feb 2023 01:01:45 -0500 Received: from mout.web.de ([212.227.17.12]:50407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRRuI-0003C3-Sz for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 01:01:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676268076; bh=o8rVdttOgufUjCjvd6BiEQl5RhuWplsztcg+3cqBLNo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=eiNhGF8f+D1LJhk4OJsxXxLBMM0zFmcJ2Eymkg51gUY0yrK05G+nO2HCias/Oev/r IAvXV0VWLDBTEe99DQtdo9my+K48d0b7Pbl9EoqoteOTCtoVJfKow4uc21DzmHqO1u o+W0d0eXm+6kbQHG9zgULdM7k0Sh75TFSypmhSPOXIkUYTk6m37oBNgKJA4Wa5slVS ARIMBRhHkKxxl852RmmV/xKzqvkpke8APu46KK/JgYJ3SxnT7F9pZEy9gwlD0IgPEL jtw5OGe0IKnb8H3mlgcRn9Fefwgw4buddD4UobiF8oZl0IOcU8TfhKb6T3NF3jnHoq 9BiBwZAV3WCkQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M1aHx-1pPX1T2XAh-003EUN; Mon, 13 Feb 2023 07:01:16 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87cz6eb10y.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 06:13:49 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> Date: Mon, 13 Feb 2023 07:01:15 +0100 Message-ID: <875yc6aytw.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:8j6wAqMQZObmpAkAXJXeWDA+H3meexr2FUlQazrNDnVHY11Akb8 scl8yjeVtI4lvszFy2+LU96/nXhCHZW1gvTjOSwCnZ45kbImhVBL7dFIPanYg9Whbb30mWS q4o0z0IfnnK/vqVSBpe2o4uYQjUwoE8rzdMYg1oi6m6yh63DrHiZ4wrumK2x0t3v1STpUXQ aEQ5b6sSfHj5pz9ktyhAg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QlFcJm+W0tQ=;EWH2KmvKiQp0MBjUyjeAj2QIO9f djEEDqbB7SXHFoCvkhgYynnXSaVC2fbbnDGMo/MrNp/j5MxRdHahmXnwrcsghcVSGAO2t3k6q 92vadSpgot/20cbU5vkIA9wCxRohEkAF4Hso9QnkdJBBSWESrvAa1/7x0sGI7du8nP9r4uqAQ C8fk/QroVYvwdbd5NHUXE8Q7Bz9w6rn1EsBF5mDJ4Nee7yn9QVxTXqzWhkczUh0hJKbTV9p3p RNn8JL7zeS8qyb4Z5cOnLHMXUdJZcPbVVoIw7AoRRW+RDjUQ7kTo2drqvqZ42w/X31hu7yKuY 17ngpr6lrArLwkfKfHgE6+Nb6miYMV5aMtIN+lnPfnVWezqSvAK07RvQpO0q9o7UDVDFjeHGK Iq3hZYfIu+aZEW035a99ND19QLOjzz9xYh20tWzA1DNuBMvmAzhX564uSgicPOabJs9jiOFHN 7FIWKAvplKhwpvXT6FxOql1KgrAtXbdU/c0NX5p/7y8DmSDBkDJCNkAsWjyCc5K6Ez1JE7bbz jQfNY1AOoyf+2Ej+3109UvmApEyR865NBpnwEW3aKfX8glkv0/yflSHcWIDouyeLLPuN8moSC KkNluj4aU3JHw51zS1LjeWJw5TisaXhVkago0SV2M84q3nYi4U9Lq6363rA3t2KRFPnqNG+9h F+A8ZRYoiVeTJXrS2oaWTrxJy/Voke/MDt7sQl5bhEkkr2hWLJkhe21DOsMGvquwrngBHDkCn 1lOJOj+Jbmj8zO+LBMjAHdBimXtFuzGGvptX2lvbEapdKopKvD2W9G+7GGlfHviSQZrrSv3N0 b9+rbUqb8ACoLelVefUFgSEs8mAVs9IJBINXtX6Cn/MGx/Xcu3UYyuvawGJvNjz8PHPktKEtV kNowdVggUpNuaUgVvGjEUukK1XMSS9VKVwuIeFKE+vqKPP0wDLBHTJ0+vhPToluNk6c3hlmlV k8VKivd7Q2KOjAJ5IbWpCSVu1W4= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > Why is our calculation so complicated? Why the is latitude of the moon: #+begin_src emacs-lisp (moon-lat (mod (+ 21.2964 (* 390.67050646 index) (* -0.0016528 time time) (* -0.00000239 time time time)) 360.0)) #+end_src calculated as a mod 360.0 value? I would expect this for the longitude, latitude should be in -90=C2=B0...90=C2=B0 AFAIU. Is it a typo? Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 01:21:57 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 06:21:57 +0000 Received: from localhost ([127.0.0.1]:47488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRSDt-0003vO-FE for submit@debbugs.gnu.org; Mon, 13 Feb 2023 01:21:57 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:47180 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRSDs-0003v7-3x for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 01:21:56 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87sffab61y.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 04:25:13 +0100") References: <87sffab61y.fsf@web.de> Date: Mon, 13 Feb 2023 07:21:43 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Mon, 13 Feb 2023, Michael Heerdegen wrote: > Sorry if I am misunderstanding, but is this good enough? Then I don't > understand. This doesn't go specifically to you only. > What I understand is: there are two conditions that have to be met at > the same time, and these are more or less independent over time: (1) the > latitude of the moon has to be smaller than a certain angle, and (2) it > has to be new moon or full moon. Correct? Yes. > My questions: > (1) AFAIU, the "phase name" is derived from one of four values of the > moon "phase". Is this really good enough to decide whether it is new > moon or full moon? AFAIU the four moon phases all have the same length. > So AFAIU the test you added is not strong enough, we must first test > whether it is full moon or new moon, only at these days can an eclipse > happen, and only for these exact dates we need to check the moon's > latitude for whether it is small enough for an eclipse. The phase is passed to eclipse-check as an argument from lunar-phase: | (lunar-phase INDEX) | | Local date and time of lunar phase INDEX. | Integer below INDEX/4 gives the lunation number, counting from Jan 1, 1900; | remainder mod 4 gives the phase: 0 new moon, 1 first quarter, 2 full moon, | 3 last quarter. Returns a list (DATE TIME PHASE). eclipse-check is only called for the actual dates/times of the lunar phases, and then checks for phase 0 ("Solar") or phase 2 ("Lunar"). IIUC this should guarantee that it is the exact date and time of new moon or full moon. > (2) https://en.wikipedia.org/wiki/Lunar_node tells that the limit for > the longitude of the moon is different for lunar vs. solar eclipses. > The same will be the case when we test the latitude. The test we > currently use doesn't reflect that. Should it? Probably. Also, the moon's orbit is elliptic, so one would expect the latitude angles at perigee to be different from those at apogee. Anyway, let's not the better be the enemy of the good. I've pushed the patch to the emacs-29 branch (with updated tests, thanks Eli for reminding me). Fixing the other issues would require much more work. Are more precise prediction of eclipses within the scope of Calendar? If yes, then this bug should be left open for a followup patch. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 02:09:14 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 07:09:14 +0000 Received: from localhost ([127.0.0.1]:47511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRSxd-0005RO-Sd for submit@debbugs.gnu.org; Mon, 13 Feb 2023 02:09:14 -0500 Received: from mout.web.de ([212.227.15.14]:50827) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRSxc-0005RB-Cx for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 02:09:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676272139; bh=79xwU/GSYmkae7gQPgwYI6/rLrdZQm04Vgy3B8MCbTU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=D7XWlmrUT/1ERsThP6WDU4z7MR9qGQyqM++cJHdPS1n+SpQgliTztIgnIRzuemG5j zPhYQBc2Cye/7+3HlQHZye/VQ/eqxgBbAuEEJuVq+zOq6K9Cihk1AAcQdxWhwV7QAq 10HIyqJ4TQm01zru7NC40RrfIjR/whqC9hoDAJE77pH60JPvgY20ccxabbbzw0jYzn svAGvAbKabxkpUCwmxM4noBklowN75EyrHHoB/igBYIdFWA5n6+cmnqHXzzO0CT4RX pusjFKVtUEMi3dixu3XrfJujsIIRLu3d8AhPMi0BK1Hjd24AIni3g8a1dT+tcErNk4 RXDo640D5RhCg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MSZMD-1oyV3D41If-00Sxcq; Mon, 13 Feb 2023 08:08:59 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Mon, 13 Feb 2023 07:21:43 +0100") References: <87sffab61y.fsf@web.de> Date: Mon, 13 Feb 2023 08:08:58 +0100 Message-ID: <87v8k69h4l.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:J8a/GRdmcIuyeLObryCSJTZkvcATw7RaCU6yLvHKgax7ILhlYwC npw5MXEMT7s54g5eeNz6ks1bnWDprPE4vFBzkNBSb/JdKd2pzZ5QZ7mi6kO38ZeBrExXOBg 091bUAiHhaDhE+cJNDBkPSs0OLWPkLu3fXxdlrkKnO8/gT3c5aL6JLtpbDCER6CiLG9qHPW wyQd4/xTAAjs4toNqAPRQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:GgnHjifRh3g=;sRaFFTZGEP+MOZnAPleiCCv9Xie 81kMIzdpzWZ4q/teU6BeRrrFoJz9O1FRFhjKxxG/EMh08/x4wnX1bbQXdVe5hEBstFOLATAUU OAGzJ0x619Ce4nhtPSJfzASuXj55u1GTHM25AChoDtB9z3h8LXyN3aqaCg9KKyckqU0tnaAQx 3m3qPpeVv+WREOawZxwZ6ZlzQ9u/wi2SSvgv78gGhGAT1M8mtcWNouQK3cuSIJ2EQvLrTPWjh eqAbO6IngXha1OqSgNMmOeOVW77uUiCy1fT8fbe3U2h+5PiYNJqpkOgLM6rqAewOgjn1Dhbs/ 1zqus/k8gd+ls0fRYmXuSajf7/INtjXu2EkgzQOWFD1GjrbrADreRdH3WBR+VfW2wMhPt0lUC ugvO+hcBGcr69KyB6sKyOMFxwWT0uSRaFsoHK0kea9PdqbogGT7mGN1Mvs6uCCUmlgUDVPGwp vhVqqYKIyHM1PVWhgFDv8nBEq8h7HnY7m+SjGLMQBWv5d7QK+cLPpWzAjkE60XUm1UplAfIbe 0med+ivbUDf+OWdEzZGtjjFMJLWba2ECK4g7wQQMg12Xc1s08SZob8SfIzXk+NTLU8jBxNYIL SDkgZJlZtbYGmOYQjk2cB62aIJVQgrien9AblswbFtieOWO4somT0dZWQhByqUmxRArB9VWdP P2Eafxa1If5brP7dEzaFob2DeLScwnmFNTGc4hf7RmAGrxFNKJQ8iJSjZ+/q0OK3Nyh08KvXg c4kkAp5gEazZ+nr5bGtQOdoi8LzTnwBbDw7PxgZnC4hV9Gex7VZV2kB9aWNgaKLLtYxNVnsmw gUtFf7AZFUw32GreA2RurdSduHWM6itt+uIMPvBy92pV4HjiUCpqcRwGEg0NOH4Fanto7xXPi bTIe1X0dHh0R/aaWTtxQL2H8b81L36W+c2928HRzEJO882tA11G3osWFMh+onD+BdMXPvKvo9 /YYr3IPMj70VEF4Whl3Tw10FPPQ= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ulrich Mueller writes: > Are more precise prediction of eclipses within the scope of Calendar? > If yes, then this bug should be left open for a followup patch. If we can do better, why not. But my concern is more whether the code is well readable and understandable. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 02:28:43 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 07:28:43 +0000 Received: from localhost ([127.0.0.1]:47547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRTGU-0005wk-T9 for submit@debbugs.gnu.org; Mon, 13 Feb 2023 02:28:43 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:53602 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRTGT-0005wS-15 for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 02:28:41 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87cz6eb10y.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 06:13:49 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> Date: Mon, 13 Feb 2023 08:28:29 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Mon, 13 Feb 2023, Michael Heerdegen wrote: > BTW (3), I also don't understand those conversions of the latitude: > #+begin_src emacs-lisp > (defun eclipse-check (moon-lat phase) > (let* ((moon-lat (* (/ float-pi 180) moon-lat)) > (moon-lat (abs (- moon-lat (* (floor (/ moon-lat float-pi)) > float-pi)))) > (moon-lat (if (> moon-lat 0.37) > (- float-pi moon-lat) > moon-lat)) > (...)) > (...))) > #+end_src > What does this do? Don't we just want to convert a value in [0 360) to > one in [-pi pi] and use the absolute value of that, or so? That would > look like > (abs (* (/ float-pi 180) (- moon-lat 180))) > Why is our calculation so complicated? IIUC, the goal is to calculate the angular distance from the ascending or descending node, whichever is closer. So one wants this: 0=C2=B0 -> 0=C2=B0 10=C2=B0 -> 10=C2=B0 ... 170=C2=B0 -> 10=C2=B0 180=C2=B0 -> 0=C2=B0 190=C2=B0 -> 10=C2=B0 ... 350=C2=B0 -> 10=C2=B0 The only thing that I don't understand is the constant 0.37. I would have expected pi/2 (=3D 90=C2=B0) there. Probably it doesn't matter, because below it checks for (< moon-lat 0.37), so any larger value will be ignored. >>>>> On Mon, 13 Feb 2023, Michael Heerdegen wrote: > Why the is latitude of the moon: > #+begin_src emacs-lisp > (moon-lat (mod > (+ 21.2964 > (* 390.67050646 index) > (* -0.0016528 time time) > (* -0.00000239 time time time)) > 360.0)) > #+end_src > calculated as a mod 360.0 value? I would expect this for the longitude, > latitude should be in -90=C2=B0...90=C2=B0 AFAIU. Is it a typo? No, the argument of latitude is the angle of the body measured from the ascending node of its orbit. So its values are expected to be between 0=C2=B0 and 360=C2=B0. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 03:13:17 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 08:13:17 +0000 Received: from localhost ([127.0.0.1]:47573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRTxd-0007Ge-Ad for submit@debbugs.gnu.org; Mon, 13 Feb 2023 03:13:17 -0500 Received: from mout.web.de ([212.227.17.11]:53713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRTxb-0007GQ-0h for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 03:13:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676275981; bh=51CWaKZHLBt81xkXN2CASyO4qiMBqQKzy2z3g3/w6pQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=TQc4IFT7MwEnUpYA1eNdCQAKrYl7x4WFClTOoonOH+/j+PRP2rCSuLCiZ4pLBqJG6 pvFtFEE1ftirr7BZSktgIJKTdZg4ii737+3cCLsXeO6w7z4R5FpzfP+KpHSQGvb5Ij VJ+uNflIdo0eP7huwhISM7mn6DflZHaciXUyH+NzcAaLXUG8GQH/KNAxG/LHHLcT5g JB4NXq+5AT0n8DyW6nbbQvXFBa0mhuzzhuBC+lb+ScVATUGB0/zqfKK/a6Np1J1nU4 UywwyadYKY4xp+hNYzDONaBdN8B5dSPyA+kXAdgLtIX9MK1mpVBdFVx0slzmW4oGxP zkG8DNDQBLGgg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MNwfK-1pC0RR1Fbk-00OLxQ; Mon, 13 Feb 2023 09:13:01 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Mon, 13 Feb 2023 08:28:29 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> Date: Mon, 13 Feb 2023 09:13:00 +0100 Message-ID: <87r0uu9e5v.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3ez9KmV0xCX6Y9pY/USCo4fyatJzzVOkwYtx6NCVwo2zgRprgz1 FDAubTia0gfS1jju9WvTfXs4Cp56LCpK6GOWCDioMoWkioNkMZTy8YvxfOT1h+YylRIekAx bNVlVdfcevRgTTl9U9ygEkWWp9PTnAwQ5GRW2RbSrl7JvJEEMLhnp+TpTDy8kmfNBkNUujB shjrftX2lfTfZ2w9Jgiww== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:D1eiljirnDs=;2c/D5OcQzPjkGP1phwLC/6piVzK pd/FG4QOV9mqTQX5R5xjzt4i7npvNfFaxHQn7xQxjz6tzhLAF1EeJhjeK7KRUHU/nTAZqEIMk 1Y1wQIzo60irHgfOv9U007s/UidJOxRa71+Ygrsw0y+4C17YIN+r0bJSo6ylPcpfDBpqpMC8e 9218MFgg1hgLMFbZgKV0pIDII8CuBCNm3/WdAQp9CiyMb8YdY2CLiZULk2X0fMeRTYDqyKXP0 X7zrt1do44Qi6R4BR+08t9kFYn4kFFqzuI2rIwDwkSygMWQVctKhlclr3Cn15myC+x0yyVd7p 3PgKys/eMphcbzQov6CnqNNUVFYR982rWF1WuJDBSJnliesR6LsGHWDFPO0Y8GYhvePiEC6Fh YXLSFLJ22IPgi0frNQtp3cAwv5TH1iGGd6vg9xyrK7b3VFR0MHSZ7ugl0Uom6Noq/l6z7wZ33 9A4qvmbnCYiKegHXlxCIc2v4NGfn4F6n5s/iT9SppEB4WF4+EWm/CJoN58EgSz8bINlz5BH+G xYgWaOt19iN/Hp6HCVZUsayz4lfPz08aQGi7Dx49Py+kow3jJWEn8/QLIkQVa/lh0T+HPjghk x7lT/VB13hrTuZPKJ7McOrFmGZm4Mt3RkI1c91MZ3i1dRtd44AZU9kJS7qEj67IDHcbN2m3v+ JIN48SC5l4oVCGN0tjrFAaM3kQNrgnhfn8oaMTjUjR0oE8NXwv9recnMq24tyBkurI1oh7Q3P dLtzObUNr6ZDs32ETwiE0z4lvEuHfK8ULBHwbnyeFtuinc8pnkHRZc3l9BJ9v84qDIS++T+5z vFNflwsOtPW8z3RYBMCTIaEzgcrr+7K19YvQbUlVGHItLXclu4z6HB1bkClKeL5m0VGg+5Is3 E2NNpqG+VYkFWG8Sz17By7i8C6CAWM4ssUwYiXLyqyE3DCgRq++rhiE/SumbH2p0F3gsXyFnf a2Fs4WPlXbza7LdYxpJgVHmhwrw= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich Mueller writes: > IIUC, the goal is to calculate the angular distance from the ascending > or descending node, whichever is closer. So one wants this: > > 0=C2=B0 -> 0=C2=B0 > 10=C2=B0 -> 10=C2=B0 > ... > 170=C2=B0 -> 10=C2=B0 > 180=C2=B0 -> 0=C2=B0 > 190=C2=B0 -> 10=C2=B0 > ... > 350=C2=B0 -> 10=C2=B0 Ok, thanks. So the input value is the longitude? > The only thing that I don't understand is the constant 0.37. I would > have expected pi/2 (=3D 90=C2=B0) there. Probably it doesn't matter, beca= use > below it checks for (< moon-lat 0.37), so any larger value will be > ignored. Maybe you gained slightly faster code on a really old computer - the book that is mentioned in the code is quite old. In theory this allows you to get rid of one `if' statement (the comparison against 0.37 is performed anyway). And yes, it doesn't affect the result. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 03:53:23 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 08:53:23 +0000 Received: from localhost ([127.0.0.1]:47606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRUaR-0008L8-FM for submit@debbugs.gnu.org; Mon, 13 Feb 2023 03:53:23 -0500 Received: from mout.web.de ([212.227.15.4]:53319) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRUaQ-0008Kp-1j for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 03:53:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676278378; bh=tfM9McqbsjtFbP2UFpDLqs6T/YQtMSDT+WJr53KPLU4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=QEYXoEX4fucpXmVIgAwYKlx8wK40Hi3OBRrGWzrD2CFpPFGKRA3kLXOCRs+PZxuhN W13S8Jtpetp9QZlDLarQBx21joma6Y9ij7fJ42ulQOEjXnpU3CozB0fboeTjy0CkgG sTh7ChfhYyBOWaLqsBG0O+v9RRvJK9qeKrTwuMcV5CpAvo6F0WoSSalr1Yhd1AZvhg dt3Q3q8AkkjUFK1xSp7VabwGwinxle6WNRNd9PyVVqvxR+j1uJjq7N3D3diJJHvZsZ PpDaDKE29/bL1+sBtCAdpD5q457eKCoNqUuaquI8Lxk4+FGp1KTqQAEze7ccDqpAKY VWu4tiaojeotA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MkEhR-1ogqDT0mvR-00keGI; Mon, 13 Feb 2023 09:52:58 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87r0uu9e5v.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 09:13:00 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> Date: Mon, 13 Feb 2023 09:52:57 +0100 Message-ID: <87mt5i9cba.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:XdBrvsSWxT+S3NbAtBVbfy3DcLeu8+CUj5U3MxSh+uUgsYvHcIX YEFxO7f6NUVTgILQsoKu/3oGAUV5ljwJvezXqFjp9sTpH0U8k53oxt/XpGdawwEQk2GZIL+ t89H0Oz6u8K7BWwO0HsO7RbKygO0ovjFsRHC6SjKaeXkenQLI33VyQNHv5tRoA/z4ICNbZD 6oBs1+v5ZktjktfR65u7Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:iOnyF9ygp8w=;uCRjRDtwvhx7SgARRKrKC8H9e9s Giy4G/X2YBEYVfD3D/WYIFxFk6pubbj9dtzMZnhcbMv2Gs3/EiYeXSFdXqn0pofn0xKJu8G11 syO1TSBqc1VUsFhcNKu6QO/0fJbNUzeSOVwY8Y2YdsyXg9ay42oaa5ZOaic4r5iWms/qzhSeK gL5jgd1j59Nf51P9FyH4wZPibaKi9BB1RhfkHtwDEkvBw6k1USQSWVyUkqdjIsx9apddtgVaN umwLSZG7mVmc43RAUJaoB8QAI8oR5W39573crTYierfHNh/sNY+WYq5hOyXbhpi4hC6WFtBfs wvaBfyXr1ez2Q+26DMtMWkSHbpnjtXOqV+lJizO3E9y+JxQgJENWKdUrYfH5GXkYho5ERPwkH IPJ6eK+ovL//2tzKctiZlG6V7sWJ6AVARW8fsCjNG5LhJa3A1+eATLEaaavfFHv86xvldRyrV I2jvVQOHtovuDDBy11yagZsZhrs1hxWgmZ6cY5723iC097WAVgsug2VS3UtHiZ06a9rH7AeGZ vDZDKdEeK+gJEbIdFGasCylWgcrW9muMU6x+/07X3QFolHWPXhnOjND8dEbJdy1EPI0QeamE2 XLdpjQInNPGYDmaCuMt02x9gNeOZzBy5+AfUHGF0AoJ3GtOxdqXKUsxz9LAsnCv1LjnUHYDEY 92VHhGs0BsFSZd9qrxUwNRGLLZ8j1bC7zvBEhLFZi4czCCz+/N3cZ4qDoU1Nb0aB6l3w0vNeW W7MUmLibZEywD0/dzTF7sO6rDWJ77G4vB8LlEHo/Or5Rum6iJeN3YFVcgZfSNE9EELQ9e83yO ZP18CsOUDlnEq3czweGG7sfbAOP32QgQoarjBla7IjmVDQtjBugnq831j+Dx4NPsCCQqyP12d aTLrlYm8GmxcKIwsEZ6uEWo083nUy0iSyeEuuJ7KtIbSdj7t0A5/sDkjYxNIqX65pG1ql6IAY a+tLCW+BJvaZuPL7f7FOI8T2q1M= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > Ulrich Mueller writes: > > > IIUC, the goal is to calculate the angular distance from the ascending > > or descending node, whichever is closer. So one wants this: > > > > 0=C2=B0 -> 0=C2=B0 > > 10=C2=B0 -> 10=C2=B0 > > ... > > 170=C2=B0 -> 10=C2=B0 > > 180=C2=B0 -> 0=C2=B0 > > 190=C2=B0 -> 10=C2=B0 > > ... > > 350=C2=B0 -> 10=C2=B0 > > Ok, thanks. So the input value is the longitude? Which (unless I'm misunderstanding in what coordinate system we are here) would be bad, since the longitude of the lunar nodes is not constant (the nodes travel along the ecliptic in only 18.6 years)...? Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 04:34:13 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 09:34:13 +0000 Received: from localhost ([127.0.0.1]:47660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRVDx-0000xY-Eh for submit@debbugs.gnu.org; Mon, 13 Feb 2023 04:34:13 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:38332 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRVDu-0000xH-U6 for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 04:34:12 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87mt5i9cba.fsf@web.de> (Michael Heerdegen's message of "Mon, 13 Feb 2023 09:52:57 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> Date: Mon, 13 Feb 2023 10:34:00 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Mon, 13 Feb 2023, Michael Heerdegen wrote: >> Ok, thanks. So the input value is the longitude? > Which (unless I'm misunderstanding in what coordinate system we are > here) would be bad, since the longitude of the lunar nodes is not > constant (the nodes travel along the ecliptic in only 18.6 years)...? No, it is the "argument of latitude" (and yes, the nomenclature is slighly confusing). Its value is 0=C2=B0 for the ascending node, which is what we want. https://en.wikipedia.org/wiki/Argument_of_latitude | It is the sum of the more commonly used true anomaly and argument | of periapsis. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 05:05:06 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 10:05:06 +0000 Received: from localhost ([127.0.0.1]:47694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRVhq-0001lh-0h for submit@debbugs.gnu.org; Mon, 13 Feb 2023 05:05:06 -0500 Received: from mout.web.de ([212.227.15.14]:55379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRVhn-0001l4-Jz for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 05:05:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676282687; bh=QQEpC2NE4tWu6f3+XFW6XpgwgPZ6257KAumrkRNJ0A0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=V2y3XI2jZpHayHZUBSVnGIxRDUseVN+/qwPYcwNUq426JFrRDzsFaAJfaqS/y+Bvp THhTaG4GDqyiJZQXR6yFdveYeSMD7N/mTnJNCYdv1GDVEARMAjajbd0cLwk/YHUj2T m8ncj4IvmIsU97N4C4IGaKDURaaBG/2T0+cJ2nC7rVRmdd1bRg2ljNfCRLHN/aHbTj 0F1n/7JA4OOTXIbJRR7kBk5Ir5slHWhFQMsnDeI8wn4Z4FDjAAstVTiDjMYTilzLGh WEGIq3L2r07LVE5Cpq8m4WzGpXrEVXRYWHQ0i74xAYBRWJXD6aAtoq/iDNrEEK+/qT /JOZQmolTiD7A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mgzeb-1ow2MM2Sc9-00hM0x; Mon, 13 Feb 2023 11:04:47 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Mon, 13 Feb 2023 10:34:00 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> Date: Mon, 13 Feb 2023 11:04:46 +0100 Message-ID: <87ilg5ank1.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MiadQ1cID9wISHA610u18z54VEixGCvKSnEuThpbmxvuu/zH0Ax jEBAw2XsqyEP15He5QRGGxtj2p1zMuFvZYMi2jBuA8EcmYSwqfcKdZP2mXBmV0/PZWZ0aon wNi14c1616tQrbrneAIjPSno82ABLg+RLXQ9AkcE09ytUqc7rhj7kf14wm3ouvcuweyBa/0 gnJ0sZ+FdI1KnfXVe7a+Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8KLln3EZpGs=;0ukwrVyjd0U/JOp+05nDk7UVmv7 IyCZ4HiZyv7NRzoLjcqlZPYbbifiAYcyBbPnzhdM78juOAU6vMaOXL2zcWnIB3z1Blq+l585A G5zhRdGRLJimq9nAhuoqh0sIryy8US6soCZUFni1Sg+qKjXS9XR3ZsAhTnFZr2JRvdpYssQed Bz+87iZ3WPlPlfRqTeC55Fx3238CipvcDm2tQZVwKAcN0KA0mno3GksRJc7cRmNuDPb0k+Fcs cIUkSsLbxBkWrfZ4GxZmx8zKsb6HoACzLYKPAGR6MHMkHs0XiiLqBDuALUkY9koSMzv5B5YeE UM5mZYZL7F1mMlheFXJMlxrc/IwzVDJCQU33ANKOv2wis8bDiG3K+rSrakeZDuojYpk7xLak3 4xw8E/PfG+72/ykvcJUXukqD0/4JQPWYS4ziL8KCiERMeDas28fa0i2y0WuyQYEBiXAGw0ruj YX2JA3ivYpL5oYHsbkucuNOw7VyAJgwIvIZjsIfM96rvsn3NjBkx0vAOl5LrV2B6iwvPSl888 K8/imov1PYJJTI0TwGrPJtHr7XiGkXdbFu3X/s27RUcKE9JE23Gw8TVQhbEkIaHDWm/67H+Oa s3Q1ynbgP1+Eb6e+WijXEjMmNYu+/71uZkTEumRl5NkZivJm6PBKV2m8R54uo7cdRsRliHpBl cfAwRcRQ3VbbpeuEIQso39JvFoPUNJh8IzpAVa6y43S+aa1loLVLilN7xnBTwQP2R41+YNjLV oDzx+0A+ue0oX31swkAXkfAHIiSfeBDik3pe9WZFXIegEWTVJX+h62/nB0CZYDY3fc6wfwgme jUrcS82jPARrOdhlywIxIR2e+yiQW0FiuRAGq8JItx0n0tTEucpy4LF/qzEYoDh5129IT44uM R/1JtdnF1IG6kj0UMiIGkVILWhxSEyIpni1nz1B2e51aNQ1l4s8WTfzK8qX+111H+Fw/lKVcB Bbks4otnlo62lLortrpxS3ryLQU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ulrich Mueller writes: > No, it is the "argument of latitude" (and yes, the nomenclature is > slighly confusing). Its value is 0=C2=B0 for the ascending node, which is > what we want. > > https://en.wikipedia.org/wiki/Argument_of_latitude > | It is the sum of the more commonly used true anomaly and argument > | of periapsis. Thank you very much. So "argument" is like the argument of a complex number, and this one correlates with the latitude, or something like that. Hmm, I think adding some small comments to the code would not harm, you seem to understand it. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 08:03:47 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 13:03:48 +0000 Received: from localhost ([127.0.0.1]:47940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRYUl-0000gJ-MG for submit@debbugs.gnu.org; Mon, 13 Feb 2023 08:03:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRYUh-0000g3-6e for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 08:03:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRYUb-0002T5-Hb; Mon, 13 Feb 2023 08:03:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=hp498eAK2IKQs2ogEI0glEkicdzUSRaQ432s16thNY4=; b=eZdcOGktM5T01W+vjGkO vrJIZtzIHIgGjpVKVCbO7Ke80gdxMRRQmcJvbxRIM8Xe8AVPB8oVtCBWZ0AfPgweM8G70HVIAAlDy v0awY9J9WRF8JfhoomkbCQG9L/4Z1Kd4fLgjzwY+Dwp7b1TEDkYy71ioazNigIb+yyD0RpERFw27t 1E6MZkmPDQUcL1R6BOyHOKFrSFEvvjuqJC6HQc/bsKlXgzigv0CtTStNip1H5U3XfJz48Y2PQJIyN swGaE2E6AxHwl9RjJcgN9v/D/pa3bs6lwOGi9j0NJlFVvgmchetWEmkKk0Pw5dnoVrI2kuZCa7X7H 0ishQqdvQZOk/w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRYUb-00056A-0p; Mon, 13 Feb 2023 08:03:37 -0500 Date: Mon, 13 Feb 2023 15:03:13 +0200 Message-Id: <83ilg5g1ke.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87ilg5ank1.fsf@web.de> (message from Michael Heerdegen on Mon, 13 Feb 2023 11:04:46 +0100) Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <87ilg5ank1.fsf@web.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: ulm@gentoo.org, 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 61460@debbugs.gnu.org > From: Michael Heerdegen > Date: Mon, 13 Feb 2023 11:04:46 +0100 > > Ulrich Mueller writes: > > > No, it is the "argument of latitude" (and yes, the nomenclature is > > slighly confusing). Its value is 0° for the ascending node, which is > > what we want. > > > > https://en.wikipedia.org/wiki/Argument_of_latitude > > | It is the sum of the more commonly used true anomaly and argument > > | of periapsis. > > Thank you very much. So "argument" is like the argument of a complex > number, and this one correlates with the latitude, or something like > that. Hmm, I think adding some small comments to the code would not > harm, you seem to understand it. Yes, please add such comments there, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 08:31:13 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 13:31:13 +0000 Received: from localhost ([127.0.0.1]:47991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRYvJ-0001TQ-Ex for submit@debbugs.gnu.org; Mon, 13 Feb 2023 08:31:13 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:35266 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRYvF-0001T5-B7 for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 08:31:11 -0500 From: Ulrich Mueller To: Eli Zaretskii Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <83ilg5g1ke.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 13 Feb 2023 15:03:13 +0200") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <87ilg5ank1.fsf@web.de> <83ilg5g1ke.fsf@gnu.org> Date: Mon, 13 Feb 2023 14:30:59 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: Michael Heerdegen , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> Thank you very much. So "argument" is like the argument of a complex >> number, and this one correlates with the latitude, or something like >> that. I wondered about the term too, but it appears to be very old. It can be found with its modern definition already in "The Equatorie of the Planetis" from 1393 [1]: "=C3=9Ee argument of latitude is =C3=BEe distaunce= of =C3=BEe mone from =C3=BEe hed of his dragoun =C3=BEat is in =C3=BEe eclipti= k lyne." (The "head of the dragon" is the ascending node.) [1] https://www.google.de/books/edition/The_Authorship_of_the_Equatorie_of_= the_P/eG3JBxlp0LEC?hl=3Dde&gbpv=3D1&dq=3D%22argument%20of%20latitude%22&pg= =3DPA235&printsec=3Dfrontcover >> Hmm, I think adding some small comments to the code would not harm, >> you seem to understand it. > Yes, please add such comments there, and thanks. This would require that I understand the code. :) I happen to have a copy of Dershowitz & Reingold "Calendrical Calculations" (3rd ed.). The calculations of the lunar orbit there (on pages 193-207) are well commented, but seem to be very different from those in lunar.el (for example, they contain corrections for the gravitational pull of Venus and Jupiter). So, I'll see what I can do, but please don't expect anything soon. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 13 09:05:57 2023 Received: (at 61460) by debbugs.gnu.org; 13 Feb 2023 14:05:57 +0000 Received: from localhost ([127.0.0.1]:48035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRZSu-0004q9-UP for submit@debbugs.gnu.org; Mon, 13 Feb 2023 09:05:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRZSr-0004ph-OW for 61460@debbugs.gnu.org; Mon, 13 Feb 2023 09:05:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRZSm-0006pR-C0; Mon, 13 Feb 2023 09:05:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YUi89yCJDjUXuDfVTijkcOO3km6QT38i16qbPmLBYrk=; b=UERhrIKYDMju 9BxO06oqWsadQT8jyz1RJv35O9uM3IBr8F6SyRtnCvxD/6XrOXrlNS4JzdX8/vLbGKqOMWYqRUmPK cY8RU/gv+z3AcMPAEwhsgC79GCQl711Gth7L2DmkxJV9KEQ8DyKO0Ur1myg6hb84Ue6dJvSvCxcw8 W9dsQvW3x+uMzdJG1YCmEH98aqraEl+kfSFfo9EDNCxsxxSWkH9T1mrJKp7DK0ewN0K8QhAcLtQl+ W793wnyv4ESkZyBn3Mo8o2LaT+MrZF5lPmjblYO66kjUAPPrfH3MKQVDaduUsJYXhLboWmYP1I4JN ZMd7qVJaCVkGZ+WJv4/JfQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRZSl-0005zF-Ka; Mon, 13 Feb 2023 09:05:47 -0500 Date: Mon, 13 Feb 2023 16:05:23 +0200 Message-Id: <837cwlfyos.fsf@gnu.org> From: Eli Zaretskii To: Ulrich Mueller In-Reply-To: (message from Ulrich Mueller on Mon, 13 Feb 2023 14:30:59 +0100) Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <87ilg5ank1.fsf@web.de> <83ilg5g1ke.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: michael_heerdegen@web.de, 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Mueller > Cc: Michael Heerdegen , 61460@debbugs.gnu.org > Date: Mon, 13 Feb 2023 14:30:59 +0100 > > > Yes, please add such comments there, and thanks. > > This would require that I understand the code. :) I happen to have a > copy of Dershowitz & Reingold "Calendrical Calculations" (3rd ed.). > The calculations of the lunar orbit there (on pages 193-207) are well > commented, but seem to be very different from those in lunar.el > (for example, they contain corrections for the gravitational pull of > Venus and Jupiter). > > So, I'll see what I can do, but please don't expect anything soon. The stuff you explained to Michael can already produce a few valuable comments, I think. Of course, more comprehensive comments will be welcome. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 00:31:02 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 05:31:02 +0000 Received: from localhost ([127.0.0.1]:52280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRnu9-0001Yf-QH for submit@debbugs.gnu.org; Tue, 14 Feb 2023 00:31:02 -0500 Received: from mout.web.de ([212.227.17.11]:38377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRnu7-0001YM-G8 for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 00:31:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676352635; bh=Yr3NsAdC6IxLYgmaensvh/mHpcADXGZKxmaC+TqGcsI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=txfXChy2XzrmRnG5PVa/2dVGMy3RY4fP+A5TAOY34LZCGaHklPCNWTEBWwNA49fcc 5y+YbXN/oGhnZ6r8RLynD3ZC7nVBnW5d2BRXTwzDFUhDDhOMeyKJV1nhrXIgIjbWh5 YrrlglpbFW7DS4q60eJoTlBwjpSvFIl9u2I4E2lhX/F6JrOeAcsp9LxV/OtMhkBXYK HRQdUAXh/g5a1W1mdN4IJAkiwqKD1TfpgZIwx1VT6dmj6N3GIMpsdusPqIGqkXqCFz MFl/EQcQWcDPl8DeIWRMteF1jGuD1MR1gGhClpDvircdsO3yX4ntXlWISQQR1EYsfB jCwU4GFq9tF4Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MxHU2-1odO663RhQ-00xPpG; Tue, 14 Feb 2023 06:30:34 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Mon, 13 Feb 2023 10:34:00 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> Date: Tue, 14 Feb 2023 06:30:33 +0100 Message-ID: <875yc4q0ee.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:nSqgKtoNFfm8PXjc/ALN+5umWI5q58yCY34E5WpVx4nw7qlrKD/ XKQbxiUUEqDzpKuW4rFoxa1OpP1kQYyT0s+oN/kpbbe8LyOLyn80vnaLLVimrw+0Fupiwgb HUClswZZaJ0lpgNaBJxzDKxzTH3VosGu7z1C7NBmt4HLJj7oZh7it16ikR/FA1ywI19i3fM vnGxPfZqrAgIYf/K05xvw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:1Zu/FzooGcQ=;I4h0wZqDWWMbDjpCdp0vBczHXem AVN2xupx5tM8wLf3FFuXRSYN/sldZiF3CueMKDxpWZnhFxtQxfUpv3LcRdEitb3iYM8r2eMiZ XXkStSFtoGhgMQsXHRay704Gtf54CisylM+jyNcNjsf9+CIvkyL5BW0ZKEn9c8ndkpQ0QwlCC J/C1ZGhym+ejODb9ZCjgwURVooXOBekJyULm5eTai5a6X/kDeOTHydltT0sHuE16AIp9pq9SD bNpNLCbw6KLsUmihXzgvI1p+frMvHJFYOod59fUT+k8pby2R84/EQ/JOnepbOmaHsFNX2xaKu 2Gm8DE81g2nlSENCYucdSGxuUMihbSxLLatnQGpv/2pPJWrVxG2v1QUfeTlMWeUX1DxO0w4jd N9xTm2QMHMeUf+Y0iOK/O426U6xNRaw8fV05l8Me0WjE8ia6r+9wUyiyD3c6bG/yY9rbxvDRa e7rzcuvsHmy3LPf9KnxIIPLjPZtWDIGLZDjgdqgDjrBUeD/TtgfGvrBFy8Oc672y8QDt7S15+ Tx9uXdm2QVorTR5E2QIgZpDfrQ6gKw4a4RAo4KmEeigkhgZOR0rU1T6p9IkIaKZt6ri3tLiBb CMtvTq58ZyFdDGWqqRoedrdvasy0ckOfswZrCLeiD943ctIHj1TX5qfCSb+hhsHGKmZi9GRyJ ptCCGC6pAxiq8xQHCmMz/vyMwkjROtDvPWz88o2PeqfGx5eeNNqsKopaIkf1gUmkptJpXuk6m CL0znVsKXHkHxKBgu9aFmv9NTDOA6rNTN24U66YLEzCYIzx/cGiBzmugtOk/fPda8q7No8shM i77NEnx/dB6hc5L2yppG1OyOd7mxuhI1E51BgmqqmCehzUizDstAbpHcGiELlQekPIfBVY0IV Fs6mWkTqtpoF8ySCj6DKQ2C2kK5MaWH8/sajxxuj3EfD2wqJueAE5/kaoR6FM2Asz22O3CQ3w N0oGbA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich Mueller writes: > https://en.wikipedia.org/wiki/Argument_of_latitude > | It is the sum of the more commonly used true anomaly and argument > | of periapsis. I did not find good discussions of the eclipse limits in the English Wikipedia version; I found good explanations in German however: https://de.wikipedia.org/wiki/Finsternis-Limit#Finsternis-Limite_bei_Sonnenfinsternissen https://de.wikipedia.org/wiki/Finsterniszyklus AFAIU you can indeed use similar values for lunar vs. solar eclipses. But in the case of the moon, we are then including penumbral lunar eclipses - in the total version see https://en.wikipedia.org/wiki/Total_penumbral_lunar_eclipse which are probably not really interesting (moon gets only a bit darker). The limits for an eclipse to happen are not really constant, but taking this into account is probably out of scope of the currently available code in lunar.el. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 02:59:43 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 07:59:43 +0000 Received: from localhost ([127.0.0.1]:52417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRqE2-0005nV-Pk for submit@debbugs.gnu.org; Tue, 14 Feb 2023 02:59:43 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:52938 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRqE1-0005nG-0o for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 02:59:41 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <875yc4q0ee.fsf@web.de> (Michael Heerdegen's message of "Tue, 14 Feb 2023 06:30:33 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> Date: Tue, 14 Feb 2023 08:59:29 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org, Nicholas Strauss X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Tue, 14 Feb 2023, Michael Heerdegen wrote: > I did not find good discussions of the eclipse limits in the English > Wikipedia version; I found good explanations in German however: > https://de.wikipedia.org/wiki/Finsternis-Limit#Finsternis-Limite_bei_So= nnenfinsternissen Thanks. I followed the legend of the diagram and was pointed to the following page, which contains a more comprehensive explanation: https://www.swetzel.ch/astronomie/finster/finster.html#3 > The limits for an eclipse to happen are not really constant, but taking > this into account is probably out of scope of the currently available > code in lunar.el. I wonder why the angles in above explanation are completely different from the ones given in eclipse-check: ((< moon-lat 2.42600766e-1) (concat "** " phase-name " Eclipse **")) ((< moon-lat 0.37) (concat "** " phase-name " Eclipse possible **")) These are in radians. The first angle is 13.9=C2=B0 (exactly) and the second one is 21.2=C2=B0. They are in argument of latitude, while (IIUC) the angles in "Finsternis-Limit" are given in ecliptic longitude. Still, with the moon's orbital inclination being only 5=C2=B0, one wouldn't expect much of a difference there. Or am I missing something? I've also found the book mentioned in lunar.el: https://books.google.de/books?id=3DvVBPtkABpUoC&lpg=3DPA186&vq=3Declipse&hl= =3Dde&pg=3DPA177#v=3Donepage&q&f=3Dfalse CCing Nicholas Strauss (who had originally submitted the code in bug #20414). From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 04:16:29 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 09:16:29 +0000 Received: from localhost ([127.0.0.1]:52549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRrQL-0007ty-CJ for submit@debbugs.gnu.org; Tue, 14 Feb 2023 04:16:29 -0500 Received: from mout.web.de ([217.72.192.78]:58883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRrQK-0007tm-53 for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 04:16:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676366162; bh=Fl3lEmdrjYQGEyuVy5/Jq+VSg1ojUXWP5EyGDo69730=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=sBCNQdQflbqpaqtZm8RiLY4K9BaHnDAEbFDCx1TQ+dDajZkOGFlx/BPJm+49r3sXV ejUXjcSkeBAxWoxz3DkV52H575KMAQcRFtlSGkAhGiS8K6s3HXOoAWcoAeyO4CS9K4 HPbs0L7xnwqoMxUM3ALBj+/5paPH+Dr7O2B8a6fW1X+j3kni1lI3grAG7jhrCgKOsG 3UnzoaTbD1hwnBvUxMuD48GSvz+7aBHvsOUn7sw+/Ce7GdtQ7c8m+y3ZZt6UnBTU0B HAPIGOwYQPttYCrq4BuaL/Ur0DNe02kj0G2Q7NkvWZqrkFGNxQkNgKVBpoYb8aMNnW dnjB3WBxEVMtA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MW9vU-1p34TQ1hO6-00XdwX; Tue, 14 Feb 2023 10:16:02 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Tue, 14 Feb 2023 08:59:29 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> Date: Tue, 14 Feb 2023 10:15:59 +0100 Message-ID: <87y1p0obe8.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:uauGCbogNQODG/V/K1WcrGX2fEvvCEv+45cl2kk3CesN+RuiIS2 gCDjO6a+V1jzv/rcUn4wKudxjab/ZCi/y+lDQts9BYzvO6lEBFdPpyaQiOjOMhK5vdX4aSE /CF1WDlpRw7CYy1BDg8PkpP51OcXEG/IBX86iD7ckr5j9+mhn9CUQTzqqi9DG9B+kqSd93v mVj2PR+Y3Y/ZWDZdU5saQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:MprTPD/80jM=;JOVrlfvEqfTVPtZZP2xTmUK2HVW hojMboFiIMJXmqatfczOIdP3dBfk3RpXC7LC1oOfwWklSzYS2AfhvYuPBAXFOmBDX6o/uqNRz MPVypz0N0kqmjyTPZqbtcq3FGpTNQJOV2g5ZlZLamQlsy4Zj0XTiYLmta78FlZLmXUu6Nr7Lv UcM5msc6jyo7jWqPjlIv8+ZNUbs2CBDRrFFRWqDG2QxRmCo/yaE430TzdbMCOcwJzxeJ3LTaa fjjYdWaCv9TQkoBUw+MZlZDrRvJSKHuL+2xdlJGMo0kNdgXNiDFqejCPY/9S5lz8DzXuqoPa0 pEVuNwSPKI2pJwkpSIKupDnuqAAsv4mvRY1xOsIz8znWG6NgP4wcSrxeZ7CXOAJJXb2kZUroR HiPy7l4rEEg8n4egXadoeT/X3YQ+8a/37+43gAoVfOm/qCa7ERetdAPOQVcoPlgWkW08QU2TX Cjfq3Mwc0ux6Ukk324GsVeQMe3hb9AkDlwmPdn3CbQ85fj4T3aunG0RTY7G+VXKrZWcxwwB3P XN+gKpb5e8UwiXKWNF7HkLfcFlv4PMUTeKIwDyZ0z2OP4BiYraqicEmCbABBW+tGzsvOAIp69 ljsH1G4kT8FLngMu252MauAMrZFCVPGN48jIE0GCKo6436ut3EM8xSRv5MRiK8dchcOmQw5lI whA2ms4x7dfwXqk077jRN0NWsk7Skysw4la4Iq1H47eVICQlEkJubRTZJCuchbJi6MN15BWID 41OFbvpyaQoYKu98JXrgCVc09WAglvyivJPfi+z49Ts/R8cD7NQ/5M9Q7Y+pxhMevAE/HR+x5 2/S9QDNc6PTqLuPjpNzSJqfZ9e9efQE+mXfrQJFx2J2tZ9NgX3myY2bPrqymuBZUXgKLecjK1 5x5xBsKBqbsDtXRU5DfSS64JAxTGVpKM/5+7ChGYhpZmAHyzaHH9Qp38VgIwtlWsrkYD1X3nw dR/HqUFOS/JHiB59SuJYqgoz5M4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org, Nicholas Strauss X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ulrich Mueller writes: > I wonder why the angles in above explanation are completely different > from the ones given in eclipse-check: > > ((< moon-lat 2.42600766e-1) > (concat "** " phase-name " Eclipse **")) > ((< moon-lat 0.37) > (concat "** " phase-name " Eclipse possible **")) > > These are in radians. The first angle is 13.9=C2=B0 (exactly) and the > second one is 21.2=C2=B0. They are in argument of latitude, while (IIUC) > the angles in "Finsternis-Limit" are given in ecliptic longitude. > Still, with the moon's orbital inclination being only 5=C2=B0, one wouldn= 't > expect much of a difference there. Or am I missing something? Indeed, I wondered too about those numbers (also a bit about the format and the number of digits) and don't have an explanation. AFAIU (rectangular spherical triangle) we should have something like tan =F0=9D=9A=ABu =3D tan =F0=9D=9A=AB=CE=BB / cos i [did I get it right?] (with u: argument of latitude, =CE=BB: ecliptic longitude, =F0=9D=9A=AB mea= ning distance from lunar node, i inclination (~ 5 degrees)). The conversion does not make much of a difference. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 05:23:19 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 10:23:19 +0000 Received: from localhost ([127.0.0.1]:52639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRsSx-0001IK-9S for submit@debbugs.gnu.org; Tue, 14 Feb 2023 05:23:19 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:40656 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRsSp-0001HS-6r for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 05:23:14 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: 61460@debbugs.gnu.org Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> Date: Tue, 14 Feb 2023 11:22:56 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Next round: The following simplifies the calculation and IMHO makes it much easier to understand. Results are identical, and tests pass. Alternatively, we could leave the result in degrees (as all other calculations in lunar.el are in degrees) and change the values in the final cond to 13.9 and 21.2 degrees. This would also get rid of the excessive number of digits. >From 32609db770004aa787c05753a1f90fe906c07c60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Tue, 14 Feb 2023 11:12:29 +0100 Subject: [PATCH] ; Simplify eclipse calculation in calendar/lunar.el * lisp/calendar/lunar.el (eclipse-check): Calculate moon-lat in degrees, then convert to radians. --- lisp/calendar/lunar.el | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 8ced4144105..ec31ea596ea 100644 --- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -155,14 +155,11 @@ remainder mod 4 gives the phase: 0 new moon, 1 first quarter, 2 full moon, ;; from "Astronomy with your Personal Computer", Subroutine Eclipse ;; Line 7000 Peter Duffett-Smith Cambridge University Press 1990 (defun eclipse-check (moon-lat phase) - (let* ((moon-lat (* (/ float-pi 180) moon-lat)) - ;; For positions near the ascending or descending node, - ;; calculate the absolute angular distance from that node. - (moon-lat (abs (- moon-lat (* (floor (/ moon-lat float-pi)) - float-pi)))) - (moon-lat (if (> moon-lat 0.37) ; FIXME (* 0.5 float-pi) - (- float-pi moon-lat) - moon-lat)) + (let* ((moon-lat (mod moon-lat 180)) + ;; Calculate the absolute angular distance from the ascending + ;; or descending node, whichever is nearer. + (moon-lat (min moon-lat (- 180 moon-lat))) + (moon-lat (degrees-to-radians moon-lat)) (phase-name (cond ((= phase 0) "Solar") ((= phase 2) "Lunar") (t "")))) -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 05:49:41 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 10:49:41 +0000 Received: from localhost ([127.0.0.1]:52683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRssX-00025e-Bn for submit@debbugs.gnu.org; Tue, 14 Feb 2023 05:49:41 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:42862 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRssV-00025N-Dk for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 05:49:40 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87y1p0obe8.fsf@web.de> (Michael Heerdegen's message of "Tue, 14 Feb 2023 10:15:59 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> Date: Tue, 14 Feb 2023 11:49:27 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org, Nicholas Strauss X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Tue, 14 Feb 2023, Michael Heerdegen wrote: > AFAIU (rectangular spherical triangle) we should have something like > tan =F0=9D=9A=ABu =3D tan =F0=9D=9A=AB=CE=BB / cos i [did I get it righ= t?] > (with u: argument of latitude, =CE=BB: ecliptic longitude, =F0=9D=9A=AB m= eaning distance > from lunar node, i inclination (~ 5 degrees)). The conversion does not > make much of a difference. I think this is correct. With cos i =3D 0.996, taking =CE=BB or u makes little difference. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 05:57:17 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 10:57:17 +0000 Received: from localhost ([127.0.0.1]:52697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRszs-0002Im-Tr for submit@debbugs.gnu.org; Tue, 14 Feb 2023 05:57:17 -0500 Received: from mout.web.de ([212.227.17.11]:52501) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRszr-0002IY-6I for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 05:57:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676372219; bh=q7RwmBshbSIzGAFDB1enFVYuwkmOWm5HXkQhjvgVLz8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=FOEtOafTVKrpKYJc29EA3wKAPfq1jnIOx6CprLToFh5QfNXxjOnAvr/nA1DzOG5sy P99kWeMbCZdccFJ2J3V47ubc/olErnFSceov8FGpwo1NWhFR7wuT2j0qY0QRE7RHel I6DCI5o/JPEjd7T6rkHcekp4woMWb4dWj6hvS2QwhtBLirY/f1n8oFJ3xd94sqn8JR 2r0Ixb9i2xOo8oU5jpb1ysNlNY2Mbeu96uUEAl0hsP6UCzFP72FkCRtYsGFElpODWe 15geva2JKRGJi08jCxhmX2imgqf98OewnMIJ3gQnQGiRoiaw+CLCTKornnQ1VjqSIM ynfCdatVC7K1g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N8Epu-1oWjxD0ioa-014E1H; Tue, 14 Feb 2023 11:56:59 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Tue, 14 Feb 2023 11:22:56 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> Date: Tue, 14 Feb 2023 11:56:58 +0100 Message-ID: <87ttzoo6px.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:gUroPRIo9uTQg04CsVxmVnezDEeMDSMeAohAApRLZFchB2MKQTr FtMetuxyKmKdPtQt6EbbW798nDalY2dXpMTrP0H0GQoOJLphvEtlcapmvEQZ8TKPHQJytIw gUmu274vQPDhy22FSmcpmLEdxzGrEL5BPrjNHJ6VvqZP5rMLamz/HxG6Cx0A5UyezeenoPG cd7Nsup3J3MgLyFhMAQIg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/IRvhSPbfSU=;jpTuHzdrd5Jw2+WeSA71ZrP1xKA Bs1U8L30x9MJk5Fy3DiW1chhne9jZ2YqOzzCgfmGtU2t6qZCJMRCahJiDOR0nHz1V+B6i6RTI MkdC5C0zAVc44PlHkzIR9fNeJoDXTnBvJ50beEmyVYzcfALXc73cbTvedm5ASRX+WK1Dh9pIr ClUxaM1LOqRKWxDnMqTZUFPNU7c6WLJmkORjQgHVVqEEI34WG1dxAALcAtCBMUaVylL+tWewE tj5Td6ioXOW8e8lRitwa2Z7QsX/4aFsH3r4gNELi91IBd04+TqhIniGADtuE5q3ZAw+fi6alv zKHb7GMsqK772PldgOBMUlK4guPPCMztlOR73aSXKiVmzVubaitA/s7R4DwPPQR850wZlxAAt 9o5EpLuv+CaNzRnNm3s1hL7esNP4j9mqJsnztBpty/SmAsweUZlwpgXFdcLYqKikuifMdHBVI 2PxVwWqcghLnefwE0BhOsTb0abiqOvCl0bQbnDlYKkhdwiAv7ba18c+zVSWitgmw8Q9rLCa3O DLU3su2Mk6GKScM03DdE5dCI4g9bloe5mrAy83BuBN/yFoq6CtJugKIblR7igP4qXcMpPrhIe cF/lUIFy9vm1UAo3on0stjpHN/xJPk1eBO9uFgezTzjTkVZDqbnzv5s3/1N3YWIP/S9hO3CSx h++p1Hl3hSLQO5DlKbS/Qyp6Xnd21kHAolAm2RH4JpevbHvWBoxg5NhT3Wu/EtUB1bD+nK7XT 968NiCSzatbYhQDF5F6R2+5rQ8VuErtsfOsenB/Pvcom5q82VQE5VncdORlB9E0Dmmh0BYWMv fFuH/f4Lifwzo7C5L/XG27SE7lZgKeuSWSNTQ2UAFWp7VvdP0CZ1drJniutO78HLnYf0F4gS+ RUt6LKMwzS91IYFXn6q9Gm5B68nIQkSsFN3W60RbKDOR2+56h5A5Smpo3aYLXHQp6zuneqIJj +sKrEg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich M=C3=BCller writes: > Next round: The following simplifies the calculation and IMHO makes it > much easier to understand. Results are identical, and tests pass. Yes, thanks. I want to suggest to get rid of the successive rebinding to the variable `moon-lat' and use a different name (`node-distance' maybe?) since that calculation is not just a simple conversion of units. > Alternatively, we could leave the result in degrees (as all other > calculations in lunar.el are in degrees) and change the values in the > final cond to 13.9 and 21.2 degrees. This would also get rid of the > excessive number of digits. Good idea. The conversion to radians is a bit artificial and not really useful, just harder to read. Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 08:31:48 2023 Received: (at 61460) by debbugs.gnu.org; 14 Feb 2023 13:31:48 +0000 Received: from localhost ([127.0.0.1]:52900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRvPQ-0000oU-78 for submit@debbugs.gnu.org; Tue, 14 Feb 2023 08:31:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRvPO-0000oH-EN for 61460@debbugs.gnu.org; Tue, 14 Feb 2023 08:31:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvPD-0003Xj-GH; Tue, 14 Feb 2023 08:31:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=a48gj13Ua6wNrmDIoxVGDEdijJrgStOPI83RisbmpVQ=; b=G6QQUvyj2Cdvd1xshRvn mphA2PgKlvyvzmzpBJZzo+25DNyfaPy5vTTQWG2zr9Dr+tVjM1x2YCeFMISMEJZB8tbTLMsT+09Ol v0H4SsF6+d8ECZ0iYgIeF+gn/6s2ZHAYGX1o3ZV1HnsCkZEFvk7cUf8Y4OJN3TUnOGXRS7syJ7hty WFJicVuKuXcKrreQs8PXXQT3VTuy0PI/+O/JollMscl9dVe/qCHquTPDpNOAFkGO5jB5XsJSxoCCj AmYEiHi6uQ/O0UBgtqo2br0kXpBgtA61t8qpXxf41DzoDV6f5af2sCPCtmhTx19PO9tbXIDh5dU3a QnlpE812+NZ4EA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRvPC-0006oI-VO; Tue, 14 Feb 2023 08:31:35 -0500 Date: Tue, 14 Feb 2023 15:31:14 +0200 Message-Id: <83zg9gcr19.fsf@gnu.org> From: Eli Zaretskii To: Ulrich =?iso-8859-1?Q?M=FCller?= In-Reply-To: (message from Ulrich =?iso-8859-1?Q?M?= =?iso-8859-1?Q?=FCller?= on Tue, 14 Feb 2023 11:22:56 +0100) Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Müller > Date: Tue, 14 Feb 2023 11:22:56 +0100 > > Next round: The following simplifies the calculation and IMHO makes it > much easier to understand. Results are identical, and tests pass. If these are just simplifications, please install on master, not on emacs-29. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 16 15:26:39 2023 Received: (at 61460) by debbugs.gnu.org; 16 Feb 2023 20:26:39 +0000 Received: from localhost ([127.0.0.1]:37742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSkpz-0006Vj-DK for submit@debbugs.gnu.org; Thu, 16 Feb 2023 15:26:39 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:38100 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSkpx-0006VT-DM for 61460@debbugs.gnu.org; Thu, 16 Feb 2023 15:26:38 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87ttzoo6px.fsf@web.de> (Michael Heerdegen's message of "Tue, 14 Feb 2023 11:56:58 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> Date: Thu, 16 Feb 2023 21:26:24 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Tue, 14 Feb 2023, Michael Heerdegen wrote: >> Next round: The following simplifies the calculation and IMHO makes >> it much easier to understand. Results are identical, and tests pass. > Yes, thanks. I want to suggest to get rid of the successive rebinding > to the variable `moon-lat' and use a different name (`node-distance' > maybe?) since that calculation is not just a simple conversion of units. >> Alternatively, we could leave the result in degrees (as all other >> calculations in lunar.el are in degrees) and change the values in the >> final cond to 13.9 and 21.2 degrees. This would also get rid of the >> excessive number of digits. > Good idea. The conversion to radians is a bit artificial and not really > useful, just harder to read. Pushed to master, including your suggestion (I went for "node-dist"). I think the last open question is what values we should use as limits for "certain" and "possible" eclipses? A calculation of these limits can be found here (complete text on Google Books): William Chauvenet, "A manual of spherical and practical astronomy", Vol. I, Lippincott & Co., London, 1863. On page 439: "a solar eclipse is certain if at new moon =CE=B2 < 1=C2=B023'= 15", impossible if =CE=B2 > 1=C2=B034'53", and doubtful between these limits." And on page 543: "a lunar eclipse is certain if at full moon =CE=B2 < 52'4", impossible if =CE=B2 > 63'53", and doubtful between these limits." These limits are given in terms of ecliptic latitude =CE=B2, which can be converted to the argument of latitude u using the same spherical triangle as above (in message #68): sin =CE=94u =3D sin =CE=B2 / sin i Using the minimum and maximum values of the lunar orbit's inclination i_min =3D 4=C2=B057'2" and i_max =3D 5=C2=B020'6" (see table on page 438), = I get the following limits for =CE=94u: Solar eclipse certain: =CE=94u < 15.10=C2=B0 Solar eclipse possible: =CE=94u < 18.65=C2=B0 Lunar eclipse certain: =CE=94u < 9.37=C2=B0 Solar eclipse possible: =CE=94u < 12.43=C2=B0 (These are close to the values given by Peter Duffet-Smith, "Practical astronomy with your calculator", 3rd ed., Cambridge University Press, 1991, page 156: Solar eclipse certain: 15=C2=B031', possible: 18=C2=B031'; = lunar eclipse certain: 9=C2=B030', possible: 12=C2=B015'.) However, if I put these limits into the comparisons in eclipse-check, then it misses the partial lunar eclipse on 2023-10-28 (I haven't checked any others, but if it is wrong in this year, then it is probably wrong in more cases). I suspect that the calculations in lunar-phase are not precise enough. Also, I believe that I have found the source of the current limits: Jean Meeus, "Astronomical algorithms", 1st ed., Willmann-Bell, Richmond, VA, 1991. This happens to be one of the references mentioned in the header of lunar.el, therefore the limits are likely to be consistent with the precision of the other calculations. On page 350 it says: "If F [the argument of latitude] differs from the nearest multiple of 180=C2=B0 by less than 13=C2=B0.9, then there is certai= nly an eclipse; if the difference is larger than 21=C2=B0.0, there is no eclipse; between these two values, the eclipse is uncertain at this stage and the case must be examined further." tl;dr I suggest that we leave the values as-is, except for a small adjustment from 21.2 to 21.0, as in the patch included below. If there aren't any nobjections, I'm going to push this to master. @Michael: Can this bug be closed then? >From 431c60084dade55acd0d407fff1cdfb2352a3d91 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Ulrich=3D20M=3DC3=3DBCller?=3D Date: Thu, 16 Feb 2023 20:09:22 +0100 Subject: [PATCH] ; * lisp/calendar/lunar.el (eclipse-check): Adjust upper limit. --- lisp/calendar/lunar.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 1f827ca34b0..8fb5c89c057 100644 --- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -164,8 +164,9 @@ remainder mod 4 gives the phase: 0 new moon, 1 first qu= arter, 2 full moon, (t "")))) (cond ((string=3D phase-name "") "") + ;; Limits 13.9=C2=B0 and 21.0=C2=B0 from Meeus (1991), page 350. ((< node-dist 13.9) (concat "** " phase-name " Eclipse **")) - ((< node-dist 21.2) (concat "** " phase-name " Eclipse possible **")) + ((< node-dist 21.0) (concat "** " phase-name " Eclipse possible **")) (t "")))) =20 (defconst lunar-cycles-per-year 12.3685 ; 365.25/29.530588853 --=20 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 00:26:14 2023 Received: (at 61460) by debbugs.gnu.org; 17 Feb 2023 05:26:15 +0000 Received: from localhost ([127.0.0.1]:38220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pStGA-0007fM-K7 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 00:26:14 -0500 Received: from mout.web.de ([212.227.17.11]:57055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pStG8-0007f5-2q for 61460@debbugs.gnu.org; Fri, 17 Feb 2023 00:26:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676611552; i=michael_heerdegen@web.de; bh=V9tDvS4qPr1dtBw1oKSKZVyIzBJh1g9iOWjEjdkwMcE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=IcUwC5vGx/heP6cYeGS1CX79R8a9fe35bu3jKZUX3RouDmaqFo0SqRIXQbKf1f6Mv qAg4IxRyYc0MiWoN3xbUj5oFYsgnQbS/sAXXvGnPJk9gETsvEmpHmGVcdMCPzzAuf4 +9z+bGfz3c9OnOnnME05S7l1qXugASmPbULdt2viqqWaus7/1evdr4ogmN04mfyeHe V+fHANoS66LSg9rhU7tQdwip/Cpk/sP/3CcEdPtKh/LulrCU062pr9nFazG7m992d3 RPhtdGI8jf2yJQ/lBTZ9YmrlKEzWLYCYBvEgPsOclZ0m/c8uZvPCVuH4MMtEzm6D0T tsEmvnFDjmzMQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N947J-1oW1Ch0SEZ-015yVI; Fri, 17 Feb 2023 06:25:52 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Thu, 16 Feb 2023 21:26:24 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> Date: Fri, 17 Feb 2023 06:25:50 +0100 Message-ID: <87pma8q2w1.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:OUoj21DKiU63s+rq8oalN8gC9xdv97K3EdeW6XCEqJxiD22rpcp DOxGCLB5JuJq6/wONCbHBgkbmF73gA6s5STx9QZBkNK4IW318kmS6jXZjDjSLHIRb8lFgBw hv1H675rPq5kFStBWRVyyLTweOEpRgmJLKW2CsyBqbnDq02po4GiIKx7/VdkKjHfLh5plvI ovC6Aonsi6uW4OQ7iuJ6A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:E8uE1gGsBCw=;Tf7xgo4y+K+Dk6822kbfaKfyDZ9 wXpemtElMBCFXUeML7NmDcgnoDyg6065vvOiEhHZpBXzL8MoIRlRzwCTkOPP3gGlJFGXyKmgP pduTbtPb+dxRGxlzhtNHqPhIaHBhmRvzPBVwiywG7jxUDMjyigt91tqh+i1LzL7VuskmRyaV1 wt4S3vhyVAPyPCOUoRByT3lLY07perTb4zyze+NcIsOT3tNPdKvTyAYQMRgpsbCJwZYTTA75k 3IQkN/W7MlXYaHucnLkYDRqjuQySw2vTErefRLK7fy0fCr8dp9BOQIDQOILI/Cd1I6ligYbNp 28123nFmKeBJfqFzObAB21touHg61xSdHJoUeYeAybeZrJF3t4n2MRTyjPVIwOR8Yl9+ejUfd 8B7JKJZhNWJJikCxgZlAk57hXIw6Zva3jTLRdwlFMlkhv+cQZdwG5bayxaxgZezVaUwwvv6sy cFNhwkWxZgl/pkGgbQqY27+kFUvAmp74ngrbhFPLLZyfvAtKlJxK709rXfSh9MzDhiOikON2t JKt5qPoHai/nAQk556Mk1kUbj6ZyOU5cKyxE0ZTBjOepvjpN0H0Y8mEm+n1DxAYsLY99B7ZW9 bto5AliHA9E1YMLGodAD8YzSL5FVWS9T5vuKLSTruV/MAXLjkIX72GnaKrITl/0/hJq0pW1XG RGQWKuaMoqmN2uYaaitCIG9RrV17ym8cYW/rvUmNqBbxzvt9VR6FZR9wjjR8EYqsgolWhPSdE 6KkOOz3VvwpD4qQQqGroTu+MJmPQIjtBhm5K9YS68wGQntZw99kZZvL76WhoNq3w5KPdi5KnU 7t5TRnyZeB97Vx24momlLVr5NeUfayc7O9S8eaoo8ZPRSOeWh6BoOu/4BZgq8XQ9hzUWTuvP9 GNWXA/JdbxRO6p7xds7/lmvxBasL3uiRGtCEslUDV2CsGGOsyUgAE18qmnNoE8rRi5SDdaeIL HVGbqAPCKsOMHhwLkS2aTEClx28= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ulrich M=C3=BCller writes: > Pushed to master, including your suggestion (I went for "node-dist"). Thank you very much. > [...] > tl;dr I suggest that we leave the values as-is, except for a small > adjustment from 21.2 to 21.0, as in the patch included below. If there > aren't any nobjections, I'm going to push this to master. Fine by me. > @Michael: Can this bug be closed then? I have some more cosmetic changes: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lun.diff Content-Transfer-Encoding: quoted-printable diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 1f827ca34b0..ebf9abc9d60 100644 =2D-- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -94,7 +94,7 @@ lunar-phase (* -0.0016528 time time) (* -0.00000239 time time time)) 360.0)) - (eclipse (eclipse-check moon-lat phase)) + (eclipse (lunar-check-for-eclipse moon-lat phase)) (adjustment (if (memq phase '(0 2)) (+ (* (- 0.1734 (* 0.000393 time)) @@ -154,18 +154,18 @@ lunar-phase ;; from "Astronomy with your Personal Computer", Subroutine Eclipse ;; Line 7000 Peter Duffett-Smith Cambridge University Press 1990 -(defun eclipse-check (moon-lat phase) - (let* ((node-dist (mod moon-lat 180)) - ;; Absolute angular distance from the ascending or descending - ;; node, whichever is nearer. - (node-dist (min node-dist (- 180 node-dist))) - (phase-name (cond ((=3D phase 0) "Solar") - ((=3D phase 2) "Lunar") - (t "")))) +(defun lunar-check-for-eclipse (moon-lat phase) + (let ((type (cond ((=3D phase 0) "Solar") + ((=3D phase 2) "Lunar") + (t nil))) + ;; Absolute angular distance from the ascending or descending + ;; node, whichever is nearer. + (node-dist (funcall (lambda (x) (min x (- 180 x))) + (mod moon-lat 180)))) (cond - ((string=3D phase-name "") "") - ((< node-dist 13.9) (concat "** " phase-name " Eclipse **")) - ((< node-dist 21.2) (concat "** " phase-name " Eclipse possible **")= ) + ((not type) "") + ((< node-dist 13.9) (concat "** " type " Eclipse **")) + ((< node-dist 21.2) (concat "** " type " Eclipse possible **")) (t "")))) (defconst lunar-cycles-per-year 12.3685 ; 365.25/29.530588853 --=-=-= Content-Type: text/plain In particular, the name of the global function should start with "lunar-". Does that look ok? Thanks, Michael --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 02:04:03 2023 Received: (at 61460) by debbugs.gnu.org; 17 Feb 2023 07:04:03 +0000 Received: from localhost ([127.0.0.1]:38322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSumo-0002C8-Vl for submit@debbugs.gnu.org; Fri, 17 Feb 2023 02:04:03 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:39678 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSumn-0002BW-2y for 61460@debbugs.gnu.org; Fri, 17 Feb 2023 02:04:02 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87pma8q2w1.fsf@web.de> (Michael Heerdegen's message of "Fri, 17 Feb 2023 06:25:50 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> Date: Fri, 17 Feb 2023 08:03:47 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Fri, 17 Feb 2023, Michael Heerdegen wrote: > I have some more cosmetic changes: > [...] > (node-dist (funcall (lambda (x) (min x (- 180 x))) > (mod moon-lat 180)))) I didn't go for this one, because IMHO it is too clever and would worsen readability of the code. (Also, there is precedent for successive rebinding in function lunar-phase.) > In particular, the name of the global function should start with > "lunar-". Does that look ok? Thank you. Updated patch below. >From 4a3abeac5c6614c9b0b346767627f978b2dd138a Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?Ulrich=3D20M=3DC3=3DBCller?=3D Date: Thu, 16 Feb 2023 20:09:22 +0100 Subject: [PATCH] ; Adjust limit for eclipse in calendar/lunar.el, rename function * lisp/calendar/lunar.el (lunar-check-for-eclipse): Renamed from 'eclipse-check'; thanks to Michael Heerdegen for the suggestion. Slightly adjust the upper limit for the distance from the node to the value found in literature. (bug#61460) --- lisp/calendar/lunar.el | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 1f827ca34b0..fe8129ec511 100644 --- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -94,7 +94,7 @@ remainder mod 4 gives the phase: 0 new moon, 1 first quar= ter, 2 full moon, (* -0.0016528 time time) (* -0.00000239 time time time)) 360.0)) - (eclipse (eclipse-check moon-lat phase)) + (eclipse (lunar-check-for-eclipse moon-lat phase)) (adjustment (if (memq phase '(0 2)) (+ (* (- 0.1734 (* 0.000393 time)) @@ -154,19 +154,18 @@ remainder mod 4 gives the phase: 0 new moon, 1 first = quarter, 2 full moon, =20 ;; from "Astronomy with your Personal Computer", Subroutine Eclipse ;; Line 7000 Peter Duffett-Smith Cambridge University Press 1990 -(defun eclipse-check (moon-lat phase) +(defun lunar-check-for-eclipse (moon-lat phase) (let* ((node-dist (mod moon-lat 180)) ;; Absolute angular distance from the ascending or descending ;; node, whichever is nearer. (node-dist (min node-dist (- 180 node-dist))) - (phase-name (cond ((=3D phase 0) "Solar") - ((=3D phase 2) "Lunar") - (t "")))) - (cond - ((string=3D phase-name "") "") - ((< node-dist 13.9) (concat "** " phase-name " Eclipse **")) - ((< node-dist 21.2) (concat "** " phase-name " Eclipse possible **")) - (t "")))) + (type (cond ((=3D phase 0) "Solar") + ((=3D phase 2) "Lunar")))) + (cond ((not type) "") + ;; Limits 13.9=C2=B0 and 21.0=C2=B0 from Meeus (1991), page 350. + ((< node-dist 13.9) (concat "** " type " Eclipse **")) + ((< node-dist 21.0) (concat "** " type " Eclipse possible **")) + (t "")))) =20 (defconst lunar-cycles-per-year 12.3685 ; 365.25/29.530588853 "Mean number of lunar cycles per 365.25 day year.") --=20 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 02:21:12 2023 Received: (at 61460) by debbugs.gnu.org; 17 Feb 2023 07:21:12 +0000 Received: from localhost ([127.0.0.1]:38333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSv3Q-0002ea-34 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 02:21:12 -0500 Received: from mout.web.de ([212.227.15.3]:35741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSv3M-0002eL-Ss for 61460@debbugs.gnu.org; Fri, 17 Feb 2023 02:21:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676618444; i=michael_heerdegen@web.de; bh=5BomryXGMPhjXKFW3IhgYsLJOUDxQnp7zNRGDYeTnIc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=TYPy0g/39hTGYlfWvFVY5RNHrheah55fA32uit7WMykv8NjUmsvNbCatZUikIuNrI KlQAgstCHtYVGPhgm/4MNZ5wNkVvd1fGoIDcu0vFRu18hgoM9aRCiUUAJTAtRrkoLo 4GaG2L0vbT9khQruCwXmgJGPASMoWkHqL7GoabxN5NuvsWvvZJKUUbEVxWeR1KdEcF 0uMycjPxCkPK3k625vX/DnJG+Q4UwzxnOM4gSSRiFfXj3h9f1NeaBTWumvr1cC0QQc Ziivlbc7DbOZShPHUIKkD58g4RvrpCzVIDJ0uZrMtF681mBIK2usZCEeVkkaAf7ZQs 691hXrO7fV8EQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Md6xz-1ot2471uZn-00aI5L; Fri, 17 Feb 2023 08:20:44 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Fri, 17 Feb 2023 08:03:47 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> Date: Fri, 17 Feb 2023 08:20:41 +0100 Message-ID: <87wn4g4v1y.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:g1sMdA7293Dryon8N73fxkbkeqZrjpR1yUPCS7hVBipQCM/VcQo YaLuqMYBuN5MG8yLTkNY1KrQIL35CYV6S9s8Fq4wLR19Cj3c8RI+Dy1C4kPxVEw3+bLBxcV gzBr1o9pzfe7iSWkOTkOmqPbsZSg0nWHrIrh7+gguwptd4hvKjrLAr+70KmYtaZPey76/he 1O7F6qihN6+r6dOKigEhg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fuxk/za4MZg=;LLAP5A+iaztESX8z+azByAzXpw+ 9DQlwNsQPAJcpI57lQzbO9wIkNTTc7KPcqkGXxPnE9znSzorrklq89MeDbE0ICuvZ/EViwfqL 5oKjBOc2NQHoT2NGXoCY+0ft84qpUUnRGHCpQb6baSTyrhnC2w+R/s9yTu0Bt/kNHQQIcH2xR Tm3P7kEtDGxwrkl8/Zq0o1hWqy5H0LRPSY7aJw6GlCHsG2UbNCN6X+2RMszuccQH+2SYhgwpR BxUzJWZFVlya7r8+eYKmH7bLyHwUVxYTL04sHnzUl7RELXgHSPolLJaoDWfXiUwZGR0Tq4/jg bg4UmEcSN5ikpivrYbQsMU+2Jb3W0AAbJZh3GITB2L9cLVX6faI8v529v7eA50Y9gdBxeLuba BS3bMJUGe2DOFMRjqHrADlsoyOQjVSY6iR1p0RXC9svC7RUeJqK19RKWp2K2GIN4cJVgmzSfL /l6kfEU3CNT0rL/zl8KJ6AaG++4k/K6EoR6N8oJSEuofDrdDgebMAKZq6i0G9WC6lJ3wlGaKm 8XhoJbFAKwNeCABJKduL3LEciYmtnn7C/bx4xWJ7kEf221aespxcv77ffaSfbWvF9lOAaivk3 QsGJRb1Hw0yTNUeODS8f8KOVq8CD2TKN831zZ1PGveLsAdjHhnvBIEDYvqbO7lgKoJtaYLS13 7/16S7kOt0XRPZ0+IEJ2JqC1w9MrqqPfqnvXIlPIFm+uLaJ5xO7X9Wj6WZ8fEdHLqsuHBI4MD 8Bpgz3+H3hTAPw/LidWmcXPr4Jj3I0ujX2CzsLvxytfIw3f4Q/eHZSqf2zSk2WdEXvGpZPq6m H1nGl06CIBSnhz6XyEFlansc06FjCyYKg9nkTp6nifZbTwG31FW6TmO0/SCxyiLKLBrDmd7BE W36Jahs30xq+GyDYRhLneJywdttejvTTImjYzvK3NndUOFYg0BCDvpaUBTTO1xbz8OGkTVayY 6DCf3T2AszY4Xjie0S0HtnvI9FU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ulrich M=C3=BCller writes: > Thank you. Updated patch below. Looks good to me, thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 17 16:36:45 2023 Received: (at control) by debbugs.gnu.org; 17 Feb 2023 21:36:45 +0000 Received: from localhost ([127.0.0.1]:41754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT8PM-0000cL-R9 for submit@debbugs.gnu.org; Fri, 17 Feb 2023 16:36:45 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:42890 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pT8PL-0000c8-UP for control@debbugs.gnu.org; Fri, 17 Feb 2023 16:36:44 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: control@debbugs.gnu.org Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> Date: Fri, 17 Feb 2023 22:36:33 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 61460 30.1 thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 00:53:47 2023 Received: (at 61460) by debbugs.gnu.org; 18 Feb 2023 05:53:47 +0000 Received: from localhost ([127.0.0.1]:42189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTGAM-000846-UV for submit@debbugs.gnu.org; Sat, 18 Feb 2023 00:53:47 -0500 Received: from mout.web.de ([212.227.15.4]:59167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTGAL-00083r-Nw for 61460@debbugs.gnu.org; Sat, 18 Feb 2023 00:53:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676699603; i=michael_heerdegen@web.de; bh=Syk4AJ7z1EotgM9aJIdOa3KRYPHJb0xNg80fF+Yv8Iw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Inw0odd8xvRnsvhbwGLoiS1OAgEF7VzVYQrkoBJZuCgQF6b5YnJvO9t/oIeBXL4nh 1LZOMbKaoNaXn4TAlzKxlHORvfn+6Dc/0pYXwuVe1r1RVHt9ttWKGjslSgX8m8CudF bcrEmI++VJPC6rQFNXxdC1lzvZNbjFbXI49oY7NxIvpU9m5VS/mlE6ZWNuS56yugew xHevgg1nxEx/QRSMKct2T6HC7j4brsDjIaqchCjAsHEtlQXbpJmrqJNQ+Lwc57yeSK aLi04T6vjEUiAtXhGCiBXWQQhWDKLrRbvNoPQoTwhoSPuYT3QhJv9H8zJ9+17K/1QG uwLiOvPNvDf9A== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MsrdM-1oejuM43zM-00tCWk; Sat, 18 Feb 2023 06:53:23 +0100 From: Michael Heerdegen To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87wn4g4v1y.fsf@web.de> (Michael Heerdegen's message of "Fri, 17 Feb 2023 08:20:41 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> Date: Sat, 18 Feb 2023 06:53:21 +0100 Message-ID: <87y1ovecz2.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:68FxqRYJx2sr5HO1HQypHDYm7iizu5PYENupmLzHYLA0XGfvLUN AHiUuChoK30ryaKJQOUaZ1tyO2Z8yqiVAIwNDT3cQerQQuPwHHWAvSg5Gk9bLWvItW1AZGS P5dVK837MI549cbvbjBUqWB+4HiEMVm1/9n30PTEGSbLs7RWkcYhvFMdFloqKO7bIOfWp5J iTYSLj/74gQHMP8kmnvdg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Tu7UNESg8y0=;33ydnJGXKbDmL0eH6X0hg+YIXBo UbgZRkTxlZhba6ZpS811qly8p/mHBoY0ljWFPg3R9mE1IvkI5oztpZ/kaM+dKgnbvCdqGafTn 3F/AMjtUaMxcBhZoLkQcbIobZRiTDHe73naS79YmbnQdo/o7umGyZ+DXH2FHeXqxcuERDqFUh F4YTcB8e5D6f8o7cTZcpiMRQhTuz4taSXZriZ3Al6ZvNmEi+bKi1zzWMXaDh2QPYK8s2H6xXl 3hUhstWzakbLxe0G6kOM8eJo53/rgwmjQvPoI7nrzPPT3oaRM0dKiyA9QEwp8q5RJHdV4b2VS jzWjn0aAHQ4Xf6N9gfJc22uTbgcGR6/LV4ZTcwGtgXb7gvxNqx2DIrknP5Uvzh1RzuLY5YICj iGFiJn0Cpj3E5WNjuJI347eijh5I6Y0810/dJx0uUbk5xDLDrrVxOEY5nesNdN9Dx6fxgvoNC iWvTURLE0/frsYAMZ2OVI5DkJ36DmoZFXpYm9ZGq3xbB64G28Y2euJDNs0lzLSQ2pewIhdWSq LmP+n/5U5iTo/9Rw3n0kTPjMdIoEtcCRmmgV5L0/PvLWqd/xY6PHuFb6pUjUkQDXA1NR/3BNu 0HxISywyJ2EO1RCztdBrigsKG9zettrtMsub7Om5zDiihlvp5C1z9+5uRnAIMULhR6knf5pxk moUmNtJ7BHG3Zv/p/kCVdQ8zZRncf3ptAcrpT69MYozPBjYjWGDinVhpWZ72clnVVYKmAt6lk PTq4gvaKs3/S09XhRo7udFOGzDLvIzcV69MUhh4NbRrquzXABOUHkNxxlDZP0Tf0fxEWM18Ih 9XawCL+vklUEONwr9fgXpMMJeRC+EYRnect5//Vf1DVxAxxbcOkP1pATa2WYXiViyVM1Ij2tz 2kjAKExuuMA/aL7ETZ9b/R1mowH3lA+5w0TDZorA5u7en16oGOa2+2gSZxsQqH0B4pjXdqUu4 YmEgNH2VVrJF6MelyAf/0d9Lxj0= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > Looks good to me, thanks, > > Michael. I think we are now done and can close this report. Thank you for your work. This one was very interesting! Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 03:56:58 2023 Received: (at 61460) by debbugs.gnu.org; 18 Feb 2023 08:56:58 +0000 Received: from localhost ([127.0.0.1]:42438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTJ1e-0004lk-4g for submit@debbugs.gnu.org; Sat, 18 Feb 2023 03:56:58 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:51690 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTJ1c-0004lU-7A for 61460@debbugs.gnu.org; Sat, 18 Feb 2023 03:56:56 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87y1ovecz2.fsf@web.de> (Michael Heerdegen's message of "Sat, 18 Feb 2023 06:53:21 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> Date: Sat, 18 Feb 2023 09:56:44 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Sat, 18 Feb 2023, Michael Heerdegen wrote: > Thank you for your work. This one was very interesting! Yeah, this one was fun. :) I was also tempted to add a defcustom for the eclipse names, so we could have "Sonnenfinsternis", etc. Then again, the additional word "possible" in these messages made me feel that we're in l10n/gettext territory, and presumably it should be solved in a more general context (there was a discussion on emacs-devel in 2021). From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 18 04:17:05 2023 Received: (at 61460) by debbugs.gnu.org; 18 Feb 2023 09:17:05 +0000 Received: from localhost ([127.0.0.1]:42461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTJL6-0005Kp-UP for submit@debbugs.gnu.org; Sat, 18 Feb 2023 04:17:05 -0500 Received: from mout.web.de ([212.227.15.3]:36871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTJL4-0005KH-GT for 61460@debbugs.gnu.org; Sat, 18 Feb 2023 04:17:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676711813; i=michael_heerdegen@web.de; bh=N007ulzuWghmC332FX2cponQerLjspm1/vMjfkqXrsE=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=iG/xG/XYxVR09EXe9BdlQZTHo3Zh2tgg4SlVqp2Dc4FBXNk1ACRMMwi7rt9wUG3bD KJJveLbkbz43bQJooO7tNkdL7dpW0zgjZGbsCVFBT/Kw3ZfrqolQOzEByz1kVyJZBi sfLK/iHM1XKKbPDwCx0/v/iUHATzjdUIuebcZFhmaUIOhIMw7SLYDKgr6ilCSQABLV ITBRkW30ypQYxY9xf9YzyxQ7/s9hEIOu8AqKRyCxcXJ9tEzMURx7VkDkDXsgCYo+Qr vp4dFBx4VO90pLTJiTOIIYIW4UpX3w6Ing1+1Z9eupKr4KM0PIInTVmcETJXScld3T i/jEiMlfeS8kQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MBB3y-1pOOjL0Cb8-00Ck5j; Sat, 18 Feb 2023 10:16:53 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Sat, 18 Feb 2023 09:56:44 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> Date: Sat, 18 Feb 2023 10:16:48 +0100 Message-ID: <8735739vun.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:uAurJaluzm7zU3hw9GD847HrBlUH9b11W/SolvohNtw7uLVaGp/ FiRV9as8tkyvE/AgHZYcegPLjhxyZ42v3UPT03NyPeEsVRluoZzjLokuv/uTxYKqKxdZ5Oe uvElgmrC5leZZk87PUwKflTqwwhELKlUW/rAK1NrZtbZWhE52n6d2GYkhotlF4If8+nEnt5 ghmJAwMP33+jEEWWv9WbA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4iKE27EQCqs=;AcVl2E9GSVRC2xDcjtXIvfhgopI mseCHRQgfpXo/kAsnCb8c4sUG1g7uPfeD869/ZZSCUEYqcwaYaKR6Na2F3aB871wME6VLUVsy OsVClApKQ8OJyRs7wifx5vDJ63wlMDLiJnfbSOSLdZMYxYolCHWovLMyAbdzSgqBRlqmZtAqQ IGnR+nQIa7Kc4AecYpFlLRKSjK5LOb6oix7dt8YhRGyobto77TZ/wAhARbSPcukopxdJVV2PP NW/jRGksaj4roLVtc9U35GTeu+Gb5/3BZoDb0F5PqKun8w14jWFvWPq6CoyLL7zcDsg5YWiuv CUvfw0NGdNbvSkLZzBMdK0IwZf7E9Del1XKZUsooHe4lrjxnbAbzjR6K2wHWLJhzR15a8ZBBg KM4Mz5WN4bncNvuESD8pouVc38gEWcyw3imtjAV6QJLXjQvYtfSIEZuCHhCghzgBd5ty6ethx UIz5kISONal1rZfForOdtZ2O+dgLuwXpg/kLLl/9Jqyd1Iiw6wBF1g9ahWUK/2hXXJDp0wHO0 5AiXdP5KLBJXMFUFKvRV9PfC9PrPGRm40acmMKkZlFdWxm4dQewMctoHf6FQvrSll3LRU45Nj +E9If0c3qVk8QqqPP3jPBNUHuZkZG/ahPOVKqcax/xTlN8E/RrG3O2AUzPMp6t6SY2ezbvmuF P+cLQr5QVadoJfpifKRnpMIzUvXGPHOJh7UdaAykKnh922Yj9OaoRfzBGaijw7pqyB2ukJq1a MXcGjyCbsKPPonFDSrvtlUf3LEYnqz5+CP5dQo/G/euQjRD6DaTdyK+uUIXa7IikHOHjhGtf9 /VatXqFfF1VgUKhz/pY/NBe8+cC8RyfKyLXkOnoTC2qLauc0NCjjrHiWcJh8fg2hHKxutcxG6 yqCaBtkM7R76ZIpFjmkNHGs/eBRQSlOgkKkSYR6ww+LmsJLUbVynMred7Vd8ULGCQ/ONy1gOz EwbsFQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Ulrich Mueller writes: > I was also tempted to add a defcustom for the eclipse names, so we could > have "Sonnenfinsternis", etc. Then again, the additional word "possible" > in these messages made me feel that we're in l10n/gettext territory, and > presumably it should be solved in a more general context (there was a > discussion on emacs-devel in 2021). Yes. That remark made me think about whether we want a `diary-eclipses' - or teach `diary-lunar-phases' to report eclipses (at the moment the latter doesn't report eclipses, I just tried). Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 21 10:15:55 2023 Received: (at 61460) by debbugs.gnu.org; 21 Feb 2023 15:15:55 +0000 Received: from localhost ([127.0.0.1]:57022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUMx-0002lu-Bi for submit@debbugs.gnu.org; Tue, 21 Feb 2023 10:15:55 -0500 Received: from mout.web.de ([212.227.15.14]:42925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUUMr-0002lb-Dj for 61460@debbugs.gnu.org; Tue, 21 Feb 2023 10:15:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1676992536; i=michael_heerdegen@web.de; bh=imZBr/ohR5kAwLi21o5G0+fxxutIL3w/+0Qe/Rd/pfI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=f58wl2oK9DvJMcqk1A46/lMXS/HGiN9QtWUqHR0ku71gjmi8enRnJSvOs3XgkFoRv SGC1c5MdAoa3qELmGLufymEtbVwlhKQRdA3QXYNurp/UuEURf9gbLTE6a8JQ/Tghf+ nzre889SHZ7vDrkpW3xzX/iybjR/voEj0W3ieKp5SQUhwFa8ZcTv/2P4dpbGvEGYs8 ffpgAlQfsXc6XcMgE0tB26jYH4K1/MFOrO16I80cSw3AzwDXXNJOPAb+t92tfkeBLD Ch42c8tWysq4SdWZ06pPCay9MCS/Ai71pRJqw4dOX+ioBjfq6vVInIpek/3W0d6yOL 4gd6dIt6mt9OA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MHVen-1pHY4U3Tqz-00DYJH; Tue, 21 Feb 2023 16:15:35 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <8735739vun.fsf@web.de> (Michael Heerdegen's message of "Sat, 18 Feb 2023 10:16:48 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> Date: Tue, 21 Feb 2023 16:15:34 +0100 Message-ID: <87a61759t5.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:c07OnRCR1Hw8lu6MCoJpe/n9imMbsoE78tFB/XeHKs89wGE5kAB i8rD9mfoRY4SAUHZ1+vpTYI5pfO85wi5cArwqzkXrozwKigUoJils00BeshtMLAT2j3KkpP PPcQaAVD5SYxNI9vLNnfI/DKDrVLHO30IsNs9ogB/Qo4ziYtx3S700u1Iw5w2mhgRJWm6JP 6cxG/QHEnbLkFMHCE7D7A== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:H2Wkpnr0oUg=;PamN7Okv7i1oFr/1UR2EQOHeBlX Ewj7/LrUbcvrdJJg29+8HjwC79tsAC1eIGNmu+V4plc2lsLWCh+GHx+GZWgIZ3OBk5Lcxzmg2 yAPGmSBcqZOsXosZY2snLhc86MJKwsv4qx11Bt0HlthDFs7OyX69y4KEENU53BY1upD/BbI89 eZD9D9bEhaKzbDKNUQYv6yF/2yG6t2/YoMXkqyh3gUdVMdzsm0ThA2Wl0EaE2603g/AzkfZy7 m3kqz6aaxg4TX0yQ2Y1XAUB/fS3TOVkUR1wkhMX57pVB8qKXPnlBJobZC777fsBQtMW/TGBRv AVlSIOLhGZ7tmxg8zSgOGeR26MwVLSaBaba8FiA7PrUq1O89fdkmRZqzJ6nrm/NYRYeLWFUEx bn+XlwIciq9J9edVPfXCAVkFn7LuNmas6E/QwcFapJyLRd0LeA54nuC1LsNPjp+YSDZvECFrt rUzxhVVEIOBCiqzh8E30SbNH6njkH+6qMr7BZnxxqxrYZFh3r7flmy5uxUqiRXGIZt9J6yyDt hgA/yU83NT1LBrGw6XaSBiZZFrqwHXqino0u3WCV3itRLbYKuUkIM/Y0s/CUvBuTnz/FxY0KT glcxmTKvX2veHYNq3oVUzNi/sfBRdPwzla+EF8zjvId8ERbMB30CLZz5okCNZhC6aYBqz8AQO oa7F3aQjfR0wZYgYzThflgc1RNzfY0pHRg+AXICtpC+g4+Q6mfp+Ptbt21dW7/8V+9xTCUgy9 wgjmHfpcI9AgpT6Stju1aPeyrZJjaYoJho+Lb7aZRcHbOCPJdfJ26gJUi158CzTtK1MwsEMDm rdawx63Mry/HIQsS/30XZgRXQM3KXmX4YHr7KLERwfuafq+3oLLCtsi54Ez+X94T7kBp9mR4G HOoPnPTS/WbQ2bvZQ4dLgac47W9M4BOQYdhwfkRjngS7VG/OhFCnNOKE+vyMrdMT3DbzllXHY fuio41BmfqygepisMxT4Snkjqhk= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Michael Heerdegen writes: > That remark made me think about whether we want a `diary-eclipses' - or > teach `diary-lunar-phases' to report eclipses (at the moment the latter > doesn't report eclipses, I just tried). Seems getting the latter is quite simple: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lunar-diary-eclipse.diff Content-Transfer-Encoding: quoted-printable diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 4f8f34d954f..5b73bb6e29e 100644 =2D-- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -284,8 +284,13 @@ diary-lunar-phases (setq index (1+ index) phase (lunar-phase index))) (if (calendar-date-equal (car phase) date) - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " - (cadr phase)))))) + (cons mark + (let ((eclipse (nth 3 phase))) + (concat (lunar-phase-name (nth 2 phase)) " " + (cadr phase) + (if (string-empty-p eclipse) + "" + (concat " " eclipse)))))))) ;; For the Chinese calendar the calculations for the new moon need to be = more ;; accurate than those above, so we use more terms in the approximation. --=-=-= Content-Type: text/plain Michael. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 04:00:51 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 09:00:51 +0000 Received: from localhost ([127.0.0.1]:57944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUkzb-0007Nx-A8 for submit@debbugs.gnu.org; Wed, 22 Feb 2023 04:00:51 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:48896 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUkzZ-0007Nj-8b for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 04:00:49 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87a61759t5.fsf@web.de> (Michael Heerdegen's message of "Tue, 21 Feb 2023 16:15:34 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> Date: Wed, 22 Feb 2023 10:00:38 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Tue, 21 Feb 2023, Michael Heerdegen wrote: >> That remark made me think about whether we want a `diary-eclipses' - or >> teach `diary-lunar-phases' to report eclipses (at the moment the latter >> doesn't report eclipses, I just tried). > Seems getting the latter is quite simple: > - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " > - (cadr phase)))))) > + (cons mark > + (let ((eclipse (nth 3 phase))) > + (concat (lunar-phase-name (nth 2 phase)) " " > + (cadr phase) > + (if (string-empty-p eclipse) > + "" > + (concat " " eclipse)))))))) It is probably a matter of personal taste, but I dislike the nested concats. This seems simpler (not tested, though): - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " - (cadr phase)))))) + (cons mark + (let ((eclipse (nth 3 phase))) + (concat (lunar-phase-name (nth 2 phase)) " " + (cadr phase) + (if (string-empty-p eclipse) "" " ") + eclipse)))))) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 04:45:33 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 09:45:33 +0000 Received: from localhost ([127.0.0.1]:58021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlgr-0008TX-DS for submit@debbugs.gnu.org; Wed, 22 Feb 2023 04:45:33 -0500 Received: from smtp-out1.suse.de ([195.135.220.28]:58736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlgo-0008TJ-Qc for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 04:45:31 -0500 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E8F9D336CE; Wed, 22 Feb 2023 09:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1677059123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FtapNsoLME74N1Pvv5dVc8g6VFQthpZLyz9CYeQ03Ao=; b=T4jDf3Ad6r2C/5D/+dIMlvI2MfJ19BXST0/wGVnu8oBmzmoehBVC7BCFdqyPd/Ugg3pGJl 4Rkl68YPsWJ0ZdpOSEcQzHIhS9pIrhncC0x2lZ+XhMb+cOar1HY/rtkxEUZDrvMybaJYCd ax1USOUrT6Lw0HWDFrFVt+OF5UskPIE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1677059123; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FtapNsoLME74N1Pvv5dVc8g6VFQthpZLyz9CYeQ03Ao=; b=Y6J6meFB4kz/YFgciybaYMbOiJJyUOFJxXqNz7p0MdpYcCEcytOwx28BCfjEWtLSHy7MwU KWe4rl51fxD766Ag== Received: from hawking.suse.de (unknown [10.168.4.11]) by relay2.suse.de (Postfix) with ESMTP id 953152C141; Wed, 22 Feb 2023 09:45:22 +0000 (UTC) Received: by hawking.suse.de (Postfix, from userid 17005) id 508844406CE; Wed, 22 Feb 2023 10:45:22 +0100 (CET) From: Andreas Schwab To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> X-Yow: I want EARS! I want two ROUND BLACK EARS to make me feel warm 'n secure!! Date: Wed, 22 Feb 2023 10:45:22 +0100 In-Reply-To: (Ulrich Mueller's message of "Wed, 22 Feb 2023 10:00:38 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: Michael Heerdegen , Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On Feb 22 2023, Ulrich Mueller wrote: >>>>>> On Tue, 21 Feb 2023, Michael Heerdegen wrote: > >>> That remark made me think about whether we want a `diary-eclipses' - or >>> teach `diary-lunar-phases' to report eclipses (at the moment the latter >>> doesn't report eclipses, I just tried). > >> Seems getting the latter is quite simple: > >> - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " >> - (cadr phase)))))) >> + (cons mark >> + (let ((eclipse (nth 3 phase))) >> + (concat (lunar-phase-name (nth 2 phase)) " " >> + (cadr phase) >> + (if (string-empty-p eclipse) >> + "" >> + (concat " " eclipse)))))))) > > It is probably a matter of personal taste, but I dislike the nested > concats. This seems simpler (not tested, though): > > - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " > - (cadr phase)))))) > + (cons mark > + (let ((eclipse (nth 3 phase))) > + (concat (lunar-phase-name (nth 2 phase)) " " > + (cadr phase) > + (if (string-empty-p eclipse) "" " ") > + eclipse)))))) concat also accepts lists, so nil is pefectly fine as an argument. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 05:03:37 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 10:03:37 +0000 Received: from localhost ([127.0.0.1]:58058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlyL-0000Zf-4M for submit@debbugs.gnu.org; Wed, 22 Feb 2023 05:03:37 -0500 Received: from mout.web.de ([212.227.17.11]:55697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUlyJ-0000ZT-3N for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 05:03:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677060190; i=michael_heerdegen@web.de; bh=ueQ/hUo4WummvLxPvNxHnj875vppsCmAt93Vm8n0J6k=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=jpNck1M7l/UozVvbHqp5Y+g3xn65ot9igQzUD0GyxtKDsYn6D+ki5RCemyDz609h7 GfPD7/W8OlSQNdbQV1nwNJEQj8A4Z4Tf46Js4kdxmyaxyywjTSvS1LVyh2XXnsgupT mgGmaJ8Hc/aWlQjWIYdk39fQuejU3eth+SQpfmxMeOKb2zwAtqxPGHPI1/iw4rr+sv U78uuarSjZ0PDJl8UdD8vkBXbbOG782tQ7CRsoND+84OOdHo61YYm6/2x4xJMoNmvW rJONfg3dxtyhjUQ8TiAsTqQ7IGtSyGeXPsBd1DbHobSakVx8bp5fsO7fDTvevIOBBb W0O5ccmAw1aQg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MwR4R-1ocOtP3FAr-00sAt7; Wed, 22 Feb 2023 11:03:10 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Wed, 22 Feb 2023 10:00:38 +0100") References: <87sffab61y.fsf@web.de> <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> Date: Wed, 22 Feb 2023 11:03:03 +0100 Message-ID: <87y1oq3tm0.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:pW8QBrJdyBMRG9jS9hm+DOC6+20QPndeGehfYTQar7+Edwzb3AE dBFeTv7S8+Kw0ioOEe6MDz1w52GqX3NgdS1swponkw9FGXq0V1f90W+trqx5fVuPLSa0WYN nRJDpLnzgkJdkY9W+wDGbPPdsyEwgi8rX9ETz+ejO4uLOQJvIW+qj1kPMFovNpJ1RoHcDDZ XYwgpNM6A0Fy/np1+J++Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ZD6M2qW8Z5A=;BKFxih5xJrBv0gJA8q2bxvWRuhw r9uueCCuOCejUZBTsb0D2nwRfHkVgXte6p5nydMtybbYUtIfT8qS/Wn+qrhoZquZrn5LTe8o8 83tuPwZHDVoqg+KOta/za6zz/1i8fXMlLPgI9oxIFRL8gVl7wZOzus6VOGItUWRPVCpUqM1ZS Xt3BLu29X6ECLkG9MaKTsPyxIFILtYcK+roj1Ht6SQOTs9STSLPza1q71rvl0mNYofWAi54mT k5/gOU/CnSgLFPoQGbmJpwg+YjoAx8Cum4OLW/4UyZ8qCOf4XiTyLiDqDq3+NAlz5Oug48CSD wJ/Zpi2J6fGxjgWByGf1j8r7+1lZcifzlhMhjCmEE0gB6LNNc8sFLFD71x/rtTbTvl8JHWH5n tweMxgLQ7XmzGb3q+PO/8IGFBZwNwJpl/5b/6qI6CJOxMpmwu/up1fAkeFs9qP9ISksOWKWOH 2m7o7TjDmGCYa8ctldPqDNOUzyY40MKfFSOnr85jV2YR3U6jrKhCbR0sY/fz+o8hdtvxZbpJI wZR+FvLafn2EIM9GMyz8EMEBYgTrCcNLupetOWopzYsE5NVttebMTy1+vuC0+JDRebhh0OGQp F+HpBRgPw5ilJUthG0eGPiGZKql3tB4gHR6suKyo6BGw7muWIbe3p6HobDHaI1PoWut2nSxzf ewjSXac2HU1l0X+NWdcTaj6+5jc72CVK3kne8sjiLOsbXer0hnDcDObotkeVxXNBWhgMGSXl+ rnu3eKID57Zw4hLMbQPY98Nrmy9b/gUw6uDIV3CcPN28wrF41fw/RGbXtvfYVYAHjBlqHWpVB lt1VTzDkuBvP0XIVvdw6iw1EtvMUpcMF7EKS0z+UzbGX/vzJ6VhPKJtZV+QSRo4L9l/gQ6nBe xD1Z9LznOvjSl1RHHfKjhzT+BHWk/tNEsR/G6h2VKHa779YnFLEnaM6T6CO7OYE1kTrbgqqAu odDtpmlJJk/4nRjfSUEuyuwLHG4= X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: Eli Zaretskii , 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich Mueller writes: > It is probably a matter of personal taste, but I dislike the nested > concats. This seems simpler (not tested, though): > > - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " > - (cadr phase)))))) > + (cons mark > + (let ((eclipse (nth 3 phase))) > + (concat (lunar-phase-name (nth 2 phase)) " " > + (cadr phase) > + (if (string-empty-p eclipse) "" " ") > + eclipse)))))) Fine by me (my preference would be Andreas' suggestion). We also need to fix the space handling in calendar-lunar-phases aka M in calendar - when no eclipse occurs, the descriptions end with a trailing space. Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 06:32:48 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 11:32:48 +0000 Received: from localhost ([127.0.0.1]:58143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUnMe-00031i-BC for submit@debbugs.gnu.org; Wed, 22 Feb 2023 06:32:48 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:41674 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUnMX-00031N-D2 for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 06:32:47 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87y1oq3tm0.fsf@web.de> (Michael Heerdegen's message of "Wed, 22 Feb 2023 11:03:03 +0100") References: <87cz6eb10y.fsf@web.de> <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> <87y1oq3tm0.fsf@web.de> Date: Wed, 22 Feb 2023 12:32:30 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Wed, 22 Feb 2023, Michael Heerdegen wrote: > Ulrich Mueller writes: >> It is probably a matter of personal taste, but I dislike the nested >> concats. This seems simpler (not tested, though): >>=20 >> - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " >> - (cadr phase)))))) >> + (cons mark >> + (let ((eclipse (nth 3 phase))) >> + (concat (lunar-phase-name (nth 2 phase)) " " >> + (cadr phase) >> + (if (string-empty-p eclipse) "" " ") >> + eclipse)))))) > Fine by me (my preference would be Andreas' suggestion). Use something like =E2=80=98(unless (string-empty-p eclipse) " ")=E2=80=99?= WFM. > We also need to fix the space handling in calendar-lunar-phases aka M in > calendar - when no eclipse occurs, the descriptions end with a > trailing space. While at it, maybe replace =E2=80=98(car (last x))=E2=80=99 by =E2=80=98(nt= h 3 x)=E2=80=99? From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 09:19:34 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 14:19:34 +0000 Received: from localhost ([127.0.0.1]:58419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpy2-0003sm-1D for submit@debbugs.gnu.org; Wed, 22 Feb 2023 09:19:34 -0500 Received: from mout.web.de ([212.227.17.12]:51087) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUpxz-0003sW-Rq for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 09:19:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677075551; i=michael_heerdegen@web.de; bh=weY/kfwn6qCUUFDrZEr0U3GM+N2/kUOam5HqQi8PYpo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=jLFbXUFDlXr3GZXoKpuIAhvqYVfRZU+jMxRGQ/h5AtVbykn6PstMzFqXyELLEmBQv lI+S4Pf5BpPwtAZwEZjpaamIilOF8VKu8+sHhHfNbouZbYDKYguxcp39UhnJgvmlVA IPzJBvrIUHux1gI7Jng97Knr5RUomLkhbqCHPOxeFjpK22HvNojkF34JQMF2a05+/2 1bH9qRTlcLKRxuxSlHSyvuhM5D31bQz+aOx/J3FNKbhwj4hcLQZUViVm+1LRRgUXfB JsfSKZHiPh6HzsxOO7Hbj4PN9AEKKcimSQ8JU+FJtsQ5+YRmX0+zCw/19bsbQ//W5l 5WY3LKxyrl9nA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MGQGF-1pJ07v3XBd-00H2kf; Wed, 22 Feb 2023 15:19:10 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Wed, 22 Feb 2023 12:32:30 +0100") References: <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> <87y1oq3tm0.fsf@web.de> Date: Wed, 22 Feb 2023 15:19:09 +0100 Message-ID: <87mt55ye8y.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:Qfu2j8O2R26zdWwkKFuZpF9VvdOtw3wFx9AZy8KfNGT7UJaH7k6 wElofTjhLokrlwhKR689DaGl25VpQc6C2GWcngSJWMbAE/EF+/7xkKL7likUaKlbnMQjs3O JUgtW4mmT90OBtb0e/OIYNSZBhitTmJRRRa8FS7hb4I8l1IQQQWxVwB5y5GazIEFA8UC8eg qMxXtdnlmuPBM21Ss/4hw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hgZ146q+ZrA=;1elrrBGyODF53M7CTTwueHt/c+1 eVikcnafvlcfE5ndVhgV0AArpqrVGXDEcM+EMdz0LRfDAEfCmIxYxxLfNJ5pVBpYhxRbtqPJ1 FAZhTL2ZfNK37YS/eMoZjlFbCT+YOhdeIX6wBKL+c2ZmdkM7YM69/udlC8ktJep/nIFvyVpoZ VjmmMDLW/nAMtw4md+liSCav0O/qG7rg3rbpdjUFkBxDm16PT2bP/SA8GHFNkz1X+2ZqeAPiM dSXHazwjuXd07gAM9C8+zXlowKkjidfA8Ms9v7jULsbFh5bDjEqn6y9XcfOIM46t3tXmhjTYd jba78fUcDwcpeLGpHh4X35wGl3+j80tmhPo5FY8ge4LRcyAYmehizmJ8bRHxGBIgsztF5DR/k oQOCnS7Nt79fjDNatzzSNf26OPlNrT1W1LpmJYxO2Nlt6gTcx9zTHAXV2TOmhtwB/f6LDfKSm E8sA3BYI2T4HNrvWXYlxzl8piKq3XtwCMwwbFwMEiFt84G0iyC47VFC/cPuNwvZG4uYJC9LJ8 zezgli7dcVHythx5aemZX0j4OwKmEk2PXcy+/H3/HUtr6Tr3UN16PFI2uxy1R/EU4dnsx+ZTE ixqCGkSDgtrPeO8lzIwjaJNEV8PKmrbQhfsELJUzOC3XXlwXr88McpPUW+3m2Y83B9IdCeM5S GSBBv0s566NcrJRGI182OnDZFDsyMg+LqMY+jUxo1NbVnXA9acjnhz42ufdqqzrj4FkdUZdZz 9eozB55omUfR7gfbpVmBLoeJvWkQG+3Wa5U6BNfYwxJqdjuEj1FUXTyfD+xK7hLWzWSxhQUn+ VxeEIyXDSDhTeK8uKSXr3N1qwBbqkwTjEFtB2zfY+C1ZUluccoEaAVIBYwUkZjdfJj0wwiCD3 bt4ctzlVkrGgVpkCZwkdHEHnvyIVXaBhyt8V7MEOGGF1UbnQBHlspPf4IESHNAhZieAWQ/iiM ZqoIpQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ulrich Mueller writes: > Use something like =E2=80=98(unless (string-empty-p eclipse) " ")=E2=80= =99? WFM. > > > We also need to fix the space handling in calendar-lunar-phases aka M in > > calendar - when no eclipse occurs, the descriptions end with a > > trailing space. > > While at it, maybe replace =E2=80=98(car (last x))=E2=80=99 by =E2=80=98(= nth 3 x)=E2=80=99? I tried to do that (and a bit more): --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-also-diary-lunar-phases-report-eclipses.patch Content-Transfer-Encoding: quoted-printable =46rom f0eaa97bbc5e4a6145295a4da14606012737820e Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Wed, 22 Feb 2023 14:56:07 +0100 Subject: [PATCH] Make also 'diary-lunar-phases' report eclipses * lisp/calendar/lunar.el (diary-lunar-phases): Report eclipses. (calendar-lunar-phases): Tweak. =2D-- lisp/calendar/lunar.el | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 4f8f34d954f..b395e08c232 100644 =2D-- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -245,10 +245,11 @@ calendar-lunar-phases (insert (mapconcat (lambda (x) - (format "%s: %s %s %s" (calendar-date-string (car x)) - (lunar-phase-name (nth 2 x)) - (cadr x) - (car (last x)))) + (let ((eclipse (nth 3 x))) + (concat (calendar-date-string (car x)) ": " + (lunar-phase-name (nth 2 x)) " " + (cadr x) (unless (string-empty-p eclipse) " ") + eclipse))) (lunar-phase-list m1 y1) "\n"))) (message "Computing phases of the moon...done")))) @@ -283,9 +284,13 @@ diary-lunar-phases (while (calendar-date-compare phase (list date)) (setq index (1+ index) phase (lunar-phase index))) - (if (calendar-date-equal (car phase) date) - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " - (cadr phase)))))) + (and (calendar-date-equal (car phase) date) + (cons mark + (let ((eclipse (nth 3 phase))) + (concat (lunar-phase-name (nth 2 phase)) " " + (cadr phase) + (unless (string-empty-p eclipse) " ") + eclipse)))))) ;; For the Chinese calendar the calculations for the new moon need to be = more ;; accurate than those above, so we use more terms in the approximation. =2D- 2.30.2 --=-=-= Content-Type: text/plain Michael. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 10:46:34 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 15:46:34 +0000 Received: from localhost ([127.0.0.1]:60129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUrKE-0006Wf-L8 for submit@debbugs.gnu.org; Wed, 22 Feb 2023 10:46:34 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:52508 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUrKC-0006WQ-BE for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 10:46:33 -0500 From: Ulrich Mueller To: Michael Heerdegen Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <87mt55ye8y.fsf@web.de> (Michael Heerdegen's message of "Wed, 22 Feb 2023 15:19:09 +0100") References: <87r0uu9e5v.fsf@web.de> <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> <87y1oq3tm0.fsf@web.de> <87mt55ye8y.fsf@web.de> Date: Wed, 22 Feb 2023 16:46:21 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Wed, 22 Feb 2023, Michael Heerdegen wrote: > + (let ((eclipse (nth 3 x))) > + (concat (calendar-date-string (car x)) ": " > + (lunar-phase-name (nth 2 x)) " " > + (cadr x) (unless (string-empty-p eclipse) " ") > + eclipse))) Fix the indentation? The tabs in this line are the only ones in the file. Otherwise LGTM. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 22 11:27:13 2023 Received: (at 61460) by debbugs.gnu.org; 22 Feb 2023 16:27:13 +0000 Received: from localhost ([127.0.0.1]:60184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUrxY-0007h0-OK for submit@debbugs.gnu.org; Wed, 22 Feb 2023 11:27:13 -0500 Received: from mout.web.de ([212.227.15.14]:33349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pUrxX-0007gm-0r for 61460@debbugs.gnu.org; Wed, 22 Feb 2023 11:27:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677083210; i=michael_heerdegen@web.de; bh=/xUSa5aWYHqV+miCDen43//7Z920BPPk3cSv3B6s0eQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=kCGc0u5lWnZzdr97LUpTL+ElVeZ6miJ5LOwHrvzWWnQIulq3HdOCPVttnZ3fNeZvS Fzxz7aaIo4R9pKVjkcJzntTvmZfD19nLMAtgkhU7AoQLw9PJt8c7FFQFz8S9BEED3J Gm5EU4FETppb2R5axI5ae216mHMlZctFwvYucR6x4qPtIkEPkaMgM6NrdzpdDI1Rep Wki4UYaOHTTPbUxizIs5HGKU/LjeKuFb0MGMzfQMxlDEyFvr+ngAzS0DFCmnOOkya0 nFZydyFKfMDwzfJUPe54Z1/cx0oBW+L4mSfJtyVo03WmYjLARikh2o6MIBbYWAc0gB kgncCEf0UEURg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1Mt8gP-1ogcsd19mD-00tAfS; Wed, 22 Feb 2023 17:26:50 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: (Ulrich Mueller's message of "Wed, 22 Feb 2023 16:46:21 +0100") References: <87mt5i9cba.fsf@web.de> <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> <87y1oq3tm0.fsf@web.de> <87mt55ye8y.fsf@web.de> Date: Wed, 22 Feb 2023 17:26:49 +0100 Message-ID: <871qmhfyye.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:GQeiKmb8pP6DI/b5hpmWHqyU9Adg+RNvzxorVLsJXYGXmkFWWpL /5tMqdx5fAC2WwgW4U8hTstjQ+FHIzc2LRi//H/mSzYetSPIa3I4BwVK96Dob4UQCAI0ihT Btm7z8dUONgb6DQuJm8qrs/EgTDiHE095pFT+9IR6qSvVTFIi61JnlsmwEhvCKlgyAjQsLX xyseT8NGccqRFcmg7rvuQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:mqLwpOFjMpQ=;O5ChhTad9/KZNSG0ARPLzdlggLH 34qyTjKVCuIvCSvfNzMTqE08lc+jAwQtBrZZpHqSBtzvyQ3LG+4H7a6hawMTCI6FbAMuexsCb 4eHeqD/8FNsFtrhI44ThcOxkIXueL145ddm/vgSt3pSIiWkinLNOOfwZC6jfMA7SHFfUz2V7B nVO3YUH95gWEHQFvD7zXtocqpmD0kVtL1Vp2B9s6/cbt6ly7ub60fXNk4Z+zUnK4++NXt51gR nOdLQB1S7fFARUTt05sr/ksOJN4yvA7f7rKczcrpc0taDI247zZCJSuGyRx8b3ivWKk19VUZy H01FXXDDiFqnfyEN1Asp1mazg6wWt0Zw09XuBClg9024hH4qy+7xmZwrEgwEaovjgRdRFymlA d4sNzlPL5nysR9D7+/xOpQ5GLulWHGBmadslK3JuJ1+XmUajhrQQvuNnefdDVHi5mhGoCZ7iM GgWKJKmvguVSSTou7VPwPB4TCNrWHSJgwvuh717Sriaw3XYC74G8SrBIls0PStDGqbQqpRP5G eX9yGyMng3QxzOu54aVL+TjfDoaBxRzvaVYRRFPf60g1FnMdrfUK8+Bn2X7KTNXbP3Dcy7cRc KUSde7y5fneQPIsqmOSZo8bABzx3pMIY+jMSpEriimOL1atYtBHYzC6AEl98lwWDWtaZ6ZMq+ uXoE+QvWcnkQhTINu02tQQiYKbVim3NLiYyCIeetOsD47KoNAhAvFeLj6I8uoKKlwAXnzYwSs g5jJnb5WtjuazXhJ9ntlOBP2M/hySu+CTpSGjRx00Wdra85/5Sihob9Y4/uSl5udMudXI2FeV rFS0BWLnsyjIbRm5QjLafsatdba6AhcqQ1b8sBMPkzujP2gj/c7CrhlJTxo2YniyccewDslyQ uH8rRPSbEUwMMGd8LveXjX4eYYupfXQtX6KB+0R0c2O6OT6wid/at8hFMQQpi7br5+fskz71R 1sldwdtNEYZw9+fTjo3w49ycX2Y= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460 Cc: 61460@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Ulrich Mueller writes: > >>>>> On Wed, 22 Feb 2023, Michael Heerdegen wrote: > > > + (let ((eclipse (nth 3 x))) > > + (concat (calendar-date-string (car x)) ": " > > + (lunar-phase-name (nth 2 x)) " " > > + (cadr x) (unless (string-empty-p eclipse) " ") > > + eclipse))) > > Fix the indentation? The tabs in this line are the only ones in the > file. Impressive discovery! Updated patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-also-diary-lunar-phases-report-eclipses.patch Content-Transfer-Encoding: quoted-printable =46rom 039668a5a4b27ea7e841592b9be42e50af1abe74 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Wed, 22 Feb 2023 14:56:07 +0100 Subject: [PATCH] Make also 'diary-lunar-phases' report eclipses * lisp/calendar/lunar.el (diary-lunar-phases): Report eclipses. (calendar-lunar-phases): Tweak. =2D-- lisp/calendar/lunar.el | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/lisp/calendar/lunar.el b/lisp/calendar/lunar.el index 4f8f34d954f..5b22043102d 100644 =2D-- a/lisp/calendar/lunar.el +++ b/lisp/calendar/lunar.el @@ -245,10 +245,11 @@ calendar-lunar-phases (insert (mapconcat (lambda (x) - (format "%s: %s %s %s" (calendar-date-string (car x)) - (lunar-phase-name (nth 2 x)) - (cadr x) - (car (last x)))) + (let ((eclipse (nth 3 x))) + (concat (calendar-date-string (car x)) ": " + (lunar-phase-name (nth 2 x)) " " + (cadr x) (unless (string-empty-p eclipse) " ") + eclipse))) (lunar-phase-list m1 y1) "\n"))) (message "Computing phases of the moon...done")))) @@ -283,9 +284,13 @@ diary-lunar-phases (while (calendar-date-compare phase (list date)) (setq index (1+ index) phase (lunar-phase index))) - (if (calendar-date-equal (car phase) date) - (cons mark (concat (lunar-phase-name (nth 2 phase)) " " - (cadr phase)))))) + (and (calendar-date-equal (car phase) date) + (cons mark + (let ((eclipse (nth 3 phase))) + (concat (lunar-phase-name (nth 2 phase)) " " + (cadr phase) + (unless (string-empty-p eclipse) " ") + eclipse)))))) ;; For the Chinese calendar the calculations for the new moon need to be = more ;; accurate than those above, so we use more terms in the approximation. =2D- 2.30.2 --=-=-= Content-Type: text/plain Michael. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 25 11:14:17 2023 Received: (at 61460-done) by debbugs.gnu.org; 25 Feb 2023 16:14:17 +0000 Received: from localhost ([127.0.0.1]:41343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVxBh-0003Vh-F2 for submit@debbugs.gnu.org; Sat, 25 Feb 2023 11:14:17 -0500 Received: from mout.web.de ([212.227.15.4]:34791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVxBe-0003VT-UW for 61460-done@debbugs.gnu.org; Sat, 25 Feb 2023 11:14:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1677341631; i=michael_heerdegen@web.de; bh=nW7t+wvHIK5bqXFqm0wE426DgPuCoNgOuQDBU2xxXP0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=wUFDfJMtS4GRH7slHiPTyDHYypjwok+I9HvO6jyAW/oOSeG4C3XuL4PqDeL814s5C 0OBgNGcWgDtAitYj0Qd3O5OVthCbmij3unBkXSEw8ScU+j8GQgJ8s2Cao8WTau7rLy lhGl7OXkf5qqi2HqXWHnuP5i8ApyILNo5TmKNZ9seJQJkj05cBqHSXNH3HwKwDAuDy NV6I4lfzzDL0tIWgMbzustHulcqSCI//XocoB9Cp5P4SJ/CYJc6vIgMCpgsTWDkhvv lprZ4xKiM4x7mvQ4KF54/Ijm3834vJR1EDGB1D19WQB/g/v+1CbBpEQfC6FzZxciBt aae28dBv0kRVg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([84.59.210.57]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MsaS7-1octS146Bf-00tiZF; Sat, 25 Feb 2023 17:13:51 +0100 From: Michael Heerdegen To: Ulrich Mueller Subject: Re: bug#61460: 30.0.50; Calendar shows eclipse for quarter moon In-Reply-To: <871qmhfyye.fsf@web.de> (Michael Heerdegen's message of "Wed, 22 Feb 2023 17:26:49 +0100") References: <875yc4q0ee.fsf@web.de> <87y1p0obe8.fsf@web.de> <87ttzoo6px.fsf@web.de> <87pma8q2w1.fsf@web.de> <87wn4g4v1y.fsf@web.de> <87y1ovecz2.fsf@web.de> <8735739vun.fsf@web.de> <87a61759t5.fsf@web.de> <87y1oq3tm0.fsf@web.de> <87mt55ye8y.fsf@web.de> <871qmhfyye.fsf@web.de> Date: Sat, 25 Feb 2023 17:13:48 +0100 Message-ID: <87edqdn2o3.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TIhYYEGeR2+TvLbeWlRazZXFh6LV8peUfeAkaFZAltgKhNMQkmg y+fWm2YQwoocyGGeOEB8je8O0o03WZcRBimurNPzG+15QpXHBgtzLtorF3tVTqcpVcIAGKc iQ+py9URjl3b6MxXN2+4u9l9XSmZFazipYeE8rkcL8KHZoNIPHZ5wKVQ1Abl81Lf4Ee85uR EIUC/12Ou7yq0QqxXiHKw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:biO2NhYDprw=;Of0iVGVEmylCpAV6bFzTH1KLJNq 4YM0lufo+MNvDfaqCIJ5hBPOt7+ish+HebNmBCnW5qwJhopTsfs4q3eWLeWofKLmNn/gAbVt4 YGlcxlZF1M8UyAxuMEAQSJZKp3EFnRrdE9ZXuDTRSxHnfYyHxUqprZzsw+BpJT6Jxre6+c+22 pxVshQMjMSZLhjb7Le1+Vug/YHCHnLTS+paD2zuI0ZW96E9FPKa47Ngx0cjJC+g9vPOGk+u7F TTbUi1Vs4iFAySwmRs+KzH0cKBDFnhEDgfgDFG0ZmF8UGlwi8yzmRjgM3qgth+Dpqescf7eEc q6tWF+Sm2iiAW/AG/lhQaYpfddJqdmmfzFDG4CJWTo+sl6Orw7ZdCzMBMPg/LqUk1wxaElxeO RxG8NTMQ6TepFtXVUJ3zRmWYqSh09gk0hh8y3K1u/3ivroeSrqMuPx78b3ZPhDDBKLcHuZ288 uh08bF2kAtJjaq/jUj+k3g9vOmuIe6OE2cBDkyGA7tJyBm/Pyk23e5pU6sfozVA0Peaw1uGHs etmFnmzAI/PO4CcS+OnhSlh29WjIKoLc1vH5QHKaP1QHzcCuaSRaWdjwSCucEe6Qw/kVUGx87 atyiYjPYklQenqjNSGDgb1iwzJEa2tau3PbiV73u3KX3lFUpWOEs2uX1VbUu4FAHn1QeS+K7G 6cCUsxjBoTMiBdS8CoCwUOLBYvJrIhIwDF9/W0jWhgcJ3Keo6TXuYJ3HzoEdJDCyLOllT7G/B dKViLU2a0aOIb0x5AQhhvihj2bMfc5nHWvC3+u0B9C+gPX62Jc/bHsImLYOkc0K6rZO/wAzcn Mh0J/+YTH/Liu1D0y6/bsrZp9WKK0wtoUpZ7Hm2BXDT0wG5+Ao90lhg1FAVYiMX3qaHEIv0hv o0Wlu/Dn4yb2hBiFsPBQurei9G1KPvRlGThEvXFLZcieZ4FpGSBvXr4XozS/u02x1pZP+/krv fZL4og== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61460-done Cc: 61460-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Michael Heerdegen writes: > Subject: [PATCH] Make also 'diary-lunar-phases' report eclipses > > * lisp/calendar/lunar.el (diary-lunar-phases): Report eclipses. > (calendar-lunar-phases): Tweak. I've pushed that last change (to master) now. And: we are done, so I'm closing this report. Thanks to everybody! Michael. From unknown Sat Jun 21 10:36:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Mar 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator