GNU bug report logs - #61458
[PATCH] services: xorg-wrapper: Support xorg server input

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Roman Scherer <roman.scherer <at> burningswell.com>
Subject: bug#61458: closed (Re: bug#61458: [PATCH] services: xorg-wrapper:
 Support xorg server input)
Date: Sat, 25 Mar 2023 02:11:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61458: [PATCH] services: xorg-wrapper: Support xorg server input

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61458 <at> debbugs.gnu.org.

-- 
61458: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61458
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 61458-done <at> debbugs.gnu.org
Subject: Re: bug#61458: [PATCH] services: xorg-wrapper: Support xorg server
 input
Date: Sat, 25 Mar 2023 10:11:04 +0800

Roman Scherer <roman <at> burningswell.com> writes:

>   services: xorg-wrapper: Support xorg server input rewriting.

Pushed with some commit description added:

    * gnu/services/xorg.scm (xorg-configuration-server-package-path)
    (xorg-configuration-dri-driver-path, xorg-configuration-xkb-bin-dir)
    (xorg-configuration-xkb-dir): New procedures.
    (xorg-wrapper): Use them for dri and xkb paths.

Thank you!

[Message part 3 (message/rfc822, inline)]

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] services: xorg-wrapper: Support xorg server input
Date: Sun, 12 Feb 2023 19:52:40 +0100

[Message part 4 (text/plain, inline)]

Hello Guix,

I would like to replace the Mesa package in my Xorg configuration. I
tried to do this with the following snippet:

```
(modify-services %desktop-services
  (slim-service-type config =>
                     (slim-configuration
                      (inherit config)
                      (xorg-configuration
                       (xorg-configuration
                        (server (replace-mesa xorg-server)))))))
```

But this unfortunately does not work, because the xorg-wrapper uses
static paths for the mesa, xkbcomp and xkeyboard-config packages in the
derivation.

The xserver starts now with the replaced mesa, but some paths still
point to the hard coded packages in Guix itself (and not the
replacement), which cause some things to not work.

This patch changes this to lookup the paths from the inputs of the
server field of the xorg-configuration instead. That way the correct
paths are setup in the xor-wrapper script. If those inputs are not found
for some reason it falls back to the current behavior, using the
packages from Guix.

Could you please review this?

Thanks, Roman.

[0001-services-xorg-wrapper-Support-xorg-server-input-tran.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.