From unknown Sun Jun 22 17:13:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61452 <61452@debbugs.gnu.org> To: bug#61452 <61452@debbugs.gnu.org> Subject: Status: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement Reply-To: bug#61452 <61452@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:13:40 +0000 retitle 61452 [PATCH] ; * src/textconv.c (textconv_query): Add empty statem= ent reassign 61452 emacs submitter 61452 Philip Kaludercic severity 61452 normal tag 61452 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 07:35:13 2023 Received: (at submit) by debbugs.gnu.org; 12 Feb 2023 12:35:13 +0000 Received: from localhost ([127.0.0.1]:44302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRBZZ-0002j4-8I for submit@debbugs.gnu.org; Sun, 12 Feb 2023 07:35:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:50080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRBZX-0002iw-Ae for submit@debbugs.gnu.org; Sun, 12 Feb 2023 07:35:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRBZV-0006lT-PF for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 07:35:09 -0500 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRBZR-0000Sp-DP for bug-gnu-emacs@gnu.org; Sun, 12 Feb 2023 07:35:08 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5297A24015F for ; Sun, 12 Feb 2023 13:35:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676205301; bh=7N7ygDiS7cSxQhNvE5oxAiHDRJ8xTS0D9cyMWqQ42qI=; h=From:To:Subject:Date:From; b=Z/HSYPfp9ryrzxdpw6ZiI+vQDz9KLgRVHPrNmRap0ELk2/dZBMktRXnwDr4e2rrts 8NF0u1gBqj4nXpUpuy/Ju7n2mLlq/qjxinubW9B4X7+OGznehGC3fstrHj93kNO3jI Vn1IK3NLrdPESgVqLjlnoTn7A+0/waWTApEePLFNF3xzAYFgJkoqS6iIGvgtYhed25 afHqVtOcbYk5FHepMQYCMYiXDXwEQO6bznMh8DXTxCRxS5B0+3tzfhkfmPi6XJjgrE 2FBkqFzHNX6+0bPPr3ZXWVmnI/Ot+Q81HG3ZEBLPysJBu5fLLhGEi4OcV95c6vgADc uIP6z3TfgCCng== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PF6PH4tbKz6tn4 for ; Sun, 12 Feb 2023 13:34:57 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement Date: Sun, 12 Feb 2023 12:34:56 +0000 Message-ID: <874jrrxdsf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tags: patch X-Debbugs-CC: Po Lu My GCC gives me this error --8<---------------cut here---------------start------------->8--- textconv.c: In function =E2=80=98textconv_query=E2=80=99: textconv.c:281:5: error: label at end of compound statement 281 | default: | ^~~~~~~ --8<---------------cut here---------------end--------------->8--- $ gcc --version gcc (Debian 10.2.1-6) 10.2.1 20210110 Copyright (C) 2020 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. It appears it doesn't want a "default" at the end of a block. Adding a semicolon fixes this. In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw scroll bars) of 2023-01-30 built on icterid Repository revision: e19b91f946a99aa812a21bbeff654569bad945d2 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-imagemagick --with-x-toolkit=3Dlucid --with-native-compilation=3Daot' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-src-textconv.c-textconv_query-Add-empty-statement.patch >From 9dda7a64ea9e4d1140c5919680d3fa436da4f902 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 12 Feb 2023 13:32:55 +0100 Subject: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement --- src/textconv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/textconv.c b/src/textconv.c index e91e127b71c..29dc7f7a41d 100644 --- a/src/textconv.c +++ b/src/textconv.c @@ -279,6 +279,7 @@ textconv_query (struct frame *f, struct textconv_callback_struct *query) } default: + ; } /* Undo any changes to the excursion. */ -- 2.30.2 --=-=-= Content-Type: text/plain -- Philip Kaludercic --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 14 09:45:48 2023 Received: (at 61452-done) by debbugs.gnu.org; 14 Feb 2023 14:45:48 +0000 Received: from localhost ([127.0.0.1]:53035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRwZ2-0002nj-7b for submit@debbugs.gnu.org; Tue, 14 Feb 2023 09:45:48 -0500 Received: from mout02.posteo.de ([185.67.36.66]:32933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRwYy-0002nU-Dm for 61452-done@debbugs.gnu.org; Tue, 14 Feb 2023 09:45:47 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 496C7240139 for <61452-done@debbugs.gnu.org>; Tue, 14 Feb 2023 15:45:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1676385938; bh=+utukMxKyt/AatANwZsGh9rQFHEgFVMZm1peRH9zYVY=; h=From:To:Subject:Date:From; b=l2vz5nknz2UO1vItKTmVoLEyBSZkcz9AXMhr5CPv7NPJmut7z8Pig0sVGk/SBl+ar ZAcQ6RbP51jYEj8zGIEHTDyEx0NPUVm6QgIXE0Yr/u6ATtx0FkTdKlOTiQTH0WD3z5 DFZAlw79Wdl4pG+aKjh3Jkz1tK62Ua9TlJ3ufAtdHqcaWiVDCgHKTO9Ps5QopJkwVi mdZaaft0SY4SW2CcW8mlD+u2NhYNChi6nVFNRQ3rXToHCIX11+7t+hOHUf5ZamDTpd 3j1ISWBP1pX69DUL7RKs3VrcheqxIviB5e7UwZ8Emt+735ME0a2fhmhcZfBad5iiRv Rk9HUhz58V62Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PGPC54ZJKz6trZ for <61452-done@debbugs.gnu.org>; Tue, 14 Feb 2023 15:45:36 +0100 (CET) From: Philip Kaludercic To: 61452-done@debbugs.gnu.org Subject: Re: bug#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement In-Reply-To: <874jrrxdsf.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 12 Feb 2023 12:34:56 +0000") References: <874jrrxdsf.fsf@posteo.net> Date: Tue, 14 Feb 2023 14:45:36 +0000 Message-ID: <875yc45mr3.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61452-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Tags: patch > > X-Debbugs-CC: Po Lu > > My GCC gives me this error > > textconv.c: In function =E2=80=98textconv_query=E2=80=99: > textconv.c:281:5: error: label at end of compound statement > 281 | default: > | ^~~~~~~ A similar patch has already been applied, so I am closing this report. > $ gcc --version > gcc (Debian 10.2.1-6) 10.2.1 20210110 > Copyright (C) 2020 Free Software Foundation, Inc. > This is free software; see the source for copying conditions. There is NO > warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOS= E. > > It appears it doesn't want a "default" at the end of a block. Adding a > semicolon fixes this. > > In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo > version 1.16.0, Xaw scroll bars) of 2023-01-30 built on icterid > Repository revision: e19b91f946a99aa812a21bbeff654569bad945d2 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 > System Description: Debian GNU/Linux 11 (bullseye) > > Configured using: > 'configure --with-imagemagick --with-x-toolkit=3Dlucid > --with-native-compilation=3Daot' --=20 Philip Kaludercic From unknown Sun Jun 22 17:13:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 Mar 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator