Subject: bug#61452: closed (Re: bug#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 14 Feb 2023 14:46:03 +0000

Your bug report

#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
61452: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61452
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#61452: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement
From: Philip Kaludercic <[email-masked]>
To: [email-masked]
Date: Tue, 14 Feb 2023 14:45:36 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Philip Kaludercic <[email-masked]> writes:

> Tags: patch
>
> X-Debbugs-CC: Po Lu <[email-masked]>
>
> My GCC gives me this error
>
> textconv.c: In function ‘textconv_query’:
> textconv.c:281:5: error: label at end of compound statement
>   281 |     default:
>       |     ^~~~~~~

A similar patch has already been applied, so I am closing this report.

> $ gcc --version
> gcc (Debian 10.2.1-6) 10.2.1 20210110
> Copyright (C) 2020 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> It appears it doesn't want a "default" at the end of a block.  Adding a
> semicolon fixes this.
>
> In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
>  version 1.16.0, Xaw scroll bars) of 2023-01-30 built on icterid
> Repository revision: e19b91f946a99aa812a21bbeff654569bad945d2
> Repository branch: master
> Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
> System Description: Debian GNU/Linux 11 (bullseye)
>
> Configured using:
>  'configure --with-imagemagick --with-x-toolkit=lucid
>  --with-native-compilation=aot'

-- 
Philip Kaludercic

Subject: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement
From: Philip Kaludercic <[email-masked]>
To: [email-masked]
Date: Sun, 12 Feb 2023 12:34:56 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Tags: patch

X-Debbugs-CC: Po Lu <[email-masked]>

My GCC gives me this error

--8<---------------cut here---------------start------------->8---
textconv.c: In function ‘textconv_query’:
textconv.c:281:5: error: label at end of compound statement
  281 |     default:
      |     ^~~~~~~
--8<---------------cut here---------------end--------------->8---

$ gcc --version
gcc (Debian 10.2.1-6) 10.2.1 20210110
Copyright (C) 2020 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

It appears it doesn't want a "default" at the end of a block.  Adding a
semicolon fixes this.

In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2023-01-30 built on icterid
Repository revision: e19b91f946a99aa812a21bbeff654569bad945d2
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-imagemagick --with-x-toolkit=lucid
 --with-native-compilation=aot'

>From 9dda7a64ea9e4d1140c5919680d3fa436da4f902 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <[email-masked]>
Date: Sun, 12 Feb 2023 13:32:55 +0100
Subject: [PATCH] ; * src/textconv.c (textconv_query): Add empty statement

---
 src/textconv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/textconv.c b/src/textconv.c
index e91e127b71c..29dc7f7a41d 100644
--- a/src/textconv.c
+++ b/src/textconv.c
@@ -279,6 +279,7 @@ textconv_query (struct frame *f, struct textconv_callback_struct *query)
 	}
 
     default:
+      ;
     }
 
   /* Undo any changes to the excursion.  */
-- 
2.30.2

-- 
Philip Kaludercic