GNU bug report logs - #61451
[PATCH] gnu: php: Drop the failed test for riscv64.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61451 in the body.
You can then email your comments to 61451 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Aleksandr Vityazev <avityazev <at> posteo.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: php: Drop the failed test for riscv64.
Date: Sun, 12 Feb 2023 09:02:45 +0000

* gnu/packages/php (php): Drop the failed test for riscv64.
[source, arguments, description]: Fix formatting.
---
 gnu/packages/php.scm | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index e0cd47b846..278d7e1760 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -71,7 +71,7 @@ (define-public php
                (base32
                 "0czflx9ikxymjfgnzaifjx9kc30ww2x4063075hcifjjwqwami5x"))
               (patches
-                (search-patches "php-fix-streams-copy-length.patch"))
+               (search-patches "php-fix-streams-copy-length.patch"))
               (modules '((guix build utils)))
               (snippet
                '(with-directory-excursion "ext"
@@ -178,7 +178,7 @@ (define-public php
              ,@(if (target-arm32?)
                    ;; Drop tests known to fail on armhf.
                    '((for-each delete-file
-                              (list
+                               (list
                                 "ext/calendar/tests/unixtojd_error1.phpt"
                                 "ext/opcache/tests/preload_006.phpt"
                                 "ext/opcache/tests/preload_011.phpt"
@@ -200,7 +200,7 @@ (define-public php
                    '())
 
              ,@(if (target-x86-32?)
-                   ;; Drop tests known to fail on i686. 
+                   ;; Drop tests known to fail on i686.
                    '((for-each delete-file
                                (list
                                 "ext/dba/tests/dba_gdbm.phpt")))
@@ -220,6 +220,12 @@ (define-public php
                                 "sapi/phpdbg/tests/watch_006.phpt")))
                    '())
 
+             ,@(if (target-riscv64?)
+                   ;; Drop tests known to fail on riscv64.
+                   '((for-each delete-file
+                               (list "sapi/cli/tests/upload_2G.phpt")))
+                   '())
+
              ;; Drop tests that are known to fail.
              (for-each delete-file
                        '("ext/posix/tests/posix_getgrgid.phpt"    ; Requires /etc/group.
@@ -419,7 +425,7 @@ (define-public php
        ("procps" ,procps)))             ; for tests
     (synopsis "PHP programming language")
     (description
-      "PHP (PHP Hypertext Processor) is a server-side (CGI) scripting
+     "PHP (PHP Hypertext Processor) is a server-side (CGI) scripting
 language designed primarily for web development but is also used as
 a general-purpose programming language.  PHP code may be embedded into
 HTML code, or it can be used in combination with various web template
-- 
2.39.1



-- 
Best regards,
Aleksandr Vityazev

Message #10 received at 61451-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Aleksandr Vityazev <avityazev <at> posteo.org>
Cc: 61451-done <at> debbugs.gnu.org
Subject: Re: [bug#61451] [PATCH] gnu: php: Drop the failed test for riscv64.
Date: Sun, 19 Feb 2023 10:12:17 +0100

Thanks for the patch! Pushed to master as
819aaca9d524d2fde3ed82c688d3731ca1797f87.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.