Subject: Re: [bug#61442] [PATCH] gnu: Add ddd

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 18 Feb 2023 12:33:10 +0100

Hello,

Andy Tai <[email-masked]> writes:

> * gnu/packages/debug.scm (ddd): New variable

Thank you. Some comments follow.

> +    (build-system gnu-build-system)
> +    (inputs (list motif ncurses gdb))
> +    (native-inputs (list pkg-config xorg-server-for-tests))

Nitpick: Could you move these 2 lines after arguments?

> +    (arguments
> +     (list #:tests? #f ;Those are manual

If I understand correctly, you're running tests in the `pre-check'
phase. Then this is not the correct way to proceed.

First you need to remove this keyword, and use (replace 'check ...)
instead of (add-before 'check 'pre-check ...)

> +           ;; avoid "friend declaration specifies default arguments and isn’t a definition" errors.

Nitpick: ;; Avoid ...

and proper filling.

> +           #:configure-flags #~(list "CXXFLAGS=-fpermissive")
> +           #:phases #~(modify-phases %standard-phases
> +                        (add-before 'check 'pre-check
> +                          (lambda* (#:key native-inputs inputs
> +                                    #:allow-other-keys)

Here you need to add "tests?" key, then wrap the function body within

    (when tests? ...)
> +                            (setenv "HOME" "/tmp")
> +                            (let ((xvfb (search-input-file (or native-inputs
> +                                                               inputs)
> +                                                           "bin/Xvfb"))
> +                                  (display ":1"))
> +                              (setenv "DISPLAY" display)
> +                              (system (string-append xvfb " " display " &"))))))))

Should this be (invoke xvfb ":1 &") ?

> +    (synopsis "graphical front end for the command-line debugger GDB")

graphical -> Graphical.

> +    (description
> +     "GNU Data Display Debugger (GNU DDD) is a graphical user interface ]

Spurious "]" character.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou