GNU bug report logs - #61437
[PATCH] doc: contributing: Cover push frequency in the Commit Policy.

Previous Next

To reply to this bug, email your comments to 61437 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] doc: contributing: Cover push frequency in the Commit Policy.
Date: Sat, 11 Feb 2023 21:15:05 +0000

* doc/contributing.texi (Commit Access): Add paragraph about push frequency.
---
 doc/contributing.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index c436bc4a31..09b9da3e89 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1852,6 +1852,12 @@ commits that caused immediate problems.  This is subject to being
 adjusted, allowing individuals to commit directly on non-controversial
 changes on parts they’re familiar with.
 
+Try to plan ahead and avoid pushing several times in a short time
+window.  This reduces the likelyhood that others working on the same
+branch will encounter problems when pushing.  It also reduces the load
+on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
+process each revision that is pushed.
+
 When pushing a commit on behalf of somebody else, please add a
 @code{Signed-off-by} line at the end of the commit log message---e.g.,
 with @command{git am --signoff}.  This improves tracking of who did
-- 
2.38.1

Message #8 received at 61437 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 61437 <at> debbugs.gnu.org
Subject: Re: [bug#61437] [PATCH] doc: contributing: Cover push frequency in
 the Commit Policy.
Date: Tue, 14 Feb 2023 14:03:08 +0100

Hi,

On sam., 11 févr. 2023 at 21:15, Christopher Baines <mail <at> cbaines.net> wrote:

> +Try to plan ahead and avoid pushing several times in a short time
> +window.  This reduces the likelyhood that others working on the same
> +branch will encounter problems when pushing.  It also reduces the load
> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
> +process each revision that is pushed.

The point is to push by batch instead of pushing several times in a row,
right?


Cheers,
simon

Message #11 received at 61437 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61437 <at> debbugs.gnu.org
Subject: Re: [bug#61437] [PATCH] doc: contributing: Cover push frequency in
 the Commit Policy.
Date: Fri, 17 Feb 2023 18:36:01 +0000

[Message part 1 (text/plain, inline)]

Simon Tournier <zimon.toutoune <at> gmail.com> writes:

> Hi,
>
> On sam., 11 févr. 2023 at 21:15, Christopher Baines <mail <at> cbaines.net> wrote:
>
>> +Try to plan ahead and avoid pushing several times in a short time
>> +window.  This reduces the likelyhood that others working on the same
>> +branch will encounter problems when pushing.  It also reduces the load
>> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
>> +process each revision that is pushed.
>
> The point is to push by batch instead of pushing several times in a row,
> right?

Pretty much, it's a balance of course as sometimes it'll be worth
pushing without much time between, but as I say there's advantages in
trying to plan ahead to reduce that.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 61437 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 61437 <at> debbugs.gnu.org
Subject: Re: [bug#61437] [PATCH] doc: contributing: Cover push frequency in
 the Commit Policy.
Date: Mon, 20 Feb 2023 12:30:35 +0100

Hi Chris,

On ven., 17 févr. 2023 at 18:36, Christopher Baines <mail <at> cbaines.net> wrote:

>>> +Try to plan ahead and avoid pushing several times in a short time
>>> +window.  This reduces the likelyhood that others working on the same
>>> +branch will encounter problems when pushing.  It also reduces the load
>>> +on services like @url{https://data.guix.gnu.org,data.guix.gnu.org} that
>>> +process each revision that is pushed.
>>
>> The point is to push by batch instead of pushing several times in a row,
>> right?
>
> Pretty much, it's a balance of course as sometimes it'll be worth
> pushing without much time between, but as I say there's advantages in
> trying to plan ahead to reduce that.

Well, maybe it is only me but I have difficulties to understand what you
mean by “plan ahead”.  Instead I would use “Try to push by batch and …”
or something like that.

Note the typo: s/likelyhood/likelihood

Well, LGTM.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.