GNU bug report logs - #61434
[PATCH] gnu: Add emacs-pasp-mode.

Previous Next

Full log

Message #14 received at 61434 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 61434 <at> debbugs.gnu.org
Subject: Re: [bug#61434] [PATCH] gnu: Add emacs-pasp-mode.
Date: Sat, 11 Feb 2023 19:55:48 +0100

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

>> This dance is not necessary. You can simply use
>> `emacs-substitute-variables', change the value, and keep the
>> defcustom.  A defconst is not a constant in Elisp anyway.
> A defconst does raise a warning if it's changed, so I'd rather do
> that.

It seems that you are trying to fix a design issue without any serious
usability consequence (who is going to set this variable anyway? Why
would it matter to us?). I believe this kind of fix is out of the scope
of a package definition.

Besides, it makes the definition less readable, to say the least. The
regexp itself is appalling (not that you can do much about it, of
course).

If you really insist of changing this defcustom, maybe 1. search forward
for "defcustom pasp-mode-version" 2. kill next regexp 3. insert
"#$version" 4. search backward for "defcustom", 5. replace match with
"defconst". It would still be awful (no serious regexp), but possibly
slightly less so.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.