GNU bug report logs - #61432
28.2; [PATCH] viper-init: disable face support

Previous Next

Full log

Message #35 received at 61432 <at> debbugs.gnu.org (full text, mbox):

From: andrés ramírez <rrandresf <at> hotmail.com>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 61432 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#61432: 28.2; [PATCH] viper-init: disable face support
Date: Mon, 13 Feb 2023 15:02:52 +0000

[Message part 1 (text/plain, inline)]

Hi. Robert.

>>>>> "Robert" == Robert Pluim <rpluim <at> gmail.com> writes:


[...]

 
    Robert> You donʼt need to check if 'viper-disable-minibuffer-faces' is bound. Itʼs a defcustom,
    Robert> it will always be bound.

Thanks for the clarification.

[...]


    Robert> Setting things to 't' to disable functionality I always find confusing. How about you
    Robert> invert it:

    Robert>     (defcustom viper-enable-minibuffer-faces t "Whether viper changes the minibuffer
    Robert> faces."  :type 'boolean :group 'viper-misc)

Done.

[patch-viper-cmd-optionally-disable-minibuffer-faces.patch (text/x-patch, inline)]

diff -u /tmp/viper/viper-cmd.el.bak /tmp/viper/viper-cmd.el
--- /tmp/viper/viper-cmd.el.bak	2023-02-12 17:45:05.775987386 +0000
+++ /tmp/viper/viper-cmd.el	2023-02-12 18:48:17.986368416 +0000
@@ -564,7 +564,7 @@
        ))
 
   ;; minibuffer faces
-  (if (viper-has-face-support-p)
+  (if (and (viper-has-face-support-p) viper-enable-minibuffer-faces)
       (setq viper-minibuffer-current-face
 	    (cond ((eq state 'emacs-state) viper-minibuffer-emacs-face)
 		  ((eq state 'vi-state) viper-minibuffer-vi-face)
@@ -1923,6 +1923,12 @@
   :group 'viper-misc)
 
 
+(defcustom viper-enable-minibuffer-faces t
+  "Whether viper changes the minibuffer faces."
+  :type 'boolean
+  :group 'viper-misc)
+
+
 ;; Try to add a suitable suffix to files whose name ends with a `.'
 ;; Useful when the user hits RET on a non-completed file name.
 ;; Used as a minibuffer exit hook in read-file-name

Diff finished.  Sun Feb 12 18:48:25 2023

[Message part 3 (text/plain, inline)]

Best Regards

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.