Subject: bug#61432: 28.2; [PATCH] viper-init: disable face support

From: Robert Pluim <[email-masked]>
Date: Mon, 13 Feb 2023 15:00:26 +0100

>>>>> On Sun, 12 Feb 2023 18:53:05 +0000, andrés ramírez <[email-masked]> said:
    INKA>    ;; minibuffer faces
    INKA> -  (if (viper-has-face-support-p)
    INKA> +  (if (and (viper-has-face-support-p) (not (and (boundp 'viper-disable-minibuffer-faces) viper-disable-minibuffer-faces)))
    INKA>        (setq viper-minibuffer-current-face
    INKA>  	    (cond ((eq state 'emacs-state) viper-minibuffer-emacs-face)
    INKA>  		  ((eq state 'vi-state) viper-minibuffer-vi-face)
    INKA> @@ -1923,6 +1923,12 @@
    INKA>    :group 'viper-misc)
 
You donʼt need to check if 'viper-disable-minibuffer-faces'  is
bound. Itʼs a defcustom, it will always be bound.

    INKA> +(defcustom viper-disable-minibuffer-faces nil
    INKA> +  "If non-nil, viper does change the minibuffer faces."
    INKA> +  :type 'boolean
    INKA> +  :group 'viper-misc)
    INKA> +
    INKA> +

Setting things to 't' to disable functionality I always find
confusing. How about you invert it:

    (defcustom viper-enable-minibuffer-faces t
      "Whether viper changes the minibuffer faces."
      :type 'boolean
      :group 'viper-misc)

Thanks

Robert
--