Subject: Re: bug#61432: 28.2; [PATCH] viper-init: disable face support

From: andrés ramírez <[email-masked]>
Date: Sun, 12 Feb 2023 18:53:05 +0000

Hi. Eli.

>>>>> "Eli" == Eli Zaretskii <[email-masked]> writes:

[...]

    Eli> Then make all those faces be the same: default.

There would be more than oneline. And There is no guarantee it should
work. I have tried several variations and have not gotten the default
faces showed when launching 'emacs -Q'

    Eli> You are suggesting a new user option?  That might be okay, but then the patch should
    Eli> include a suitable defcustom.

Yes. I am suggesting a new user option. For not changing minibuffer
faces when using viper.

Attached the new version of the patch.

diff -u /tmp/viper/viper-cmd.el.bak /tmp/viper/viper-cmd.el
--- /tmp/viper/viper-cmd.el.bak	2023-02-12 17:45:05.775987386 +0000
+++ /tmp/viper/viper-cmd.el	2023-02-12 18:48:17.986368416 +0000
@@ -564,7 +564,7 @@
        ))
 
   ;; minibuffer faces
-  (if (viper-has-face-support-p)
+  (if (and (viper-has-face-support-p) (not (and (boundp 'viper-disable-minibuffer-faces) viper-disable-minibuffer-faces)))
       (setq viper-minibuffer-current-face
 	    (cond ((eq state 'emacs-state) viper-minibuffer-emacs-face)
 		  ((eq state 'vi-state) viper-minibuffer-vi-face)
@@ -1923,6 +1923,12 @@
   :group 'viper-misc)

+(defcustom viper-disable-minibuffer-faces nil
+  "If non-nil, viper does change the minibuffer faces."
+  :type 'boolean
+  :group 'viper-misc)
+
+
 ;; Try to add a suitable suffix to files whose name ends with a `.'
 ;; Useful when the user hits RET on a non-completed file name.
 ;; Used as a minibuffer exit hook in read-file-name

Diff finished.  Sun Feb 12 18:48:25 2023

Best Regards