Subject: Re: bug#61432: 28.2; [PATCH] viper-init: disable face support

From: andrés ramírez <[email-masked]>
Date: Sun, 12 Feb 2023 17:54:45 +0000

Hi. Eli.
>>>>> "Eli" == Eli Zaretskii <[email-masked]> writes:

    Eli> The easiest one is this: (require 'viper-init) (setq viper-minibuffer-vi-face
    Eli> viper-minibuffer-emacs-face) Did you try that?

Yes. without success.

    Eli> What is the "right behavior"?  

The right behaviour is staying as If it were an 'emacs -Q'. minibuffer
faces should stay as by default on vanilla emacs.

    Eli> Which face do you want to avoid seeing?  

I would like minibuffer faces stay as vanilla emacs when activating viper.

[...]

    Eli> Anyway, the above is just a hint: how you can arrange for the viper faces do whatever you
    Eli> like.

Thanks. But I have not being able of having the faces on minibuffer not
changing after activating viper. 

What about a oneline patch?

diff -u /tmp/viper/viper-cmd.el.bak /tmp/viper/viper-cmd.el
--- /tmp/viper/viper-cmd.el.bak	2023-02-12 17:45:05.775987386 +0000
+++ /tmp/viper/viper-cmd.el	2023-02-12 17:06:44.589089504 +0000
@@ -564,7 +564,7 @@
        ))
 
   ;; minibuffer faces
-  (if (viper-has-face-support-p)
+  (if (and (viper-has-face-support-p) (not (and (boundp 'viper-disable-face-support) viper-disable-face-support)))
       (setq viper-minibuffer-current-face
 	    (cond ((eq state 'emacs-state) viper-minibuffer-emacs-face)
 		  ((eq state 'vi-state) viper-minibuffer-vi-face)

Diff finished.  Sun Feb 12 17:45:44 2023

Best Regards