GNU bug report logs - #6143
24.0.50; don't ispell-kill-ispell over and over

Previous Next

Full log

Message #54 received at 6143 <at> debbugs.gnu.org (full text, mbox):

From: Agustin Martin <agustin.martin <at> hispalinux.es>
To: jidanni <at> jidanni.org, 6143 <at> debbugs.gnu.org
Subject: Re: bug#6143: ispell killing still not fixed
Date: Thu, 24 Jun 2010 17:23:45 +0200

[Message part 1 (text/plain, inline)]

On Thu, Jun 24, 2010 at 10:43:09PM +0800, jidanni <at> jidanni.org wrote:
> AM> Has this fixed the over and over ispell process restart?
> 
> No. Anyway, as it is hard to detect just what is causing the problem,
> can we just have a flag, e.g., (setq ispell-never-kill 't) so that once
> ispell is started, it is never killed until emacs quits. And thus will
> be detected too, so no second ispell will be started.

I tend to disagree here (but have good news),

ispell process should not be restarted unless needed. And if needed should
be restarted. Other behavior may make more harm than good and hide
underlying problems.

The good news are that seems I found the underlying problem (at least for
the single extra ispell restart). Directory value, being the same, was 
sometimes set with unexpanded `~' and sometimes with it expanded, so they 
looked different to the comparison operator. 

I am testing attached patch that should make the expanded version to be
used everywhere. I am testing it along with a dirty hack in .emacs

(setq ispell-local-dictionary "american")
(load "ispell")
(setq ispell-program-name "aspell")
(ispell-set-spellchecker-params)
(ispell-start-process)

that should start an ispell process. With the attached changes at least
extra restart seems to be fixed.

If I see no further problems I will commit changes soon, so you can test
them in your box.

Thanks for your feedback,

-- 
Agustin

[ispell.el_expand-default-directory.diff (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.