GNU bug report logs - #61413
[PATCH] Make warnings show a "warning" emoji instead of a stop-sign

Previous Next

Full log

Message #96 received at 61413 <at> debbugs.gnu.org (full text, mbox):

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: rudolf <at> adamkovic.org, rms <at> gnu.org, stefankangas <at> gmail.com,
 Hi-Angel <at> yandex.ru, Eli Zaretskii <eliz <at> gnu.org>, 61413 <at> debbugs.gnu.org
Subject: Re: bug#61413: [PATCH] Make warnings show a "warning" emoji instead
 of a stop-sign
Date: Fri, 21 Feb 2025 00:03:11 +0100

[Message part 1 (text/plain, inline)]

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
>
>> How does the attached look?
>
> I think the change looks good.  I've just realized that the other caller
> of button--properties might need a tweak.
>
> In unbuttonize-region, we should change this call:
> (remove-text-properties start end
>                             (button--properties nil nil nil))
>
> to:
> (remove-text-properties start end
>                             ;; t to ensure help-echo gets reset.
>                             (button--properties nil nil t))

(Thanks, should have caught that button--properties was called by
unbuttonize-region too 🤦)

> But, now we don't know if the help-echo property was effectively added
> by the library or it was already there :-(.  Sadness.

Would the attached address that problem?  (To apply on top of the
previous patch; I'll squash it all if we are happy with it)

[fixup.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.