GNU bug report logs - #61413
[PATCH] Make warnings show a "warning" emoji instead of a stop-sign

Previous Next

Full log

View this message in rfc822 format

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: rudolf <at> adamkovic.org, rms <at> gnu.org, stefankangas <at> gmail.com, Hi-Angel <at> yandex.ru, Eli Zaretskii <eliz <at> gnu.org>, 61413 <at> debbugs.gnu.org
Subject: bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign
Date: Thu, 20 Feb 2025 22:50:33 +0100

[Message part 1 (text/plain, inline)]

Mauro Aranda <maurooaranda <at> gmail.com> writes:

>>> I think we'd like something similar for buttonize-region, so I wonder if
>>> it's not better to do the change inside button--properties, though.
>>
>> ACK to improve buttonize-region too.  button--properties does not have
>> access to the information needed to get the fallback help-echo tho
>> (STRING for buttonize, START END for buttonize-region), are you thinking
>> of passing that fallback as a new argument, or have I missed something?
>
> I was thinking in not overwriting the help-echo property if the
> help-echo argument is nil.

💡 Gotcha.  Much cleaner than the original patch - that
(get-text-property 0 …) was not very elegant.

> Currently, button--properties forces a value for the help-echo property.
> So it would be like: If it's nil,  don't add the help-echo property to
> the property list at all, leaving a previous help-echo property
> untouched.

How does the attached look?

[0001-Prevent-button.el-from-clearing-help-echo-strings.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.