GNU bug report logs - #61413
[PATCH] Make warnings show a "warning" emoji instead of a stop-sign

Previous Next

Full log

View this message in rfc822 format

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Rudolf Adamkovič <rudolf <at> adamkovic.org>
Cc: rpluim <at> gmail.com, Konstantin Kharlamov <Hi-Angel <at> yandex.ru>, rms <at> gnu.org, 61413 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign
Date: Sat, 15 Feb 2025 23:40:10 +0100

[Message part 1 (text/plain, inline)]

Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:

> 'buttonize' clobbers the help-echo property added by 'icon-string' ☹️
> That does make the current emoji extra-obscure, since hovering over it
> gives no clue as to what it does!
>
> Solutions:
>
> (a) display-warning could retrieve the property from the string returned
> by icon-string, then spoon-feeding it back to buttonize,
> (b) buttonize could check whether its STRING argument has a help-echo
> property before clobbering it with nil,
> (c) we invent a sentinel value for buttonize's HELP-ECHO argument to
> mean "psst, STRING already has the right help-echo property; use that".

See attached patches.  No intuition which is best; I guess (a) is the
least disruptive - no change in the semantics of 'buttonize'.

I wonder how critical we think finding a new graphical representation
for that button feels now, considering that once this is fixed,
mouse-hovering & C-h . will let users now what that button is for.

[a-spoonfeed.patch (text/x-patch, attachment)]

[b-fallback.patch (text/x-patch, attachment)]

[c-sentinel.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.