GNU bug report logs - #61413
[PATCH] Make warnings show a "warning" emoji instead of a stop-sign

Previous Next

Full log

Message #117 received at 61413 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: rudolf <at> adamkovic.org, rms <at> gnu.org, maurooaranda <at> gmail.com,
 stefankangas <at> gmail.com, Hi-Angel <at> yandex.ru, 61413 <at> debbugs.gnu.org
Subject: Re: bug#61413: [PATCH] Make warnings show a "warning" emoji instead
 of a stop-sign
Date: Thu, 06 Mar 2025 15:52:52 +0200

> From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
> Cc: Mauro Aranda <maurooaranda <at> gmail.com>,  rudolf <at> adamkovic.org,
>   rms <at> gnu.org,  stefankangas <at> gmail.com,  Hi-Angel <at> yandex.ru,
>   61413 <at> debbugs.gnu.org
> Date: Sun, 02 Mar 2025 12:01:15 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Mauro Aranda <maurooaranda <at> gmail.com>
> >> 
> >> Kévin Le Gouguec <kevin.legouguec <at> gmail.com> writes:
> >> 
> >>  > Mauro Aranda <maurooaranda <at> gmail.com> writes:
> >>  >
> >>  >> But, now we don't know if the help-echo property was effectively added
> >>  >> by the library or it was already there :-(.  Sadness.
> >>  >
> >>  > Would the attached address that problem?  (To apply on top of the
> >>  > previous patch; I'll squash it all if we are happy with it)
> >> 
> >> Looks good to me, thanks.
> >
> > If you want me to install some patches, please post them.
> 
> Thanks for the nudge; re-attaching the patch that makes button.el
> preserve help-echo strings; reviewed by Mauro in two parts¹², then
> squashed³.  I can install it if we think that fix is unambiguously good.

LGTM, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.