Subject: bug#61413: [PATCH] Make warnings show a "warning" emoji instead of a stop-sign

From: Kévin Le Gouguec <[email-masked]>
Date: Sat, 15 Feb 2025 23:50:08 +0100

Kévin Le Gouguec <[email-masked]> writes:

> * A caveat for terminals:
>
> As Eli mentions, icons.el already knows to fall back to a suitable
> representation on TTYs.  In practice though, the Linux TTY can display a
> few non-ASCII characters; as a result, here (6.13 if that matters) Emacs
> falls back to warnings-suppress's _symbol_ representation…
>
>   (symbol ,(if (and (eq system-type 'windows-nt)
>                     (null window-system))
>                " » "
>              " ■ "))    ; 👈 that one
>
> … which one could bikeshed too, if one were so inclined 🫣

Over at bug#60854, I note that Robert mentioned:

> Whilst youʼre changing stuff, the text should not be "stop", it should
> be "suppress" or "ignore" or something.

Referring to the current 'text presentation.

In light of all this, how do we feel about the attached patch?  (FTR,
"×" displays fine in a Linux TTY here; I do not have a Windows console
handy however so that patch might go overboard)

diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index 8a5c73ebd3a..46fa9d521d7 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -214,12 +214,8 @@ warning-suppress-p
 
 (define-icon warnings-suppress button
   `((emoji "⛔")
-    ;; Many MS-Windows console fonts don't have good glyphs for U+25A0.
-    (symbol ,(if (and (eq system-type 'windows-nt)
-                      (null window-system))
-                 " » "
-               " ■ "))
-    (text " stop "))
+    (symbol " × ")
+    (text " suppress "))
   "Suppress warnings."
   :version "29.1"
   :help-echo "Click to suppress this warning type")