GNU bug report logs - #61412
[PATCH] Add inlay hints to eglot

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dimitri Belopopsky <dimitri <at> belopopsky.com>
Subject: bug#61066: closed (Re: bug#61412: Inlay hints implementation)
Date: Sat, 25 Feb 2023 00:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61412: [PATCH] Add inlay hint support to eglot

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61066 <at> debbugs.gnu.org.

-- 
61412: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61412
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: João Távora <joaotavora <at> gmail.com>
To: Dimitri Belopopsky <dimitri <at> belopopsky.com>, 61412-done <at> debbugs.gnu.org
Cc: Po Lu <luangruo <at> yahoo.com>, Chinmay Dalal <dalal.chinmay.0101 <at> gmail.com>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#61412: Inlay hints implementation
Date: Sat, 25 Feb 2023 00:21:40 +0000

Inlay hints are not implemented in Eglot as of a few days ago.

I'm going to go ahead and close this bug. Please open new bugs for any
missing features
or problems with the new functionality.

Thanks,
João

[Message part 3 (message/rfc822, inline)]

From: Dimitri Belopopsky <dimitri <at> belopopsky.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add inlay hint support to eglot
Date: Wed, 25 Jan 2023 23:34:02 +0100

[Message part 4 (text/plain, inline)]

Hello,

I've been working on adding support for inlay hints inside eglot using
overlays.
Here is a working patch, but I'm still missing a few things:

- I can't figure out a way to show the hints on a document without causing
lags or timeouts from the lsp server
- I'm currently updating the hints by sending the whole file each time (to
make sure all hints get updated correctly). I'm not sure on how to make
this more efficient (or if it even necessary).

On the implementation side:
- implemented with overlays as a minor model, enabled by default
- shows all hints supported by the protocol
- there is a customisation to disable the minor mode if the user doesn't
want the feature

I'd love to get a few points to finish this patch, and of course any ideas
and feedbacks are welcome!

Kind regards,

Dimitri Belopopsky

[Message part 5 (text/html, inline)]

[0001-Add-inlay-hints-to-eglot.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.