From unknown Sat Aug 09 18:41:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61411: [PATCH] Handle a case where url-basic-auth can crash Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 Feb 2023 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 61411@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167610140332418 (code B ref -1); Sat, 11 Feb 2023 07:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2023 07:43:23 +0000 Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQkXb-0008Qo-2s for submit@debbugs.gnu.org; Sat, 11 Feb 2023 02:43:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:36916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQkXV-0008Qd-EA for submit@debbugs.gnu.org; Sat, 11 Feb 2023 02:43:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQkXV-0003qr-5x for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:43:17 -0500 Received: from mail.elken.dev ([165.22.120.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQkXT-0001Vh-1W for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:43:16 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 1EA00452EC for ; Sat, 11 Feb 2023 08:43:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1676101391; bh=LWJC23A5g66LOcXb6Qjd+lrxaqHBTs4HUr2/8CNxAgY=; h=Date:From:To:Subject:From; b=J7OCSg5wf2EQ2JWN+pwY08fyWySE8vl5D9ZfNeyTUugDgjgjn4vo+jTa7g8uy98Es nlv02cUuChKD0XhAVEcvXYvs6eOJHSr/JVQxGU0u1ZWQ+onoJ3BDnOT0LPhC8FBipP BY+N2itE0ctoQDzuFSmkard7RKzKlpJ8z6Maej+/fJiJfAOi0Tz04MYCfgdOmxMU2B BD2ctnoiCdXTqx4xEDWBsBLVlAP7K1Sv9GAakB+DNMVfpK8Qu4XA7K4LqpVfBFLbVK LCKqmlKfFmLTZ08tlYJKs52GAC5C0REjFYoX4BKA3AmzWA3mCuSAGN+MTqeRLMrXcS 6HbwnPkL8ezuA== MIME-Version: 1.0 Date: Sat, 11 Feb 2023 07:43:10 +0000 From: me@elken.dev Message-ID: X-Sender: me@elken.dev Content-Type: multipart/mixed; boundary="=_ac31fe584b544a0693faae1201319cf0" Received-SPF: pass client-ip=165.22.120.78; envelope-from=me@elken.dev; helo=mail.elken.dev X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=_ac31fe584b544a0693faae1201319cf0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi all, This seems like a simple patch, in cases where 'url-request-noninteractive' is set and valid credentials either aren't found or the server sends 401 regardless (which is how I found this bug), this causes Emacs to crash. I have copyright assignment assigned, even though this would fall under a "trivial change". Thanks, Ellis --=_ac31fe584b544a0693faae1201319cf0 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-potential-crash-with-url-basic-auth.patch Content-Disposition: attachment; filename=0001-Fix-potential-crash-with-url-basic-auth.patch; size=943 RnJvbSBjMzVlZGRmOGJjOTM4Y2NmYTBkOWE1NWZjNmYxNDI1OTViYzJkZTE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRlOiBTYXQs IDExIEZlYiAyMDIzIDA3OjI3OjU2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHBvdGVudGlh bCBjcmFzaCB3aXRoIHVybC1iYXNpYy1hdXRoCgoqIGxpc3AvdXJsL3VybC1hdXRoLmVsICh1cmwt YmFzaWMtYXV0aCk6CkhhbmRsZSBhIGNhc2Ugd2hlcmUgRW1hY3Mgd291bGQgY3Jhc2ggd2hlcmUg bm8gdmFsaWQgY3JlZGVudGlhbHMgYXJlIGZvdW5kCmFuZCAndXJsLXJlcXVlc3Qtbm9uaW50ZXJh Y3RpdmUnIGlzIHQKLS0tCiBsaXNwL3VybC91cmwtYXV0aC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdXJs L3VybC1hdXRoLmVsIGIvbGlzcC91cmwvdXJsLWF1dGguZWwKaW5kZXggZTllZTcyMDI5Zi4uODNi NGZhNjQ2OCAxMDA2NDQKLS0tIGEvbGlzcC91cmwvdXJsLWF1dGguZWwKKysrIGIvbGlzcC91cmwv dXJsLWF1dGguZWwKQEAgLTEwMCw3ICsxMDAsNyBAQCBpbnN0ZWFkIG9mIHRoZSBmaWxlbmFtZSBp bmhlcml0YW5jZSBtZXRob2QuIgogCQkJICAgICAoc2V0cSByZXR2YWwKIAkJCQkgICAoYmFzZTY0 LWVuY29kZS1zdHJpbmcKIAkJCQkgICAgKGZvcm1hdCAiJXM6JXMiIHVzZXIKLQkJCQkJICAgIChl bmNvZGUtY29kaW5nLXN0cmluZyBwYXNzICd1dGYtOCkpCisJCQkJCSAgICAoZW5jb2RlLWNvZGlu Zy1zdHJpbmcgKG9yIHBhc3MgIiIpICd1dGYtOCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB0KSkpKQogCQkgKHN5bWJvbC12YWx1ZSB1cmwtYmFzaWMtYXV0aC1zdG9yYWdl KSkpKQogICAgICAoYnlzZXJ2Ci0tIAoyLjM5LjAKCg== --=_ac31fe584b544a0693faae1201319cf0-- From unknown Sat Aug 09 18:41:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61411: [PATCH] Handle a case where url-basic-auth can crash References: In-Reply-To: Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Feb 2023 21:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 61411@debbugs.gnu.org Received: via spool by 61411-submit@debbugs.gnu.org id=B61411.167736100623739 (code B ref 61411); Sat, 25 Feb 2023 21:37:02 +0000 Received: (at 61411) by debbugs.gnu.org; 25 Feb 2023 21:36:46 +0000 Received: from localhost ([127.0.0.1]:41721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW2Dl-0006Ap-Tc for submit@debbugs.gnu.org; Sat, 25 Feb 2023 16:36:46 -0500 Received: from mail.elken.dev ([165.22.120.78]:57627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW2Dj-0006Ac-WE for 61411@debbugs.gnu.org; Sat, 25 Feb 2023 16:36:44 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 0537C45D52 for <61411@debbugs.gnu.org>; Sat, 25 Feb 2023 22:36:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1677360998; bh=oPk4Ip8QW1EReoVR55fJorVXLl0K4B9i87OlQsMxXws=; h=Date:From:To:Subject:From; b=u2nxmaMdfb9lPgFGHpIo80xUsKoyzOMMoaetKZY4HHIacZ6Tvcon+VLKAuembjMaZ 3VXTA+k7XJcUKckTjw7vKTrCq3ot6MFt0S3cJFAhmyY0Dqjl9h8o2MGx+bJ+m/AquA L8uiDfiWfr/st/lgxQMSu1CH7U9lIccYxiAqCJqGD49Ud6FC00P2t3oiRfm1Hwf8eA VeCntu9kzZB9zCuqUuIemaqo9kbhRWrZQKhgx5eVfYGSKXj6Y4jAdPerxb/7+p1GtM 4Pgjw7c8PcLU+pju+mww4RlLb7C0b0B2AuHay1Xw+RIskE0Y4q8YGqPsUGt3ZfG7Cn qYCBEs/slUASg== MIME-Version: 1.0 Date: Sat, 25 Feb 2023 21:36:37 +0000 From: me@elken.dev Message-ID: X-Sender: me@elken.dev Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Not sure of the etiquette here, but it's been a little bit now so I'm just bumping this :) From unknown Sat Aug 09 18:41:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61411: [PATCH] Handle a case where url-basic-auth can crash Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Feb 2023 05:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: me@elken.dev Cc: 61411@debbugs.gnu.org Received: via spool by 61411-submit@debbugs.gnu.org id=B61411.167738937823745 (code B ref 61411); Sun, 26 Feb 2023 05:30:04 +0000 Received: (at 61411) by debbugs.gnu.org; 26 Feb 2023 05:29:38 +0000 Received: from localhost ([127.0.0.1]:42148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW9bN-0006Av-VD for submit@debbugs.gnu.org; Sun, 26 Feb 2023 00:29:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pW9bL-0006Ag-3b for 61411@debbugs.gnu.org; Sun, 26 Feb 2023 00:29:36 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW9bF-0003ah-FW; Sun, 26 Feb 2023 00:29:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GJyhvIXoFY6DJy1Sdi3yVOGumtwMqO/sSfLM2wcA0g8=; b=A99CM6anHJla z+Wgi9e7p2OLMEjESlhe+zAUg0+hgPAQErC2DGrWT2kTKOHNCn0sH+sPuGRYpbZ1a2HGdEL3dLN08 Ss3jjrzW0CKXTG31tz8luc4/QmnAmB6+ghNcif9FrtkpUw4B3udUDz7Hm00PcBCUNKrkPyc+u9N+F FnfVIT7Kzc0Et4D3kvea6s6DAqQ8fyakVshtTDWt0gL2FBh9GCKuWdbANsECqkmhzn7H3m0VL5gAt zwBocMLzraLxAw1mSmT0wQLArFQcHtFXit3NjbjNNMmnYAnkjReLxVEsBU14wgBb1qn7oOEDSDxZ9 pJ/ARyEtDwgQ7xMZi3TWrg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pW9bA-000469-Ob; Sun, 26 Feb 2023 00:29:26 -0500 Date: Sun, 26 Feb 2023 07:29:29 +0200 Message-Id: <83sfetj8p2.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bug-gnu-emacs@gnu.org) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 25 Feb 2023 21:36:37 +0000 > From: me--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Not sure of the etiquette here, but it's been a little bit now so I'm > just bumping this :) That bug report has no description of the situation where the problem happens and no reproduction recipe. Talking about "crash" is also inaccurate, I think: it just signals an error, right? So it isn't surprising that bug report got no attention. Could you please add the missing details? Thanks. From unknown Sat Aug 09 18:41:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61411: [PATCH] Handle a case where url-basic-auth can crash Resent-From: me@elken.dev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Feb 2023 08:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 61411@debbugs.gnu.org Received: via spool by 61411-submit@debbugs.gnu.org id=B61411.167740156022911 (code B ref 61411); Sun, 26 Feb 2023 08:53:01 +0000 Received: (at 61411) by debbugs.gnu.org; 26 Feb 2023 08:52:40 +0000 Received: from localhost ([127.0.0.1]:42325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWCls-0005xT-G0 for submit@debbugs.gnu.org; Sun, 26 Feb 2023 03:52:40 -0500 Received: from mail.elken.dev ([165.22.120.78]:45553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWClq-0005xG-RC for 61411@debbugs.gnu.org; Sun, 26 Feb 2023 03:52:39 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 56CAB414E8; Sun, 26 Feb 2023 09:52:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1677401552; bh=WEK/otyjKHH6bkmRXvL7nretpBI6omP/BccrjOpOgg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B9mGuD3nWJtD0urCHwkE/DrhCvB2DvojZGzopiK8UHZwkTH/wcLK+4JrlIvwdm0Ja 8qjoLdIFZMMEnSz1+S/API6zsW3TZrOCyxFiD49DJhC+cwvm18iZNsaPGecD+vPXYq jGNgv8iXGiLaekoxyW3ZpbOcUDfgPM/MYfjDo4z/+6xs/A1DMF6rcljuhGqB7qOSNJ m/HWMLAKHc7sX8OXnMu25QxD5W1fkLFpG/XfHd5Fo6EvILVZEZiUTGl84hlfYOWJhO EJplg1jTu10+xbuqKmE1BBCnhfuvSCZdmeFrfRXXR9mH23XDWKjkKfdKko4fZhRLkc e8qvsOmd56h0Q== MIME-Version: 1.0 Date: Sun, 26 Feb 2023 08:52:31 +0000 From: me@elken.dev In-Reply-To: <83sfetj8p2.fsf@gnu.org> References: <83sfetj8p2.fsf@gnu.org> Message-ID: <7d66200bf9f7541a75484418fa3474ac@elken.dev> X-Sender: me@elken.dev Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli, Thanks for responding; I incorrectly assumed because the patch was so trivial my description was enough. My bad! Below is a snippet of elisp that when `M-x eval-buffer`'d crashes an `emacs -Q` and causes an `emacs -Q -l repro.el` to freeze indefinitely on e444115d026c809395d4d248a99bb467bc87bb1d (require 'url) (eval-when-compile (require 'cl-lib)) (cl-defun send-request (endpoint &key verb data headers noninteractive json noauth sync callback) (let* ((url-request-method (or verb "GET")) (url-cookie-trusted-urls '(".*")) (url-request-noninteractive noninteractive) (url-request-extra-headers `(("Referer" . ,endpoint) ("X-CSRF-TOKEN" . nil) ("Cookie" . nil))) (url-request-data data)) (if sync (with-current-buffer (url-retrieve-synchronously endpoint) (funcall (or callback #'identity) url-http-response-status)) (url-retrieve endpoint (or callback #'identity))))) (send-request "https://httpstat.us/401" :noninteractive t :sync t) The linked API is a simple service used to return various status codes, in this instance always a 401 regardless of what authentication is passed. I'm not sure if my patch is the best catch-all solution to the underlying issue (I confess, I don't fully understand why this crashes). With my simple patch applied though, Emacs continues as expected. I hope this is enough information now, I apologize for the poor initial report. As I already had a patch ready, I didn't think I should have used `M-x report-emacs-bug` but I will in future :) From unknown Sat Aug 09 18:41:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: me@elken.dev Subject: bug#61411: closed (Re: bug#61411: [PATCH] Handle a case where url-basic-auth can crash) Message-ID: References: <83a60ve3d3.fsf@gnu.org> X-Gnu-PR-Message: they-closed 61411 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 61411@debbugs.gnu.org Date: Thu, 02 Mar 2023 12:38:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1677760682-25896-1" This is a multi-part message in MIME format... ------------=_1677760682-25896-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61411: [PATCH] Handle a case where url-basic-auth can crash which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61411@debbugs.gnu.org. --=20 61411: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61411 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1677760682-25896-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61411-done) by debbugs.gnu.org; 2 Mar 2023 12:37:29 +0000 Received: from localhost ([127.0.0.1]:56058 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXiBd-0006it-FJ for submit@debbugs.gnu.org; Thu, 02 Mar 2023 07:37:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXiBb-0006ig-67 for 61411-done@debbugs.gnu.org; Thu, 02 Mar 2023 07:37:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXiBV-000546-CA; Thu, 02 Mar 2023 07:37:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CzvvHVj+oYt1mPAD6L0l5D4cxmKjRN8Jm5EtWmR2Kw4=; b=iUM3aEQqHRvu Ce0EDou6sh/p7x6IwkRaBdVMulxkrCyLMlceBYqorwgWZJkH4VZylDHsxesvy6z8PdDea+WLJBmEo psXUVkKBKTBFiVBBxxY5zwP5K8dHojkpFX1mLoUt5Qddnf3QCaIUewOn4eSMbxyJQ2nvmPnxc5CsP GOnnDmucft7UAjTPPsb9K7MEqpffzu4HMFhNlHw95Ry5zkik2Yt39KnJEcamujBfKZj05/aqNpc+j GJJNqlhneaLdS2jPubbUlJS7jkxCbHMacXiRQ1VpmcHDlEVNOlrLYBbwkeqNnJS38qUnznlW+B5hA 7RVowqsaKksTheIKT/NIrw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXiBR-0001iu-OQ; Thu, 02 Mar 2023 07:37:21 -0500 Date: Thu, 02 Mar 2023 14:37:12 +0200 Message-Id: <83a60ve3d3.fsf@gnu.org> From: Eli Zaretskii To: me@elken.dev In-Reply-To: <7d66200bf9f7541a75484418fa3474ac@elken.dev> (me@elken.dev) Subject: Re: bug#61411: [PATCH] Handle a case where url-basic-auth can crash References: <83sfetj8p2.fsf@gnu.org> <7d66200bf9f7541a75484418fa3474ac@elken.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61411-done Cc: 61411-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 26 Feb 2023 08:52:31 +0000 > From: me@elken.dev > Cc: 61411@debbugs.gnu.org > > Thanks for responding; I incorrectly assumed because the patch was so > trivial my description was enough. My bad! > > Below is a snippet of elisp that when `M-x eval-buffer`'d crashes an > `emacs -Q` and causes an `emacs -Q -l repro.el` to freeze indefinitely > on e444115d026c809395d4d248a99bb467bc87bb1d > > (require 'url) > (eval-when-compile (require 'cl-lib)) > > (cl-defun send-request (endpoint &key verb data headers noninteractive > json noauth sync callback) > (let* ((url-request-method (or verb "GET")) > (url-cookie-trusted-urls '(".*")) > (url-request-noninteractive noninteractive) > (url-request-extra-headers > `(("Referer" . ,endpoint) > ("X-CSRF-TOKEN" . nil) > ("Cookie" . nil))) > (url-request-data data)) > (if sync > (with-current-buffer (url-retrieve-synchronously endpoint) > (funcall (or callback #'identity) url-http-response-status)) > (url-retrieve > endpoint > (or callback #'identity))))) > > (send-request "https://httpstat.us/401" :noninteractive t :sync t) > > The linked API is a simple service used to return various status codes, > in this instance always a 401 regardless of what authentication is > passed. > > I'm not sure if my patch is the best catch-all solution to the > underlying issue (I confess, I don't fully understand why this crashes). > With my simple patch applied though, Emacs continues as expected. > > I hope this is enough information now, I apologize for the poor initial > report. As I already had a patch ready, I didn't think I should have > used `M-x report-emacs-bug` but I will in future :) Thanks, I fixed this in a slightly different manner on the emacs-29 branch, and I'm therefore closing this bug. ------------=_1677760682-25896-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Feb 2023 07:43:23 +0000 Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQkXb-0008Qo-2s for submit@debbugs.gnu.org; Sat, 11 Feb 2023 02:43:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:36916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQkXV-0008Qd-EA for submit@debbugs.gnu.org; Sat, 11 Feb 2023 02:43:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQkXV-0003qr-5x for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:43:17 -0500 Received: from mail.elken.dev ([165.22.120.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pQkXT-0001Vh-1W for bug-gnu-emacs@gnu.org; Sat, 11 Feb 2023 02:43:16 -0500 Received: from authenticated-user (mail.elken.dev [165.22.120.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by mail.elken.dev (Postfix) with ESMTPSA id 1EA00452EC for ; Sat, 11 Feb 2023 08:43:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elken.dev; s=mail; t=1676101391; bh=LWJC23A5g66LOcXb6Qjd+lrxaqHBTs4HUr2/8CNxAgY=; h=Date:From:To:Subject:From; b=J7OCSg5wf2EQ2JWN+pwY08fyWySE8vl5D9ZfNeyTUugDgjgjn4vo+jTa7g8uy98Es nlv02cUuChKD0XhAVEcvXYvs6eOJHSr/JVQxGU0u1ZWQ+onoJ3BDnOT0LPhC8FBipP BY+N2itE0ctoQDzuFSmkard7RKzKlpJ8z6Maej+/fJiJfAOi0Tz04MYCfgdOmxMU2B BD2ctnoiCdXTqx4xEDWBsBLVlAP7K1Sv9GAakB+DNMVfpK8Qu4XA7K4LqpVfBFLbVK LCKqmlKfFmLTZ08tlYJKs52GAC5C0REjFYoX4BKA3AmzWA3mCuSAGN+MTqeRLMrXcS 6HbwnPkL8ezuA== MIME-Version: 1.0 Date: Sat, 11 Feb 2023 07:43:10 +0000 From: me@elken.dev To: bug-gnu-emacs@gnu.org Subject: [PATCH] Handle a case where url-basic-auth can crash Message-ID: X-Sender: me@elken.dev Content-Type: multipart/mixed; boundary="=_ac31fe584b544a0693faae1201319cf0" Received-SPF: pass client-ip=165.22.120.78; envelope-from=me@elken.dev; helo=mail.elken.dev X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=_ac31fe584b544a0693faae1201319cf0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi all, This seems like a simple patch, in cases where 'url-request-noninteractive' is set and valid credentials either aren't found or the server sends 401 regardless (which is how I found this bug), this causes Emacs to crash. I have copyright assignment assigned, even though this would fall under a "trivial change". Thanks, Ellis --=_ac31fe584b544a0693faae1201319cf0 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-Fix-potential-crash-with-url-basic-auth.patch Content-Disposition: attachment; filename=0001-Fix-potential-crash-with-url-basic-auth.patch; size=943 RnJvbSBjMzVlZGRmOGJjOTM4Y2NmYTBkOWE1NWZjNmYxNDI1OTViYzJkZTE1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFbGxpcyBLZW55byA8bWVAZWxrZW4uZGV2PgpEYXRlOiBTYXQs IDExIEZlYiAyMDIzIDA3OjI3OjU2ICswMDAwClN1YmplY3Q6IFtQQVRDSF0gRml4IHBvdGVudGlh bCBjcmFzaCB3aXRoIHVybC1iYXNpYy1hdXRoCgoqIGxpc3AvdXJsL3VybC1hdXRoLmVsICh1cmwt YmFzaWMtYXV0aCk6CkhhbmRsZSBhIGNhc2Ugd2hlcmUgRW1hY3Mgd291bGQgY3Jhc2ggd2hlcmUg bm8gdmFsaWQgY3JlZGVudGlhbHMgYXJlIGZvdW5kCmFuZCAndXJsLXJlcXVlc3Qtbm9uaW50ZXJh Y3RpdmUnIGlzIHQKLS0tCiBsaXNwL3VybC91cmwtYXV0aC5lbCB8IDIgKy0KIDEgZmlsZSBjaGFu Z2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2xpc3AvdXJs L3VybC1hdXRoLmVsIGIvbGlzcC91cmwvdXJsLWF1dGguZWwKaW5kZXggZTllZTcyMDI5Zi4uODNi NGZhNjQ2OCAxMDA2NDQKLS0tIGEvbGlzcC91cmwvdXJsLWF1dGguZWwKKysrIGIvbGlzcC91cmwv dXJsLWF1dGguZWwKQEAgLTEwMCw3ICsxMDAsNyBAQCBpbnN0ZWFkIG9mIHRoZSBmaWxlbmFtZSBp bmhlcml0YW5jZSBtZXRob2QuIgogCQkJICAgICAoc2V0cSByZXR2YWwKIAkJCQkgICAoYmFzZTY0 LWVuY29kZS1zdHJpbmcKIAkJCQkgICAgKGZvcm1hdCAiJXM6JXMiIHVzZXIKLQkJCQkJICAgIChl bmNvZGUtY29kaW5nLXN0cmluZyBwYXNzICd1dGYtOCkpCisJCQkJCSAgICAoZW5jb2RlLWNvZGlu Zy1zdHJpbmcgKG9yIHBhc3MgIiIpICd1dGYtOCkpCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB0KSkpKQogCQkgKHN5bWJvbC12YWx1ZSB1cmwtYmFzaWMtYXV0aC1zdG9yYWdl KSkpKQogICAgICAoYnlzZXJ2Ci0tIAoyLjM5LjAKCg== --=_ac31fe584b544a0693faae1201319cf0-- ------------=_1677760682-25896-1--