GNU bug report logs - #61394
30.0.50; [PATCH] Image-dired thumb name based on content

Previous Next

Full log

Message #71 received at 61394 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: contovob <at> tcd.ie, stefankangas <at> gmail.com, 61394 <at> debbugs.gnu.org
Subject: Re: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on
 content
Date: Fri, 28 Jul 2023 09:55:13 +0300

> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Cc: stefankangas <at> gmail.com,  contovob <at> tcd.ie,  61394 <at> debbugs.gnu.org
> Date: Thu, 27 Jul 2023 23:30:29 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> [...]
> 
> > Thanks, installed.  But now 1 set in image-dired-util-tests fails; it
> > sounds like the method of producing per-directory thumbnails has
> > changed, and now produces a SHA-1 hash?  Can you please look into
> > fixing that test?
> 
> Ok, I think this patch should do.

Thanks, the tests now pass, but I wonder about this part:

>      (should (equal (cdr (file-name-split
> -                         (image-dired-thumb-name "/tmp/foo.jpg")))
> -                   '("tmp" ".image-dired" "foo.jpg.thumb.jpg")))
> +                         (image-dired-thumb-name abs-path)))
> +                   (list "tmp" ".image-dired" hash-name)))

Does this mean that thumbnail naming under 'per-directory' has
changed, and it now uses the SHA-1 hash of the base-name?  IOW, does
this mean your changes for bug#61394 included incompatible changes in
behavior?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.