GNU bug report logs - #61394
30.0.50; [PATCH] Image-dired thumb name based on content

Previous Next

Full log

View this message in rfc822 format

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: contovob <at> tcd.ie, Eli Zaretskii <eliz <at> gnu.org>, 61394 <at> debbugs.gnu.org
Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content
Date: Wed, 15 Feb 2023 06:19:02 -0800

Manuel Giraud <manuel <at> ledu-giraud.fr> writes:

> The performance impact is important.  Here are the results from a list
> of images of mine:
> --8<---------------cut here---------------start------------->8---
> (length *images*) -> 3664
>
> (benchmark-run-compiled 10 (dolist (im *images*) (sha1 im)))
>  -> (0.367976492 1 0.2809483390000196)
>
> (benchmark-run-compiled 10 (dolist (im *images*) (image-dired-contents-sha1 im)))
>  -> (72.115512605 84 26.079076938000014)
> --8<---------------cut here---------------end--------------->8---

Thanks.  That's a slowdown by a factor close to 100, so while I think
the feature sounds useful, it should indeed be made optional.

> Maybe we could have this in another option for
> `image-dired-thumbnail-storage'?

I think 'image-dired-thumbnail-storage' is already complicated enough,
and I'd rather not complicate it further.

> What do you think of 'image-dired-contents?

Hmm, it sounds a bit too nondescript.  How about something like
'image-dired-thumbnail-naming'?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.