GNU bug report logs - #61394
30.0.50; [PATCH] Image-dired thumb name based on content

Previous Next

Full log

Message #119 received at 61394 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: contovob <at> tcd.ie, stefankangas <at> gmail.com, 61394 <at> debbugs.gnu.org
Subject: Re: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on
 content
Date: Thu, 03 Aug 2023 13:10:43 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
>> Cc: stefankangas <at> gmail.com,  contovob <at> tcd.ie,  61394 <at> debbugs.gnu.org
>> Date: Wed, 02 Aug 2023 20:00:19 +0200
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > Thanks.  Maybe I'm missing something, but isn't the problem limited to
>> > just one method of naming the thumbnail files?  If so, shouldn't these
>> > changes be limited to that method alone?
>> 
>> Yes.  First I had a test about the method around the call to
>> 'image-dired-update-thumbnail-at-point' but then I realize that nothing
>> will be done for others methods as I'm doing a test on the thumb name
>> change:
>>         ... (unless (string= thumb old-thumb) ...
>
> This at least warrants a comment, so that others won't have to be
> bothered by the same questions.

What about this one?  I've also permuted some instructions to avoid a
flicker when updating the thumbnail.
-- 
Manuel Giraud

[0001-Fix-thumbnail-update-when-thumb-name-is-based-on-ima.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.