From unknown Sat Sep 06 14:24:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61387 <61387@debbugs.gnu.org> To: bug#61387 <61387@debbugs.gnu.org> Subject: Status: 30.0.50; Support webkit2gtk-4.1 Reply-To: bug#61387 <61387@debbugs.gnu.org> Date: Sat, 06 Sep 2025 21:24:25 +0000 retitle 61387 30.0.50; Support webkit2gtk-4.1 reassign 61387 emacs submitter 61387 Ulrich M=C3=BCller severity 61387 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 06:53:25 2023 Received: (at submit) by debbugs.gnu.org; 9 Feb 2023 11:53:25 +0000 Received: from localhost ([127.0.0.1]:57734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ5US-0005Qu-NV for submit@debbugs.gnu.org; Thu, 09 Feb 2023 06:53:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:36318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ5UP-0005Qf-FT for submit@debbugs.gnu.org; Thu, 09 Feb 2023 06:53:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ5UO-0005y1-1r for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 06:53:20 -0500 Received: from mail.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pQ5UI-0006br-Sq for bug-gnu-emacs@gnu.org; Thu, 09 Feb 2023 06:53:18 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Support webkit2gtk-4.1 Date: Thu, 09 Feb 2023 12:52:56 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:470:ea4a:1:5054:ff:fec7:86e4; envelope-from=ulm@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Gentoo is transitioning from webkit2gtk-4.0 to 4.1, see downstream bug at . Would it be possible to support webkit2gtk-4.1? IIUC there should be no API differences, so updating configure should be enough. The patch below adds a configure option --with-webkit2gtk=VALUE that allows to select version 4.0 or 4.1. I have tested this with the tip of the master branch (as of today), and it seems to build and work just fine with webkit2gtk-4.1. >From c3f765e7f987f4c29aaf9df80e304ee24b69427d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Thu, 9 Feb 2023 10:58:48 +0100 Subject: [PATCH] Support webkit2gtk version 4.1 * configure.ac: Add --with-webkit2gtk=VALUE configuration option, where VALUE can be 4.0 (default) or 4.1. --- configure.ac | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index fc17dbd8318..ac0ed8d5d11 100644 --- a/configure.ac +++ b/configure.ac @@ -521,6 +521,18 @@ otherwise for the first of 'inotify', 'kqueue' or 'gfile' that is usable.]) OPTION_DEFAULT_OFF([xwidgets], [enable use of xwidgets in Emacs buffers (requires gtk3 or macOS Cocoa)]) +AC_ARG_WITH([webkit2gtk],[AS_HELP_STRING([--with-webkit2gtk=VALUE], + [version of webkit2gtk to use (VALUE one of: 4.0, 4.1; default 4.0)])], + [ case "${withval}" in + 4.0|4.1) val=$withval ;; + *) AC_MSG_ERROR(['--with-webkit2gtk=$withval is invalid; +this option's value should be '4.0' or '4.1'.]) + ;; + esac + with_webkit2gtk=$val + ], + [with_webkit2gtk=4.0]) + OPTION_DEFAULT_OFF([be-app], [enable use of Haiku's Application Kit as a window system]) @@ -3583,7 +3595,7 @@ XWIDGETS_OBJ= if test "$with_xwidgets" != "no"; then if test "$USE_GTK_TOOLKIT" = "GTK3" && test "$window_system" != "none"; then WEBKIT_REQUIRED=2.12 - WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED" + WEBKIT_MODULES="webkit2gtk-$with_webkit2gtk >= $WEBKIT_REQUIRED" EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) HAVE_XWIDGETS=$HAVE_WEBKIT XWIDGETS_OBJ="xwidget.o" -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 07:24:14 2023 Received: (at 61387) by debbugs.gnu.org; 9 Feb 2023 12:24:14 +0000 Received: from localhost ([127.0.0.1]:57782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ5yI-0006E8-6O for submit@debbugs.gnu.org; Thu, 09 Feb 2023 07:24:14 -0500 Received: from sonic302-48.consmr.mail.ne1.yahoo.com ([66.163.186.174]:37453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ5yF-0006Dr-5m for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 07:24:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675945443; bh=ocS/NRgwDXwT3qUUY/gyAoh3fruc1Kx6VeuGMmL+1IA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=Q0Ww6wYL5nA0cXq3ovNN5uEUd/2SHegvYrov3CKJwH18oGVty6UhQcHRjU1JyBEBROpOZ3EMJAcuC9TJpOiKN3Liy8hsRRUQNW+0GcLARrdxP/sGk68DZYbKZDhtF8i4qnX8WSi3T5ucvXBEg4BbDKmJalCrlTET6VIk42E+eFEvNhr69dKyvwBWKw+Nl82tm9qSS9FmzTFwEGDIJ2g/aFeSwDGr18kOLAlbHloi3wCtrCJlR35XGjJc/T6eCBjYiC9pX3LWu23mqjxTGVrfPWNcZpBtfHs1ZLIYipo5X6hmnmNTTJzXOQgsBOa7nens2AY/F0MXJD+T+zJttlObJw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675945443; bh=Cb/iFimFaIB5MuJ3sjYjp9p0XkpOJNvkS0T1tOTob5W=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=C66czxGZJjnh+Jm90qq63s7gLoUQ7TAd3+CYqmP4X1ibiM2R0BtnjZGqvc+MFk/4BPykEGFcLXGUet1X7ozPuFLtq+wjjYethOPvYWOS5cBozs9/tfG8fi4YCAT2m9z6hH/fdQ2PhcyF64Q4xThSna88zA+n/LAn9h4MXw6t5BEE90Lf/fL3clLE/kdJGTLhLQ9kgmtNwScktEZY11VnhjeV3KCDYOJMEBvnvvK5RES+yTpfm1aPFk2QDIZhsM5hese1Xi/YVYOeC0ct1pyJgpkWB/apJPtEi+PU3ghrhv9XdQ73CZKw+EUA8nlax7k/vEm2BEN8ZcmkNEEx8FgVFA== X-YMail-OSG: ZF1YUfsVM1mzwX8FR1nmolqZIkS6itHqOPWDg2C8Th_bIxPx.aVpCjBlK2u5z.I ixBj6kahy2zLcE23BOCbvJrd4ZRIGDidO7RZdU1kVLENOE4g_bZUQRwjIHLB9NRq_Dz_8vl5KkB6 3ms5g2CSKKZEaFYbmzCVOJi2Q9QxYFdc4otRSZRSJIzGs_7i7kfs0k0gXqJRJSM4wAG4QDWIyACQ jvjbeljj842EX_vHvOn.03sRNi7wrp70Cfknz3ywRq6pleVy88FR74eWwoy0UVmCPXuTVbHmdVCj D4I8UM6IwQzy4RGOXweb9jrzVqnwa0fuBL6H91sX9K6KrqxsxA5LFyaRz8bcvxLcNlANsIcx_t0l 5FZhmFKmyqqSsvN5wBnYb_W7L0qsiBh1L_t4drLCRPDlViccLji1xH7I_RzcT39QKssDE8jqMJhT DAiKgJVm4VC311t2TX33yxfOyoXtToyQGT6fMO5xLiUIuRWIZ6Snlt.9sozCFbVRk1MATCRaowyS 1hRoUlGRQEJUWAiXJzBW6EVZATUOkYr5hvj1JNaStrXhMIBRbeBMDdmmqWnsWVkI71g3xhCKwFI_ YwzgR8XY_JtkIdKGWSVTacjFWQJGUtj81iPmBaljAV7J.j4P_p.exdSEOHdFUz0l.gwizMEFRF37 WZkGuJaQ_lpVJ9nR_FeQ0334dNLKhkkGMAO1wZiTMUYnj6JpDxSJJ8BHMe9DUwKv7xgwtQ272Ejz dRb6s1aXOfwxVcLJHZYjLme.rvATxbIxGBEll1YzXgXvpxD2G2pWcV.jtV78_A4jWQ27SlbxV_Pp GFqBwBdZoJ3wolSNbCFxmXHkxJadw9pMmicTcIS2ueYKA97FCAFYkYVyS2q5uF9ffCI0TEQRIQa4 Rhjhx1MG91lYe8GjG3AIhGqhe8C_8Ue5EjEnTlWe.7H6NGVbCaGK46zrtgZ.ifw6EJSqVGO6cnY. 6_554MTxrRgkYJi8QMGlkKV0hG9pXnxmFh7KVJ09iTPGviUXQR1HUuYzuIhmHQp1S68WeCS33ZuC eE5E13cmO2M6eHSqCfhkj.8yBI2A_4Uw_xUGMBhgwEWdkmsfdceeIb9ab1Eb7FnCWqs6jBCCJAoR 3lwmxIYWlbUh_GBRyfAjR2.qw7MztLuhQPr6TtLWPoL5WnIAoobvTOjLum_IOAAIvaVcC0cFukTp uSxxZD5ZV_P2Npl_5bJIQVRqEx0GM38gxDXtI3eL59hueXjjJ.4TyxBrwd57RPAh6dWnAcaC38mu DqVr4ipAop3unx6nJ6ZuELlPGPwrLmuKqHDyX3yd1V56nr9kkvndbkxLcQDN30dTvA0M26P3HOsH bNP7wclDZMIuhAdiycZNs30trwJhkUSvLJLS5V31NFihf4RyHRpHNneLmzgldon._O9.LMmowfrF m1kW6l3ZVffWHUHaxqvt7rPO7S05wOOGN6tZf8ZeOG9NKLWmoctQaR.hHXVSIwSfCiLpiy5AUtLK JQz5KqdEc8lCoX7_6hlOjrxD227GyZNL6SwiojS443N5ey6PCedyWqzfsFBz1EfDzcBKf.KUCHuo oWgrfhi3am0jPsVrFJSd9JusYOUTJJ4eEcHNAalpuC9pI_U6i85jR88X2PIk1hS2gOWmbcBb50Au bUhCRLWBWQhHz6WxFtmu0.IMZeRaRN3ROQsAmoR9EFuZuFJ0xHs16H.9WpOVVSnkqAGOPGmXEvLo FCN5jHO_UfWuf63.gwnKJ28wsziuZnWt_EPWINIWe7dlV7_FmXAN9WSjNSbC5UrhwRQBoYykD9bh InjeMuN._000p9ISZHmtlrTht7VwIUJW8mz9EzQ5MeGFsYW1YqKGxr75h10PbBpVMdoI0hh.T5wQ 707KxNA5ufC7g0T.KWiwPxy87AtUXArBPlesW3iyM0K28wwBkarhrBY7LAGxRS65poQFXakc86WN lbFFyPIElUjoaX7jMdUVe_adzldqIyCDonzWXAa64rRO5VfTgia0I46ejSEDczqOwo0Q4tnpWlSB LXIqiYr4Fuwx7fdU0WxQMnZuR0J0.2iv8RwIuJcAkxV7ZVEGYRrzrfNMFqrOZ8mTXo6x9lEizEFT QXVqu7mDQc48r8WS2ktRq79ywMwYv1ECxCs22jUujB_v3jDa13FzFge8QKwK.DuXQ12zujZ7R1hO .Jjpv4UhHHlYuakSY0hHfxOUlrBe_2.QXjY5I1_aBgqigl7mu.DYFFaLccqO7VfvzGjEwJvUt9eW tdZdKWL7_dhnCdoMaIwpxk8kXCLhvORlxHCt5mQ_jVl7z4QihfNZd4UNIzvTPaKMF1_iLBC7UVwn XdTb0TRbvJSA- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Thu, 9 Feb 2023 12:24:03 +0000 Received: by hermes--production-sg3-9fc5746c8-7wpmf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ec0b24217e4d44b8d2327ba9ccaffc72; Thu, 09 Feb 2023 12:22:00 +0000 (UTC) From: Po Lu To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Thu, 09 Feb 2023 12:52:56 +0100") References: Date: Thu, 09 Feb 2023 20:21:55 +0800 Message-ID: <87ilgb3u70.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21161 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 707 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61387 Cc: 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich M=C3=BCller writes: > Gentoo is transitioning from webkit2gtk-4.0 to 4.1, > see downstream bug at . > > Would it be possible to support webkit2gtk-4.1? IIUC there should be > no API differences, so updating configure should be enough. > > The patch below adds a configure option --with-webkit2gtk=3DVALUE that > allows to select version 4.0 or 4.1. > > I have tested this with the tip of the master branch (as of today), > and it seems to build and work just fine with webkit2gtk-4.1. I think it is ok to support both versions. However, please make configure search for both versions instead of making the user pick one at configure time. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 08:49:38 2023 Received: (at 61387) by debbugs.gnu.org; 9 Feb 2023 13:49:38 +0000 Received: from localhost ([127.0.0.1]:57948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ7Iw-0004rv-8P for submit@debbugs.gnu.org; Thu, 09 Feb 2023 08:49:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ7Iu-0004rb-NA for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 08:49:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ7Ip-0004uf-At; Thu, 09 Feb 2023 08:49:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+v0JNao5RSH2vkMoH54DxlJrgSiGPqKFsCylXureUws=; b=WvhIkI6rZxKsvBtj+y8f uUxYjzhzTIA03D65dLC/4ZvF3H+oOlh3zITEI/yqpX/N/xpqIOR5dnm+xK9fke2DFuXwebB8nDyRh /+Af41u9o4d6DiYyd77fV0umi5h4HZGnag4iKCiC0ZXnATH7D413DB5hsHK765Vmk+dEEsSrRFXar zuL+VYvnhTkRYCpoAt5mKOHFP/PIe5Flq5Oku7ieqN4bkz81Stpt2+2E+uu0icOC95yGbqzils0Do DPwPfCBRquttYClGXaicH7bLY+0hj/burJQp6zLqBJqMrA0psv2gTQ6j891KUvFDogOQr07OBEPdd HTaablaHp73iyw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ7Io-0004RG-QU; Thu, 09 Feb 2023 08:49:31 -0500 Date: Thu, 09 Feb 2023 15:49:21 +0200 Message-Id: <83zg9nkkym.fsf@gnu.org> From: Eli Zaretskii To: Ulrich =?iso-8859-1?Q?M=FCller?= In-Reply-To: (message from Ulrich =?iso-8859-1?Q?M?= =?iso-8859-1?Q?=FCller?= on Thu, 09 Feb 2023 12:52:56 +0100) Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 References: MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61387 Cc: 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Müller > Date: Thu, 09 Feb 2023 12:52:56 +0100 > > Gentoo is transitioning from webkit2gtk-4.0 to 4.1, > see downstream bug at . > > Would it be possible to support webkit2gtk-4.1? IIUC there should be > no API differences, so updating configure should be enough. Are you proposing this for Emacs 29 or for Emacs 30? > The patch below adds a configure option --with-webkit2gtk=VALUE that > allows to select version 4.0 or 4.1. Is it really necessary to ask for a specific version? Why cannot Emacs use the version that is installed? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 09:19:50 2023 Received: (at 61387) by debbugs.gnu.org; 9 Feb 2023 14:19:50 +0000 Received: from localhost ([127.0.0.1]:58013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ7mA-0005gU-2l for submit@debbugs.gnu.org; Thu, 09 Feb 2023 09:19:50 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:38794 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ7m7-0005gF-P6 for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 09:19:48 -0500 From: Ulrich Mueller To: Eli Zaretskii Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 In-Reply-To: <83zg9nkkym.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Feb 2023 15:49:21 +0200") References: <83zg9nkkym.fsf@gnu.org> Date: Thu, 09 Feb 2023 15:19:37 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61387 Cc: 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Thu, 09 Feb 2023, Eli Zaretskii wrote: > Are you proposing this for Emacs 29 or for Emacs 30? Emacs 30, because I thought that it was to late for it to land in the emacs-29 branch? If it could be included in Emacs 29, I would prefer that. >> The patch below adds a configure option --with-webkit2gtk=VALUE that >> allows to select version 4.0 or 4.1. > Is it really necessary to ask for a specific version? Why cannot > Emacs use the version that is installed? That could be done as a fallback, but a configure switch is still needed. Think of a package for a distro, which has to include the information whether webkit2gtk-4.0 or 4.1 have to be pulled in as a dependency. There, Emacs has to be built against a well-defined version, even if both versions of webkit2 are installed on the build system (for Gentoo, that will be the case for some transition time). Should I update the patch to allow 3 values "4.0", "4.1", and "auto", with "auto" being the default? And in the default case, should it check for 4.0 or 4.1 first? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 10:42:18 2023 Received: (at 61387) by debbugs.gnu.org; 9 Feb 2023 15:42:18 +0000 Received: from localhost ([127.0.0.1]:33305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ93y-0000H2-8J for submit@debbugs.gnu.org; Thu, 09 Feb 2023 10:42:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ93w-0000Go-NU for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 10:42:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ93r-0003h1-0c; Thu, 09 Feb 2023 10:42:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=AyAHthukHIVRDdsrlTdO//LE0R2TatAwVoL6TL6MjJc=; b=BKY++p6zzPl5 /yuN7595qC0eBG0AIHlKtMrQrsFyofzN7In13iIdZwW8RdfiRrdbKX03ASZKmwuu+Lmh605jfpPop 5+rOerYN7i3gnMdnyywUf7G2sd482kknv3mhNOTA6cFvWIyZYXFQ05SaJBBoe7DOi9CNxFrHqMnr8 fc06hzmU5ma+2WmkDaMuE61QmCu2o1iuX0wA8SxwHjCYZ9flGgBHf/jnElFLJo2NsqHo3WWlF7sUY Z01qpyC251Hwr5kGt1APve1y7pd0hOEZx8u/pYpO6XzlbH7FkG88x6fy5LoHBznqF4nQ6lJFk97/B 1GiSVMy328YMSncUuQ23vQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ93p-0000TM-El; Thu, 09 Feb 2023 10:42:09 -0500 Date: Thu, 09 Feb 2023 17:41:55 +0200 Message-Id: <83sffelubg.fsf@gnu.org> From: Eli Zaretskii To: Ulrich Mueller In-Reply-To: (message from Ulrich Mueller on Thu, 09 Feb 2023 15:19:37 +0100) Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 References: <83zg9nkkym.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61387 Cc: 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ulrich Mueller > Cc: 61387@debbugs.gnu.org > Date: Thu, 09 Feb 2023 15:19:37 +0100 > > >>>>> On Thu, 09 Feb 2023, Eli Zaretskii wrote: > > > Are you proposing this for Emacs 29 or for Emacs 30? > > Emacs 30, because I thought that it was to late for it to land in the > emacs-29 branch? If it could be included in Emacs 29, I would prefer > that. But if Gentoo is transitioning to this new version of webkit, wouldn't it make sense for Emacs 29 to support that, rather than require users to have a version of webkit that is considered outdated by Gentoo? > >> The patch below adds a configure option --with-webkit2gtk=VALUE that > >> allows to select version 4.0 or 4.1. > > > Is it really necessary to ask for a specific version? Why cannot > > Emacs use the version that is installed? > > That could be done as a fallback, but a configure switch is still > needed. Think of a package for a distro, which has to include the > information whether webkit2gtk-4.0 or 4.1 have to be pulled in as > a dependency. There, Emacs has to be built against a well-defined > version, even if both versions of webkit2 are installed on the build > system (for Gentoo, that will be the case for some transition time). > > Should I update the patch to allow 3 values "4.0", "4.1", and "auto", > with "auto" being the default? Yes, please. > And in the default case, should it check for 4.0 or 4.1 first? I think 4.1 first, don't you agree? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 10:55:05 2023 Received: (at 61387) by debbugs.gnu.org; 9 Feb 2023 15:55:05 +0000 Received: from localhost ([127.0.0.1]:33321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ9GL-0000fD-Bm for submit@debbugs.gnu.org; Thu, 09 Feb 2023 10:55:05 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:49408 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ9GJ-0000ec-Lk for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 10:55:04 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: Eli Zaretskii Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 In-Reply-To: <83sffelubg.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 09 Feb 2023 17:41:55 +0200") References: <83zg9nkkym.fsf@gnu.org> <83sffelubg.fsf@gnu.org> Date: Thu, 09 Feb 2023 16:54:53 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61387 Cc: 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Thu, 09 Feb 2023, Eli Zaretskii wrote: > But if Gentoo is transitioning to this new version of webkit, wouldn't > it make sense for Emacs 29 to support that, rather than require users > to have a version of webkit that is considered outdated by Gentoo? We would have backported the patch to the Gentoo package for Emacs 29. Including it upstream is of course preferable. >> Should I update the patch to allow 3 values "4.0", "4.1", and "auto", >> with "auto" being the default? > Yes, please. >> And in the default case, should it check for 4.0 or 4.1 first? > I think 4.1 first, don't you agree? Yes. Please find the updated patch below. It applies cleanly to both master and emacs-29. >From 9ac6e3711426eddacd095380b8e7f64a405706b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Thu, 9 Feb 2023 10:58:48 +0100 Subject: [PATCH] Support webkit2gtk version 4.1 * configure.ac: Add --with-webkit2gtk=VALUE configuration option, where VALUE can be 4.0, 4.1, or auto (default). --- configure.ac | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index fc17dbd8318..d951fa84701 100644 --- a/configure.ac +++ b/configure.ac @@ -521,6 +521,19 @@ otherwise for the first of 'inotify', 'kqueue' or 'gfile' that is usable.]) OPTION_DEFAULT_OFF([xwidgets], [enable use of xwidgets in Emacs buffers (requires gtk3 or macOS Cocoa)]) +AC_ARG_WITH([webkit2gtk],[AS_HELP_STRING([--with-webkit2gtk=VALUE], + [version of webkit2gtk API to use (VALUE one of: 4.0, 4.1, auto; +default auto)])], + [ case "${withval}" in + 4.0|4.1|auto) val=$withval ;; + *) AC_MSG_ERROR(['--with-webkit2gtk=$withval' is invalid; +this option's value should be '4.0', '4.1', or 'auto'.]) + ;; + esac + with_webkit2gtk=$val + ], + [with_webkit2gtk=auto]) + OPTION_DEFAULT_OFF([be-app], [enable use of Haiku's Application Kit as a window system]) @@ -3583,8 +3596,17 @@ XWIDGETS_OBJ= if test "$with_xwidgets" != "no"; then if test "$USE_GTK_TOOLKIT" = "GTK3" && test "$window_system" != "none"; then WEBKIT_REQUIRED=2.12 - WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED" - EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) + if test "$with_webkit2gtk" = "auto"; then + WEBKIT_MODULES="webkit2gtk-4.1 >= $WEBKIT_REQUIRED" + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) + if test "$HAVE_WEBKIT" = "no"; then + WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED" + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) + fi + else + WEBKIT_MODULES="webkit2gtk-$with_webkit2gtk >= $WEBKIT_REQUIRED" + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) + fi HAVE_XWIDGETS=$HAVE_WEBKIT XWIDGETS_OBJ="xwidget.o" if test "$HAVE_X_WINDOWS" = "yes" && test "${with_cairo}" = "no"; then -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 09 21:58:18 2023 Received: (at 61387) by debbugs.gnu.org; 10 Feb 2023 02:58:18 +0000 Received: from localhost ([127.0.0.1]:34017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQJcA-0000aE-DH for submit@debbugs.gnu.org; Thu, 09 Feb 2023 21:58:18 -0500 Received: from sonic317-2.consmr.mail.ne1.yahoo.com ([66.163.184.229]:40521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQJc8-0000Zy-6Y for 61387@debbugs.gnu.org; Thu, 09 Feb 2023 21:58:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675997890; bh=qMyJOQvT1IOh0cfIMRP/E4zq8jdExi5KU1EbkQJho1Q=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=pm10Bss5zVHtrQ4wVUrv/iBA9SjBkFv5C9CXHTiQ5yoMRz3O8BAhX4m9zTrz6V6oGMZn0wrjWJkro2VmA3xgNWf6a6SVPCovWGX9FfVCNCalLnrT2wg/hTMqt0PL6cRTkyGbom7TbxO90xlxx95u8AwBy/dqdS3Uw/4tYZ3+z4AygOYy4ar51RTkTv9JPlQmUJSx+pHxD7bwyWxoBm+xEX0PojGa937p2xc1ZojbKNT3uFLNoEXob+BridfvTnSv8wEn/7s+3xEHg+r36W3GCNYhbmSXUh5dF9MalQMQcvPgnhzaBO0Zd+FvaS80fDlJCUoMc9JgLVxka3eQrneQ7g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1675997890; bh=0TInpogmzg3/jol+d7r9uo9PsPdIcwL+CZBGiI58QBt=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=jrQUttgU/w/jVAuondoHVgdZV9fmz3LKiL2aMhb+qat1KFB4stK+IRKVbK9Qe65O8fpTp3uaGsxqbwD/niBd66wdLO+VlL8g/4A/IsyL2//jkc5zxaLOw5PPYqRTrEjsQeK6QLRDuvgfi/cJVj/W8uIX8ia1mw1ePpUF1z1/WAct+Xgqwbu9sc46utPtCnI5BEcGzt3NL8HalzTWAvWFqY0BelZtKSYuAy6Y5RbqQBaKsU4qZFxt0aFb92KOGH0Y4jlWQvg6LU6qQxEiHCZmXgx4HmTnDrRjAo55LrVGSO+TXbc76BNC9kCOB/z0jLDjFakW7/tp7LLO7sW/QQX8Ng== X-YMail-OSG: bslKdqkVM1mZ7vXqhDa98RdivJZXmevXOTfSeeffPceD4W1wZVNGodPn32Hvr9e 58gG1pgOpE.8dV.jPQZyJgmWvgxOR7GvzKnAgmQcbLvWiecMnMXRLDtLMA8rNO2Sb0C7ge24yEcA 1OgAayYy.13kstfmrVj.GdwvRmbbLbax0xOrCJz5UDd_V7hwRjM.6a6DR1cOf8XwhuW_YutMU_c2 MRcjY3mht9FxK_3fQ2q110XolXEXe_hpylNOl1iMM5WzxAKFfNeEk.qSMBpJfdRlTm.bD2n6p70n uEOYrEQVLzQYY.RBO4CefYdMK0fQoXh6oANi_pWD9bHgGyKQLHW5Q5jnkLi0egythykaAQ4XeCKN ICnowmuPuznfZpwBgA1LvThO2mkzOj40D7wK6qvRW0m1D6WUDtwr0CEWln4xh_r.sWShQpzLgxx9 oo3XfQ_laGOd2ELTxM3GSyXwMUMCJlRk2MZfFEAe2O6YDob6.UrU5Z71ueT21jHFmbxlX.bSw7hT KKZCIQjETTpBx462XBO9qWQKfeskzQsyGQmigyuS9TkwUA8rL.YpF1SpjQpmPAt.sSLtvzPE7czY 3H3WYwEnNWMDMkDASiI59eyq2WKovmFPM.ty18bALbGP8c7mhOWb06U52G0MueJGYyZ7_2VNMgiF uzwsGvnADNtcGm.vSyL1u_Ne8zpnKj8YF2yWbCzJzMIyY65G_zwi7M2h8gF2_R_GdHsXXQKtPko4 MWvBvtYsjySvKd8Zirtt8l85x7LJ3Ikmswxp82F4YqNcc204r_y8wdKbRMGzq770Z3n5UGzdZBZB LPcUQMSEs9YQcQ77VnRwMhndLCFQ5HGWbR6GuzRR8JW7qw0TtVXqgkWe1w5f9Xjk7amlDwk3ZGn. xiILDEb2UcgiQOB8PjwITzunBUw9rJ7CIBBsI3V1tpICZrGpknjlX4QZBQFa6Pt0QMFacna8LpsJ Qrrwl6gkHrC5fe_IcYOTUsNEVDyyPmnNF2e1joiPQNDZ6UNgT8vy._Na19rDx1WztG.dUkzlD35D xtiGvSqMpssIhd5r56vtOQ9nJYx3laAOFvdRaLwvVmevnSU2wOP0d5hvyDOg2X0oXZZQ101CGo6e eYI7OSE1axmLSRDu0xZh.MHroWlFZFOrbhgNlr.NNV4NiNC7GG5eBvV63PSHbH.iYCr5XQ44yoi. wbOJpoSzGLxMLRAJ3gyAzDlkmsy0MbxR6p80Gc9PNm1INJx3qrHeZyGKGTXJ1Yaaqj_wSF4FyAHo 4iD8uvI9VGUeDYMeGnH8cEJ0LEQyLDqpAJHshfm.XvM4ctayhuBGFCGVBE2Up9MYbHE6gHPdsmHI Gyt2p4sHr.ApTkMRj4FLiYNpoJe5XjxlU7nZokMIoNaRBy3TGlI3OtIj.jHRyfZJWGp5G2uNWcmN H96kYoybOphb0DF9f9lRdHS58LNDruwfgYgarU2RpyzwmhqYOoYdsiBnZlhpIoSVQ8Dgd4a..hj0 nKDjMRoiMsk9J4IroMYiZf4VJvWplKKdsmc10s9lYsr.3PVO1BTcKDnsPuL3aoNjHItylja3R2cf dXR56DGCrPB1lA61OJTKq43_whsSjhuwRFF.BLDAZcmAXL057IFRcUSAboLPA_eB1tUPDRhKB0NB 4cAtZGw4jVxYNyhZU46GiMjjGWW3WMRyRMR3X3tKSLrvZieGtGDtDvReXDxDHaiVBfpQolTh8J6y gy9zqxJ417vqbMESN7OpBj8J8zjXKlBcyOhgmJt0Of_J_htdKIXYBqlw6.snH.4d6xZDrspYbPf5 1_4B_caNeAQlymZkRFfjusEBsuEeEarOjDwcC6vS1fIQhZVK1OumHM3N02YzEtvHOcwKw5AakR7F 1J9UKMxhBXP9BiBABK.Kc7iPskvLFbVGMqjq7diaqn7Vr2UiUrR5rZaiMQtvxTinFH4Vm0haGy3k 7.y.HzxSrtffiLP20MglRoTBtsYWNdmK7cJnasrNEFkmYqg8OGOkqjQHoIXnDsU2JZ1w3fI1ENjB K.AFHfAIliCZabd3y3BMUlQNOIbdNG8TZGuS2ryuRn.lCT2vdflqgd4Siq.tpOcCVQULohM846Al WqOvPjq_Je3wyQRMddgCrizBq8qNOgHxScXwwBOa0R9ntJt60Md5eXLwBywHnPZDjBBAxlPkutfS bPvg9qFQRYo4EH8HX.t60zdIJIVxHhKzr4AjdqoJ76l1lKHEjWfuB37kqOdR4Il6_sv8rJUiQ4Cd uDChEtZS9978XSCrxUVzvHYjbCKF_r8k5oWjyoyPmcIb4EpSCkf_CYshFQvLabt1Q.ljIp9SvZjS nSBpZd6mA X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 10 Feb 2023 02:58:10 +0000 Received: by hermes--production-sg3-9fc5746c8-2jxhw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fd540164e4cdac3f309c0c31f48682f6; Fri, 10 Feb 2023 02:56:07 +0000 (UTC) From: Po Lu To: Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Thu, 09 Feb 2023 16:54:53 +0100") References: <83zg9nkkym.fsf@gnu.org> <83sffelubg.fsf@gnu.org> Date: Fri, 10 Feb 2023 10:56:01 +0800 Message-ID: <87wn4q2pq6.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.21161 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 3565 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61387 Cc: Eli Zaretskii , 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ulrich M=C3=BCller writes: >>>>>> On Thu, 09 Feb 2023, Eli Zaretskii wrote: > >> But if Gentoo is transitioning to this new version of webkit, wouldn't >> it make sense for Emacs 29 to support that, rather than require users >> to have a version of webkit that is considered outdated by Gentoo? > > We would have backported the patch to the Gentoo package for Emacs 29. > Including it upstream is of course preferable. > >>> Should I update the patch to allow 3 values "4.0", "4.1", and "auto", >>> with "auto" being the default? > >> Yes, please. > >>> And in the default case, should it check for 4.0 or 4.1 first? > >> I think 4.1 first, don't you agree? > > Yes. Please find the updated patch below. It applies cleanly to both > master and emacs-29. > > >>>From 9ac6e3711426eddacd095380b8e7f64a405706b2 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Ulrich=3D20M=3DC3=3DBCller?=3D > Date: Thu, 9 Feb 2023 10:58:48 +0100 > Subject: [PATCH] Support webkit2gtk version 4.1 > > * configure.ac: Add --with-webkit2gtk=3DVALUE configuration option, > where VALUE can be 4.0, 4.1, or auto (default). > --- > configure.ac | 26 ++++++++++++++++++++++++-- > 1 file changed, 24 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index fc17dbd8318..d951fa84701 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -521,6 +521,19 @@ otherwise for the first of 'inotify', 'kqueue' or 'g= file' that is usable.]) > OPTION_DEFAULT_OFF([xwidgets], > [enable use of xwidgets in Emacs buffers (requires gtk3 or macOS Cocoa= )]) >=20=20 > +AC_ARG_WITH([webkit2gtk],[AS_HELP_STRING([--with-webkit2gtk=3DVALUE], > + [version of webkit2gtk API to use (VALUE one of: 4.0, 4.1, auto; > +default auto)])], > + [ case "${withval}" in > + 4.0|4.1|auto) val=3D$withval ;; > + *) AC_MSG_ERROR(['--with-webkit2gtk=3D$withval' is invalid; > +this option's value should be '4.0', '4.1', or 'auto'.]) > + ;; > + esac > + with_webkit2gtk=3D$val > + ], > + [with_webkit2gtk=3Dauto]) > + > OPTION_DEFAULT_OFF([be-app], > [enable use of Haiku's Application Kit as a window system]) >=20=20 > @@ -3583,8 +3596,17 @@ XWIDGETS_OBJ=3D > if test "$with_xwidgets" !=3D "no"; then > if test "$USE_GTK_TOOLKIT" =3D "GTK3" && test "$window_system" !=3D "n= one"; then > WEBKIT_REQUIRED=3D2.12 > - WEBKIT_MODULES=3D"webkit2gtk-4.0 >=3D $WEBKIT_REQUIRED" > - EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + if test "$with_webkit2gtk" =3D "auto"; then > + WEBKIT_MODULES=3D"webkit2gtk-4.1 >=3D $WEBKIT_REQUIRED" > + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + if test "$HAVE_WEBKIT" =3D "no"; then > + WEBKIT_MODULES=3D"webkit2gtk-4.0 >=3D $WEBKIT_REQUIRED" > + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + fi > + else > + WEBKIT_MODULES=3D"webkit2gtk-$with_webkit2gtk >=3D $WEBKIT_REQUIRE= D" > + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) > + fi > HAVE_XWIDGETS=3D$HAVE_WEBKIT > XWIDGETS_OBJ=3D"xwidget.o" > if test "$HAVE_X_WINDOWS" =3D "yes" && test "${with_cairo}" =3D "no"= ; then Please make the configure script detect WebKitGTK 4.1 by default, and fall back to 4.0. Not many systems will have both installed at the same time, and it is best for Emacs to use the newer version. People who want to use the older version can specify the cflags on the command line to configure. There is no need for a ``--with-webkit2gtk'' option, which is not very consistent with every other library we support. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 10 00:27:23 2023 Received: (at 61387) by debbugs.gnu.org; 10 Feb 2023 05:27:23 +0000 Received: from localhost ([127.0.0.1]:34110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQLwR-0004e4-FS for submit@debbugs.gnu.org; Fri, 10 Feb 2023 00:27:23 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:43798 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQLwP-0004dn-9d for 61387@debbugs.gnu.org; Fri, 10 Feb 2023 00:27:21 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: Po Lu Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 In-Reply-To: <87wn4q2pq6.fsf@yahoo.com> (Po Lu's message of "Fri, 10 Feb 2023 10:56:01 +0800") References: <83zg9nkkym.fsf@gnu.org> <83sffelubg.fsf@gnu.org> <87wn4q2pq6.fsf@yahoo.com> Date: Fri, 10 Feb 2023 06:27:11 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61387 Cc: Eli Zaretskii , 61387@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >>>>> On Fri, 10 Feb 2023, Po Lu wrote: > Please make the configure script detect WebKitGTK 4.1 by default, and > fall back to 4.0. > Not many systems will have both installed at the same time, and it is > best for Emacs to use the newer version. > People who want to use the older version can specify the cflags on the > command line to configure. There is no need for a ``--with-webkit2gtk'' > option, which is not very consistent with every other library we support. >From be0951e9ddf7cf4d39b8b2328a46cd5cc31ba067 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ulrich=20M=C3=BCller?= Date: Thu, 9 Feb 2023 10:58:48 +0100 Subject: [PATCH] Support webkit2gtk-4.1 * configure.ac: Check for webkit2gtk API version 4.1 first, then fall back to 4.0. --- configure.ac | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 645082c9746..bc7e61048c3 100644 --- a/configure.ac +++ b/configure.ac @@ -3613,8 +3613,12 @@ XWIDGETS_OBJ= if test "$with_xwidgets" != "no"; then if test "$USE_GTK_TOOLKIT" = "GTK3" && test "$window_system" != "none"; then WEBKIT_REQUIRED=2.12 - WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED" + WEBKIT_MODULES="webkit2gtk-4.1 >= $WEBKIT_REQUIRED" EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) + if test "$HAVE_WEBKIT" = "no"; then + WEBKIT_MODULES="webkit2gtk-4.0 >= $WEBKIT_REQUIRED" + EMACS_CHECK_MODULES([WEBKIT], [$WEBKIT_MODULES]) + fi HAVE_XWIDGETS=$HAVE_WEBKIT XWIDGETS_OBJ="xwidget.o" if test "$HAVE_X_WINDOWS" = "yes" && test "${with_cairo}" = "no"; then -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 04:40:36 2023 Received: (at 61387) by debbugs.gnu.org; 12 Feb 2023 09:40:36 +0000 Received: from localhost ([127.0.0.1]:44070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR8qa-00018G-Ei for submit@debbugs.gnu.org; Sun, 12 Feb 2023 04:40:36 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:47804 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR8qX-000180-GP for 61387@debbugs.gnu.org; Sun, 12 Feb 2023 04:40:35 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: 61387@debbugs.gnu.org Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 In-Reply-To: ("Ulrich =?utf-8?Q?M=C3=BCller=22's?= message of "Fri, 10 Feb 2023 06:27:11 +0100") References: <83zg9nkkym.fsf@gnu.org> <83sffelubg.fsf@gnu.org> <87wn4q2pq6.fsf@yahoo.com> Date: Sun, 12 Feb 2023 10:40:23 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61387 Cc: Po Lu , Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 61387 29.1 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 12 04:46:41 2023 Received: (at control) by debbugs.gnu.org; 12 Feb 2023 09:46:42 +0000 Received: from localhost ([127.0.0.1]:44083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR8wT-0001IP-MC for submit@debbugs.gnu.org; Sun, 12 Feb 2023 04:46:41 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:48420 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pR8wS-0001IB-8j for control@debbugs.gnu.org; Sun, 12 Feb 2023 04:46:40 -0500 From: Ulrich =?utf-8?Q?M=C3=BCller?= To: control@debbugs.gnu.org Subject: Re: bug#61387: 30.0.50; Support webkit2gtk-4.1 Date: Sun, 12 Feb 2023 10:46:30 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 61387 29.1 thanks From unknown Sat Sep 06 14:24:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 12 Mar 2023 11:24:16 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator