From debbugs-submit-bounces@debbugs.gnu.org Fri May 07 16:41:28 2010 Received: (at submit) by debbugs.gnu.org; 7 May 2010 20:41:29 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OAUMS-0002CQ-Kc for submit@debbugs.gnu.org; Fri, 07 May 2010 16:41:28 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OAUMQ-0002CL-JM for submit@debbugs.gnu.org; Fri, 07 May 2010 16:41:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Am4GAG8Y5EtFpYAg/2dsb2JhbACRYYw6cr9ehRUEjDM X-IronPort-AV: E=Sophos;i="4.52,350,1270440000"; d="scan'208";a="63687958" Received: from 69-165-128-32.dsl.teksavvy.com (HELO pastel.home) ([69.165.128.32]) by ironport2-out.pppoe.ca with ESMTP; 07 May 2010 16:41:16 -0400 Received: by pastel.home (Postfix, from userid 20848) id D5C02814C; Fri, 7 May 2010 16:41:15 -0400 (EDT) From: Stefan Monnier To: submit@debbugs.gnu.org Subject: [Yuriy Vostrikov] emacs, vc-git Message-ID: Date: Fri, 07 May 2010 16:41:15 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit Cc: Yuriy Vostrikov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.9 (/) [ I do not use Git enough to be sure if his patch is the right way to fix it. It does look OK, tho maybe the right (but harder) place to fix it is in Tramp. Can someone take a look and install it? --Stef ] Hello. You are last commiter of vc-git.el so i'm writing to you. It's probably a good idea to forcefully disable pager then calling git command from vc-git.el. If buffer is tramp controlled then git will be run on remote host by tramp magic. In this particular case git stdout will be connected to pty instead of pipe and default git behavior to call $PAGER in this case. Which is effectively makes vc-git broken on tramp controlled buffers. Patch is attached. === modified file 'lisp/vc-git.el' --- lisp/vc-git.el 2010-04-21 02:05:24 +0000 +++ lisp/vc-git.el 2010-05-05 09:28:56 +0000 @@ -966,7 +966,7 @@ (defun vc-git-command (buffer okstatus file-or-list &rest flags) "A wrapper around `vc-do-command' for use in vc-git.el. The difference to vc-do-command is that this function always invokes `git'." - (apply 'vc-do-command (or buffer "*vc*") okstatus "git" file-or-list flags)) + (apply 'vc-do-command (or buffer "*vc*") okstatus "git" file-or-list (cons "--no-pager" flags))) (defun vc-git--empty-db-p () "Check if the git db is empty (no commit done yet)." From debbugs-submit-bounces@debbugs.gnu.org Fri May 07 17:39:07 2010 Received: (at 6137) by debbugs.gnu.org; 7 May 2010 21:39:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OAVGF-0002bt-1C for submit@debbugs.gnu.org; Fri, 07 May 2010 17:39:07 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OAVGC-0002bX-PU for 6137@debbugs.gnu.org; Fri, 07 May 2010 17:39:05 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OAVGA-00044b-O0; Fri, 07 May 2010 17:39:02 -0400 To: 6137@debbugs.gnu.org Subject: Re: bug#6137: [Yuriy Vostrikov] emacs, vc-git References: From: Glenn Morris X-Spook: Maple bootleg Glock target InfoSec Hamas DRM SAPO X-Ran: 1\PM)QlAxhw#ufr3-; User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 6137 Cc: delamonpansie@gmail.com, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) [ Resending from help-debbugs, where it ended up. Please specify a package if you want to use the submit@debbugs address to create a new report.] Stefan Monnier wrote: [ I do not use Git enough to be sure if his patch is the right way to fix it. It does look OK, tho maybe the right (but harder) place to fix it is in Tramp. Can someone take a look and install it? --Stef ] Hello. You are last commiter of vc-git.el so i'm writing to you. It's probably a good idea to forcefully disable pager then calling git command from vc-git.el. If buffer is tramp controlled then git will be run on remote host by tramp magic. In this particular case git stdout will be connected to pty instead of pipe and default git behavior to call $PAGER in this case. Which is effectively makes vc-git broken on tramp controlled buffers. Patch is attached. === modified file 'lisp/vc-git.el' --- lisp/vc-git.el 2010-04-21 02:05:24 +0000 +++ lisp/vc-git.el 2010-05-05 09:28:56 +0000 @@ -966,7 +966,7 @@ (defun vc-git-command (buffer okstatus file-or-list &rest flags) "A wrapper around `vc-do-command' for use in vc-git.el. The difference to vc-do-command is that this function always invokes `git'." - (apply 'vc-do-command (or buffer "*vc*") okstatus "git" file-or-list flags)) + (apply 'vc-do-command (or buffer "*vc*") okstatus "git" file-or-list (cons "--no-pager" flags))) (defun vc-git--empty-db-p () "Check if the git db is empty (no commit done yet)." From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 30 02:45:56 2012 Received: (at 6137-done) by debbugs.gnu.org; 30 Nov 2012 07:45:56 +0000 Received: from localhost ([127.0.0.1]:46075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeLIH-0003Zh-8C for submit@debbugs.gnu.org; Fri, 30 Nov 2012 02:45:54 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:50105) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TeLIE-0003ZV-9U for 6137-done@debbugs.gnu.org; Fri, 30 Nov 2012 02:45:51 -0500 Received: by mail-pa0-f44.google.com with SMTP id hz11so158731pad.3 for <6137-done@debbugs.gnu.org>; Thu, 29 Nov 2012 23:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=8zwIGnB/O4cy7kgBbJtGZ6efcari0i+0agVf+wDxhOo=; b=Azf9/qlZkGQtMZHquXSc5m7sb8wPsJmM7vesDD/sn0YbNMqBCAQ+7v2gvcBLY5gqzp F4M4cfVvPhYV5F+LCr1kvT2tyTFOGZAmStwpZav0GEvkL1KqXkSkOWxT6KR//a/NuY/O GBOrVXTTkUptihyERKq+//eRWv+V0vtJtJD5BVDNIunsg3IgcMDlznWhZotgmhqH0ovq 0vMHHVX5e+u2Uez/ZkMTC60PMUeHc5XkvqGAyXuk0Axu//tyChjVakfQICCNYgSIMTwU cGWmBFZ+2VxjhHpXq+4ne7sraZPIMnhNJOXww5Sw0JsXHRoOpxpDpzf6A6m/XwE2+640 /TLQ== Received: by 10.66.73.102 with SMTP id k6mr1114091pav.22.1354261425445; Thu, 29 Nov 2012 23:43:45 -0800 (PST) Received: from ulysses ([155.69.16.180]) by mx.google.com with ESMTPS id uh10sm2626290pbc.35.2012.11.29.23.43.41 (version=SSLv3 cipher=OTHER); Thu, 29 Nov 2012 23:43:44 -0800 (PST) From: Chong Yidong To: Stefan Monnier Subject: Re: bug#6137: [Yuriy Vostrikov] emacs, vc-git References: Date: Fri, 30 Nov 2012 15:43:38 +0800 In-Reply-To: (Stefan Monnier's message of "Fri, 07 May 2010 16:41:15 -0400") Message-ID: <87a9tzsfh1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 6137-done Cc: Yuriy Vostrikov , 6137-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) Stefan Monnier writes: > [ I do not use Git enough to be sure if his patch is the right way to > fix it. It does look OK, tho maybe the right (but harder) place to > fix it is in Tramp. Can someone take a look and install it? --Stef ] > > Hello. > You are last commiter of vc-git.el so i'm writing to you. > > It's probably a good idea to forcefully disable pager then calling git > command from vc-git.el. If buffer is tramp controlled then git will > be run on remote host by tramp magic. In this particular case git > stdout will be connected to pty instead of pipe and default git > behavior to call $PAGER in this case. Which is effectively makes > vc-git broken on tramp controlled buffers. Patch is attached. Since no one's done anything about this, and the fix looks OK, I've committed it to trunk. From unknown Sun Jun 22 11:39:44 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Dec 2012 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator