GNU bug report logs - #61366
[PATCH] ; Add usage, will not continue if no parameters are provided.

Previous Next

Full log

View this message in rfc822 format

From: lux <lx <at> shellcodes.org>
To: 61366 <at> debbugs.gnu.org
Subject: bug#61366: [PATCH] ; Add usage, will not continue if no parameters are provided.
Date: Sat, 18 Feb 2023 23:27:34 +0800

Xi Lu <lx <at> shellcodes.org> writes:

> ---
>  admin/notes/tree-sitter/build-module/build.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/admin/notes/tree-sitter/build-module/build.sh b/admin/notes/tree-sitter/build-module/build.sh
> index 9dc674237ca..08a71c1dde1 100755
> --- a/admin/notes/tree-sitter/build-module/build.sh
> +++ b/admin/notes/tree-sitter/build-module/build.sh
> @@ -3,6 +3,12 @@
>  lang=$1
>  topdir="$PWD"
>  
> +if [ $# -lt 1 ]
> +then
> +    echo "Usage: $0 <language>"
> +    exit
> +fi
> +
>  case $(uname) in
>      "Darwin")
>          soext="dylib"

This patch need to review. If not give the `language' paramter, some
errors will be printed.

IMHO, Can the batch.sh and build.sh merge to one shell file?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.