GNU bug report logs - #61360
[PATCH] gnu: gimp: Don't retain reference on GCC.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61360: closed ([PATCH] gnu: gimp: Don't retain reference on GCC.)
Date: Thu, 02 Mar 2023 03:45:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 02 Mar 2023 11:44:39 +0800
with message-id <87fsanq0k8.fsf_-_ <at> envs.net>
and subject line Re: bug#61360: [PATCH] gnu: gimp: Don't retain reference on GCC.
has caused the debbugs.gnu.org bug report #61360,
regarding [PATCH] gnu: gimp: Don't retain reference on GCC.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
61360: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61360
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: gimp: Don't retain reference on GCC.
Date: Wed,  8 Feb 2023 15:09:30 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

Partly fixes <https://issues.guix.gnu.org/57677>.

* gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
---
 gnu/packages/gimp.scm | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index beb43f0ae2..69281f98e9 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -302,6 +302,19 @@ (define-public gimp
                "doc"))                  ; 9 MiB of gtk-doc HTML
     (arguments
      (list
+      #:modules `((ice-9 popen)
+                  (ice-9 rdelim)
+                  ,@%gnu-build-system-modules)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'remove-gcc-reference
+            ;; Avoid reference to GCC.
+            (lambda _
+              (let* ((port (open-input-pipe "gcc -v 2>&1 | tail -n 1"))
+                     (cc-version (read-line port)))
+                (close-pipe port)
+                (substitute* "app/gimp-version.c"
+                  (("CC_VERSION") (string-append "\"" cc-version "\"")))))))
       #:configure-flags
       #~(list (string-append "--with-html-dir=" #$output "/share/gtk-doc/html")
 
-- 
2.39.1

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 61360-done <at> debbugs.gnu.org, iyzsong <at> member.fsf.org
Subject: Re: bug#61360: [PATCH] gnu: gimp: Don't retain reference on GCC.
Date: Thu, 02 Mar 2023 11:44:39 +0800

Christopher Baines <mail <at> cbaines.net> writes:

> iyzsong--- via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> From: 宋文武 <iyzsong <at> member.fsf.org>
>>
>> Partly fixes <https://issues.guix.gnu.org/57677>.
>>
>> * gnu/packages/gimp.scm (gimp)[arguments]: Add #:modules and #:phases.
>> ---
>>  gnu/packages/gimp.scm | 13 +++++++++++++
>>  1 file changed, 13 insertions(+)
>
> I don't quite get what's going on here, but it seems good to push.
>

Pushed, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.