GNU bug report logs - #6135
font lock is not turned on in js-mode anymore

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6135 in the body.
You can then email your comments to 6135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
To: bug-gnu-emacs <at> gnu.org
Subject: font lock is not turned on in js-mode anymore
Date: Fri, 7 May 2010 18:22:06 +0300

Since a few days, opening a .js file (js-mode) doesn't turn buffer
fontification on, despite `global-font-lock-mode' being t.  Directly
invoking `M-x font-lock-mode' in this new buffer does bring syntax
highlight back, so it's not like "fontification does not work" it is
"fontification is not turned on".

Paul

Message #8 received at 6135 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Cc: 6135 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6135: font lock is not turned on in js-mode anymore
Date: Tue, 15 Jun 2010 23:52:17 -0400

Paul Pogonyshev wrote:

> Since a few days, opening a .js file (js-mode) doesn't turn buffer
> fontification on, despite `global-font-lock-mode' being t.  Directly
> invoking `M-x font-lock-mode' in this new buffer does bring syntax
> highlight back, so it's not like "fontification does not work" it is
> "fontification is not turned on".

It seems this is somehow due to
  
  2010-04-27  Stefan Monnier  <monnier at iro.umontreal.ca>
  
  * emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Avoid
  re-enabling a minor mode after the user turned the minor mode off if
  MODE-enable-in-buffers is run twice (typically once from
  fundamental-mode's after-change-major-mode-hook and a second time from
  run-mode-hook's own after-change-major-mode-hook).

Message #11 received at 6135 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 6135 <at> debbugs.gnu.org, Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Subject: Re: bug#6135: font lock is not turned on in js-mode anymore
Date: Wed, 16 Jun 2010 09:56:36 -0400

>> Since a few days, opening a .js file (js-mode) doesn't turn buffer
>> fontification on, despite `global-font-lock-mode' being t.  Directly
>> invoking `M-x font-lock-mode' in this new buffer does bring syntax
>> highlight back, so it's not like "fontification does not work" it is
>> "fontification is not turned on".

> It seems this is somehow due to
  
>   2010-04-27  Stefan Monnier  <monnier at iro.umontreal.ca>
  
>   * emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Avoid
>   re-enabling a minor mode after the user turned the minor mode off if
>   MODE-enable-in-buffers is run twice (typically once from
>   fundamental-mode's after-change-major-mode-hook and a second time from
>   run-mode-hook's own after-change-major-mode-hook).

What's the recipe to reproduce the problem?


        Stefan

Message #14 received at 6135 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6135 <at> debbugs.gnu.org, Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Subject: Re: bug#6135: font lock is not turned on in js-mode anymore
Date: Wed, 16 Jun 2010 11:53:34 -0400

Stefan Monnier wrote:

> What's the recipe to reproduce the problem?

emacs -Q -f js-mode
C-h v font-lock-mode

Message #17 received at 6135 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 6135 <at> debbugs.gnu.org, Paul Pogonyshev <p.pogonyshev <at> anakreon.net>
Subject: Re: bug#6135: font lock is not turned on in js-mode anymore
Date: Wed, 16 Jun 2010 16:01:34 -0400

>> What's the recipe to reproduce the problem?
> emacs -Q -f js-mode
> C-h v font-lock-mode

Thanks.  I've installed a change in emacs-23 which seems to fix
this problem.  Part of the problem is that js-mode jumps through
some hoops to apply syntax-fontification to the whole buffer eagerly.


        Stefan

Message #22 received at 6135-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 6135-done <at> debbugs.gnu.org
Subject: Re: bug#6135: font lock is not turned on in js-mode anymore
Date: Wed, 16 Jun 2010 16:55:42 -0400

Stefan Monnier wrote:

> I've installed a change in emacs-23 which seems to fix this problem.

Works for me, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.