GNU bug report logs - #61326
30.0.50; Editing fil in zip file without extension save creates new file

Previous Next

Full log

View this message in rfc822 format

From: Ruijie Yu <ruijie <at> netyu.xyz>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: asjo <at> koldfront.dk, 61326 <at> debbugs.gnu.org
Subject: bug#61326: [PATCH v5] Work around zip's filename extension limitation (was: Adding --no-add-suffix to zip patch)
Date: Thu, 20 Apr 2023 16:49:29 +0800

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Ruijie Yu <ruijie <at> netyu.xyz>
>> Cc: Eli Zaretskii <eliz <at> gnu.org>, asjo <at> koldfront.dk, 61326 <at> debbugs.gnu.org
>> Date: Mon, 17 Apr 2023 16:48:13 +0800
>> 
>> 
>> Ruijie Yu <ruijie <at> netyu.xyz> writes:
>> 
>> > New iteration.  As mentioned from my last message, I have reverted the
>> > part where I tried to rewrite part of `archive-expunge' using `cl-do'.
>> >
>> > FTR, I am still waiting for the counter signature from FSF before this
>> > can be included into emacs.git.
>> >
>> 
>> Ping?
>> 
>> Removing the "DRAFT" from subject, because I think it is probably
>> complete.  Also, my FSF process should now be complete.
>
> Great, then, with these two issues out of our way, we can install this
> now.
>
> However, the patch as posted back then no longer applies.  Please
> rebase on the current master branch and re-post.
>
> Thanks.

Thanks.  I have made one change after the previous iteration: I turned
the "bug#xxx" comment in the test/lisp/arc-mode-tests.el into a
docstring.  Also, interestingly, git-rebase finishes cleanly on my end.

Here attached is a patch _without_ indentation changes.

[0001-Handle-modifications-on-extensionless-zips-correctly.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Here attached is a patch _with_ indentation changes (on functions which
I have touched) -- I simply re-indented these functions without tabs.
Not sure if you want this, so I provided the other patch file as an
alternative.  Please choose whichever you prefer to install.

[0001-Handle-modifications-on-extensionless-zips-correctly.patch (text/x-patch, attachment)]

[Message part 5 (text/plain, inline)]

-- 
Best,


RY

[Please note that this mail might go to spam due to some
misconfiguration in my mail server -- will fix soon.]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.