GNU bug report logs - #61326
30.0.50; Editing fil in zip file without extension save creates new file

Previous Next

Package: emacs;

Reported by: Adam Sjøgren <asjo <at> koldfront.dk>

Date: Mon, 6 Feb 2023 17:01:02 UTC

Severity: normal

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Ruijie Yu <ruijie <at> netyu.xyz>
To: Ruijie Yu <ruijie <at> netyu.xyz>
Cc: Eli Zaretskii <eliz <at> gnu.org>, asjo <at> koldfront.dk, 61326 <at> debbugs.gnu.org
Subject: bug#61326: [DRAFT PATCH v5] Work around zip's filename extension limitation (was: Adding --no-add-suffix to zip patch)
Date: Fri, 17 Mar 2023 11:19:39 +0800
[Message part 1 (text/plain, inline)]
> [...]
> Thank you for the review.  I will take a closer look at etc/CONTRIBUTE
> -- apparently I didn't read it in enough detail.  I will report back
> within the next few days.

New iteration.  As mentioned from my last message, I have reverted the
part where I tried to rewrite part of `archive-expunge' using `cl-do'.

Test cases for arc-mode still pass:
    $ make -C test arc-mode-tests

Note that I mentioned the new internal helper functions in the commit
message, as I saw João too has mentioned updates to internal functions
in 9d3fdf7e0.

If mentioning the internal functions turns out to be unnecessary, simply
removing these lines from the patch should suffice.  Otherwise, if
there's something else that looks wrong in the commit message, please
let me know.

FTR, I am still waiting for the counter signature from FSF before this
can be included into emacs.git.

[0001-Handle-modifications-on-extensionless-zips-correctly.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
--
Best,


RY

This bug report was last modified 2 years and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.