GNU bug report logs - #61320
28.2; `vc-cvs-parse-root' returns wrong results

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
Subject: bug#61320: closed (Re: bug#61320: `vc-cvs-parse-root' returns
 wrong results)
Date: Sat, 13 May 2023 06:05:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61320: 28.2; `vc-cvs-parse-root' returns wrong results

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61320 <at> debbugs.gnu.org.

-- 
61320: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61320
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Farblos <akfkqu.9df7rp <at> vodafonemail.de>
Cc: 61320-done <at> debbugs.gnu.org
Subject: Re: bug#61320: `vc-cvs-parse-root' returns wrong results
Date: Sat, 13 May 2023 09:04:22 +0300

> Date: Fri, 12 May 2023 22:48:46 +0200
> From:  Farblos via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Fixed in master:
> 
> M-x emacs-version RET
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, 
> cairo version 1.16.0) of 2023-05-12
> 
> (vc-cvs-parse-root ":local:/var/lib/cvs")
> ("local" nil nil "/var/lib/cvs")
> 
> (vc-cvs-parse-root "/var/lib/cvs")
> ("local" nil nil "/var/lib/cvs")
> 
> Feel free to close this issue.

Thanks, done.

[Message part 3 (message/rfc822, inline)]

From: "Farblos" <AKFKQU.9DF7RP <at> vodafonemail.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.2; `vc-cvs-parse-root' returns wrong results
Date: Mon, 06 Feb 2023 13:43:44 +0100

This reproduces also in master.

Not sure why nobody has reported this.  Most likely because the current
callers of `vc-cvs-parse-root' care only about some aspects of the
actual result of `vc-cvs-parse-root'.

$ emacs -Q

In scratch buffer evaluate the following (specification of Ctrl-J
omitted for clarity):

(load-library "vc-cvs")
t

;; this one is correct in the sense that 3rd element of the list is nil
;; (making it a local root for `vc-cvs-repository-hostname'), but
;; probably is not what the author has intended:
(vc-cvs-parse-root ":local:/var/lib/cvs")
("local" nil nil "var:/lib/cvs")

;; but this one is completely broken:
(vc-cvs-parse-root "/var/lib/cvs")
("ext" nil "var" "/lib/cvs")

There might be different fixes, but IMHO the regexp used in function
`vc-cvs-parse-uhp' should be anchored to beginning of line or string:

  "\\`\\([^/]+\\)\\(/.*\\)"

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.