From unknown Sun Jun 22 11:48:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61320: 28.2; `vc-cvs-parse-root' returns wrong results Resent-From: "Farblos" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 12:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61320 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61320@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167568744824111 (code B ref -1); Mon, 06 Feb 2023 12:45:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 12:44:08 +0000 Received: from localhost ([127.0.0.1]:47547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP0qu-0006Gp-GU for submit@debbugs.gnu.org; Mon, 06 Feb 2023 07:44:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:42730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP0qt-0006Gh-Gs for submit@debbugs.gnu.org; Mon, 06 Feb 2023 07:44:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP0qq-00006V-Eq for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 07:44:05 -0500 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP0qn-0002eG-22 for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 07:44:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1675687430; bh=90X3y2aKQ8UB4X1kzJU38KkCRMmjRS3VhLPRwM2GEAc=; h=From:To:Message-ID:Date:Subject:Content-type:From; b=AgM+pex9CxuC0OWbT49aoeYh2EyHjPk9vEAbuRJtXY/G7hXr8fSguJFe4tp1+bPc9 RetJS3qrNx9inyLPBBO1cJByTDJdBRACBkJtTGfhiyhS5+7WQPcZaTmrt01vudvSGM Ld7Xp7gXln9bSkrL8Xt+Tt9XQFUM6Ra7RsNsBlXk= Received: from mp100.fra-mediabeam.com (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4P9QtG190Wz20sv for ; Mon, 6 Feb 2023 12:43:47 +0000 (UTC) Received: from mailbackend01 (unknown [10.0.0.2]) by mp100.fra-mediabeam.com (Postfix) with ESMTP id 4P9QtC3yNLz2xTW for ; Mon, 6 Feb 2023 12:43:46 +0000 (UTC) From: "Farblos" Message-ID: <7a41388dd2024aa1bda0b526ac6bf297@vodafonemail.de> Date: Mon, 06 Feb 2023 13:43:44 +0100 X-Priority: 3 MIME-Version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate: clean X-purgate-size: 916 X-purgate-ID: 155817::1675687427-669B01CD-326CB6EC/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=AKFKQU.9DF7RP@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This reproduces also in master=2E Not sure why nobody has reported this=2E Most likely because the curre= nt callers of `vc-cvs-parse-root' care only about some aspects of the actual result of `vc-cvs-parse-root'=2E $ emacs -Q In scratch buffer evaluate the following (specification of Ctrl-J omitted for clarity): (load-library "vc-cvs") t ;; this one is correct in the sense that 3rd element of the list is nil ;; (making it a local root for `vc-cvs-repository-hostname'), but ;; probably is not what the author has intended: (vc-cvs-parse-root ":local:/var/lib/cvs") ("local" nil nil "var:/lib/cvs") ;; but this one is completely broken: (vc-cvs-parse-root "/var/lib/cvs") ("ext" nil "var" "/lib/cvs") There might be different fixes, but IMHO the regexp used in function `vc-cvs-parse-uhp' should be anchored to beginning of line or string: "\\`\\([^/]+\\)\\(/=2E*\\)" From unknown Sun Jun 22 11:48:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61320: `vc-cvs-parse-root' returns wrong results References: <7a41388dd2024aa1bda0b526ac6bf297@vodafonemail.de> In-Reply-To: <7a41388dd2024aa1bda0b526ac6bf297@vodafonemail.de> Resent-From: Farblos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 May 2023 20:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61320 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61320@debbugs.gnu.org Received: via spool by 61320-submit@debbugs.gnu.org id=B61320.168392455127600 (code B ref 61320); Fri, 12 May 2023 20:50:02 +0000 Received: (at 61320) by debbugs.gnu.org; 12 May 2023 20:49:11 +0000 Received: from localhost ([127.0.0.1]:33636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxZhO-0007B3-Sf for submit@debbugs.gnu.org; Fri, 12 May 2023 16:49:11 -0400 Received: from mr6.vodafonemail.de ([145.253.228.166]:39158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxZhM-0007Aj-W2 for 61320@debbugs.gnu.org; Fri, 12 May 2023 16:49:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1683924542; bh=utvsjC7fpSajGzfiV3ninVZyrxSy5fY3cP16N9pwReE=; h=Message-ID:Date:User-Agent:To:Content-Language:From:Subject: Content-Type:From; b=U1q627yo5cprZy64zrwWJt+i1ldbOav2N2nskS2CTJVFbnU5PD/NRb8TaH4AG+iRm y2PDAtTJC6osTd0JzRtlFFFYuQqHIGwshoJzm6ysO44kTatK3epJWnhwUfNrQKMA0z BQmbZ1m+VJxcbBVRl6HPOAFyheWzpj46PNfH57mE= Received: from smtp.vodafone.de (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr6.vodafonemail.de (Postfix) with ESMTPS id 4QJ18G520Lz1yGd for <61320@debbugs.gnu.org>; Fri, 12 May 2023 20:49:02 +0000 (UTC) Received: from [192.168.178.42] (port-92-194-102-108.dynamic.as20676.net [92.194.102.108]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id 4QJ18B0pYCzHnHc for <61320@debbugs.gnu.org>; Fri, 12 May 2023 20:48:54 +0000 (UTC) Message-ID: <654c3633-ff72-c84d-b897-c731790316bf@vodafonemail.de> Date: Fri, 12 May 2023 22:48:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Content-Language: de-DE-frami From: Farblos Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate: clean X-purgate-size: 340 X-purgate-ID: 155817::1683924538-37FFE4F5-E6361AE6/0/0 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Fixed in master: M-x emacs-version RET GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2023-05-12 (vc-cvs-parse-root ":local:/var/lib/cvs") ("local" nil nil "/var/lib/cvs") (vc-cvs-parse-root "/var/lib/cvs") ("local" nil nil "/var/lib/cvs") Feel free to close this issue. From unknown Sun Jun 22 11:48:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Farblos" Subject: bug#61320: closed (Re: bug#61320: `vc-cvs-parse-root' returns wrong results) Message-ID: References: <838rdsbwd5.fsf@gnu.org> <7a41388dd2024aa1bda0b526ac6bf297@vodafonemail.de> X-Gnu-PR-Message: they-closed 61320 X-Gnu-PR-Package: emacs Reply-To: 61320@debbugs.gnu.org Date: Sat, 13 May 2023 06:05:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1683957901-2251-1" This is a multi-part message in MIME format... ------------=_1683957901-2251-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61320: 28.2; `vc-cvs-parse-root' returns wrong results which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61320@debbugs.gnu.org. --=20 61320: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61320 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1683957901-2251-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61320-done) by debbugs.gnu.org; 13 May 2023 06:04:31 +0000 Received: from localhost ([127.0.0.1]:35466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxiMp-0000ZU-F9 for submit@debbugs.gnu.org; Sat, 13 May 2023 02:04:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxiMn-0000ZH-NA for 61320-done@debbugs.gnu.org; Sat, 13 May 2023 02:04:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxiMh-0004d6-DZ; Sat, 13 May 2023 02:04:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JsTALKXFMES1COCYGmLD1G+VzJSFWZUu+gOQgi0qqw8=; b=WF2MrZ04cuJc xUJST0BExBGRV1AM42GJB6c4md4aCF/5pzFDeG7JQFVUoTXxpefOjtvQyl7p3Dt27ujNnrlvdvMi0 CLKxYIa8EDEns86z3e0BICKgOXNKWg2Z1M1uF3Rsi7UgSmhQUWiILOZn4doI+LAS3bVJahDpDSvoJ 0uVQrxVDKOl6uNNZ26N66hA57POz7W90DMfvzx3p+FVJOfCdbTukWShRLJ05qa9NxO/DARTJa6Bae JPyBxd5CmbVPOL/ewHj4esYCyS+JtA7UVgghLdR3SSjBl33c9E4KCE9f0qMoGscAcwfULvneZ3WPm shfsXyv05sTvkR3erMbxTQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxiMg-0001v4-Qc; Sat, 13 May 2023 02:04:23 -0400 Date: Sat, 13 May 2023 09:04:22 +0300 Message-Id: <838rdsbwd5.fsf@gnu.org> From: Eli Zaretskii To: Farblos In-Reply-To: <654c3633-ff72-c84d-b897-c731790316bf@vodafonemail.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#61320: `vc-cvs-parse-root' returns wrong results References: <7a41388dd2024aa1bda0b526ac6bf297@vodafonemail.de> <654c3633-ff72-c84d-b897-c731790316bf@vodafonemail.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61320-done Cc: 61320-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 12 May 2023 22:48:46 +0200 > From: Farblos via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Fixed in master: > > M-x emacs-version RET > > GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, > cairo version 1.16.0) of 2023-05-12 > > (vc-cvs-parse-root ":local:/var/lib/cvs") > ("local" nil nil "/var/lib/cvs") > > (vc-cvs-parse-root "/var/lib/cvs") > ("local" nil nil "/var/lib/cvs") > > Feel free to close this issue. Thanks, done. ------------=_1683957901-2251-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 12:44:08 +0000 Received: from localhost ([127.0.0.1]:47547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP0qu-0006Gp-GU for submit@debbugs.gnu.org; Mon, 06 Feb 2023 07:44:08 -0500 Received: from lists.gnu.org ([209.51.188.17]:42730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP0qt-0006Gh-Gs for submit@debbugs.gnu.org; Mon, 06 Feb 2023 07:44:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP0qq-00006V-Eq for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 07:44:05 -0500 Received: from mr3.vodafonemail.de ([145.253.228.163]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP0qn-0002eG-22 for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 07:44:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-mb-mr2-21dec; t=1675687430; bh=90X3y2aKQ8UB4X1kzJU38KkCRMmjRS3VhLPRwM2GEAc=; h=From:To:Message-ID:Date:Subject:Content-type:From; b=AgM+pex9CxuC0OWbT49aoeYh2EyHjPk9vEAbuRJtXY/G7hXr8fSguJFe4tp1+bPc9 RetJS3qrNx9inyLPBBO1cJByTDJdBRACBkJtTGfhiyhS5+7WQPcZaTmrt01vudvSGM Ld7Xp7gXln9bSkrL8Xt+Tt9XQFUM6Ra7RsNsBlXk= Received: from mp100.fra-mediabeam.com (unknown [10.0.0.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mr3.vodafonemail.de (Postfix) with ESMTPS id 4P9QtG190Wz20sv for ; Mon, 6 Feb 2023 12:43:47 +0000 (UTC) Received: from mailbackend01 (unknown [10.0.0.2]) by mp100.fra-mediabeam.com (Postfix) with ESMTP id 4P9QtC3yNLz2xTW for ; Mon, 6 Feb 2023 12:43:46 +0000 (UTC) From: "Farblos" To: bug-gnu-emacs@gnu.org Message-ID: <7a41388dd2024aa1bda0b526ac6bf297@vodafonemail.de> Date: Mon, 06 Feb 2023 13:43:44 +0100 X-Priority: 3 Subject: 28.2; `vc-cvs-parse-root' returns wrong results MIME-Version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-purgate-type: clean X-purgate: clean X-purgate-size: 916 X-purgate-ID: 155817::1675687427-669B01CD-326CB6EC/0/0 Received-SPF: pass client-ip=145.253.228.163; envelope-from=AKFKQU.9DF7RP@vodafonemail.de; helo=mr3.vodafonemail.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This reproduces also in master=2E Not sure why nobody has reported this=2E Most likely because the curre= nt callers of `vc-cvs-parse-root' care only about some aspects of the actual result of `vc-cvs-parse-root'=2E $ emacs -Q In scratch buffer evaluate the following (specification of Ctrl-J omitted for clarity): (load-library "vc-cvs") t ;; this one is correct in the sense that 3rd element of the list is nil ;; (making it a local root for `vc-cvs-repository-hostname'), but ;; probably is not what the author has intended: (vc-cvs-parse-root ":local:/var/lib/cvs") ("local" nil nil "var:/lib/cvs") ;; but this one is completely broken: (vc-cvs-parse-root "/var/lib/cvs") ("ext" nil "var" "/lib/cvs") There might be different fixes, but IMHO the regexp used in function `vc-cvs-parse-uhp' should be anchored to beginning of line or string: "\\`\\([^/]+\\)\\(/=2E*\\)" ------------=_1683957901-2251-1--