GNU bug report logs - #61312
Patch for eglot: scala LSP binary name

Previous Next

Package: emacs;

Reported by: skykanin <skykanin <at> proton.me>

Date: Mon, 6 Feb 2023 05:52:02 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: skykanin <skykanin <at> proton.me>, João Távora <joaotavora <at> gmail.com>
Cc: 61312 <at> debbugs.gnu.org
Subject: bug#61312: Patch for eglot: scala LSP binary name
Date: Mon, 06 Feb 2023 17:46:23 +0200
> Date: Sun, 05 Feb 2023 21:15:48 +0000
> From:  skykanin via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> It seems that eglot expects the scala metals LSP server binary to be named `metals-emacs` instead of `metals`. The included patch fixes this behaviour. At least in the nix package manager the `metals` binary is simply call 'metals'. However if other package managers distribute an alias for the binary as 'metals-emacs' as well we could instead do something like:
> ```
> (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs"))
> ```

Looking at this site:

  https://github.com/rossabaker/lsp-scala

I see this:

  (defcustom lsp-scala-server-command "metals-emacs"
    "The command to launch the Scala language server."
    :group 'lsp-scala
  :type 'file)

So maybe we do need to support both names.

João, WDYT?




This bug report was last modified 2 years and 156 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.