From unknown Thu Aug 14 22:20:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61312: Patch for eglot: scala LSP binary name Resent-From: skykanin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 05:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61312@debbugs.gnu.org X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Received: via spool by submit@debbugs.gnu.org id=B.167566270214036 (code B ref -1); Mon, 06 Feb 2023 05:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 05:51:42 +0000 Received: from localhost ([127.0.0.1]:47193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOuPl-0003eD-I8 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 00:51:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:44504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOmMt-0000BA-Sh for submit@debbugs.gnu.org; Sun, 05 Feb 2023 16:16:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOmMt-0001Uh-Gf for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:16:11 -0500 Received: from mail-40138.protonmail.ch ([185.70.40.138]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOmMm-0001y5-LR for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:16:10 -0500 Date: Sun, 05 Feb 2023 21:15:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1675631753; x=1675890953; bh=lBELv8IVVzkJLwDh4bQ50SUpGJq0x46p7cTeEut5OSw=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Rg94/eJmXNkBlqnMqlPX7VXEVuneF3wBbAMDB//Wg7JLP8u4hstSE6Uhi9GB9NzRI aASAMbt7WJnqcWhewPg3p1Nwk6xqfONu6MYJ65MJts0VuHPsU8iQdHMGKgqJ8+ntTJ iksMrsfS7C6kU7qIP7OoEBji/dJ2mq6A9b+OsQTlehkaUSXFc4iXtT4RMQH1YERT4u ixyZmumpUEHf9dwpb7e/UNF0fWQSEzCW88N4VGMuN7NaFFx/BXB/pH8XYjAdEBmheS aokw4T7th+pA2eXCK0SsNHXslgCS7ni2j4bcXbrIM4HcM4pOAG/7e56Bq4/Sbyi2q3 i2eXUqjm3XQpg== From: skykanin Message-ID: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> Feedback-ID: 66914596:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA" Received-SPF: pass client-ip=185.70.40.138; envelope-from=skykanin@proton.me; helo=mail-40138.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Mon, 06 Feb 2023 00:51:39 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, It seems that eglot expects the scala metals LSP server binary to be named = `metals-emacs` instead of `metals`. The included patch fixes this behaviour= . At least in the nix package manager the `metals` binary is simply call 'm= etals'. However if other package managers distribute an alias for the binar= y as 'metals-emacs' as well we could instead do something like: ``` (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs")) ``` --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA Content-Type: text/x-patch; name=0001-Patch-eglot-scala-LSP-server-binary-name.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Patch-eglot-scala-LSP-server-binary-name.patch RnJvbSAyMTVkNTRmZjVlZTMzNTJiY2RhMDFkODhkN2ExNjc5MjVjZDhkYmViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBza3lrYW5pbiA8Mzc4OTc2NCtza3lrYW5pbkB1c2Vycy5ub3Jl cGx5LmdpdGh1Yi5jb20+CkRhdGU6IFN1biwgNSBGZWIgMjAyMyAyMTo0MToxOSArMDEwMApTdWJq ZWN0OiBbUEFUQ0hdIFBhdGNoIGVnbG90IHNjYWxhIExTUCBzZXJ2ZXIgYmluYXJ5IG5hbWUKCkVu c3VyZSB0aGF0IGVnbG90IHBpY2tzIHVwIHRoZSBjb3JyZWN0CmJpbmFyeSBuYW1lIGZvciB0aGUg c2NhbGEgbWV0YWxzIExTUCBzZXJ2ZXIuCi0tLQogbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgfCAy ICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVs CmluZGV4IDRmYTg4NmJjNzguLmNhMDI1Y2Y3ZDggMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVz L2VnbG90LmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC0yMjEsNyArMjIxLDcg QEAgY2hvc2VuIChpbnRlcmFjdGl2ZWx5IG9yIGF1dG9tYXRpY2FsbHkpLiIKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLS1jbGllbnQtaWQiICJlbWFjcy5l Z2xvdC1kYXJ0IikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlbGl4aXItbW9k ZSAuICgibGFuZ3VhZ2Vfc2VydmVyLnNoIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChhZGEtbW9kZSAuICgiYWRhX2xhbmd1YWdlX3NlcnZlciIpKQotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc2NhbGEtbW9kZSAuICgibWV0YWxzLWVtYWNzIikpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChzY2FsYS1tb2RlIC4gKCJtZXRhbHMiKSkKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJhY2tldC1tb2RlIC4gKCJyYWNrZXQiICItbCIg InJhY2tldC1sYW5nc2VydmVyIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgo dGV4LW1vZGUgY29udGV4dC1tb2RlIHRleGluZm8tbW9kZSBiaWJ0ZXgtbW9kZSkKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC4gLChlZ2xvdC1hbHRlcm5hdGl2ZXMgJygiZGlnZXN0 aWYiICJ0ZXhsYWIiKSkpCi0tIAoyLjM5LjAKCg== --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA-- From unknown Thu Aug 14 22:20:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61312: Patch for eglot: scala LSP binary name Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: skykanin , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 61312@debbugs.gnu.org Received: via spool by 61312-submit@debbugs.gnu.org id=B61312.167569838314742 (code B ref 61312); Mon, 06 Feb 2023 15:47:02 +0000 Received: (at 61312) by debbugs.gnu.org; 6 Feb 2023 15:46:23 +0000 Received: from localhost ([127.0.0.1]:49649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP3hG-0003ph-Ln for submit@debbugs.gnu.org; Mon, 06 Feb 2023 10:46:22 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP3hE-0003pU-1R for 61312@debbugs.gnu.org; Mon, 06 Feb 2023 10:46:21 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP3h5-0000iD-Et; Mon, 06 Feb 2023 10:46:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=q69seeDp9DvQaxTNiQ9MNlTFYa4j8GFyVY2D5vl23Y8=; b=TLuwX9R6lvclG6PETe2+ 746g9acWPE08Omym5HoPPDWCUFEmghhdWf3Dc4fREqAChW3/3zlQLcmg52Tl+J6wsIhs1pRbWguhl Ixhuzs9MqT1SajFuXhiPf9x/qMzSLkrWFA/dnsO/GZCnfQyw1aOoHfnOU1mJr79pAcvXAZxPpzSne GbV5enWzhAB3qooilKZgzQ4iCyJ+7hVB760x4ujjIouGj4cNoa0/bPZg5PuWJ8JVwwEQ/3M6XSpdS vAjU8zgr121Pn91eq75vKMczi6YqEv+XQmqUxv0z1HXdGsMM2FXY0BWJk19smPIddvNHN0HRfJ/ga KJyY8PRAhm5Xgw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP3h4-0007dt-Ua; Mon, 06 Feb 2023 10:46:11 -0500 Date: Mon, 06 Feb 2023 17:46:23 +0200 Message-Id: <83ttzypzjk.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> (bug-gnu-emacs@gnu.org) References: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 05 Feb 2023 21:15:48 +0000 > From: skykanin via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > It seems that eglot expects the scala metals LSP server binary to be named `metals-emacs` instead of `metals`. The included patch fixes this behaviour. At least in the nix package manager the `metals` binary is simply call 'metals'. However if other package managers distribute an alias for the binary as 'metals-emacs' as well we could instead do something like: > ``` > (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs")) > ``` Looking at this site: https://github.com/rossabaker/lsp-scala I see this: (defcustom lsp-scala-server-command "metals-emacs" "The command to launch the Scala language server." :group 'lsp-scala :type 'file) So maybe we do need to support both names. João, WDYT? From unknown Thu Aug 14 22:20:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61312: Patch for eglot: scala LSP binary name Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 18:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61312 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61312@debbugs.gnu.org, skykanin Received: via spool by 61312-submit@debbugs.gnu.org id=B61312.16757091583110 (code B ref 61312); Mon, 06 Feb 2023 18:46:02 +0000 Received: (at 61312) by debbugs.gnu.org; 6 Feb 2023 18:45:58 +0000 Received: from localhost ([127.0.0.1]:49933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP6V4-0000o6-09 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 13:45:58 -0500 Received: from mail-oa1-f48.google.com ([209.85.160.48]:42911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP6V2-0000nr-JR for 61312@debbugs.gnu.org; Mon, 06 Feb 2023 13:45:56 -0500 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-142b72a728fso16233971fac.9 for <61312@debbugs.gnu.org>; Mon, 06 Feb 2023 10:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TQMUhhLURTJ1NObAdE6yGTuashbHjJP05+7qP9zGfKY=; b=JX5PnmSaUWNuCAQ/Dq4J0y1LaAPsGYAj6NuMYccAiRMgHVgf2//BedeVTfGIcX22Ie yzt1CipM0yRKqcPJX0D0dKSGR+6Zs3s+JHRgw2xyOINNZdS1OrbYC/3a/A3RQtuCzmjL AjjBPJRtfThc/62vUB3KFwPNCcOlUcGcPlkfiCvGidA5jyju5AuQYpHcwWsdL7JpVcKm AeAwxywzXMFnfAOlIPDGSt/QegEKwRq5sU7TyGbY3k0e9VFz+AORh51/Q99Tz0rEfbQY G2s8Eqyqbv+P3zzLn0c/AwzG+RMiSJzEH5KHv2wiICS1yz2VmJqmwn/yWAPFDXTp90j9 BGQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TQMUhhLURTJ1NObAdE6yGTuashbHjJP05+7qP9zGfKY=; b=7vH2ivlxis4JltcsdE072+G0WH5A1G4PFnTaI1L34xh/BZpk3vdipaxyIpLkzR6IKN awhl8oGM1mf10huVbSDkj/+NxdmHS2+cGdp/Lwxby7PXcVaN9KmV4JvNhISKNuJRU/2W xumGWUUwlSwCwXNUntRL+8Ayd8yGN73FDGX3vgT162PlbLCyblRC/4raGcAhNmc7LCkZ ivYCDIyVTyoUtkw/ONqPDaI0lPMAjGE7jcPLCv8HZKUGN0lD9jE13KiVQ7GSb7O72wom 9GVmR+cIjZdvRHVBMbbEQOrzzjsrLJHuV0VPZm5nmJhCmA2Bx/sCF/n/O2/nAbOUfuqI 52cA== X-Gm-Message-State: AO0yUKWsEQAdVmcaWyH5JeB/oU6ntU1QExdfkolnwo/9XT7w+sU9l35M TwOh3Bwf/VYc2LOSDA8rFgvqV5npa4RUkQdF8gA= X-Google-Smtp-Source: AK7set9Tx6hJHJonI834Eb3sVq5PSToKdD3Vt31RjmnTEnpupVUZQVsYH7qcvoiTk5eXVrA3A1ZNyYl5A1Aqgq7a2o8= X-Received: by 2002:a05:6870:6390:b0:169:f796:4aea with SMTP id t16-20020a056870639000b00169f7964aeamr1029143oap.171.1675709150708; Mon, 06 Feb 2023 10:45:50 -0800 (PST) MIME-Version: 1.0 References: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> <83ttzypzjk.fsf@gnu.org> In-Reply-To: <83ttzypzjk.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Mon, 6 Feb 2023 18:45:39 +0000 Message-ID: Content-Type: multipart/alternative; boundary="000000000000acc69105f40c7011" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000acc69105f40c7011 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Eli, As usual, I defer this decision to you. I think it's reasonable to support both names, and I also think it's reasonable to stick to just the one we think is most used or representative of the program. In this case, I think "metals-emacs" is a contradiction of LSP's stated goal, which is to have editor-agnostic servers. But I don't know what the reasons were for doing this, I haven't investigated. It would be even more reasonable, I think, if distributions settled -- or mostly settled - on names for their binaries they distribute, much like *nix toolchains do. Of course we do not control that process, but maybe we could influence it instead of being constantly influenced by it. Jo=C3=A3o --000000000000acc69105f40c7011 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, Eli,

As usual, I defer t= his decision to you. I think it's reasonable to
support both = names, and I also think it's reasonable=C2=A0to stick to=C2=A0
just the one we think is most used or representative of the=C2=A0
program.

In this case, I think "metals-ema= cs" is a contradiction of LSP's
stated goal, which is to= have editor-agnostic servers. But I=C2=A0
don't know what th= e reasons were for doing this, I haven't
investigated.
<= div>
It would be even more reasonable, I think, if distributi= ons=C2=A0
settled -- or mostly settled - on names for their binar= ies they=C2=A0
distribute, much like *nix toolchains do. Of cours= e we do not=C2=A0
control that process, but maybe we could influe= nce it instead
of being constantly influenced by it.
Jo=C3=A3o
--000000000000acc69105f40c7011-- From unknown Thu Aug 14 22:20:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: skykanin Subject: bug#61312: closed (Re: bug#61312: Patch for eglot: scala LSP binary name) Message-ID: References: <83bkm3m9az.fsf@gnu.org> <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> X-Gnu-PR-Message: they-closed 61312 X-Gnu-PR-Package: emacs Reply-To: 61312@debbugs.gnu.org Date: Thu, 09 Feb 2023 10:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1675937942-10160-1" This is a multi-part message in MIME format... ------------=_1675937942-10160-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61312: Patch for eglot: scala LSP binary name which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61312@debbugs.gnu.org. --=20 61312: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61312 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1675937942-10160-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61312-done) by debbugs.gnu.org; 9 Feb 2023 10:18:03 +0000 Received: from localhost ([127.0.0.1]:57579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ40A-0002cj-T7 for submit@debbugs.gnu.org; Thu, 09 Feb 2023 05:18:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pQ406-0002c9-0o for 61312-done@debbugs.gnu.org; Thu, 09 Feb 2023 05:18:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ400-0005mT-NZ; Thu, 09 Feb 2023 05:17:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=jaivFyLd134PD6LKXvWDO2eGTcM8gSV0UvCeU+IcQWA=; b=jAHNSztZRxQiMZA/pIXO QnnnJTc5ZlZ82Fekf7Ht45V8JfQ1zL5H4XFUGr3Ys0qB+pvUg0KmxjUBqm0E7RdJJJY83jbVUG5ma 1t/ZQgIPlnNx0zBgnb3BotW0fjLDnsg+SrakJ6mAAhM/VvZKdCO3DrdEec9md9VOvymu0V+8MYp6R KVnb5ZgYnCdQzABv5qolENKoznPBQVd/74V5aR+0UIgubGLP9oge6GXVGsymbp0ipVnJctNSIMgu5 rUznvy9UJirHKiJHB/vyMUWpXzboCX/+ZwPObxrKbPb17NtDxeflgsJw/VMvpz3pP8pFxIfKjjc9T CUk5B+LPbZ25KQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pQ3zz-0003aO-Nt; Thu, 09 Feb 2023 05:17:52 -0500 Date: Thu, 09 Feb 2023 12:18:12 +0200 Message-Id: <83bkm3m9az.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Mon, 6 Feb 2023 18:45:39 +0000) Subject: Re: bug#61312: Patch for eglot: scala LSP binary name References: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> <83ttzypzjk.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61312-done Cc: 61312-done@debbugs.gnu.org, skykanin@proton.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Mon, 6 Feb 2023 18:45:39 +0000 > Cc: skykanin , 61312@debbugs.gnu.org > > As usual, I defer this decision to you. I think it's reasonable to > support both names, and I also think it's reasonable to stick to > just the one we think is most used or representative of the > program. > > In this case, I think "metals-emacs" is a contradiction of LSP's > stated goal, which is to have editor-agnostic servers. But I > don't know what the reasons were for doing this, I haven't > investigated. > > It would be even more reasonable, I think, if distributions > settled -- or mostly settled - on names for their binaries they > distribute, much like *nix toolchains do. Of course we do not > control that process, but maybe we could influence it instead > of being constantly influenced by it. Thanks, I went with supporting both names in Emacs 29. I cannot see any harm in supporting both, once "metals" is the first name to check. With that, I'm closing this bug. ------------=_1675937942-10160-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 05:51:42 +0000 Received: from localhost ([127.0.0.1]:47193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOuPl-0003eD-I8 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 00:51:42 -0500 Received: from lists.gnu.org ([209.51.188.17]:44504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOmMt-0000BA-Sh for submit@debbugs.gnu.org; Sun, 05 Feb 2023 16:16:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOmMt-0001Uh-Gf for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:16:11 -0500 Received: from mail-40138.protonmail.ch ([185.70.40.138]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOmMm-0001y5-LR for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:16:10 -0500 Date: Sun, 05 Feb 2023 21:15:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1675631753; x=1675890953; bh=lBELv8IVVzkJLwDh4bQ50SUpGJq0x46p7cTeEut5OSw=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Rg94/eJmXNkBlqnMqlPX7VXEVuneF3wBbAMDB//Wg7JLP8u4hstSE6Uhi9GB9NzRI aASAMbt7WJnqcWhewPg3p1Nwk6xqfONu6MYJ65MJts0VuHPsU8iQdHMGKgqJ8+ntTJ iksMrsfS7C6kU7qIP7OoEBji/dJ2mq6A9b+OsQTlehkaUSXFc4iXtT4RMQH1YERT4u ixyZmumpUEHf9dwpb7e/UNF0fWQSEzCW88N4VGMuN7NaFFx/BXB/pH8XYjAdEBmheS aokw4T7th+pA2eXCK0SsNHXslgCS7ni2j4bcXbrIM4HcM4pOAG/7e56Bq4/Sbyi2q3 i2eXUqjm3XQpg== To: "bug-gnu-emacs@gnu.org" From: skykanin Subject: Patch for eglot: scala LSP binary name Message-ID: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> Feedback-ID: 66914596:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA" Received-SPF: pass client-ip=185.70.40.138; envelope-from=skykanin@proton.me; helo=mail-40138.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 06 Feb 2023 00:51:39 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, It seems that eglot expects the scala metals LSP server binary to be named = `metals-emacs` instead of `metals`. The included patch fixes this behaviour= . At least in the nix package manager the `metals` binary is simply call 'm= etals'. However if other package managers distribute an alias for the binar= y as 'metals-emacs' as well we could instead do something like: ``` (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs")) ``` --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA Content-Type: text/x-patch; name=0001-Patch-eglot-scala-LSP-server-binary-name.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Patch-eglot-scala-LSP-server-binary-name.patch RnJvbSAyMTVkNTRmZjVlZTMzNTJiY2RhMDFkODhkN2ExNjc5MjVjZDhkYmViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBza3lrYW5pbiA8Mzc4OTc2NCtza3lrYW5pbkB1c2Vycy5ub3Jl cGx5LmdpdGh1Yi5jb20+CkRhdGU6IFN1biwgNSBGZWIgMjAyMyAyMTo0MToxOSArMDEwMApTdWJq ZWN0OiBbUEFUQ0hdIFBhdGNoIGVnbG90IHNjYWxhIExTUCBzZXJ2ZXIgYmluYXJ5IG5hbWUKCkVu c3VyZSB0aGF0IGVnbG90IHBpY2tzIHVwIHRoZSBjb3JyZWN0CmJpbmFyeSBuYW1lIGZvciB0aGUg c2NhbGEgbWV0YWxzIExTUCBzZXJ2ZXIuCi0tLQogbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgfCAy ICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVs CmluZGV4IDRmYTg4NmJjNzguLmNhMDI1Y2Y3ZDggMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVz L2VnbG90LmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC0yMjEsNyArMjIxLDcg QEAgY2hvc2VuIChpbnRlcmFjdGl2ZWx5IG9yIGF1dG9tYXRpY2FsbHkpLiIKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLS1jbGllbnQtaWQiICJlbWFjcy5l Z2xvdC1kYXJ0IikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlbGl4aXItbW9k ZSAuICgibGFuZ3VhZ2Vfc2VydmVyLnNoIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChhZGEtbW9kZSAuICgiYWRhX2xhbmd1YWdlX3NlcnZlciIpKQotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc2NhbGEtbW9kZSAuICgibWV0YWxzLWVtYWNzIikpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChzY2FsYS1tb2RlIC4gKCJtZXRhbHMiKSkKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJhY2tldC1tb2RlIC4gKCJyYWNrZXQiICItbCIg InJhY2tldC1sYW5nc2VydmVyIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgo dGV4LW1vZGUgY29udGV4dC1tb2RlIHRleGluZm8tbW9kZSBiaWJ0ZXgtbW9kZSkKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC4gLChlZ2xvdC1hbHRlcm5hdGl2ZXMgJygiZGlnZXN0 aWYiICJ0ZXhsYWIiKSkpCi0tIAoyLjM5LjAKCg== --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA-- ------------=_1675937942-10160-1--