GNU bug report logs - #6131
[PATCH]: fiemap support for efficient sparse file copy

Previous Next

Full log

View this message in rfc822 format

From: "jeff.liu" <jeff.liu <at> oracle.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: Sunil Mushran <sunil.mushran <at> oracle.com>, Tao Ma <tao.ma <at> oracle.com>, bug-coreutils <at> gnu.org, Joel Becker <Joel.Becker <at> oracle.com>, Chris Mason <chris.mason <at> oracle.com>
Subject: bug#6131: [PATCH]: fiemap support for efficient sparse file copy
Date: Fri, 21 May 2010 23:01:41 +0800

Jim Meyering wrote:
> jeff.liu wrote:
> ...
>>>> Subject: [PATCH 1/1] tests: add a new test for FIEMAP-copy
>>>>
>>>> * tests/cp/sparse-fiemap: Add a new test for FIEMAP-copy against a
>>>> loopbacked ext4 partition.
>>>> * tests/Makefile.am (sparse-fiemap): Reference the new test.
> 
> BTW, I've just made this additional change to your test,
> 
> diff --git a/tests/cp/sparse-fiemap b/tests/cp/sparse-fiemap
> index 6312a4c..bdc7ded 100755
> --- a/tests/cp/sparse-fiemap
> +++ b/tests/cp/sparse-fiemap
> @@ -27,6 +27,7 @@ require_root_
>  cwd=`pwd`
>  cleanup_() { cd /; umount "$cwd/mnt"; }
> 
> +skip=0
>  # Create an ext4 loopback file system
>  dd if=/dev/zero of=blob bs=8192 count=1000 || skip=1
>  mkdir mnt
> 
> And will push this correction to the one you appear to have used as a model:
> 
> From c9bcbc8f9fc791c97bc85678f5f22458a76689ac Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering <at> redhat.com>
> Date: Fri, 21 May 2010 14:55:36 +0200
> Subject: [PATCH] tests: fix cp-a-selinux to skip cleanly upon mkfs failure
> 
> * tests/cp/cp-a-selinux: Initialize skip, to avoid a syntax error
> in subsequent "test".
> ---
>  tests/cp/cp-a-selinux |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/cp/cp-a-selinux b/tests/cp/cp-a-selinux
> index b65070a..5b9ff0f 100755
> --- a/tests/cp/cp-a-selinux
> +++ b/tests/cp/cp-a-selinux
> @@ -45,7 +45,7 @@ test -s err && fail=1   #there must be no stderr output for -a
>  ls -Z e | grep $ctx || fail=1
>  ls -Z f | grep $ctx || fail=1
> 
> -
> +skip=0
>  # Create a file system, then mount it with the context=... option.
>  dd if=/dev/zero of=blob bs=8192 count=200 > /dev/null 2>&1 \
>                                               || skip=1
Hmm, here also has a '2>&1' for `dd'. :)
> --
> 1.7.1.262.g5ef3d


Thanks,
-Jeff
-- 
With Windows 7, Microsoft is asserting legal control over your computer and is using this power to
abuse computer users.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.